Rockbox General > Rockbox General Discussion
[iPod Nano] Bookmarks not working
Lear:
--- Quote from: dflachbart on June 12, 2007, 08:54:30 PM ---Well, I noticed that this feature is only scheduled for 3.1, so I went ahead and looked at the bookmark code myself. I hacked the 'create_bookmark' function to use the folder name of the song as the playlist name if the current playlist name is empty, and also made sure that 'system_check' does not return false in this case.
This seems to generate the same bookmark as if the song has been played from the file view. Since I am new to the rockbox code (and my C is a bit rusty) it is absolutely possible that this change has side effects which I can't oversee right now, but all I can say is that it is working fine for my own purposes (on 80G ipod).
--- End quote ---
This would indeed be the same as if the file was played from the file view, which might not be what the user wants or expects. The problem when playing tracks from the database is that not only should the right file be resumed, but that the following tracks should be the right ones too.
That means that the resume should be based on a particular database selection, rather than a playlist or folder (which is what the current bookmark system supports). I'm not familiar with the database, so I don't know what that should look like...
dflachbart:
--- Quote from: GodEater on June 13, 2007, 02:44:29 AM ---It's always worth putting on the patch tracker - even if the code is horrid, it's a starting point for someone else to have a go at tidying up and improving it.
--- End quote ---
Valid point, will do...
--- Quote from: Lear on June 13, 2007, 03:18:19 AM ---
This would indeed be the same as if the file was played from the file view, which might not be what the user wants or expects. The problem when playing tracks from the database is that not only should the right file be resumed, but that the following tracks should be the right ones too.
--- End quote ---
True, and that's why I said it works fine for my own needs, I usually play only albums from the database view.
--- Quote ---That means that the resume should be based on a particular database selection, rather than a playlist or folder (which is what the current bookmark system supports). I'm not familiar with the database, so I don't know what that should look like...
--- End quote ---
Yeah, I guess for a generic solution something like a temp playlist for the current selection would need to be created...
Dirk
Navigation
[0] Message Index
[*] Previous page
Go to full version