[iPod Nano] Bookmarks not working

[Nitro2985]

I've setup my bookmark options with Bookmark on stop to "On"
Load last bookmark to "Yes"
And
Maintain a List of Recent Bookmarks to "Yes"

It won't pickup where it left off when I switch songs, hold start/pause for 2 seconds (which actually causes the iPod to shut down), or press "select" when playing a song and select "bookmark -> create bookmark."

Am I doing anything wrong?

[Lear]

Selecting files to play from the database perhaps? Bookmarks are currently not supported there. Saved playlists work though.

[Nitro2985]

Ah, that's it.  It works now that I'm selecting from the "files" option.

[dflachbart]

Selecting files to play from the database perhaps? Bookmarks are currently not supported there. Saved playlists work though.

Oh cool, that explains it. I was just about to open a new thread regarding this issue (I thought I was doing something wrong) when I came across this post...

When you are saying "currently", does this mean it's on the to-do list for the near future ? I'd prefer to work in the database view, but this is currently preventing it...


Thanks,
Dirk

[GodEater]

When you are saying "currently", does this mean it's on the to-do list for the near future ? I'd prefer to work in the database view, but this is currently preventing it...

It'll happen when someone works on it - we never make estimates for when anything gets done in Rockbox, because the developers ALL work in their spare time - and no-one can ever predict when "real life" will intrude on their Rockbox work, or if they'll simply lose interest in it.

[dflachbart]

It'll happen when someone works on it - we never make estimates for when anything gets done in Rockbox, because the developers ALL work in their spare time - and no-one can ever predict when "real life" will intrude on their Rockbox work, or if they'll simply lose interest in it.

Of course I fully understand what you are saying (being a dev myself...). My main intention was to find out if this is a feature that is deemed "desirable" by the Rockbox team, or if there maybe aren't any plans at all for this.

Thanks,
Dirk

[GodEater]

Oh, I think it's definitely deemed desirable - it'll be the implementation that'll be argued about - not the feature

[dflachbart]

 

[dflachbart]

Well, I noticed that this feature is only scheduled for 3.1, so I went ahead and looked at the bookmark code myself. I hacked the 'create_bookmark' function to use the folder name of the song as the playlist name if the current playlist name is empty, and also made sure that 'system_check' does not return false in this case.

This seems to generate the same bookmark as if the song has been played from the file view. Since I am new to the rockbox code (and my C is a bit rusty) it is absolutely possible that this change has side effects which I can't oversee right now, but all I can say is that it is working fine for my own purposes (on 80G ipod).

I doubt that such a "dirty hack" is worth putting on the patch tracker though...


Dirk

[GodEater]

It's always worth putting on the patch tracker - even if the code is horrid, it's a starting point for someone else to have a go at tidying up and improving it.

[Lear]

Well, I noticed that this feature is only scheduled for 3.1, so I went ahead and looked at the bookmark code myself. I hacked the 'create_bookmark' function to use the folder name of the song as the playlist name if the current playlist name is empty, and also made sure that 'system_check' does not return false in this case.

This seems to generate the same bookmark as if the song has been played from the file view. Since I am new to the rockbox code (and my C is a bit rusty) it is absolutely possible that this change has side effects which I can't oversee right now, but all I can say is that it is working fine for my own purposes (on 80G ipod).

This would indeed be the same as if the file was played from the file view, which might not be what the user wants or expects. The problem when playing tracks from the database is that not only should the right file be resumed, but that the following tracks should be the right ones too.

That means that the resume should be based on a particular database selection, rather than a playlist or folder (which is what the current bookmark system supports). I'm not familiar with the database, so I don't know what that should look like...

[dflachbart]

It's always worth putting on the patch tracker - even if the code is horrid, it's a starting point for someone else to have a go at tidying up and improving it.

Valid point, will do...

This would indeed be the same as if the file was played from the file view, which might not be what the user wants or expects. The problem when playing tracks from the database is that not only should the right file be resumed, but that the following tracks should be the right ones too.

True, and that's why I said it works fine for my own needs, I usually play only albums from the database view.

That means that the resume should be based on a particular database selection, rather than a playlist or folder (which is what the current bookmark system supports). I'm not familiar with the database, so I don't know what that should look like...

Yeah, I guess for a generic solution something like a temp playlist for the current selection would need to be created...


Dirk