Support and General Use > Theming and Appearance Customization

WPS doesn't show

<< < (2/3) > >>

RedBreva:
I've had a go at fixing the errors in this one.  A few unclosed conditionals and a background image that was 4bpp (original version requires a greyscale patched build??) and it seems to work ok in a recent Sim...

http://www.rockbox-themes.org/index.php?res=160x128x2

pixelma:
You can use the background bmp in the bitdepth it was - just not with the "%x" tag for displaying a static bitmap. One would have to use the backdrop tag "%X" for it which works with current rockbox builds and on greyscale too.

The first line would change from

--- Code: ---%x|a|bg.bmp|0|0|
--- End code ---
to

--- Code: ---%X|bg.bmp|
--- End code ---

Edit: I've just looked at the rockbox-themes site and I didn't see a difference in the actual .wps file to the one in the wiki. At least there are still the 3 mistakes in the code that I had found (in addition to the backdrop) - only the bg.bmp is changed, unnecessarily.

RedBreva:

--- Quote ---Edit: I've just looked at the rockbox-themes site and I didn't see a difference in the actual .wps file to the one in the wiki.
--- End quote ---

Strange...  I have just checked and the 'themed' zip works fine in the sim, but the one on the Wiki fails to load and displays the default wps...  :o

From Rockbox-Themes

--- Code: ---%t4%s%ac%?Ia%?D2>;
%t4%s%ac%?Id;
%t8%ffHz%ac%fc%ar%?fv%fbkbps;
%t8%s%ac%?pn%?Ia|>%?Id;
%t8%pm

--- End code ---

From Wiki

--- Code: ---%t4%s%ac%?Ia;
%t4%s%ac%?Id;
%t8%ffHz%ac%fc%ar%?fv%fbkbps;
%t8%s%ac%?pn%?Id>;
%t8%pm

--- End code ---

Thanks for the %X tip, I will bear that in mind for future fixes...

pixelma:
Thanks for pointing this line out, now I see the difference. It's just that I expected a different fix because my idea about its meaning was another. I thought that the following part:

--- Code: ---%?D2>
--- End code ---
should mean:

--- Code: ---%?D2>
--- End code ---
but you fixed it by closing the now new conditional later, though it makes me wonder how this works...

And there are two other mistakes but it seems they don't cause the parser to fail. It's in this line:

--- Code: ---%s%ac%?ia
--- End code ---
I think that would be "%ic" and "%?d2".

RedBreva:
I see what you mean, but for now the aim was to get it to load... it needs to be used to see if it actually works the way it should...

If I get some time later today, I may have another go at checking/fixing it - including restoring the original bg.bmp image, and do the same thing for the other wiki version of this theme.
Edit: Pixelma was correct with that tag, and now it loads *and* seems to work as expected.  I also updated/uploaded the version2 amwps with the nokia font.

On a wider note:
In view of the recent licensing discussions, are we assuming that anything posted to the wiki is 'open' for modification etc. Should these fixes even be happening, and would it be OK to licence the repaired version under CC3 for example?

Navigation

[0] Message Index

[#] Next page

[*] Previous page