WPS doesn't show

[Iggy]

Hi guys,

I'm new to Rockbox and have a problem with AMwps on my H120.
I downloaded it from the WPS Gallery and extracted it right on my player. But instead of showing me the screen with the spinning disc it just shows me something that looks like the standard theme (look below). I have already the font package installed and I'm using a recent build.

[Llorean]

Many WPSes have small errors in them. The newer versions of Rockbox reject these WPSes and show the default one instead. The errors in the .wps file will have to be fixed before you can use it.

[Iggy]

Thanks for your reply.

So is there any way that the author can fix it or could I do it myself? Maybe someone with experience in WPS building could do it. The screenshot looks good and I think this would become my favorite WPS.

[Llorean]

http://www.rockbox.org/twiki/bin/view/Main/CustomWPS if you want to fix your personal copy.

[Iggy]

Hmm, I don't really know where to look for errors. The WPS looks somewhat complex and I don't understand what I must change to get it to work. I have looked at the Link you provided, but unfortunately it doesn't help me to understand better where the error in the WPS lies . If someone could help me that would be most appreciated.

I have BTW send a PM to the author, but it seems he is inactive, because he was last logged in in October 2006.

[RedBreva]

I've had a go at fixing the errors in this one.  A few unclosed conditionals and a background image that was 4bpp (original version requires a greyscale patched build??) and it seems to work ok in a recent Sim...

http://www.rockbox-themes.org/index.php?res=160x128x2

[pixelma]

You can use the background bmp in the bitdepth it was - just not with the "%x" tag for displaying a static bitmap. One would have to use the backdrop tag "%X" for it which works with current rockbox builds and on greyscale too.

The first line would change from

Code: [Select]

%x|a|bg.bmp|0|0|

to

Code: [Select]

%X|bg.bmp|

Edit: I've just looked at the rockbox-themes site and I didn't see a difference in the actual .wps file to the one in the wiki. At least there are still the 3 mistakes in the code that I had found (in addition to the backdrop) - only the bg.bmp is changed, unnecessarily.

[RedBreva]

Edit: I've just looked at the rockbox-themes site and I didn't see a difference in the actual .wps file to the one in the wiki.

Strange...  I have just checked and the 'themed' zip works fine in the sim, but the one on the Wiki fails to load and displays the default wps...  

From Rockbox-Themes

Code: [Select]

%t4%s%ac%?Ia<%Ia|>%?D2<%?D2|Unknown Artist>>;
%t4%s%ac%?Id<%Id|%?D1<%D1|Unknown Album>>;
%t8%ffHz%ac%fc%ar%?fv<~|>%fbkbps;
%t8%s%ac%?pn<%pn|%?Ia<%Ia|%D2>>%?Ia<%?Id< - |>|>%?Id<%Id|%D1>;
%t8%pm

From Wiki

Code: [Select]

%t4%s%ac%?Ia<%Ia|%?D2<%?D2|Unknown Artist>>;
%t4%s%ac%?Id<%Id|%?D1<%D1|Unknown Album>>;
%t8%ffHz%ac%fc%ar%?fv<~|>%fbkbps;
%t8%s%ac%?pn<%pn|%?Ia<%Ia|%D2>%?Ia<%?Id< - |>|>%?Id<%Id|%D1>>;
%t8%pm

Thanks for the %X tip, I will bear that in mind for future fixes...

[pixelma]

Thanks for pointing this line out, now I see the difference. It's just that I expected a different fix because my idea about its meaning was another. I thought that the following part:

Code: [Select]

%?D2<%?D2|Unknown Artist>>

should mean:

Code: [Select]

%?D2<%D2|Unknown Artist>>

but you fixed it by closing the now new conditional later, though it makes me wonder how this works...

And there are two other mistakes but it seems they don't cause the parser to fail. It's in this line:

Code: [Select]

%s%ac%?ia<%ia|%?ic<$ic|%?2<%d2|Unknown Artist>>>

I think that would be "%ic" and "%?d2".

[RedBreva]

I see what you mean, but for now the aim was to get it to load... it needs to be used to see if it actually works the way it should...

If I get some time later today, I may have another go at checking/fixing it - including restoring the original bg.bmp image, and do the same thing for the other wiki version of this theme.
Edit: Pixelma was correct with that tag, and now it loads *and* seems to work as expected.  I also updated/uploaded the version2 amwps with the nokia font.

On a wider note:
In view of the recent licensing discussions, are we assuming that anything posted to the wiki is 'open' for modification etc. Should these fixes even be happening, and would it be OK to licence the repaired version under CC3 for example?

[Iggy]

Thank you very much guys

Now it works and I have the pleasure of enjoying the theme.^^

Just one more favor, if it isn't too much work. I don't need the peak meter that comes up every few seconds. How do I remove that? Which lines must be removed or changed?

[RedBreva]

I know what you mean, I too thought that a bit strange:

to edit your local copy :-
Remove the ;%t8%pm from line 66 and the ;%t8 from line 67

[Iggy]

Uhh, that doesn't work right...

Yes, the peak meter is gone now, but the 'titles' (next, file, vis) are there and due to the not existing peak meter they get confused. They come up in the wrong order. One would have to delete the 'vis' (or 'peak' in v2 of the theme).
And in line 67 are several ;%t8, how should I know which I should remove?