Rockbox General > Rockbox General Discussion
Rejection of "ignore the" patch (split from the Evil_G unsupported build thread)
jurrie:
--- Quote from: Llorean on June 13, 2007, 05:23:33 PM ---I don't understand how it's a better idea not updating the files?
--- End quote ---
First: it's a lot of content to copy for each file just to add one, or a few, tags. Second (and this is admittedly personal preference): I prefer that a "Player" not modify content.
--- Quote ---Surely the files on your device aren't the primary copy of your music collection.
--- End quote ---
Correct. However, the primary copy is where the change should be made (a flac file, in my case) and then propogated/published downstream.
--- Quote ---Meanwhile, altering the files on the device allows the tags to be used by other programs (as there are programs that do support them),
--- End quote ---
Programs inquiring about audio content could(should?) query the database instead.
--- Quote --- and insures that should you need to re-initialize the database you won't have to re-run the plugin.
--- End quote ---
Yup, that's one thing that I overlooked previously. I've updated my previous post to reflect this "con".
In the end, it may just be a difference in philosophy. I look at at Rockboxed players as players. Content (including tags) should be created/manipulated elsewhere. So.... if the perception is that this really is a "Rockbox issue" (which I don't - it's a tag accuracy/integrity issue), then having a sorting-tag fixer utility provided by the Rockbox community (a la, Rockbox Utility) would be my preferred solution. Such a utility could be run on the primary audio content copy, or if the player's content is mounted on the utility's host it could be run on the Rockbox audio content copy.
Llorean:
The expectation is that the user will have files they've manually added these tags to.
The plugin would exist as a *means* of adding these tags should their current audio management tools not support the tags, or because they don't want to manually add them and wish to use a basic algorithm stripping a certain list of articles. This plugin should of course be a "last resort" as a tool doing this would work best on a computer where it could run faster.
The idea isn't that this plugin is a primary solution. Rather it's a last resort solution for those who absolutely refuse to tag their files manually or have a utility on their computer do it, and insist everything must be done on the player.
I don't think it would be a good idea to address the database directly, nor do I think plugins should be reading from the database for information about a song unless the plugin is directly related to the database because when doing so the database may not exist. Not that the sort tags are likely to be used outside the context of the database, but I think they're an attribute of the file metadata and should be kept in the file metadata.
Manipulating the database directly, a la iTunes, results in files that aren't properly usable elsewhere because some or all of the metadata a user expects to have been added to them by their actions doesn't show up. (iTunes has been known to not write tags to files, only updating the iPod database, making those files impossible to use in Rockbox since they have no recognizable filename nor complete metadata)
jurrie:
--- Quote from: Llorean on June 13, 2007, 08:45:58 PM ---The expectation is that the user will have files they've manually added these tags to.
--- End quote ---
Agreed.
--- Quote ---The idea isn't that this plugin is a primary solution. Rather it's a last resort solution for those who absolutely refuse to tag their files manually or have a utility on their computer do it, and insist everything must be done on the player.
--- End quote ---
Right.... I guess we just differ in opinion on where this tool should run.
--- Quote ---I don't think it would be a good idea to address the database directly,
--- End quote ---
Agreed. That's why I suggested a database API. The only information that would be available to be read, or changed, would be that which the database elected to make available.
I'll stop harping on this now. The easiest way for me to contribute in this area is to provide the simple conversion tools for one or more common formats. Guess I'll get with safetydan to see what format he's looking for.
safetydan:
I'll just chime in here and say that I've no interest in working on a tag editing plugin. Especially since even such mainstream applications as iTunes already support editing and maintaining the sort tags.
The only thing I'm going to address is getting the database to use the sort metadata (when it's available) for sorting album/artist/title for display.
alienbiker99:
not to bring up this topic again, but i had a new idea. i was using mediamonkey and found out that it can ignore what ever words you want to ignore by typing it in one of the options. so i was thinking, why can't this kind of option be implemented into rockbox. this would solve the problem of not being multi-language. you would type it into an option which would create a .cfg then the database would ignore the word(s) that are in the config file + one space.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version