Rockbox General > Rockbox General Discussion
Rejection of "ignore the" patch (split from the Evil_G unsupported build thread)
magnumforce2006:
--- Quote from: Llorean on May 21, 2007, 11:20:57 PM ---Then write the patch to use both the Sort and Display tags.
A halfway solution should not be accepted just because nobody who wants to use it can be bothered to do it the right way.
--- End quote ---
And who deems this the "right way?" Why is shifting around a "the" field somehow sacrilege? I just don't really understand your reasoning.
Additionally, what do you even mean by sort and display tags? ID3V1 vs V2?
Yotto:
Because it's arbitrary, and only works for one language (or maybe a couple, I'm not language... ologist). Are you willing to code for Spanish, French, Italian... Maybe have a section where you can choose the language? What about people who have multiple languages in their song titles? What about Americans who would never be able to find "Bamba, La" because they don't think of that as the song title?
That's the first problem I can see, thinking about this for 5 seconds. The "Right way" Llorean's talking about isn't "Keep all your songs that start with 'the' together," it's "Think up a more intelligent way to sort the songs that fixes the problem."
lalittle:
--- Quote from: Llorean on May 21, 2007, 11:13:11 PM ---It's not the right way to solve the problem.
--- End quote ---
So you're saying that while you're in favor of (or at least don't object to) the behavior that's being sought, it's the particular method that you disagree with, correct?
I'm still confused about what it is you dislike about the concept of "ignoring" certain text strings (plus one space) that appear at the beginning of the tag. Isn't this literally the concept behind what needs to be done in order to sort the tags properly? In JR Media Center, the option for this is called "Ignore articles (a, an, the)," and it works perfectly. The articles are still present, but the sort order is correct.
Thanks for clarification,
Larry
magnumforce2006:
All I'm saying you guys, is that the default apple firmware and my old rio firmware, AND the creative players (I believe) all have databases with this sorting behavior.
It's what a lot of people are accustomed to, and I don't quite understand the resistance against it... Different languages? How would this adversely affect those users? And to add on to all of that... why not just make it an option? If you don't want that sorting behavior, don't use it.
I'm not a programmer so I'll stop there, because I know I really have no leverage in arguments due to that fact.
Llorean:
Your method: Clutters the code to solve the problem for ONE language in a firmware that supports many, and it does so in a manner that can conflict if for some albums you consider "The" a valid part of the sorting, while for others you don't (this is possible in many music collections).
My method: Works for any language or combination of languages, uses existing standards, and adds greater flexibility up to and including adding in one swoop the possibility to ignore The, ignore any other part of the title you want, have albums by various artists show up as a single album, have two disk sets have their disks labelled properly but still show up as a single album, all with one "feature".
The Rockbox developers decide what the "Right" way is, and reject patches that aren't the "Right" way because the patch tracker is the ROCKBOX patch tracker. It's for submitting patches to be included, and if we don't want them, they get rejected and closed. And by "Right" I mean "The way that is Right for Rockbox." Just because someone else chose to do it a different way is absolutely NO argument for Rockbox to use a halfway measure.
And no, I do not mean "ID3v1 vs ID3v2". Do some research in the tagging formats, or read the explanation I've given several times before when this same subject has come up. I'm getting tired of repeating myself on the same topic. See information on the TSOP, TSOT, and TSOA tags for ID3v2.4, and their equivalent tags in other tagging specs.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version