Rockbox General > Rockbox General Discussion

Rejection of "ignore the" patch (split from the Evil_G unsupported build thread)

(1/23) > >>

lalittle:

--- Quote from: evilg123 on May 20, 2007, 02:30:39 PM ---The ignore the patch is not included because the dev's rejected it, meaning that it is not likely to ever be included in SVN.
--- End quote ---

When you say "rejected," do you mean they decided it wasn't something that they thought was necessary?  If so, that seems really odd to me.  I'd think that EVERYBODY who uses the database view would want this.

I tried to find out more information on this, but I couldn't -- it's hard to search for issues where one of the search terms is the word "the."

Thanks,

Larry

magnumforce2006:

--- Quote from: lalittle on May 21, 2007, 08:33:33 PM ---
--- Quote from: evilg123 on May 20, 2007, 02:30:39 PM ---The ignore the patch is not included because the dev's rejected it, meaning that it is not likely to ever be included in SVN.
--- End quote ---

When you say "rejected," do you mean they decided it wasn't something that they thought was necessary?  If so, that seems really odd to me.  I'd think that EVERYBODY who uses the database view would want this.

--- End quote ---

I'm puzzled about this as well  ???

Llorean:
It's not the right way to solve the problem.

The proper solution is this:
There are in many tagging formats two tags each for Title, Artist, and Album. One for display, and one for use in sorting. If you want The to be ignored, for the sorting tag, you put "Blah, The" instead of "The Blah" (which you use for the display tag).

So a correct solution would be for someone to make a patch to use all of the tags effectively, rather than for it to intentionaly ignore a string of characters.

Until then, simply tag your files "Blah, The" if you want "The" not to be used in the search.

magnumforce2006:

--- Quote from: Llorean on May 21, 2007, 11:13:11 PM ---It's not the right way to solve the problem.

The proper solution is this:
There are in many tagging formats two tags each for Title, Artist, and Album. One for display, and one for use in sorting. If you want The to be ignored, for the sorting tag, you put "Blah, The" instead of "The Blah" (which you use for the display tag).

So a correct solution would be for someone to make a patch to use all of the tags effectively, rather than for it to intentionaly ignore a string of characters.

Until then, simply tag your files "Blah, The" if you want "The" not to be used in the search.

--- End quote ---

This is not the proper formatting for those artists, however, and will screw up many last.fm submissions.

Llorean:
Then write the patch to use both the Sort and Display tags.

A halfway solution should not be accepted just because nobody who wants to use it can be bothered to do it the right way.

Navigation

[0] Message Index

[#] Next page