Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Welcome to the Rockbox Technical Forums!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Album Art Tags in wps - Error or Ignore??
« previous next »
  • Print
Pages: [1]

Author Topic: Album Art Tags in wps - Error or Ignore??  (Read 1549 times)

Offline RedBreva

  • Member
  • *
  • Posts: 101
    • Rockbox Themes Site
Album Art Tags in wps - Error or Ignore??
« on: May 21, 2007, 10:31:22 AM »
There are several AA themes which used to work with a standard daily build, by - I think - having the offending non standard tags below the bottom line of the screen.  If an AA build was present, AA was displayed, else No-Album Art placeholder graphic was seen.

Since the improved parsing, this no longer works, the AA tags causing a failure.  

My question is *should* it?  Might it be possible to just ignore these (well known) unknown tags to allow the old method to work...

Just a suggestion, what's the opinion of other people??
Logged

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: Album Art Tags in wps - Error or Ignore??
« Reply #1 on: May 21, 2007, 11:49:08 AM »
Why should the official build go out of its way to work with WPSes with tags it doesn't recognize? These tags are invalid, and I don't think it should make exceptions for tags that are "Invalid, but we'll ignore them since they're valid in other builds." It somewhat defeats the purpose of the parser rejecting invalid tags and otherwise if there are exceptions. What if someone does %C as a typo rather than intending to have album art? The parser will ignore it, and they'll think there's nothing wrong with the WPS, except that it's behaving irregularly, and possibly report a bug.

I think there should be no exceptions.
Logged

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Album Art Tags in wps - Error or Ignore??
 

  • SMF 2.0.18 | SMF © 2021, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.884 seconds with 22 queries.