Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Welcome to the Rockbox Technical Forums!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Trying to figure out exactly how the new rockbox build broke my wps screen.
« previous next »
  • Print
Pages: [1] 2

Author Topic: Trying to figure out exactly how the new rockbox build broke my wps screen.  (Read 4053 times)

Offline lalittle

  • Member
  • *
  • Posts: 103
Trying to figure out exactly how the new rockbox build broke my wps screen.
« on: May 15, 2007, 08:52:18 PM »
The new build seems to have thrown a wrench in the works for me when it comes to my wps screen.  I basically reverse engineered my wps screen from an existing one, and it's been working great for a year or two now.  It doesn't work, however, with the newer build I just installed, and I have no idea what it is in my wps that the new build doesn't like.  Trying to figure this out is going to be extremely complicated since this stuff is very complicated and foreign to me.

Is there some documentation that shows which aspects of the new wps format have changed compared to the old one so that I don't have to essentially start from scratch?  It took me quite a while to figure this stuff out before, and I had the luxury of a wps screen that already worked.  Now, the "base" screen I'm using doesn't even work anymore, so I have no idea where to look for where the problem might be occurring.

Thanks,

Larry
Logged

Offline lights0ut

  • Artist
  • Member
  • *
  • Posts: 382
Re: Trying to figure out exactly how the new rockbox build broke my wps screen.
« Reply #1 on: May 15, 2007, 09:07:33 PM »
The WPS parser is now more picky code that would be wrong but not critical used to not break a WPS, but now it will. (I actually prefer this, because as a WPS author I like to know if I missed a < character or something)

You could try running the theme on a simulator by running it with the  --debugwps option, but as it seems you are a little lacking in WPS code knowledge I doubt that the output would be of use to you. If you want, I will try to fix the wps for you, just PM me the .wps file, or post it here.
Logged

Offline lalittle

  • Member
  • *
  • Posts: 103
Re: Trying to figure out exactly how the new rockbox build broke my wps screen.
« Reply #2 on: May 15, 2007, 09:21:07 PM »
Thanks evil,

I'm sending you the file.

I noticed that at least some of the syntax is changed, such as the clock.  How "much" of it is changed is what I honestly don't know.  Thanks for any help you might be able to offer in getting this to work again.

Thanks again,

Larry
Logged

Offline lights0ut

  • Artist
  • Member
  • *
  • Posts: 382
Re: Trying to figure out exactly how the new rockbox build broke my wps screen.
« Reply #3 on: May 15, 2007, 09:26:28 PM »
As far as I know, changes in RTC code will not break the WPS, but I will fix that too ;)
Logged

Offline Angyman

  • Member
  • *
  • Posts: 54
Re: Trying to figure out exactly how the new rockbox build broke my wps screen.
« Reply #4 on: May 16, 2007, 02:01:30 AM »
Most WPS just have to be fixed in these areas:

Clock Syntax - See the wiki
Conditionals - no more blank spaces before the "<" sign allowed...
e.g.: ?It     <- is not allowed       ?It       <-works...
Logged

Offline lalittle

  • Member
  • *
  • Posts: 103
Re: Trying to figure out exactly how the new rockbox build broke my wps screen.
« Reply #5 on: May 16, 2007, 02:45:55 AM »
Quote from: evilg123 on May 15, 2007, 09:26:28 PM
As far as I know, changes in RTC code will not break the WPS, but I will fix that too ;)

Thanks -- I appreciate you taking the time to do this.

Larry
Logged

Offline lights0ut

  • Artist
  • Member
  • *
  • Posts: 382
Re: Trying to figure out exactly how the new rockbox build broke my wps screen.
« Reply #6 on: May 16, 2007, 08:38:09 PM »
Larry, I get errors trying to extract the zip file you emailed me. I can open it up, but when I got to view/extract the file I get errors. I don't run windows so I'm not using the latest version of winzip, which  I have heard can cause some compatibility problems (WinZip 11 format, I think). I'm trying to find the right program, I run linux so if anyone can recommend something that'd be good. What would be better is if you could send me a .zip made from WinRAR, I'm sure that there are no issues with that program (don't worry it's free). Either that or just send me the .wps file.

EDIT: nevermind, got it to work ;) Turns out that Gnome's archive manager can handle the archive, still used to my kde apps
« Last Edit: May 16, 2007, 08:42:50 PM by evilg123 »
Logged

Offline lights0ut

  • Artist
  • Member
  • *
  • Posts: 382
Re: Trying to figure out exactly how the new rockbox build broke my wps screen.
« Reply #7 on: May 16, 2007, 09:29:06 PM »
Larry, your wps is fixed, due to the nature of the problem, I thought it best to make a new archive, so
here is a link
 
The problem was that first, your cfg was referencing Applebox.wps (note the lowercase .wps) and the actual file was named Applebox.WPS. The way the parser works, the file needs to be named EXACTLY the same as it is referenced in the .cfg for it to be found by the parser. The second problem was that in the conditional for the hard disk activity, (%?h i think) there is a true value but not a false value.
(seen as this )   %?h< true
The parser requires that all conditionals have all values set to something (at least null (space)  ) and have them properly closed.
(like this ) %?h

This works on my local simulator so it should be OK on your player, I would remove the previous version from the player before I put the fixed one on there just to be safe.
Logged

Offline lalittle

  • Member
  • *
  • Posts: 103
Re: Trying to figure out exactly how the new rockbox build broke my wps screen.
« Reply #8 on: May 16, 2007, 10:31:35 PM »
THANKS so much for taking the time to do this.  The wps file is rather complicated to me, so even though I was able to make some changes to the original one myself, I don't think I would have been able to figure out all the things you fixed even by spending considerable time on it.

I'll give it a try and report back.

Thanks again,

Larry
Logged

Offline lalittle

  • Member
  • *
  • Posts: 103
Re: Trying to figure out exactly how the new rockbox build broke my wps screen.
« Reply #9 on: May 17, 2007, 03:28:14 AM »
Quote from: evilg123 on May 16, 2007, 09:29:06 PM
Larry, your wps is fixed, due to the nature of the problem, I thought it best to make a new archive, so
here is a link
 
The problem was that first, your cfg was referencing Applebox.wps (note the lowercase .wps) and the actual file was named Applebox.WPS. The way the parser works, the file needs to be named EXACTLY the same as it is referenced in the .cfg for it to be found by the parser. The second problem was that in the conditional for the hard disk activity, (%?h i think) there is a true value but not a false value.
(seen as this )   %?h< true
The parser requires that all conditionals have all values set to something (at least null (space)  ) and have them properly closed.
(like this ) %?h

This works on my local simulator so it should be OK on your player, I would remove the previous version from the player before I put the fixed one on there just to be safe.

evilg123,

Everything seems to work except for the battery level "icon display" in the UPPER right corner.  The battery "time remaining" readout displays correctly in the BOTTOM right corner, but there should also be an icon in the upper right that gives a graphic representation of the battery level, as well as the power and charging status.  This isn't displaying.

Also, you mentioned the hard drive activity indicator causing a problem, but I compared the old line to the new one, and the line I'm looking at is the same (i.e. "%?lh<%xda|%xdb>").  I'm therefore confused what was changed in this regard.

Thanks again for all your help,

Larry

UPDATE:  After a reboot, the "graphic" battery indicator was suddenely working again.  I posted about this, and when I looked back, it was once again missing.  Any idea what could be causing this "here one minute - gone the next" behavior for the graphic battery indicator?  This is the only thing I can see that is doing this.
« Last Edit: May 17, 2007, 03:39:12 AM by lalittle »
Logged

Offline lalittle

  • Member
  • *
  • Posts: 103
Re: Trying to figure out exactly how the new rockbox build broke my wps screen.
« Reply #10 on: May 17, 2007, 10:47:32 PM »
Here is the line in the wps that appears to display the graphic battery info.  Can anyone tell me what it is about this that the newer rockbox builds don't like?  This worked before (February builds) but now the battery info doesn't consistently stay on the screen -- sometimes it's there, but other times this area of the screen is just blank.

In looking at this line, I discovered that it's the same line repeating six times.  If I add hard returns after each ";" I end up with this:

%t1%pe%?bp<%?bc<%xdt|%xdG>|%?bl<%xdA|%xdB|%xdC|%xdD|%xdE|%xdF>>;
%t1%pe%?bp<%?bc<%xdt|%xdG>|%?bl<%xdA|%xdB|%xdC|%xdD|%xdE|%xdF>>;
%t1%pe%?bp<%?bc<%xdt|%xdG>|%?bl<%xdA|%xdB|%xdC|%xdD|%xdE|%xdF>>;
%t1%pe%?bp<%?bc<%xdt|%xdG>|%?bl<%xdA|%xdB|%xdC|%xdD|%xdE|%xdF>>;
%t1%pe%?bp<%?bc<%xdt|%xdG>|%?bl<%xdA|%xdB|%xdC|%xdD|%xdE|%xdF>>;
%t1%pe%?bp<%?bc<%xdt|%xdG>|%?bl<%xdA|%xdB|%xdC|%xdD|%xdE|%xdF>>

Can anyone tell me why this is?  I didn't design this part of the wps, so I have no idea why this would be the case, but it doesn't make sense to me as it is.  Could this be related to the problem?

[EDIT by NicolasP: merged two similar posts ]

Thanks,

Larry
« Last Edit: May 19, 2007, 01:06:09 PM by NicolasP »
Logged

Offline lalittle

  • Member
  • *
  • Posts: 103
Re: Trying to figure out exactly how the new rockbox build broke my wps screen.
« Reply #11 on: May 18, 2007, 12:09:12 AM »
I seem to have found a relationship between the disappearing battery graphic and plugging in the iPod to power.

I boot the iPod, play a song, and the battery graphic is present.  I then plug it into power (car adapter) at which point the battery graphic changes to indicate "charging."  When I unplug the iPod, the graphic changes back to the battery level graphic, then disappears.  It does not show up again until I restart the iPod, at which point the battery "level" graphic will remain until I once again plug in the iPod.

Thanks for any help with this,

Larry
Logged

Offline lights0ut

  • Artist
  • Member
  • *
  • Posts: 382
Re: Trying to figure out exactly how the new rockbox build broke my wps screen.
« Reply #12 on: May 18, 2007, 05:44:46 AM »
If it's the same line repeated 6 times, have you tried it with just one line? Remove the other
five lines, as you've pointed out, they're the exact same and therefore unnecessary. Maybe this
was supposed to be an animation but never got finished?
Logged

Offline lalittle

  • Member
  • *
  • Posts: 103
Re: Trying to figure out exactly how the new rockbox build broke my wps screen.
« Reply #13 on: May 18, 2007, 07:51:59 PM »
Quote from: evilg123 on May 18, 2007, 05:44:46 AM
If it's the same line repeated 6 times, have you tried it with just one line? Remove the other
five lines, as you've pointed out, they're the exact same and therefore unnecessary. Maybe this
was supposed to be an animation but never got finished?

I tried it with just one line and I still get the same type of behavior -- inconsistent display of the battery graphics.  There must be something "wrong" with the line/s in the newer builds, but I just can't tell what the problem might be.  All I know is that it worked fine before, but not with the new rockbox builds.

If anybody could take a look at the line and tell me if something looks out of whack, I'd appreciate it.  As far as I can tell, it looks like it should work to me, but I'm not very experienced with this stuff.

Thanks,

Larry
Logged

Offline lalittle

  • Member
  • *
  • Posts: 103
Re: Trying to figure out exactly how the new rockbox build broke my wps screen.
« Reply #14 on: May 18, 2007, 11:44:39 PM »
I figured out the disappearing battery graphic.  It was the presence of "%xdF" in the ?bl section of the line.  There is no "F" picture, so it appears that it was placing a blank in that section.  I removed the "%xdF" from the ?bl list, and the problem went away.

I also took out the "%t" from the line, as well as all the repeats, since I couldn't find any reason for the subline function on that line.  If anyone knows of a reason that this line contained the subline capability, please let me know.

Thanks,

Larry
Logged

  • Print
Pages: [1] 2
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Trying to figure out exactly how the new rockbox build broke my wps screen.
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.476 seconds with 15 queries.