Rockbox General > Rockbox General Discussion

id3 V1 vs V2

<< < (2/3) > >>

Lear:
By the way, that bug was introduced with the WPS tokenizer. The old code treated empty strings as "no value" in conditionals.

Zivo:

--- Quote from: Lear on May 02, 2007, 10:14:41 AM ---Hm, do you mean that e.g.  would show a blank line rather than "Empty" if an ID3V1 tag didn't provide a value? If so, then yes, that is a bug. It seems the ID3V1 parser doesn't handle empty strings the way other parts of Rockbox expects...

--- End quote ---

this is not what i meant
what i meant is
%?ia still if no artist in id3v1 it will show blank line insted the directory

when you look at "show ID3 info" in the [artist] you will see jest blank line
unlike ID3v2 which will show you

i dont think the bug is in the WPS code
i believe its something in the player that reads the ID3 info
and doesnt consider blank fields in ID3v1 as

correct me if i m wrong

roolku:

--- Quote from: Lear on May 02, 2007, 10:21:46 AM ---By the way, that bug was introduced with the WPS tokenizer. The old code treated empty strings as "no value" in conditionals.

--- End quote ---

Yes, I have noticed that myself. ID3v1 can not have null strings, only empty ones, so I get lots of empty comments in brackets in my wps. :)

So either do a

return (!string &&  !*string)  ? string : null;    

instead of a

return string;

for every tag concerned or better yet solve it globally for all tags.

Lear:

--- Quote from: Zivo on May 02, 2007, 10:35:37 AM ---this is not what i meant
what i meant is
%?ia still if no artist in id3v1 it will show blank line insted the directory

--- End quote ---

That's what I meant too, even if my wording wasn't entirely clear. :)


--- Quote ---when you look at "show ID3 info" in the [artist] you will see jest blank line
unlike ID3v2 which will show you

--- End quote ---

Ah, then I guess the ID3 info screen needs a fix too.


--- Quote ---i dont think the bug is in the WPS code
i believe its something in the player that reads the ID3 info
and doesnt consider blank fields in ID3v1 as

--- End quote ---

The WPS code used to treat blank fields as 'no info', but that was changed recently.

Zivo:

--- Quote from: roolku on May 02, 2007, 11:30:00 AM ---

Yes, I have noticed that myself. ID3v1 can not have null strings, only empty ones, so I get lots of empty comments in brackets in my wps. :)

So either do a

return (!string &&  !*string)  ? string : null;    

instead of a

return string;

for every tag concerned or better yet solve it globally for all tags.


--- End quote ---


i didnt understand what is this code, is it for WPS ?
where should i wirte it and how it can help me ?

Navigation

[0] Message Index

[#] Next page

[*] Previous page