id3 V1 vs V2

[Zivo]

hello

i have music file some with id31 some with id32
when i choose priority to v2 it doesnt show v1
and when i choose priority to v1 it doesnt show v2

so what im asking why to use the word "priority"
as i understand it means that if you have a file with both v1 & v2
than the player will choose the priortiy version that you selected

anyone have the answer

thank you

[roolku]

as i understand it means that if you have a file with both v1 & v2
than the player will choose the priortiy version that you selected

I am fairly sure (from reading the code) this is how it is supposed to work. If it doesn't it is a bug.

However you may want to make sure the the tag is really not there and not just empty which could lead to the described behaviour.

[Zivo]

i will cheack it again

but if some other users have the same problem

please write it here

[Zivo]

ok i cheak it

and its my mistake , so i m sorry

but...

the reason i thought this is not working its because of another bug


when you use id3v1 and not fill all the fields, like "artist" for exemple.
the player show you an empty line insted the condition you wrtie for empty fields.
in the ID3v2 it works great even if the ID3v1 is partly filled and the priority is v2

so can it be fixed?

[Lear]

Hm, do you mean that e.g. %?ia<%ia|Empty> would show a blank line rather than "Empty" if an ID3V1 tag didn't provide a value? If so, then yes, that is a bug. It seems the ID3V1 parser doesn't handle empty strings the way other parts of Rockbox expects...

[Lear]

By the way, that bug was introduced with the WPS tokenizer. The old code treated empty strings as "no value" in conditionals.

[Zivo]

Hm, do you mean that e.g.  would show a blank line rather than "Empty" if an ID3V1 tag didn't provide a value? If so, then yes, that is a bug. It seems the ID3V1 parser doesn't handle empty strings the way other parts of Rockbox expects...

this is not what i meant
what i meant is
%?ia<%ia|%d1> still if no artist in id3v1 it will show blank line insted the directory

when you look at "show ID3 info" in the [artist] you will see jest blank line
unlike ID3v2 which will show you

i dont think the bug is in the WPS code
i believe its something in the player that reads the ID3 info
and doesnt consider blank fields in ID3v1 as

correct me if i m wrong

[roolku]

By the way, that bug was introduced with the WPS tokenizer. The old code treated empty strings as "no value" in conditionals.

Yes, I have noticed that myself. ID3v1 can not have null strings, only empty ones, so I get lots of empty comments in brackets in my wps.

So either do a

return (!string &&  !*string)  ? string : null;    

instead of a

return string;

for every tag concerned or better yet solve it globally for all tags.

[Lear]

this is not what i meant
what i meant is
%?ia<%ia|%d1> still if no artist in id3v1 it will show blank line insted the directory

That's what I meant too, even if my wording wasn't entirely clear.

when you look at "show ID3 info" in the [artist] you will see jest blank line
unlike ID3v2 which will show you

Ah, then I guess the ID3 info screen needs a fix too.

i dont think the bug is in the WPS code
i believe its something in the player that reads the ID3 info
and doesnt consider blank fields in ID3v1 as

The WPS code used to treat blank fields as 'no info', but that was changed recently.

[Zivo]

Yes, I have noticed that myself. ID3v1 can not have null strings, only empty ones, so I get lots of empty comments in brackets in my wps.

So either do a

return (!string &&  !*string)  ? string : null;    

instead of a

return string;

for every tag concerned or better yet solve it globally for all tags.

i didnt understand what is this code, is it for WPS ?
where should i wirte it and how it can help me ?

[NicolasP]

Your problem should be solved in the latest SVN builds. You have nothing to do but check it works

[Zivo]

alright thanks for your attention 8-)