Rockbox Development > New Ports
Cowon D2
JdGordon:
void* is usually used to just say "random data... no real type.." but yeah, we could have used int32_t or something.. but its there now..
yes, plugins get rebuilt, but there is a mechanism where if you only update the rockbox.target file plugins of older revisions will still load if the API versions are compatible... adding funcitons in the middle of the struct breaks that.
BUTTON_RC_MODE would be ideal...
1) yeah, i noticed that also, i think we need to add a error margin around the joins, or something
2,3) not realy sure what your mean...
I havnt tested the plugin yet and wont be able to till next week unfortunatly.
saratoga:
--- Quote from: shotofadds on May 01, 2008, 06:22:20 AM ---
I don't really understand "add functions to the end of the plugin api or you break builds unless a full rebuild is done". Surely the very act of updating plugin.h causes all plugins to be rebuilt? (but that's rather off-topic for this thread I guess...)
--- End quote ---
I think that since files include headers, rather then headers including other files, changes to .h files do not propagate down to the files that include them automatically.
shotofadds:
--- Quote from: saratoga on May 01, 2008, 10:37:40 AM ---I think that since files include headers, rather then headers including other files, changes to .h files do not propagate down to the files that include them automatically.
--- End quote ---
I don't think that's right, eg. a change to plugin.h causes "make rocks" to rebuild every plugin.
But then again, if there's a "best practise" for this kind of thing, let me know as this is the first time I've done any changes in this area.
kugel.:
About the plugin API stuff. The plugins get rebuilt, sure, but only if you make a full build.
If you only do "make bin", the plugins are not built.
make bin is very much faster and is very usefull, especially when plugins/plugin api do not change.
The version number is just to make older plugins work with newer rockbox.target files.
So, if you put new functions to the end, old plugins will still work. If you put the into the middle, old plugins will mess up.
To make old plugins work, you need to put it to the end, until you choose to increase the plugin api version number. Then plugins will error and need to be rebuilt. That's allways a good situation to reorganize the api functions.
* kugel. hopes that was correct.
shotofadds:
Sounds about right. Here's version 2 of test_touchpad, which should address those comments: http://www.pastebin.ca/1004398
jdgordon: I noticed one more thing: in stylus mode, the button_data doesn't seem to contain the x/y values for BUTTON_REL events. Is that intentional? It's not very useful if so...
And no, I don't know why I didn't use the tracker for this patch... ???
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version