Rockbox Development > New Ports
Cowon D2
JdGordon:
not sure what you mean by that...
What I was saying is that we should force touchpad targets to have a common button mapping for the touchscreen to make everything easier.. (1 manual, 1 keymap file, easier to move between targets, etc). sure they will all have differences, but we can either use #ifdef TARGET, or use the keymap system to check for touch buttons first then move to the target keymap.c file for its real buttons (which I don't think is needed while we only have 2 touchpad targets...)
Llorean:
Your second suggestion is more or less what I was trying to propose. I think it's probably not a bad idea to assume we'll have more touchscreen targets (PDAs if as-an-app happens, for one), so treating the touchscreen controls as something completely separate from the keymap defines (since there's really only ever going to be one set of maps for the touchscreen, while physical buttons will always vary by target).
linuxstb:
--- Quote from: jdgordon on April 13, 2008, 08:27:10 AM ---as for CENTER/RE, yes, I couldnt remember which is which... I prefer UK english also, I'll change it.
--- End quote ---
The convention is to use US English for C symbols, and British English for user-visible text. So in this case it should be BUTTON_CENTER (but referred to as "centre" in the manual and any LANG strings).
JdGordon:
did a bit more work on this today.
keymap-touchpad.c is shared and only deals with the touchpad codes.. what should happen is the action code goes through that file, then if the button hasnt been found it goes to the tartgets keymap file.. seems to work but not fully tested.
Yeeze:
I am not sure but I think when talking about the controls, we might also consider "gesture" support...
There is no need to implement the recognition now, but we should think about the defines to keep them in the keymap or so...
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version