Support and General Use > Theming and Appearance Customization

Contest?

<< < (5/5)

Llorean:
Your statement shows a complete misunderstanding of how .cfg files work.

They're all treated the same (themes, iconsets, standard cfgs, equalizer presets), they're all *just* config files. Your requirement means distinguishing some way between whether a .cfg is a theme, an eq preset, or otherwise, or distinguishing as to whether a setting should be reset if not present, or left the same if not present. Both of which break how .cfg files work presently. Loading things from a preferred .cfg file when they're not present is somewhat silly: Every time someone clicked on an equalizer presets, it'd reset every other setting to the preferred one. And if you say "only with themes", you're forcing people to use the "Browse themes" option, or otherwise designate a theme WPS: What about those of us who switch themes for in-car use but choose a very limited theme that only changes certain aspects of the view (font and color, perhaps, not even WPS?).

I think any theme that changes the text color should also change the backdrop or background, and any theme that does *not* change the text color should reset it to the default (manually), but this should never be enforced in code, because it prevents the use of flexible .cfg files. Instead it should be enforced in themes.

But what does "black on black" have to do with iconsets? Why on Earth should a theme force a reset of iconsets to the default, just because?

I can see perhaps a default iconset being chosen if the new font height is less than the iconset height, MAYBE, but I don't see resetting the icon set every single time a theme is changed as a valid option.

lights0ut:
Llorean, I'm starting to agree to your way of thinking on this whole icons issue. In summary are you saying that if a theme has a specific iconset for the theme it should set and if there is no iconset for the theme, the cfg should leave the icons alone. After all this discussion I think that makes the most sense.

RedBreva:
I have made a start on a Wikipage to sum up these notes

http://www.rockbox.org/twiki/bin/view/Main/ThemeGuidelines

Feel free to amend and expand...

lights0ut:
just wondering if anyone was still interested in this? I'm currently in the process of acting on my plans to reorganize the WPS gallery (mainly the iPod 5G), and I was thinking of doing a mass round of debugging after I was done (depending on how much effort I exert on reorganizing)

Navigation

[0] Message Index

[*] Previous page