Rockbox Development > Starting Development and Compiling
gigabeat screen rotation patch
lights0ut:
Nate has let me know that this patch needs a resync due to recent commits for LCD optimizations.
We no longer use DMA for the LCD so the code has been changed a bit. I've been unsuccessfully trying to sync this, so I thought I'd just get the word out.
The file that is out of sync is:
/firmware/target/arm/s3c2440/gigabeat-fx/lcd-meg-fx.c
which has 3 hunks fail. I think what needs to be done is modify the variables in the new functions (LCD_WIDTH changes to R_LCD_WIDTH) but it may be more.
lights0ut:
I've managed to sync this patch so no worries, but thanks to anyone who even considered lending a hand ;)
Mad Cow:
--- Quote from: evilg123 on May 17, 2007, 06:33:37 PM ---I've managed to sync this patch so no worries, but thanks to anyone who even considered lending a hand
--- End quote ---
What did you do? I'm glad to hear that though, because I'm terrible with patches and I didn't really want to do it. ;)
lights0ut:
I'll attach the .rej so you can see what wasn't patching, and try to explain as best I can:
-the first hunk I needed to just copy and paste, as well as the second.
-The next hunk dealt with DMA, which was removed from SVN as we do not usDMA to access the
Gigabeat's LCD. By looking at the diffs from the recent SVN commits I figured that this stuff was
unneccessary, so I continued to the next hunk
-the hunk after that deals with the memcpy function (which I assume is used to draw the LCD) and appears to
be the same, so again i just copied the the intended code and replaced it.
At first, I thought I had to find all instances of LCD_WIDTH and replace them with R_LCD_WIDTH etc. but after running into problems I decided to take some closer looks at the patch file, the .orig, the .rej, and the SVN diffs (the SVN diffs were the real key to this). After reading them, I came up with the solution I just explained, and after some 'massaging' it worked. I didn't quite copy and paste as I was supposed to, an extra } character here or there, and I think one of the parts I needed I forgot to paste in the first time. That stuff I figured out from gcc's error messages.
[attachment deleted by admin for age]
Mad Cow:
--- Quote from: evilg123 on May 17, 2007, 07:53:41 PM ---I'll attach the .rej so you can see what wasn't patching, and try to explain as best I can:
-the first hunk I needed to just copy and paste, as well as the second.
-The next hunk dealt with DMA, which was removed from SVN as we do not usDMA to access the
Gigabeat's LCD. By looking at the diffs from the recent SVN commits I figured that this stuff was
unneccessary, so I continued to the next hunk
-the hunk after that deals with the memcpy function (which I assume is used to draw the LCD) and appears to
be the same, so again i just copied the the intended code and replaced it.
At first, I thought I had to find all instances of LCD_WIDTH and replace them with R_LCD_WIDTH etc. but after running into problems I decided to take some closer looks at the patch file, the .orig, the .rej, and the SVN diffs (the SVN diffs were the real key to this). After reading them, I came up with the solution I just explained, and after some 'massaging' it worked. I didn't quite copy and paste as I was supposed to, an extra } character here or there, and I think one of the parts I needed I forgot to paste in the first time. That stuff I figured out from gcc's error messages.
--- End quote ---
I have no idea what you just said, but good job. :D
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version