WPS tokenizer: REPORT PROBLEMS HERE

[Mmmm]

Mmmm: I'll probably readd the crossfeed tag eventually but it won't be %xd anymore.
I'm about to commit a fix that should prevent crashing with the code you gave.

Great stuff.... I'm not worried about the letters used, anything will do: cf cd cr although I think some of those may be taken already..I haven't had a look at that bit of the code for a long long time...

[NicolasP]

However, my WPS up on the Wiki, (TextBox), is still causing a freeze, and it contains no hash characters.

It is more complicated, but I don't see why it is misbehaving. Can anyone shed some light?

That WPS made me find another flaw in the parsing code, so thanks again
It should work fine with r13162.

[vimes]

Is the problem still present with the latest version (r13127) ?

I just downloaded the latest version (couldn't find the r#####) and it still displays the info improperly. I uploaded comparison images in hope it will help you out.

[Llorean]

Um, that theme requires a custom build. You are aware that this thread is about the OFFICIAL build, right?

[vimes]

Yep, but I never ever used custom builds and there were working great before (i.e. except for the covers of course) so I figured the problem relied in the official build.

[Llorean]

Also, from the screenshots, it looks like you're not using the same font...

[vimes]

In any case, it also happens with the UniCatcher theme provided with the build while  using the default_rockbox font

[Llorean]

Unicatcher is not meant to be used with rockbox_default.

You cannot expect themes to look right if you haven't installed the fonts they require.

[bascule]

However, my WPS up on the Wiki, (TextBox), is still causing a freeze, and it contains no hash characters.

It is more complicated, but I don't see why it is misbehaving. Can anyone shed some light?

That WPS made me find another flaw in the parsing code, so thanks again
It should work fine with r13162.

Thanks, Nicolas, that works fine, now.

[RedBreva]

a few themes have failed to load with %bp - output from debugwps complains that it is invalid...

As far as I can tell from the Wiki it is still valid code...

[NicolasP]

How have they failed ? It's normal that %bp is deemed unknown on th sim, because the sim doesn't have charging.

[RedBreva]

The sim 'locks up' after loading - for example:
http://www.rockbox-themes.org/data/160x128x2/Headphones.zip

The debug output is here:
http://www.rockbox-themes.org/temp/headphones.zip
The only error I could see was the unknown for pb :-(

The music plays fine if the default theme is selected.

[NicolasP]

According to the debug output, the WPS has too many tokens, and this cuts a conditional before it closes. That's why the player locks.

[stripwax]

IMO the player should not lock up ...  no matter what kind of crap wps you throw at it..

If the token buffer is too full to fit a closing conditional, then either that last conditional should be removed, or the token buffer rolled back.

Or even, if the WPS failed to load for whatever reason, how about emptying the entire token buffer and inserting a single string token that describes what the error was?

[NicolasP]

Of course, I was planning on adding an error case for this, but I haven't had much time for rockbox in the last few days. My goal is to prevent all possible lock-ups.
About the message, I like the idea but displaying a splash message and then the default WPS would probably be a better solution than a WPS with a message. The only problem is that the error strings would need to be localized and that's probably not worth the binsize, so I think we'll have to stick to the sim messages.