Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search




Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Welcome to the Rockbox Technical Forums!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Conditionals with timings
« previous next »
  • Print
Pages: [1] 2

Author Topic: Conditionals with timings  (Read 5263 times)

Offline ew

  • Member
  • *
  • Posts: 52
Conditionals with timings
« on: August 20, 2010, 01:23:50 PM »
Is there a problem with conditionals and timings in the latest build.

The following snippet

Quote
%?mp<|%pb(0,0,-,-,linebarpb.bmp)|%pb(0,0,-,-,linebarpb.bmp)|%pb(0,0,-,-,linebarpb.bmp)|||%pb(0,0,-,-,linebarpb.bmp)|%pb(0,0,-,-,linebarpb.bmp)>

used to skip (display for 0 seconds) any blank values.  The recent build (27847 using the Sansa e200 simulator) seems to display all of the blank values.

Also, another observation using the recent change to the skin parser.  I used to have viewports that called other viewports.  For example:

%Vd(a)
......
%Vl(a,bla,bla....)
Display this text and the next viewport
%Vd(b)
......
%Vl(b,bla,bla....)
Display text
Display image

With the new skin parser, stuff in the secondary viewport are not cleared when they are no longer called by the primary viewport.  The old skin parser used to clear the sub viewports.  I did not know if that was something that was intended or unintended - I just though I would ask.

Thanks,

EW
Logged

Offline JdGordon

  • Global Moderator
  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: Conditionals with timings
« Reply #1 on: August 21, 2010, 03:44:29 AM »
apparently there is, it shuold have been fixed during the week,,, I'll have another look tomorow maybe
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline ew

  • Member
  • *
  • Posts: 52
Re: Conditionals with timings
« Reply #2 on: August 29, 2010, 04:51:51 PM »
Have you had a chance to look into this?  Unless I am doing something wrong - and, I realized that I must have posted the wrong snippet from my wps.

The snippet (conditional timing that is not working for me) is:

Quote
%?ic<%s%al%t(6)Composer:|%t(0)>;%?iA<%s%al%t(6)Alb Artist:|%t(0)>;%?ia<%s%al%t(6)Trk Artist:|%t(0)>
%?ic<%s%al%t(6)%ic|%t(0)>;%?iA<%s%al%t(6)%iA|%t(0)>;%?ia<%s%al%t(6)%ia|%t(0)>

Thanks,
Logged

Offline JdGordon

  • Global Moderator
  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: Conditionals with timings
« Reply #3 on: August 30, 2010, 12:30:37 AM »
how is it not working for you?
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline [Saint]

  • Rockbox Expert
  • Member
  • *
  • Posts: 1662
  • Hayden Pearce
    • Google+
Re: Conditionals with timings
« Reply #4 on: August 30, 2010, 12:38:56 AM »
Code: [Select]

%?ic<%s%al%t(6)Composer:|%t(0)>;%?iA<%s%al%t(6)Alb Artist:|%t(0)>;%?ia<%s%al%t(6)Trk Artist:|%t(0)>

%?ic<%s%al%t(6)%ic|%t(0)>;%?iA<%s%al%t(6)%iA|%t(0)>;%?ia<%s%al%t(6)%ia|%t(0)>



Is working as expected for me...I had to add the newline in the middle as the themeeditor seems to think its one line without doing so.

Code: [Select]
%?ic<%s%al%t(6)Composer:|%t(0)>;%?iA<%s%al%t(6)Alb Artist:|%t(0)>;%?ia<%s%al%t(6)Trk Artist:|%t(0)>
%?ic<%s%al%t(6)%ic|%t(0)>;%?iA<%s%al%t(6)%iA|%t(0)>;%?ia<%s%al%t(6)%ia|%t(0)>

Appears as:

Composer:Current Composer;Alb Artist:Current Album Artist; Trk Artist:Current Track Artist

As opposed to:

Composer:
Current Composer
;
Alb Artist:
Current Album Artist
;
Trk Artist:
Current Track Artist

* ";" signifies an alternation.


Something definitely isn't right in Alternating-Subline Town.



[St.]
Logged
Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline ew

  • Member
  • *
  • Posts: 52
Re: Conditionals with timings
« Reply #5 on: August 30, 2010, 10:53:57 AM »
Perhaps I should have clarified what my issue is.

There are 3 alternating displays (the info for each is divided into 2 lines):
  • Composer
  • Track Artist
  • Album Artist

On top of that is a conditional.  The conditional says that if the tag value is blank, skip (or display for time=zero) that display.

For example if the composer tag = "abc", and there are no Track Artist or Album Artist tags, the display will be:

Composer
ABC

and there would be no alternating text (because of the conditional.

What is happening for me is that the blanks are displaying alternatively.  It is as if the %t(0) tag is being displayed for a short time instead of no time at all.

I hope this explanation is a bit clearer.
Logged

Offline JdGordon

  • Global Moderator
  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: Conditionals with timings
« Reply #6 on: August 30, 2010, 08:39:40 PM »
interesting experiment... can you add ;%t(0) at least 25 times to your line and see if there is a difference in the time it takes to get back to displaying the composer text?
I think I see the bug and if you do notice an extra delay then it would be confirmed.. or alternativly, can you build your own builds?
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline ew

  • Member
  • *
  • Posts: 52
Re: Conditionals with timings
« Reply #7 on: August 30, 2010, 08:53:17 PM »
What I did is added ;%t(0) - 25 times at the end of one of the two lines.  The two lines have always been in sync (same conditions, same timings, just different text being displayed.

The two lines were out of sync - which means to me that the ;%t(0) did add some time.

Just to be clear - what I tested is the following:

1st line
Quote
%?ic<%s%al%t(6)Composer:|%t(0)>;%?iA<%s%al%t(6)Alb Artist:|%t(0)>;%?ia<%s%al%t(6)Trk Artist:|%t(0)>;%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0)
2nd line
Quote
%?ic<%s%al%t(6)%ic|%t(0)>;%?iA<%s%al%t(6)%iA|%t(0)>;%?ia<%s%al%t(6)%ia|%t(0)>

I hope this helps...

Thanks for looking at this.
Logged

Offline JdGordon

  • Global Moderator
  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: Conditionals with timings
« Reply #8 on: August 30, 2010, 09:09:41 PM »
yep, OK, then I see what the problem is.
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline JdGordon

  • Global Moderator
  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: Conditionals with timings
« Reply #9 on: August 30, 2010, 09:20:30 PM »
should be fixed in  r27956, so once that finishes building (3 min or so) please try it and let me know
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline JdGordon

  • Global Moderator
  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: Conditionals with timings
« Reply #10 on: August 30, 2010, 09:44:54 PM »
woops, no that is almost certainly wrong
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline JdGordon

  • Global Moderator
  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: Conditionals with timings
« Reply #11 on: August 30, 2010, 09:58:00 PM »
Yeah, this is a non-trivial fix. the issue is that we dont know which subline we want to draw based on the timeout untill we pick one and then calculate the conditionals so find the timeout.

So this is not fixed, ew, can you file a bug (I don't think there is one for this yet) although because it isnt trivial it probably wont be fixed any time soon.)
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline audio-i

  • Artist
  • Member
  • *
  • Posts: 266
Re: Conditionals with timings
« Reply #12 on: August 30, 2010, 10:28:47 PM »
Is this problem related or similar to FS#11542?
Logged

Offline JdGordon

  • Global Moderator
  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: Conditionals with timings
« Reply #13 on: August 30, 2010, 10:34:13 PM »
unrelated. that one is the timeout tag was being ignored, this one is that the subline chooser mechanism isnt smart enough to see that the line currently being displayed has been set to %t(0).

I'm not sure how to go about fixing this. I really dont want to conditionally check each subline for a %t buried inside conditionals.
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline ew

  • Member
  • *
  • Posts: 52
Re: Conditionals with timings
« Reply #14 on: August 31, 2010, 06:06:34 AM »
I will file a bug, but it will be a bit later today.  Thanks for looking into this.
Logged

  • Print
Pages: [1] 2
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Conditionals with timings
 

  • SMF 2.0.6 | SMF © 2013, Simple Machines
  • XHTML
  • RSS
  • WAP2

Page created in 0.126 seconds with 68 queries.