My proposal was intended for the Sansa e200, but should also work for other players which have a buttonlight available. I tried it out with my Sansa which has an illuminated scrollring as buttonlight.
Now my proposal:
When the user is pressing the select-button (for example to choose an entry from the menu) the button-driver should turn off the light of the scrollring as long as the button is pressed. When you release the button it turns on again. It then appears as if the buttonlight is kind of "flashing" for a moment.
This is a nice visual feedback for pressing the button.
I already implemented it and tried it with my Sansa .. looks quite nice.
You can find the patch on Flyspray (FS#9857). Only one file needs to be changed.http://www.rockbox.org/tracker/task/9857?project=1&type=4&order=dateopened&sort=desc
The only problem I could see with this is the following:
Maybe the lifetime of the LEDs will be decreased by switching off and on the buttonlight too frequently.
Does this come into count compared to the on/off-cycles caused by the normal timeout? What do you think?