Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search




Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Thank You for your continued support and contributions!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Hardware
| | |-+  pp502x: Does IDE0 have to be reset at startup?
« previous next »
  • Print
Pages: [1]

Author Topic: pp502x: Does IDE0 have to be reset at startup?  (Read 2904 times)

Offline dreamlayers

  • Developer
  • Member
  • *
  • Posts: 425
  • Boris Gjenero
    • My Blog
pp502x: Does IDE0 have to be reset at startup?
« on: December 14, 2008, 07:09:03 PM »
When Rockbox starts on my 5th generation 30 gig Video iPod, there are two clicks while the logo is displayed.  It sounds like the heads are locked and unlocked, and it seems unnecessary.  The initial lock is triggered when IDE0 is reset in system_init, and the unlock is when Rockbox tries to access the drive.  If IDE0 isn't reset, there are no clicks and startup is a bit faster.  I see no problems.  Since the bootloader was just using IDE0, it should be in a reasonable state.  A reset might be necessary if starting Rockbox from flash, but iPods can't do that now.

The same change may be possible for other pp502x based devices with hard drives.

What is the proper procedure to follow here?  Should I have submitted a patch instead?  Should I make it for other pp502x targets also, and say it needs testing on those?  I can't say I know the hardware very well, and there might be a good reason why IDE0 should be reset.  (Change is simple, DEV_RS = 0x3dfffef8 instead of 0x3ffffef8 in firmware/target/arm/system-pp502x.c (edited: I meant pp502x not pp5002))
« Last Edit: December 15, 2008, 12:42:26 AM by dreamlayers »
Logged

Offline saratoga

  • Developer
  • Member
  • *
  • Posts: 8761
Re: pp502x: Does IDE0 have to be reset at startup?
« Reply #1 on: December 14, 2008, 07:48:21 PM »
The best thing to do would be to look at the SVN logs, figure out who wrote that code, and then ask them what they think via email or IRC.
Logged

Offline karashata

  • Rockbox Expert
  • Member
  • *
  • Posts: 603
  • Just a fluffy dragon with too much time on my paws
    • Alex Vanderpol (karashata) on Twitter
Re: pp502x: Does IDE0 have to be reset at startup?
« Reply #2 on: December 15, 2008, 01:45:49 PM »
My H10 20GB doesn't click on boot, and boot-up is already pretty breezy so I would suspect any potential improvement would be next-to unnoticed. However, it may not hurt to see if it makes any difference, I may give it a quick test and see what happens.

EDIT: I can't make out any difference in boot time, but making that change doesn't break anything, so it probably wouldn't hurt to make it if it fixes something elsewhere. I suppose we'll have to wait and see what whoever wrote the code says.
« Last Edit: December 15, 2008, 01:56:38 PM by karashata »
Logged
Welp, my iriver H10 20GB is out of commission again.

Offline dreamlayers

  • Developer
  • Member
  • *
  • Posts: 425
  • Boris Gjenero
    • My Blog
Re: pp502x: Does IDE0 have to be reset at startup?
« Reply #3 on: December 15, 2008, 06:02:25 PM »
The reset code was added via FS#8379 - power consumption issues PP502x/5G.  I've e-mailed Andree Buschmann about it.

The code was already separated into sections for different targets, so it would be easy to only make this change for those targets which benefit from it.

The altered code even works if Rockbox is loaded directly from the firmware partition.

Edit:  A while ago Andree told me to submit a patch.  I just did:  http://www.rockbox.org/tracker/task/9749
« Last Edit: January 02, 2009, 04:01:22 PM by dreamlayers »
Logged

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Hardware
| | |-+  pp502x: Does IDE0 have to be reset at startup?
 

  • SMF 2.0.6 | SMF © 2013, Simple Machines
  • XHTML
  • RSS
  • WAP2

Page created in 0.063 seconds with 42 queries.