31
Audio Playback, Database and Playlists / Re: Converting ID3 image tags from PNG to JPG
« Last post by chris_s on April 14, 2024, 10:51:43 AM »Try adding
to your config
https://github.com/Rockbox/rockbox/blob/b06073f7716373b115b4e039193ce622dbccb3a5/lib/rbcodec/metadata/id3tags.c#L302
Code: [Select]
id3v23_unsync => 0
to your config
Quote
Embedded JPEG images must not be unsynchronized.https://download.rockbox.org/daily/manual/rockbox-ipodvideo/rockbox-buildap3.html#x19-447000C
https://github.com/Rockbox/rockbox/blob/b06073f7716373b115b4e039193ce622dbccb3a5/lib/rbcodec/metadata/id3tags.c#L302
32
Audio Playback, Database and Playlists / Re: Converting ID3 image tags from PNG to JPG
« Last post by Bilgus on April 14, 2024, 09:33:23 AM »ID3 v 2.4 was just a bunch of new genre categories if I recall
edit:
looks like 2.4 has a few other things to offer as well:
edit:
looks like 2.4 has a few other things to offer as well:
- multi-value tags
- date recorded and date released tags
- alternate placement of id3 data in file
- UTF-8 encoding
33
Hardware / Re: Xduoo x3
« Last post by Orest30 on April 14, 2024, 09:06:31 AM »I wonder what happened, worked fine for 3 year and now i tried everything cant make it work,any help?
34
Audio Playback, Database and Playlists / Re: Converting ID3 image tags from PNG to JPG
« Last post by wintermute23 on April 13, 2024, 09:37:38 PM »The file I'm modifying has tags in v2.4 format; if I remove that config flag, it complains "Writing of ID3v2.4 is not fully supported (prohibited now via `write_v24')." and does not update the embedded image. It might be worth seeing if I can find a file with v2.3 tags, and playing around with that. Depending on how common v2.4 tags are, if that works it might be a decent solution.
35
Audio Playback, Database and Playlists / Re: Converting ID3 image tags from PNG to JPG
« Last post by saratoga on April 13, 2024, 09:12:31 PM »One thing that jumps out at me is the write_v24 bit:
If you try writing the default 2.3 tags do they parse?
-----
You could try decoding one of the files in the UI simulator to see if it throws an error. 1000x1000 is a bit big but should work fine.
There are some old windows sim builds if you want to try quickly without building from scratch: http://rasher.dk/rockbox/simulator/ They're really out of date but should be ok for testing ID3 parsing.
Quote
write_v24
If FALSE (default), writing of ID3v2.4 is prohibited (it is not fully supported; allow on your own risk).
If you try writing the default 2.3 tags do they parse?
-----
You could try decoding one of the files in the UI simulator to see if it throws an error. 1000x1000 is a bit big but should work fine.
There are some old windows sim builds if you want to try quickly without building from scratch: http://rasher.dk/rockbox/simulator/ They're really out of date but should be ok for testing ID3 parsing.
36
Other - Installation/Removal / Re: Surfans F20 "NAND open error"
« Last post by amachronic on April 13, 2024, 07:22:20 PM »Ok, so the LCD configuration is in firmware/target/mips/ingenic_x1000/erosqnative/lcd-erosqnative.c. Vertical/horizontal flip is controlled by this command:
The data byte is what controls the orientation. Bit 7 = vertical flip, bit 6 = horizontal flip. The "inverted" build is just a horizontal flip, so 0xd8 becomes 0x98. Bit 3 is RGB/BGR order, so changing that may help fix the colors.
Another thing you can try is adding the "display invert on" command (0x21), assuming the default is non-inverted; maybe also try 0x20 "display invert off" just in case it defaults to on for some reason.
To stop the display from going to sleep you can comment out / remove the code in lcd_tgt_sleep(), the backlight will still turn off but the controller will keep running normally.
I don't remember if dconrad ever figured out what the display controller was... not that it would help since you could have a different one, but most of them support a similar command set (called MIPI DCS) and you can check eg. the ILI9341 datasheet for info.
Code: [Select]
/* Set Address Mode */
LCD_INSTR_CMD, 0x36,
LCD_INSTR_DAT, 0xd8,
The data byte is what controls the orientation. Bit 7 = vertical flip, bit 6 = horizontal flip. The "inverted" build is just a horizontal flip, so 0xd8 becomes 0x98. Bit 3 is RGB/BGR order, so changing that may help fix the colors.
Another thing you can try is adding the "display invert on" command (0x21), assuming the default is non-inverted; maybe also try 0x20 "display invert off" just in case it defaults to on for some reason.
Code: [Select]
// vvv add this
LCD_INSTR_CMD, 0x21,
// ^^^
/* Exit Sleep */
LCD_INSTR_CMD, 0x11,
LCD_INSTR_UDELAY, 120000,
/* Display On */
LCD_INSTR_CMD, 0x29,
LCD_INSTR_UDELAY, 20000,
LCD_INSTR_END,
To stop the display from going to sleep you can comment out / remove the code in lcd_tgt_sleep(), the backlight will still turn off but the controller will keep running normally.
I don't remember if dconrad ever figured out what the display controller was... not that it would help since you could have a different one, but most of them support a similar command set (called MIPI DCS) and you can check eg. the ILI9341 datasheet for info.
37
Audio Playback, Database and Playlists / Re: Converting ID3 image tags from PNG to JPG
« Last post by wintermute23 on April 13, 2024, 06:16:08 PM »Yeah, as I say, RockBox can read the file generated. I've considered just dropping the JPG into the directory with the same filename as the podcast (that should work, right?), but whit it copies podcasts over to my iPod, it reports a pretty naïve count of files copied, and I'd need to rework that to something more complicated to make it work properly.
Not entirely out of the question, but getting the art properly embedded is definitely the more elegant solution.
Not entirely out of the question, but getting the art properly embedded is definitely the more elegant solution.
38
Audio Playback, Database and Playlists / Re: Converting ID3 image tags from PNG to JPG
« Last post by philden on April 13, 2024, 05:45:21 PM »Have you tried saving the jpeg as a separate file instead of being embedded?
39
Audio Playback, Database and Playlists / Re: Converting ID3 image tags from PNG to JPG
« Last post by wintermute23 on April 13, 2024, 02:58:03 PM »That's certainly worth trying. That 1000×1000 limit was added because the sample file I'm using had an embedded image that was 3600×3600, which seemed excessive. Quite a few of the music files I have have cover art in the 1000×1000 range, so it didn't occur to me it might be a problem.
And after a quick test, changing the image size to 190×190, it's still not working.
And after a quick test, changing the image size to 190×190, it's still not working.
40
Audio Playback, Database and Playlists / Re: Converting ID3 image tags from PNG to JPG
« Last post by philden on April 13, 2024, 02:45:00 PM »I'm not experienced with Perl, but does your code generate a 1000x1000 pixel jpeg? If so this is very big. I'd try making a much smaller file which will take less memory to display. I'd suggest a maximum of 300x300, or use the exact size that your favourite theme uses.