Rockbox Technical Forums

Rockbox General => Rockbox General Discussion => Topic started by: Adam on January 28, 2007, 08:48:27 AM

Title: Testers wanted for SPC player (SNES audio)
Post by: Adam on January 28, 2007, 08:48:27 AM
I've got a great SPC player from blargg up and running on a number of targets, I'd like tests on a few more before considering committing it.
Similarly to the NSF player (which is now included in daily builds), I have a a page with a bunch of builds including the SPC player (http://hcs64.com/rockbox/spc.html).  Please let me know if you test it, good or bad results, and if you happen to need it built for another player that I don't have a build for yet.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: Spug on January 28, 2007, 12:59:28 PM
Thanks, I'll test it out. However, the page says that it's a build from 01/28/2006? I strongly assume you wrote the wrong year, but it also says "cvs" rather than "svn", so I'm a bit unsure.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: Adam on January 28, 2007, 01:46:31 PM
Doh, yeah, you're right.  It is 2007,and it is SVN.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: andryou on January 28, 2007, 04:29:04 PM
I just want to say that I'd really like to see this integrated into the builds just like your NSF player was =] Nice work.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: Peter200lx on January 28, 2007, 05:14:17 PM
hmm, I'd love to test this. , but could you have a build for the iRiver H120 that includes the RTC Mod for H1x0 series (http://www.rockbox.org/tracker/task/6419)? If it would be too much additional work, I could try doing it myself, I've just had a tough time working the patches, and haven't succeeded sense the SVN change. Of course, I don't know much about both SVN and building anyways.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: Llorean on January 28, 2007, 05:24:47 PM
This is a TESTING build, for a specific patch, which is the reason I'm not forcing it to be moved to the Unsupported Builds forums right now.

Please do not request that he add additional patches to it. It is NOT a general purpose unsupported build.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: Peter200lx on January 28, 2007, 07:42:38 PM
Sorry, I will withdraw the request
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: Adam on January 29, 2007, 02:11:50 AM
New build now up, 0.24
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: rossic on January 29, 2007, 02:42:11 AM
I'll give it a run on my H340.  

Do you have any specific testing methods you want done, or just normal use?  
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: caitsith2 on January 29, 2007, 03:23:27 AM
Im using it as normal.  I am also doing battery life benchmarks in various situations.  So far, I have had about 7 hours of continuous playback on a directory of spcs.   I have also logged 5 hours of a single spc on repeat one. (plus at least 1 hour 30 minutes of activity before that.)  My player is an Ipod video 30GB model.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: Adam on January 29, 2007, 08:38:40 AM
Frequent normal use is probably the best idea.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: Sherv on January 29, 2007, 09:34:07 AM
SWEET!!! Wow dude, thanks so much, so far so good on my x5 60gig!
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: mor on January 29, 2007, 12:33:11 PM
hey adam, im not gay, but i really love you. nice work really nice nice, im starting to test right now, you can count on me testing for you .
ok again the specs:
Ipod 5g - 60 giga.
runnin os 1.21 + rockbox on default new loader.

a COP add-on to your build would be great for ipod 5g and others ipod´s.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: Chronon on January 29, 2007, 04:28:57 PM
I had a play at lunch today.  It worked well for me on my 5G 60gb iPod.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: Llorean on January 29, 2007, 06:06:40 PM
Seriously folks, this is a testing build. *Any* additional patch added to it means he no longer knows if the bugs come from his patch or the other one.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: mor on January 29, 2007, 08:01:16 PM
8 hours later...
everithing went fine Adam.
i heard all my colletctions of SPc´s and they really sound SMOOTH and NICE.
i just didnt found my final fantasy 6 collection,
but  Zelda,  chronno trigger, starfox,  FZero, nigel manssel, rocckmanX123, Megaman7, megaman forte, Super metroid, super mario rpg, super contra and a lot of other collections played without anny bugs or skip.
i was using PHK wps scheme and did not changed any config during playback.
crosfeed turned on 100% of the time.
i loaded one game at a time, and browsed to the root dir on every new game.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: link343 on January 29, 2007, 09:03:30 PM
Yea, I'll test it out. I try it out tonight and I'll try to get on tomorrow to tell you what i think. Sounds very good. I love it. Rockbox is getting very good with all the plug ins.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: abcminiuser on January 31, 2007, 11:23:58 PM
Works fine when patched into my iPod 4G B&W. Haven't run into any obvious problems yet. Nice work!

- Dean
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: Adam on February 01, 2007, 11:08:21 AM
new builds against new SVN (http://hcs64.com/rockbox/spc.html) (no change to SPC patch)
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: Adam on February 07, 2007, 02:07:41 AM
spc26 build now up, in line with the fixes made to the playback code (remember that irritating clicking? no longer!)
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: vincent404 on February 07, 2007, 07:08:54 PM
One thing I've noticed via playing the Secret of Mana soundtrack is that the plugin tends to lack the effects of the SPC files (echoes, reverb, etc). Not sure if this is a limitation of the codec at this point, but other than that, love the thing. Can't wait till this makes it into the official build.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: Adam on February 07, 2007, 08:06:12 PM
The reverb is currently disabled until I can get it running faster, but it is well-implemented in the source.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: Sherv on February 15, 2007, 02:05:23 PM
Sweet, this codec has been included into the main source! Congrats on that, Adam! Dare I ask what's next? ;)
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: adam917 on February 16, 2007, 11:19:05 AM
Any RSN support is out yet?
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: blargg on February 16, 2007, 08:53:56 PM
RAR can require a ton of memory to extract from solid archives, and the source is a mess of C++. Very unlikely.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: Llorean on February 16, 2007, 08:58:31 PM
Not to mention it's easier to playlist individual files than multi-track files.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: dma on February 19, 2007, 04:09:24 AM
Really great work! The reproduction seems pretty accurate.

There were several soundtracks i had in streaming format on my H120 and now i can enjoy as .spc, saving some precious HD space, so many thanks. :)

Recommended source for SNES music archives: http://snesmusic.org/
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: Wrzlbrnft on February 21, 2007, 10:54:02 AM
Great job!!! Since I got Rockbox on my H320 I always waited for SPC playback! Thank you so much!

But would it be possible to set the playback volume a little bit louder (for example like the one in the NSF codec)? Most of the tracks are not loud enough and I always have to put the volume to the maximum to hear something.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: Slogra on March 07, 2007, 02:58:49 PM
This is awesome! I've tried some tracks and it works very well.

Just wondering, what kinda resampling are you using?

And I wouldn't mind a volume boost as long as it doesn't lower the quality caused by clipping.
Also I hope you can speedup the reverb code although it sounds very nice already without it.

THX!
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: Llorean on March 07, 2007, 03:00:38 PM
Some of my SPCs are already significantly louder than I'd like them. I'm not sure how the format works, but there seems to be a very large range of 'average' volumes of files.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: adam917 on March 10, 2007, 06:02:27 PM
Does the codec buffer (almost) the whole music buffer of SPCs (hundreds or maybe thousands at a time could fill 24 MiB) if you queue up a large collection of SPCs? I'm asking because for some reason, I notice the HDD spinning up when I switch to another SPC in my playlist, and I think spinning up the drive just for 64.2 kiB (file size) that should already be buffered (the very next file) can put a lot of drain on the battery life.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: Llorean on March 10, 2007, 06:06:12 PM
The Codec buffer is limited to 32 songs (I may have the number wrong, but there is a set maximum number) but it should happily buffer the next many SPC files up to that maximum number of files.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: adam917 on March 10, 2007, 06:57:18 PM

The Codec buffer is limited to 32 songs (I may have the number wrong, but there is a set maximum number) but it should happily buffer the next many SPC files up to that maximum number of files.
Is this limitation for a reason? Can it be lifted? Not that I have a problem with letting 32 files (files, right?) play out, but it would be nice to have the limit higher, especially for jumping around between one game or track & another.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: Llorean on March 10, 2007, 07:00:23 PM
In the past, 32 files was more than one could reasonably expect unless songs were exceptionally short. Since the audio buffer is only about 29 or 30 mb on the largest targets (not counting the 60gb iPod 5G which has twice as much) the 32 file limit would mean each file would have to be under 1mb, not common with streaming audio formats in general.

With the addition of SPC, SID and other smaller formats the situation has changed, and while it would be possible to just up the number I believe it hasn't been done because it's generally felt that just increasing it isn't the proper solution, rather the option for an arbitrary number of files which I think is what will happen with the metadata on buffer feature once that's done (don't ask when, we don't know yet).

At least, I think this is the situation.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: adam917 on March 12, 2007, 05:50:26 AM

In the past, 32 files was more than one could reasonably expect unless songs were exceptionally short. Since the audio buffer is only about 29 or 30 mb on the largest targets (not counting the 60gb iPod 5G which has twice as much) the 32 file limit would mean each file would have to be under 1mb, not common with streaming audio formats in general.

With the addition of SPC, SID and other smaller formats the situation has changed, and while it would be possible to just up the number I believe it hasn't been done because it's generally felt that just increasing it isn't the proper solution, rather the option for an arbitrary number of files which I think is what will happen with the metadata on buffer feature once that's done (don't ask when, we don't know yet).

At least, I think this is the situation.
Can you re-word that 2nd paragraph? It seems I got lost somewhere. I'm guessing what you're saying is that changing the number of buffered files isn't the best solution, as a problem will occur when a new feature that allows metadata to be buffer is added to Rockbox. Is this right?
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: Llorean on March 12, 2007, 06:04:21 AM
It's more like "Changing the maximum number of buffered files will be less efficient for every other codec right now, so the limit should probably stay the same until the better method is implemented"
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: psychosync on January 24, 2010, 08:40:56 PM
Are you still working on this plugin? It still misses the snes reverb...
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: saratoga on January 24, 2010, 09:26:34 PM
Are you still working on this plugin? It still misses the snes reverb...

He hasn't posted in years, so probably not.
Title: Re: Testers wanted for SPC player (SNES audio)
Post by: Adam on January 24, 2010, 11:46:16 PM
Reverb is disabled only on targets that aren't known to be able to handle it.  It is enabled for:
- Gigabeat (F or S)
- devices with Coldfire CPUs
- device with dual core PortalPlayer CPUs

Now, I could give you a build that enables reverb for whatever device you have, and I guess if it holds up for the more intensive sets (Uncharted Waters 2 being the worst that I remember) then it could be enabled in the main build.