Rockbox Technical Forums

Rockbox General => Rockbox General Discussion => Topic started by: JdGordon on September 20, 2006, 08:34:38 AM

Title: small army needed - test major patch
Post by: JdGordon on September 20, 2006, 08:34:38 AM
hey all,

Well, I have been working on this patch for the last while and I tihnk it is at the stage where its finished apart from bugs and code cleanup.

What I need is a small army of testers to help find any bugs which I havnt found myself.

What this patch does is completly replace how all settings and most menus are handled in the code, The big thing for users is no more config block settings, so no reset settings when the code gets updated (yippee :D )

So, If you are willing to help out, please grab the patch from the bottom of http://www.rockbox.org/twiki/bin/view/Main/MenuSettingsRecoding compile it and test it on your target. It has about a dozen warnings which I know about and will fix, but they are not important and its completly safe to run with them.

What to test and look out for:
- every setting needs to be tested, some cannot be updated "live" (i.e volume can, backlight cant)
- look out for the words "Not Done Yet!" in the menus, if you see this make sure u reply with your target and where exactly you saw it.
- any menu/settings that crash.
- any drawing bugs
- any menu items which are not where they should be (or not there at all!)
- any voice bugs in the menu/settings screens

Last thing, the settings will be saved to /.rockbox/config.cfg, and at the moment the config file is incompatible with the current .cfg files, so if you have a /.rockbox/config.cfg you shuold back it up first.
If you want to help out but cannot compile it for yourself, post a reply or pm me and i will  compile it for you.

Thanks all.
Title: Re: small army needed - test major patch
Post by: JdGordon on September 20, 2006, 08:08:39 PM
bumping, and letting all know i have attached rockbox.ipod for the nano onto the wiki page for those that need it, if other builds are requested i'll put them there also
Title: Re: small army needed - test major patch
Post by: soap on September 20, 2006, 08:17:29 PM
I can test this weekend, but not before.
Title: Re: small army needed - test major patch
Post by: AlexP on September 21, 2006, 01:39:14 AM
I tried to build this for the H140, but after the warnings on make (having patched fine), it refused to make zip, saying something like nothing to do.  Sorry for the vague error message, but I'm in front of a different computer at the moment.  I'll be happy to test if you pop a H140 build up there.
Title: Re: small army needed - test major patch
Post by: JdGordon on September 21, 2006, 02:15:14 AM
BigBambi: hmm.. that sounds odd... you dont need to make zip tho, you only need to copy rockbox.iriver onto the player, all other files from the .zip are fine from a different build
Title: Re: small army needed - test major patch
Post by: AlexP on September 21, 2006, 02:43:12 AM
OK, I'll have a look at that.  I've just got into work though, so can test but not build...

I'll try it tonight if still necessary.
Title: Re: small army needed - test major patch
Post by: JdGordon on September 21, 2006, 02:44:28 AM
ta,
yes testing will be needed right up untill it gets commited.
Title: Re: small army needed - test major patch
Post by: JdGordon on September 21, 2006, 03:48:50 AM
for anyone that is willing to try, please make sure you use v16 from the wiki... config files are now compatible with regular files.. (well apart from a few settings which ant)
Title: Re: small army needed - test major patch
Post by: mightybrick on September 21, 2006, 06:39:24 AM

bumping, and letting all know i have attached rockbox.ipod for the nano onto the wiki page for those that need it, if other builds are requested i'll put them there also


for anyone that is willing to try, please make sure you use v16 from the wiki... config files are now compatible with regular files.. (well apart from a few settings which ant)

It appears the rockbox.ipod for the nano on the wiki is from v15.  Can you compile a new one for the v17 changes to be tested?  Or will testing the v15 be sufficient?
Thanks
Title: Re: small army needed - test major patch
Post by: JdGordon on September 21, 2006, 06:52:34 AM
well.. not really much has changed between the 2, except regular .cfg files work with v17 and not in v15, but apart from that, any bugs you find in v15 are most likely still in 17 so it would still be helpful.

I just realised that not all settings actually do work in 17, which is why i havnt uploaded a new version yet, hopefully ill find the bug in the next hour or so and update
Title: Re: small army needed - test major patch
Post by: JdGordon on September 21, 2006, 08:42:15 AM
yay! fixed it.

I wont be at the computer again till proably monday, so please leave any bugs you find in the thread, and il respond to them all then.

there is a nano version ont he wiki now.

thanks all
Title: Re: small army needed - test major patch
Post by: AlexP on September 21, 2006, 05:53:24 PM
Not much luck I'm afraid!  I still can't compile for H140, this time using v18 and CVS 060921 22:30.

I've managed to patch before, but it's probably something I'm doing.  Nonetheless, here is the error message on make (patching is still OK, a couple of offsets, but nothing major)

Code: [Select]
sound_menu.c:259: error: structure has no member named 'spdif'
sound_menu.c:259: error: initializer element is not constant
sound_menu.c:259: error: (near initialization for 'spdif..global_settings_variable')
sound_menu.c:259: error: initializer element is not constant
sound_menu.c:259: error: (near initialization for 'spdif.')
make[1]: *** [home/rockdev/rockbox-devel/build/apps/sound_menu.o] Error 1
make: *** [all] Error 2


Any ideas?  I've had a look at line 259 in sound_menu.c and spdif is indeed mentioned:

Code: [Select]

MAKE_SETTING_OPT(spdif,NULL);


but my limited programming ability doesn't include knowing what this means!
If it's just me being stupid, if you post a compiled rockbox.iriver for H140, I'll be happy to test - I might be able to do that bit!
Title: Re: small army needed - test major patch
Post by: JdGordon on September 22, 2006, 12:54:39 AM
grr... serves me roght for not testing that target yet :p
im about to upload a new version of the patch onto the wiki, major change is dircache is not crashing for me anymore which is good (although the fix is bad...)

ill up the nano and h100 builds onto the wiki for you both... please test it and let me know any bugs you find. It shuold be stable enough to use as a replacemtn for cvs rockbox.target
Title: Re: small army needed - test major patch
Post by: AlexP on September 22, 2006, 02:50:58 AM
Hi, one immediate comment: the default contrast is so dark as to be unreadable, and rec to clear settings had no effect, as I guess it is the default that is wrong!  When changing the contrast (via the remote), selecting a new value had no effect (the tick did change to the new value), and only when I gave up and pressed stop to exit the menu did the contrast change.  Given the setting doesn't change as you scroll (which would be really useful for things like contrast, if possible), it is quite annoying to have to leave the menu then re-enter 20 times until the setting is correct.

Edit:
Oh, and on the wiki page the attached rockbox.iriver says it is for H100, but it's actually for H120.  I tried to edit it, but couldn't see how to change the comment without uploading a new file.

Edit 2: More comments:  

When using a WPS that disables status bar, when you press A/B to go to the menu the statusbar isn't redrawn, so you can still see a line of WPS at the top of the screen.  When you press a button (to scroll for instance), the statusbar re-appears.

In the recording settings, quality I can only see options for MP3 at various bitrates (64, 96, 128, 160, 192, 224).  The options for wavpack and wav are missing, as well as MP3 at 320 KBit/s.

For backlight fade in on main unit, the only option is off.

Inverse LCD mode is just called LCD mode now with settings on or off.  Perhaps LCD mode with the settings called Normal and Inverse?

In remote LCD settings, the forth item is Not Done Yet!

In remote LCD settings, again there is LCD mode not inverse LCD mode, or setting options that say Normal or inverse, not on or off

On the scrolling settings, I think actually owing to the new list settings, there is no example line, so you can't tell what your changed setting is doing until you go back to the WPS or filetree and find a long enough line, then have to go all the way back to the settings to try again - annoying!

On turning dircache on, it no longer tells you you need to restart for the changes to take effect.  I don't know whether that's because the splash is missing, or because you don't have to restart anymore!

Edit 3:

View Current Playlist under Playlist options doesn't do anything if you haven't got a playlist loaded.  Perhaps a splash saying no playlist or something?
Title: Re: small army needed - test major patch
Post by: mightybrick on September 22, 2006, 04:09:22 AM
I tried testing the rockbox.ipod v19 for the nano, but when rockbox tries to boot, I get a blank screen with the message:
Quote

Data abort
00014310

and it freezes.  I have to reboot, and manually go into diskmode and put the CVS rockbox.ipod back into the root to boot completely.
I hope that all made sense!   ;D
Title: Re: small army needed - test major patch
Post by: SUSaiyan on September 22, 2006, 07:15:32 AM

I tried testing the rockbox.ipod v19 for the nano, but when rockbox tries to boot, I get a blank screen with the message:
Quote

Data abort
00014310

and it freezes.  I have to reboot, and manually go into diskmode and put the CVS rockbox.ipod back into the root to boot completely.
I hope that all made sense!   ;D


i have that exact same problem, though the last line actually says "at 00014310" (woo, nitpicking). if its any help, ive got a 4Gb nano, and its black (not that that matters  :D)
Title: Re: small army needed - test major patch
Post by: RaeNye on September 22, 2006, 08:45:34 AM
Testing on X5, here're some glitches:

General Settings->Display->Browse .(r)wps files does nothing (browse fonts/plugins/themes do work)

General Settings->Display->Remote-LCD Settings->Not Done yet!
(instead of Caption Backlight)

General Settings->Display->Remote-LCD Settings->LCD Mode now displays on/off instead of normal/inverse (or whatever it was before...)

Recording Settings has both the submenu File Split Options and its four children (Measure, What to do, Time, Filesize).
Title: Re: small army needed - test major patch
Post by: RaeNye on September 22, 2006, 09:01:03 AM
And the most important thing -
I really like the check mark besides the active setting, but you can't cancel a setting anymore... settings are saved when pressing back even if you didn't click to set the check mark on the current value.

Another thing - some settings happen immediately (e.g., volume) even without applying the check mark, but others (e.g. LCD contrast) aren't applied until you exit the menu item.
Title: Re: small army needed - test major patch
Post by: Llorean on September 22, 2006, 09:12:39 AM
I think he's going to change it so moving the cursor doesn't select a setting, backing out doesn't do anything but back out, and pressing select moves the checkmark (after which if you back out, it's saved). I *think*.
Title: Re: small army needed - test major patch
Post by: soap on September 22, 2006, 04:15:36 PM
Oh, and on the wiki page the attached rockbox.iriver says it is for H100, but it's actually for H120.  I tried to edit it, but couldn't see how to change the comment without uploading a new file.



I changed the wiki entry to reflect H120.
Title: Re: small army needed - test major patch
Post by: Rincewind on September 22, 2006, 06:22:07 PM

I think he's going to change it so moving the cursor doesn't select a setting, backing out doesn't do anything but back out, and pressing select moves the checkmark (after which if you back out, it's saved). I *think*.


I hope not. Because I really like it that it is possible to change a setting without pressing select. My H120 has a quite loud click when I press select, so I try not to push it if I don't need to.
Also, If I interpret your post correctly, this would mean that it takes one more button press to change a setting. I don't think that's a good idea. Why should the current behavior be changed at all?
Title: Re: small army needed - test major patch
Post by: Llorean on September 22, 2006, 08:30:20 PM
It could be possible that a right-press moves the checkmark instead of "Select" I imagine. I think the problem was that with the screen like it is now it acts in "unexpected" ways when you try to cancel out of the screen and the selection changes, or if it doesn't show some users the moved checkmark then they don't have visual confirmation of a settings change.

I dunno. I think "selection" should be a separate function from "navigation" but that's just me. Like the common concept of setting a radio button from a series of options and then clicking "Okay" after. I'm certainly not oppossed to a one-button solution, but the current highlighted entry shouldn't be considered the selection in my opinion.
Title: Re: small army needed - test major patch
Post by: Rincewind on September 23, 2006, 07:48:02 AM
the current highlighted setting is only the selection for settings that change instantly and that's good, because otherwise you have click navi every time you want to see how something like contrast changes.

for every other setting, the current highlighted only applies when leave the screen (not canceling).

Maybe a nice feature would be an indicator what the previous setting was. This indicator changes with the cursor on dynamic settings and stays at the value that you would get by canceling with the other settings.

(sorry for the grammer, I'm in a hurry)
Title: Re: small army needed - test major patch
Post by: JdGordon on September 24, 2006, 04:17:21 AM
thanks all for testing.
RE: the bugs on the first page, I'll hopefully fix them tonight ro tomorow.
RE: the setting seelction screen. I'm quite open to ideas for the setting selection screen. however, I want to try and please the majority (actually, I lie, I want to please the core dev guys...). iirc "they" don't like the current way where left backs out and cancels, So i figured this would be a fairly reasonable compromise.
now, I have no problems adding settings to deal with the settings screen, e.g I would gladly add an option for 1 button selection/cancelation in the screen, but the core devs are fairly against that (so i might just sneak ti in and not tell :D )

OK, now the important bits...
Each setting can have a callback function associated which "applies" whatever value is curently selected, most dont need this (and some it is plain wrong to do this), so aside from the contrtast and "sound items" (e.g volume) which others need this?
Title: Re: small army needed - test major patch
Post by: AlexP on September 24, 2006, 05:19:23 AM
Good work!

RE: which items need immediate update, I can't think of anything other than contrast and sound, but unfortunately I managed to drop my H140 yesterday when accessing the disk, and now am having disk problems!  :-\  More unfortunately still, Toshiba seem to have stopped selling the 1.8" ATA disks (everywhere I found in the UK says discontinued) - I guess in preparation for release of the perpendicular disks.

So no more testing for me for a while!
Title: Re: small army needed - test major patch
Post by: JdGordon on September 24, 2006, 05:33:32 AM
:( thats terrible... ive dropped mine a few times, but fortunatly it still works.... ebay has heaps of 1.8" discs...
Title: Re: small army needed - test major patch
Post by: JdGordon on September 24, 2006, 06:10:34 AM
Replying to BibBambi, message # 13...

contrast: odd... the default must be set to high elsewhere in the code, because i use DEFAULT_CONTRAST_SETTING which is set in the target config... will investigate further later.

menu not redrwaing status bar: yes, ive known about this for a while, but keep forgetting to fix, done now.

recording setting qaulities missing: fixed.
backlight fade in: fixed
invert display strings: fixed
In remote LCD settings, the forth item is Not Done Yet!: fixed
remote invert: fixed
scrolling settings: hmm... ill look into this later, remind me if i forget please :p
dircache reminder... yes, ill put that back soon... its being stupid and not going in easily!
current playlist: fix later
Title: Re: small army needed - test major patch
Post by: JdGordon on September 24, 2006, 06:12:07 AM

I tried testing the rockbox.ipod v19 for the nano, but when rockbox tries to boot, I get a blank screen with the message:
Quote

Data abort
00014310

and it freezes.  I have to reboot, and manually go into diskmode and put the CVS rockbox.ipod back into the root to boot completely.
I hope that all made sense!   ;D


righto, damn this is going to be a pain to debug.. ill grab my sisters nano and figure it out... that magic number does help tho, it narrows it down to about 100 lines of code :p

edit: damn... whatever it is isnt crashing the sim.. and the function is a loop, so this is gonna be a huge PITA to figure out :'(
Title: Re: small army needed - test major patch
Post by: JdGordon on September 24, 2006, 06:15:49 AM

Testing on X5, here're some glitches:

General Settings->Display->Browse .(r)wps files does nothing (browse fonts/plugins/themes do work)

are u sure you have rwps's ?
 the rest is fixed..

ill post a patch will all the fixes later tonight
Title: Re: small army needed - test major patch
Post by: Rincewind on September 24, 2006, 09:12:45 AM
the scrolling options could need a callback, so that you can see directly what changes when you change delays and speed. This requires a sample scrolling line in the selection screen, of course.

On the selection thing:
If it gets decided to make settings selection a two button press thing (with SELCECT to select an action but don't applying it, and LEFT or RIGHT to leave the screen afterwards), then I hope you make it easy to change this back (maybe an #ifdef or a special action that you can define in your keymap instead of the default one?) because I think that this behaviour is one thing that rockbox does different from other firmwares and that makes navigation very fast.

I liked the original button handling - before the new settings display - better (with LEFT to apply a setting and go back; and STOP to cancel). But the current one is ok, too (with RIGHT to apply setting; and LEFT and STOP to cancel). Actually, I never use the cancel button, whereever it is, because it gives a 1 sec delay showing the "cancelled" splash. I just apply the setting where the cursor was when I entered the screen (Yes, I can remember if it was "on" or "off" :) )

It would be a sad thing if Rockbox gets dumbed down to make it "usable" for people that expect everything to work just in the same way than their crappy retail firmware.

PS: If change something, don't forget the iriver remotes, They have a different button layout without a 4-way selection pad.
Title: Re: small army needed - test major patch
Post by: JdGordon on September 24, 2006, 04:32:03 PM
im working all this week ( :'( ) so i dont know how much time i will have to play with this, but when i do get a chance im going to try fiving the nano dta abort, and figure out what to do about the scrolling selection screen...

and talk about the selection screen buttons... we'll discuss this, but in another thread, and in a little while...

ta
Title: Re: small army needed - test major patch
Post by: AlexP on September 24, 2006, 04:43:17 PM

im working all this week ( :'( ) so i dont know how much time i will have to play with this, but when i do get a chance im going to try fiving the nano dta abort, and figure out what to do about the scrolling selection screen...


Every one has to from time to time!  Just curious, I assume this patch is to simplify the internal architecture of the menus etc, as clearly we here are trying to make it the same to the end user as before (other than the settings not resetting on config block bump)?

Oh, and I've managed to buy a 60gb drive from ebay, so hopefully I'll be back up and running (and testing) soon...  :)
Title: Re: small army needed - test major patch
Post by: JdGordon on September 24, 2006, 05:08:45 PM
yes, the patch simplifies the whole way settings are handled, from saving/loading of cfg files, to menus and settings, and i've been told i have to keep backwards compatibility which means make it so the user never knows anything changed.

and congrats :)
Title: Re: small army needed - test major patch
Post by: JdGordon on September 25, 2006, 04:22:11 AM
yay, that was fairly painful, but we found the bug, nano version is on the wiki for the lazy's....
Title: Re: small army needed - test major patch
Post by: JdGordon on September 25, 2006, 08:07:40 AM
new toy for you all to play with in v22 of the patch (will be uploaded as soon as im done with the reply)
if there is a file /.rockbox/user_menu.config a new menu item will apear at the top of the main menu called "User Menu"!
this lets you have your own favorites there, and can be any menu item that can be reachable from the main menu.

the file is a regular text file something like this...

# browse wps files
3,2,1
# write config file
4,3

etc...
each number is the sub item you want linked to.. (0 based..), so the 3,2,1 means "general settings" > "display settings" > "browse wps"
if you want to be funny, you can have "endless" looping, -1 will goto the main menu, there is no danger, except if you do that you will get to a point where it wont let you enter any more submenus untill u back out... ( you can have a maximum on 32 items int he user menu, and no, you cannot make sub menus there... yet...)

this is most probably the last new feature that will get into the patch, because i would like to see it "commitable" by the end of the week... so lots of testing please :D

Oh! im not sure if i ever mentioned the other added feature.
putting ~ at the begining of any setting will force that value to be written back when settings are saved, even if the actual value is different...

i.e
~volume = -33 will never save any other value except -33 to volume, you will be ablw to change the value, but it will always be -33 in the config file.
I added this because i am sick of blowing my ears off when i turn on the player and forget i had it on full volume, so this forces it to always start at a sane level. (you are allowed 16 of these values)
Title: Re: small army needed - test major patch
Post by: RaeNye on September 25, 2006, 08:40:04 AM


General Settings->Display->Browse .(r)wps files does nothing (browse fonts/plugins/themes do work)

are u sure you have rwps's ?
 the rest is fixed..

No, but I sure have .wps's...


Actually, I never use the cancel button, whereever it is, because it gives a 1 sec delay showing the "cancelled" splash.

That was really annoying for me as well.

What about something like "LEFT cancels, RIGHT applies and backs out, SELECT applies and stays in the menu" without any splashes at all?
Keeps the one-click option for those who use it without any new settings.
Title: Re: small army needed - test major patch
Post by: Llorean on September 25, 2006, 09:06:42 AM
RaeNye: If I were designing it, that's pretty much the key definitions I'd pick.
Title: Re: small army needed - test major patch
Post by: Rincewind on September 25, 2006, 09:33:30 AM

new toy for you all to play with in v22 of the patch (will be uploaded as soon as im done with the reply)
if there is a file /.rockbox/user_menu.config a new menu item will apear at the top of the main menu called "User Menu"!
this lets you have your own favorites there, and can be any menu item that can be reachable from the main menu.

WOW!
That's amazing. I have to try this out right now. I'll try to make this menu available in my record button configuration patch so that iriver users can have one button access to this menu.


Oh! im not sure if i ever mentioned the other added feature.
putting ~ at the begining of any setting will force that value to be written back when settings are saved, even if the actual value is different...

i.e
~volume = -33 will never save any other value except -33 to volume, you will be ablw to change the value, but it will always be -33 in the config file.
I added this because i am sick of blowing my ears off when i turn on the player and forget i had it on full volume, so this forces it to always start at a sane level. (you are allowed 16 of these values)

I don't know if I understand this correctly, but does that mean that these default values get loaded at every boot?
Title: Re: small army needed - test major patch
Post by: Rincewind on September 25, 2006, 09:45:02 AM

What about something like "LEFT cancels, RIGHT applies and backs out, SELECT applies and stays in the menu" without any splashes at all?
Keeps the one-click option for those who use it without any new settings.


*Thumbs up*

I know that this should be discussed later, but I just had an idea I want to get rid off.

The only problem I see is, that when a user presses SELECT and backs out with LEFT afterwards the setting gets cancelled, which might not be what he wanted. So I would say that when you have pressed SELECT,  the settings was applied already, so going out with both LEFT and RIGHT should make no difference.
Or we could make both RIGHT and LEFT apply settings and leave; and only use STOP to cancel. That would be reasonable for a newbe, too. If he fears to have done something wrong, he would press STOP anyway (I would do).
Title: Re: small army needed - test major patch
Post by: Llorean on September 25, 2006, 09:52:57 AM
I think that the idea was "Left leaves the setting where the checkmark is visibly" which would mean that if you moved the checkmark with 'Select' then "backed out" the setting would still hold.
Title: Re: small army needed - test major patch
Post by: Rincewind on September 25, 2006, 09:58:19 AM

I think that the idea was "Left leaves the setting where the checkmark is visibly" which would mean that if you moved the checkmark with 'Select' then "backed out" the setting would still hold.

OK, with this definition, that's what I wanted to say.
Title: Re: small army needed - test major patch
Post by: Rincewind on September 25, 2006, 04:01:42 PM
testing the patch, I found some small "errors".

* in Sound Settings -> Crossfeed -> High Frequency Atenuation
 the Values of the Settings have the Unit "Hz". They should have "dB".
* Some integer settings have the highest values on top, some have them at the bottom. Maybe this could be unified?

I took a look at the code, too.
The Menu code looks much cleaner than before and it is easy to see where things should be added to create new menu entries. But to add a new setting it looks like there are more places where I have to add code (settings.c, settings.h, settings_list.c, maybe more?)
I like the comment style you used to make clear what entries belong to which menu.
But I found it confusing, that nearly all the menus are inside main_menu.c and sound_menu.c but without a logical order which menus are where.
I would suggest to put all the menu definitions in one file and the functions and callbacks in a second file (or more files if one is too big). This would make it possible to rearrange the whole menu structure by only editing one file without moving functions and structs between files.

I noticed, that the onplay menu isn't converted yet. But it seems to be fully functional. Are there plans to convert this too or is it something completely different from the main menu?
Title: Re: small army needed - test major patch
Post by: JdGordon on September 25, 2006, 04:37:00 PM
hey all...
RayNye: bugger, nothing looks wrong.. so ill have another look this arvo.

Rincwind: "I'll try to make this menu available in my record button configuration patch so that iriver users can have one button access to this menu." - I think this should replace (optionally) the quickscreen, i dont know if anyone agress with me tho.

re: button arguments again :D im making a post to the dev mailing list later this arfternoon, hopefully we can come to an agreement there, but thanks for the suggestions

Rincewind again: bugs, ta, ill fix them.
the menu code hasnt really been neatened up yet, but it will be so its in a more logical order.
as for adding settings, you need to add it to settings.h (like currently), then settings_list.c (instead of settings.c like now), one of the menu files (if relevant), and then you need it it settings.c under settings_apply(), so actually one less thing to do than currently (you dont need to put it under settings_reply() like you used to)

and lastly, yes, only the main menu has been converted so far, the others will follow, although there is no real reason to.
Title: Re: small army needed - test major patch
Post by: Rincewind on September 25, 2006, 06:24:35 PM

I think this should replace (optionally) the quickscreen, i dont know if anyone agress with me tho.

I would agree with it. It should be optional, though. I think many people really like the quickmenu.

I have an idea for the favorites menu:
Would it be possible to have .cfg files appear directly in the menu? With this, one could load several settings at once with only one menu item.
More generally, it would be very nice to specify a file in the user_menu.config like this:

Code: [Select]

# something from the main menu
1,2,3
# load cfg file
.rockbox/flat_eq.cfg; "Flat Equalizer"
# load plugin
.rockobx/rocks/tetrox.rock; "Tetris Plugin"
# play mp3
music/my favorite tune.mp3; "The best song ever"
Title: Re: small army needed - test major patch
Post by: JdGordon on September 25, 2006, 08:23:16 PM
ha, nice idea, I'm not sure if it will actually be possible tho.
Title: Re: small army needed - test major patch
Post by: Llorean on September 26, 2006, 04:15:46 AM
This custom menu thing should *really* be separated out from the Menu Rework patch. You know how the guys feel about patches that add more than one thing. ;)
Title: Re: small army needed - test major patch
Post by: mightybrick on September 26, 2006, 04:53:47 AM

new toy for you all to play with in v22 of the patch (will be uploaded as soon as im done with the reply)
if there is a file /.rockbox/user_menu.config a new menu item will apear at the top of the main menu called "User Menu"!
this lets you have your own favorites there, and can be any menu item that can be reachable from the main menu.
each number is the sub item you want linked to.. (0 based..), so the 3,2,1 means "general settings" > "display settings" > "browse wps"
if you want to be funny, you can have "endless" looping, -1 will goto the main menu, there is no danger, except if you do that you will get to a point where it wont let you enter any more submenus untill u back out... ( you can have a maximum on 32 items int he user menu, and no, you cannot make sub menus there... yet...)

With the custom menu option, I created a link to the Tagcache submenu, but also displayed in the User Menu was a link to the User Menu, which looped back to itself.  Like this:
Quote

User Menu
     User Menu
     Tagcache

Is a link to the User Menu always displayed, or is this a bug?  My config file reads like this:
Quote

#Tagcache
3,1,7

Any suggestions?
Title: Re: small army needed - test major patch
Post by: Bagder on September 26, 2006, 05:13:08 AM

This custom menu thing should *really* be separated out from the Menu Rework patch.


Amen. Creeping featurism within a single patch is only gonna make it a lot less likely to be looked at or taken seriously.

Keep separate things in separate patches.
Title: Re: small army needed - test major patch
Post by: JdGordon on September 26, 2006, 05:15:08 AM
hmm.... thats odd... have u got a blank line at the top of the user_menu.config? i just tried and that puts the user menu item there, without it it works fine. (will fix this bug)


as for the settings keys, i've just shot an email off to the dev ml, so hopefully we can come to a decision there
Title: Re: small army needed - test major patch
Post by: mightybrick on September 26, 2006, 05:18:48 AM

hmm.... thats odd... have u got a blank line at the top of the user_menu.config? i just tried and that puts the user menu item there, without it it works fine. (will fix this bug)

Nope, no blank line at top of the file.  ???
Title: Re: small army needed - test major patch
Post by: JdGordon on October 03, 2006, 04:54:43 AM
bumpage time...
I'm trying to get this ready to be commitable. So the user menu has been removed because id rather get this committed sooner and fix it afterwards.

ill post a new patch in a little while, but untill then, can people post any new bugs they've found that havnt been menioted in the thread yet?
ta
Title: Re: small army needed - test major patch
Post by: mightybrick on October 05, 2006, 03:05:33 AM
This may be a small thing, but I thought it may be good to help things stay consistent.  From the WPS on the iPod, a clockwise scroll increase the volume, and counter-clockwise decreases it.  In the volume menu within the sound settings menu it's just the opposite, a counter-clockwise scroll increases the volume, and clockwise decreases it, due to the ordering of the volume settings listed.  Shouldn't this be altered to maintain consistency, having the direction of scrolling the same direction for the volume in both locations?  It threw me off the first several times I adjusted the volume there.  
I don't know if this is something that can be remedied through your patch, or should be filed as a bug report if others find it counter-intuitive as well.
What are your thoughts?
Title: Re: small army needed - test major patch
Post by: JdGordon on October 05, 2006, 04:08:11 AM
hehe, thats definatly bad, but no really relevant im afriad.. actually it might be..

anyway, patch development has pretty much stopped for the time being. for some unknown reason, using the patch causes the cpu to stay boosted, and the audio codec to get starved, so playback doesnt work, and untill i figure out why I havnt really got motivation to fix the other bugs...
I'll keep the thread posted on any news.