Rockbox Technical Forums

Rockbox General => Announcements => Topic started by: JdGordon on August 15, 2006, 06:52:00 AM

Title: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on August 15, 2006, 06:52:00 AM
The entire button system in rockbox is about to be changed, now because of the size of the update there will almost certainly be hickups...

so if you find a problem, please post here, DONT repeat one that has been mentioned already, and MAKE SURE  that the name of your player is in your post (i.e h300, ipod, x5, etc) as well as making sure the problem exists in a CVS (not daily) build.

See here for detailed information: http://www.rockbox.org/twiki/bin/view/Main/ButtonActionIdea

Thanks.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: webmeister on August 15, 2006, 11:00:01 AM
iAudio X5:
- When exiting a plugin (e.g. jewels) with "joystick right" the plugin exits and then starts again.
- "Show ID3 Info" closes immediately when opened with "joystick right". If opened with "joystick press" (select), it closes at the next button press (e.g. "joystick down").
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: thelostsoul on August 15, 2006, 11:51:03 AM
On 4g iPOD, not sure how much of a concern this would be for devs atm because it deals with the debug menu, but it's kinda important since I need to set the CPU frequency @ 75 in order for me to use the music playing functionality without my iPOD freezing/crashing.

I can't find a real way to increase the freqency in the Menu - Info - Debug - CPU Frequency selection.  Only way I get it up is to keep pressing random buttons until it finally goes up, but it was alot easier with the old commands (just press the menu key and it goes up).

Aside from that, all other button configs seem to be in order and working fine.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on August 15, 2006, 11:12:21 PM
"- When exiting a plugin (e.g. jewels) with "joystick right" the plugin exits and then starts again."
- fixed.. hopefully, please check (ill assume it is unless someone mentions it again)
"Cant exit a folder in directory-view with the STOP Button on my H120 Remote. "
- should have been fixed last night, if its still hapening let us know
"I've made a keymaps file for the iriver H10:"
- Ta, added
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on August 15, 2006, 11:37:29 PM
I can't find a real way to increase the freqency in the Menu - Info - Debug - CPU Frequency selection.  Only way I get it up is to keep pressing random buttons until it finally goes up, but it was alot easier with the old commands (just press the menu key and it goes up).
the scroll wheel doesnt work? it should..

psycho_maniac: which target? that should have been fixed lat night...
please try the cvs build again (onse it starts up again.. it seems to be hung atm)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on August 16, 2006, 12:37:33 AM
its backwards?? haha.. so it is... ill fix that.. actually bugger... its not soo easy :'(
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: thelostsoul on August 16, 2006, 12:56:33 AM
its backwards?? haha.. so it is... ill fix that.. actually bugger... its not soo easy :'(

Just reverse the code, right?  Might result in a couple errors, but it won't be backwards anymore...right? lol
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: bluebrother on August 16, 2006, 02:49:02 AM
some not working buttons for h100 series I've found:
- nudging in the pitch screen doesn't work anymore (was hold left / right)
- resetting the pitch (play + stop) doesn't work anymore
- accessing the pitch screen from wps (play + up / down) doesn't work
- quick access of the id3 screen (play + mode) doesn't work
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: nls on August 16, 2006, 08:51:27 AM
on H300 you can not select wich value to change in the "Set Time/date" screen so the only adjustable value is the hour, also holding the up or down button doesn't repeat so you have to click it lots of times.

edit:
And now I know why :-) in the "Set Time/date" screen both ACTION_SETTINGS_INC/ACTION_SETTINGS_DEC
 and ACTION_STD_PREV/ACTION_STD_NEXT are used and they are mapped to the same buttons for the irivers. (lines 920-940 in screens.c)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on August 16, 2006, 09:18:46 AM
cleaned up the thread a bit... if i deletd your post and your problem is still there im sorry, please reply again (i dont tinhk i did)

bluebrothers stuff is all fixed
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Davide-NYC on August 16, 2006, 11:12:22 AM
Using an iRiver H140, with H300 LCD/Joystick remote and H100 LCD remote.
I generally use the H300 remote and I just re-introduce the H100 remote for testing.
So I might be introducing issues that were not caused by the button changes.

First off, there is no way to file browse UP a level using the H100 remote. You can't get out of a directory!  :D

Secondly I propose a unified button mapping for all three iRiver remotes on both iRiver HD targets (H1xx, H3xx). The LCD remotes would essentially have 1:1 button mappings from the main unit with the addition of the -10/+10 (a.k.a. bitrate/source) button which could serve as dedicated volume up/down in the event that the UP/DOWN buttons are busy doing something else. (i.e. selecting items)

The non-LCD remote is a bit of a special case and should be constrained to the WPS functions regardless of what view the main unit is in. (IMO) THen again, I don't own one of those particular remotes yet so I have no actual use testing experience with it.

See this thread for more gory details --> http://forums.rockbox.org/index.php?topic=5851.0

Thanks!  ;D
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: AM on August 16, 2006, 12:08:13 PM
h100 sim & ipod4g sim
Reset Settings immediately cancels when entered using RIGHT. Works properly when using SELECT.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Hansmaulwurf on August 16, 2006, 12:13:32 PM
"Cant exit a folder in directory-view with the STOP Button on my H120 Remote. "
- should have been fixed last night, if its still hapening let us know
Still doesnt work.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: geoffire on August 16, 2006, 02:21:25 PM
I'm using a iaudio x5L,  i've noticed quicker responce with the new button config (was a nagging issue for me) but the graphical eq no longer works. Now right moves over (say from Q to Gain) and left goes back a menu. i cannot find a way to change the values.

Thanks
-Jeff
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on August 16, 2006, 07:12:20 PM
I'm using a iaudio x5L,  i've noticed quicker responce with the new button config (was a nagging issue for me) but the graphical eq no longer works. Now right moves over (say from Q to Gain) and left goes back a menu. i cannot find a way to change the values.

Thanks
-Jeff
it looks like Linus has fixed this
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on August 17, 2006, 12:41:19 AM
iAudio X5:
- When exiting a plugin (e.g. jewels) with "joystick right" the plugin exits and then starts again.
- "Show ID3 Info" closes immediately when opened with "joystick right". If opened with "joystick press" (select), it closes at the next button press (e.g. "joystick down").
both fixed now
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: tvg on August 17, 2006, 01:59:47 AM
It it connected with possible start of remote to function on X5?
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: LinusN on August 17, 2006, 02:20:16 AM
It it connected with possible start of remote to function on X5?
Yes, I'm working on that.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: psycho_maniac on August 17, 2006, 03:16:08 AM
target: h120
when i go to delete a directory on the root of the drivei hold in navi go down to delete directory and press the navi right  then it asks if i want to delete this for a nano second then goes back to the root of the drive.  just updated to 8/16/06 9:24pm version and still does it.

[edit]had to specify how i get to that in menu because clicking in the navi it works but pressing right of thte navi does not work[/edit]
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on August 17, 2006, 04:52:12 AM
yes/no screen is really fixed this time..
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: AlexP on August 17, 2006, 05:03:43 AM
A couple of things I've noticed:

H140, 060817 - 0540 (although I downloaded CVS when the latest build was 2006-08-17 09:38)

You still can't go up a directory on the remote (I know this has been pointed out, but it's uber annoying!)

On the recent bookmarks menu, you now have to use left and right to scroll through the bookmarks not up and down, which means you can't use left to exit and have to use stop, which makes it hard to use the unit one handed.

Keys for the text editor are completely weird: You can't exit from the main unit, stop goes up a line, left goes down a line, down does page down etc!

That's what I've noticed for now!

Cheers,

Alex
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on August 17, 2006, 05:18:59 AM
Bger is working on the remote (hopefully he'll commit fix soon)
the bookmarks screen sux and should be replaced... but the buttons are wrong and on the toto list..
I'm not sure what to do about text editor.. the new button stuff hasnt been added to the plugins correctly yet and its needed for the list to work (which is why buttons are all wrong).. i might just disable text_editor for the time being
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: AlexP on August 17, 2006, 05:26:17 AM
Bger is working on the remote (hopefully he'll commit fix soon)
the bookmarks screen sux and should be replaced... but the buttons are wrong and on the toto list..
I'm not sure what to do about text editor.. the new button stuff hasnt been added to the plugins correctly yet and its needed for the list to work (which is why buttons are all wrong).. i might just disable text_editor for the time being

OK, cheers.

Just a note - the reason I was using the text editor was I was trying to turn off the new horizontal scrolling behaviour, and didn't have a PC with me.  Seeing as the option is not in the menus, using the text editor on a cfg file was the only way, and I dislike the new behaviour so much I just had to change it!  I managed it in the end with a combination of remote and main unit!
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Eriol on August 17, 2006, 04:06:39 PM
It it connected with possible start of remote to function on X5?
Yes, I'm working on that.
And I'm glad you got it working, so now I have a slight suggestion because the menus don't work as expected to somebody used to the menus on the base X5 for the remote.  In the X5's normal firmware menus, the vol +/- are used to navigate up and down the menus, while the FF/RW keys are used to "select" (ff) and go "back" (rw).  Right now in rockbox FF and RW are used to go up/down, and vol doesn't seem to have a use (could be wrong on this point).

One minor bug (maybe just not a context coded for it yet) is that it seems that once you get to the "shuffle/repeat/showfiles" menu (the one you can get to directly from the main playing screen), the remote does nothing.  You can get back out of it, but you can't "do" anything there, and as the ability to quickly shuffle/unshuffle is a great feature in rockbox IMO, the lack of functionality of the remote here is somewhat crippling.

A more serious bug is that holding down the play key brings up the menu, then seems to trigger the shutdown of the player.  This IS the on/off for the player (it's even on a GPIO register instead of the normal ADC like the rest of the keys), but strangely, you hold the key down, the file tree comes up, and when released, then the main unit display goes off and you can STILL SCROLL UP/DOWN on the remote, and then the remote and main units power down.  I can't see that this is anything resembling normal behavior, so I think it bears mentioning.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: LinusN on August 17, 2006, 05:14:33 PM
And I'm glad you got it working, so now I have a slight suggestion because the menus don't work as expected to somebody used to the menus on the base X5 for the remote.  In the X5's normal firmware menus, the vol +/- are used to navigate up and down the menus, while the FF/RW keys are used to "select" (ff) and go "back" (rw).  Right now in rockbox FF and RW are used to go up/down, and vol doesn't seem to have a use (could be wrong on this point).
I haven't used the original firmware, so I don't know how it uses the remote buttons. I just chose a button combination that I felt was practical.

Quote
One minor bug (maybe just not a context coded for it yet) is that it seems that once you get to the "shuffle/repeat/showfiles" menu (the one you can get to directly from the main playing screen), the remote does nothing.  You can get back out of it, but you can't "do" anything there, and as the ability to quickly shuffle/unshuffle is a great feature in rockbox IMO, the lack of functionality of the remote here is somewhat crippling.
Yes, that's why I called it a "draft" in the commit message. I haven't added all contexts.

Quote
A more serious bug is that holding down the play key brings up the menu, then seems to trigger the shutdown of the player.
That's bad. I have to rethink the usage of the Play button then.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mmmm on August 17, 2006, 06:50:49 PM
there is no way to file browse UP a level using the H100 remote. You can't get out of a directory!  :D
I've restored the previous functionality of the H1xx remote stop key in the file browser which was to act as the back (<-) button on the main unit.

OK now?
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Davide-NYC on August 18, 2006, 01:04:38 AM
You can now browse UP with the H100 remote.
Thanks Mmmm!  :D
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mmmm on August 18, 2006, 03:00:04 AM
But you cant stop with the H3xx remotes! :D

Fixed!
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Hansmaulwurf on August 18, 2006, 04:53:58 AM
Thanks for fixing the Stop-Button on the H120 Remote.
But Im sorry I found another Remote Button Bug for the H120 Remote:
When you use the navi-wheel on the H120 Remote to fast-forward of fast backward a song the song doesnt start playback after you stop the forward/backward going. Also the whole H120 remote crashed, the only thing you can do is shut the play off. No other things, like going to menu, enter dir-mode, etc., are working. But the Main-Unit does work. When you fast forward/backward with the main unit a bit after you chrashed the remote, everything works fine again.

Very strange, Im not sure of it is a Buttan Changes related Bug but it start happening after the new system was implemented.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: volt on August 18, 2006, 09:26:17 PM
iAudio x5: CVS-061686
- Setting the date is shifty - you have to use "joystick left" only to change between hr, min, sec, date, year, etc.
- Changing foreground/background colors (General Settings/Display/LCD Settings) is impossible; any button either moves between R G B or exits the option
- There are also uncertainties between "play" and "joystick press", as in, sometimes Rockbox asks you to press "play" to do something (battery_bench for one) but pressing "play" cancels, and "joystick press" initiates the battery bench.
- In the browser after "joystick press" to bring up the file submenu if you use "joystick right" on "delete", Rockbox asks you if you want to delete but immediately returns back to the file submenu (as if the "joystick right" was pressed twice).
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Davide-NYC on August 18, 2006, 10:22:51 PM
Quote
When you use the navi-wheel on the H120 Remote to fast-forward of fast backward a song the song doesnt start playback after you stop the forward/backward going.

I can confirm this bug using an iRiver H140 and the H300 Joystick remote when pressing remote LEFT/RIGHT as well.

When you 'nudge' a track with the remote, track position changes successfully. But playback never resumes when you release the button.

Using the main unit LEFT/RIGHT "unsticks" the track position and resumes playback when released.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: TrueNorthOz on August 19, 2006, 04:54:20 AM
With Version 060819 ; You cannot move around the the fields in the time and date function. Cursor is stuck on hour field. using arrows does not work !
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on August 19, 2006, 05:09:26 AM
unless something horrible happens (i.e i become social and go out tonight) the time and eq and other screens should all be fixed in the next few hours...

Davide-NYX: can you test the very latest cvs build and let us know if the rmeote works properly? Bger has fixed it up... hopefully :p
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Hansmaulwurf on August 19, 2006, 05:26:53 AM
Davide-NYX: can you test the very latest cvs build and let us know if the rmeote works properly? Bger has fixed it up... hopefully :p
The fast-forward/backward bug is still there but the other things work normal as far as I can see.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on August 19, 2006, 05:36:33 AM
Quote from: Hansmaulwurf link=topic=5829.msg45836#msg45836
The fast-forward/backward bug is still there but the other things work normal as far as I can see.
[/quote
is this with the very latest?? becuase i just checked my h100 lcd remote and it works fine
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Hansmaulwurf on August 19, 2006, 06:54:11 AM
You are right, it works.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Davide-NYC on August 19, 2006, 05:34:18 PM
Yes, nudging with both the H100 and H300 LCD remotes works now. Thanks!

Unfotunatley I have to report a new bug.
Well, it's either a bug or an incomplete change.
Please refer to the 'button labeling' in the gifs below.
All tests were done using an iRiver H140:

While in File Browser H100 remote does not +item or -item.
Instead the FF / NAVI / REW bottons (top left rocker switch) do up_dir / action / action.
(I'd prefer this with the vol -/+ rocker doing the -item/+item, but this is not the design spec)

Virtual Keyboard entry on H300LCD remote:
LEFT/RIGHT are correct.
What should be UP/DOWN is mapped to -10/+10
All else with VKeyBd seems to be cool.


[attachment deleted by admin, too old]
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mmmm on August 19, 2006, 06:11:52 PM
This is weird...Mine doesn't work in the filebrowser! H100 remote, ff goes up a level, rew goes down, play tries to select and resume at the same time and stop stops play and goes back down a level....Does everybody elses work then? ???
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on August 19, 2006, 07:21:39 PM
Davide-NYC:
i just tested, my h100 lcd remote works as expected in the browser (ffd/rew is up/down entry, not enter dir)

and there should have been no change in the vkeyboard as its not using the actinos stuff yet
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mmmm on August 19, 2006, 07:27:31 PM
Davide-NYC:
i just tested, my h100 lcd remote works as expected in the browser (ffd/rew is up/down entry, not enter dir)

and there should have been no change in the vkeyboard as its not using the actinos stuff yet
really? mine doesn't work.... I'll do an update again...maybe I missed something...  ;D

I fixed the problem...some stuff in listtree_scroll_wo_cmb was a bit awry...But maybe I didn't need to if yours is working anyway.

 There is some other weird stuff in there too in the h300lcd version...using BUTTON_RIGHT and BUTTON_LEFT!!!! these aren't remote buttons...... agggghhhhh what's going on...am I losing it?  ??? :-\
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Llorean on August 19, 2006, 07:48:28 PM
The pictures that have been poster are based on button labels, and don't actually indicate what the buttons are intended to do in Rockbox.

For example, Left/Right on the H100 remote (fast forward and rewind) are actually *supposed* to move the cursor up and down in a list, while in list views. While on the H300 remote, the proper Up and Down buttons should be used.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mmmm on August 19, 2006, 07:56:23 PM
Right, well...here's a patch that seems to fix everything up nicely for me... I don't understand how JdGordon can have a working filebrowser and I haven't..weird

Give this a go and tell me if it sorts it out (if it isn't working) or doesn't break it  (if it is working).

Patch (http://forums.rockbox.org/index.php?topic=5829.msg46008#msg46008)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Davide-NYC on August 19, 2006, 08:53:52 PM
Davide-NYC:
i just tested, my h100 lcd remote works as expected in the browser (ffd/rew is up/down entry, not enter dir)

and there should have been no change in the vkeyboard as its not using the actinos stuff yet

I just redownloaded a clean CVS and rebuilt. The H100 remote buttons still do not behave corectly in file browser.
Remote << / navi / >> performs  up_dir / action / action respectively.
It is supposed to perform -item / action / +item

Mmmm,
When patching source using your patch I get an error while trying to NORMAL MAKE for an H120 target:

Code: [Select]
CC keymaps/keymap-h1x0_h3x0.c
keymaps/keymap-h1x0_h3x0.c:334: error: `BUTTON_REW' undeclared here (not in a fu
nction)
keymaps/keymap-h1x0_h3x0.c:334: error: initializer element is not constant
keymaps/keymap-h1x0_h3x0.c:334: error: (near initialization for `button_context_
listtree_scroll_wo_cmb_h300lcdremote[3].button_code')
keymaps/keymap-h1x0_h3x0.c:334: error: initializer element is not constant
keymaps/keymap-h1x0_h3x0.c:334: error: (near initialization for `button_context_
listtree_scroll_wo_cmb_h300lcdremote[3]')
keymaps/keymap-h1x0_h3x0.c:335: error: initializer element is not constant
keymaps/keymap-h1x0_h3x0.c:335: error: (near initialization for `button_context_
listtree_scroll_wo_cmb_h300lcdremote[4]')
keymaps/keymap-h1x0_h3x0.c:336: error: initializer element is not constant
keymaps/keymap-h1x0_h3x0.c:336: error: (near initialization for `button_context_
listtree_scroll_wo_cmb_h300lcdremote[5]')
keymaps/keymap-h1x0_h3x0.c:337: error: initializer element is not constant
keymaps/keymap-h1x0_h3x0.c:337: error: (near initialization for `button_context_
listtree_scroll_wo_cmb_h300lcdremote[6]')
keymaps/keymap-h1x0_h3x0.c:338: error: initializer element is not constant
keymaps/keymap-h1x0_h3x0.c:338: error: (near initialization for `button_context_
listtree_scroll_wo_cmb_h300lcdremote[7]')
keymaps/keymap-h1x0_h3x0.c:339: error: initializer element is not constant
keymaps/keymap-h1x0_h3x0.c:339: error: (near initialization for `button_context_
listtree_scroll_wo_cmb_h300lcdremote[8]')
make[1]: *** [/home/Administrator/rockbox-devel/build.H120/apps/keymaps/keymap-h
1x0_h3x0.o] Error 1
make: *** [all] Error 2

Looking forward to this patch or the fix!  ;D
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: PaulJam on August 20, 2006, 05:46:57 AM
[Fixed]
Target: h300

The buttoncombination short press - long press on RIGHT in the WPS to jump to the next directory doesn't work anymore.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Hansmaulwurf on August 20, 2006, 06:02:57 AM
Yes, nudging with both the H100 and H300 LCD remotes works now. Thanks!

Unfotunatley I have to report a new bug.

While in File Browser H100 remote does not +item or -item.
Instead the FF / NAVI / REW bottons (top left rocker switch) do up_dir / action / action.
(I'd prefer this with the vol -/+ rocker doing the -item/+item, but this is not the design spec)

Virtual Keyboard entry on H300LCD remote:
LEFT/RIGHT are correct.
What should be UP/DOWN is mapped to -10/+10
All else with VKeyBd seems to be cool.


Same Problem here, i cant move +item -item in the directory-view. Only go a directory up or down, or go +10 -10 items at once.

In some menus like the "Language" menu there is the same problem, you cant go up/down one item with the remote.

Another new Bug: The Quick-Screen on the H120 remote doesnt work anymore, the only thing you can change in the Quick-Screen are the "Show Files" over the Navi-Wheel (Bevor the system change I think you changed the "Repeat" Mode with the Navi-Wheel). "Shuffle" and "Repeat" Modes cant be selecetd with the remote.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on August 20, 2006, 06:10:46 AM
Target: h300

The buttoncombination short press - long press on RIGHT in the WPS to jump to the next directory doesn't work anymore.
that combo is bloody hard to get working now, so its been remmaped to play+next/prev
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mmmm on August 20, 2006, 06:37:54 AM
Mmmm,
When patching source using your patch I get an error while trying to NORMAL MAKE for an H120 target:

Looking forward to this patch or the fix!  ;D
Oops... This one should work... :)

Another new Bug: The Quick-Screen on the H120 remote doesnt work anymore, the only thing you can change in the Quick-Screen are the "Show Files" over the Navi-Wheel (Bevor the system change I think you changed the "Repeat" Mode with the Navi-Wheel). "Shuffle" and "Repeat" Modes cant be selecetd with the remote.
This patch also fixes this problem !

EDIT:
                                             ...PATCH COMMITTED...
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mmmm on August 20, 2006, 08:38:11 AM
Try CVS now...all remote probs (that use button code) should be sorted (I hope)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mikerman on August 20, 2006, 09:08:27 AM
Target: h300

The buttoncombination short press - long press on RIGHT in the WPS to jump to the next directory doesn't work anymore.
that combo is bloody hard to get working now, so its been remmaped to play+next/prev
Could we please try to get the short press + long press left/right combination functional again?  It's really needed needed for convenient (one-handed) use.  Thanks--
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: roger767 on August 20, 2006, 10:32:02 AM
On my iRiver ihp 120. I always set "Load last Bookmark" to ask, when I get the LLB screen I cant exit the screen or get a list of my bookmarks. I can only confirm by hitting the Navi button.

PS. this is with the controls on the player.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mmmm on August 20, 2006, 12:00:28 PM
I've added the recording screen to the button action code and I need some testers.

It seems to work nicely for the H1xx with both remotes but I can only test on the OndioFM, Recorder and X5 using the Sim which isn't really very good for testing the recording screen.

So if there is anyone with a target that records out there could you patch and test that the buttons do as they should? Thanks...  ;D

EDIT:
                                   ...COMMITTED...
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mmmm on August 20, 2006, 12:26:16 PM
On my iRiver ihp 120. I always set "Load last Bookmark" to ask, when I get the LLB screen I cant exit the screen or get a list of my bookmarks. I can only confirm by hitting the Navi button.

PS. this is with the controls on the player.

Yep, confirmed......

Try it now....That should have fixed it...
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Hansmaulwurf on August 20, 2006, 02:03:17 PM
Try CVS now...all remote probs (that use button code) should be sorted (I hope)
Everything fine now, thanks for fixing!  :-*
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: LinusN on August 20, 2006, 02:33:58 PM
Could we please try to get the short press + long press left/right combination functional again?  It's really needed needed for convenient (one-handed) use.  Thanks--
Seconded, because that is the *only* way to do it on the X5.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Davide-NYC on August 20, 2006, 03:25:45 PM
Small bug with H100 remote on H120 with Mmmm's patch:

While in the Recording Screen: pressing and holding bitrate/source (aka -10/+10) does not change value more than one.
All changes to setting are done by quick presses. Incrementing and decreneting the volume drastically requires many short taps.
In other words: if a user selects gain and wants to reduce it drastically they have to 'tap-tap-tap-tap' in single increments.

[FIXED]
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on August 21, 2006, 12:23:28 AM
Seconded, because that is the *only* way to do it on the X5.
doesnt the x5 have keys on the side? wouldnt that make 2 key combos easier?
I guess the eaisest way to add this back in would be playing with states in the wps code again... unless you can think of a way the actions code can do it?
Ill be working on my sisters computer tonight so i can get the settings screens al working again (including time/eq/etc), so hopefully we should be back to usable again real soon :p
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Llorean on August 21, 2006, 12:25:54 AM
I think the X5 can't do button combos, can it?
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Atheistic Freedom on August 21, 2006, 01:37:09 AM
Dunno if this has to do with the button changes, but with iPod 5G (Video), you have to re-select 'Yes' for the Hardware EQ to actually turn on (regardless of what is highlighted) every time you turn off your iPod, then turn it back on.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: LinusN on August 21, 2006, 02:12:42 AM
I think the X5 can't do button combos, can it?
Correct. The  only button it can use for combos is the Power button, and that is far too inconvenient.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Atheistic Freedom on August 21, 2006, 01:16:35 PM
http://forums.rockbox.org/index.php?topic=5985.0

Recent CVS button tweak makes it so you have to hold down the select button and scroll to 'unlock' the bug from choosing the Playlist option as son as you let go of the button.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on August 21, 2006, 06:33:40 PM
hmmm... are you sure it was working before that commit? I tryed t make sure that it wouldnt actually affect anything... ill have a look.
and so i dont forget, X5 has problems in the tree possibly, and off-off on the reocrder in the trree needs getting to work
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: keuleJ on August 22, 2006, 10:55:35 AM
H140: The A-B-Function in the WPS doesn't seem to work. If you're in A-B-Mode you can push PLAY plus LEFT, but nothing happens.
Can anybody confirm this? Or if not tell me what I did wrong?
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: tvg on August 22, 2006, 12:02:50 PM
Builв 22.08.2006 for iAudio X5 freezes on "Pause" on Remote while playing FLAC. Build 18.08.2006 did not.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on August 22, 2006, 05:13:29 PM
H140: The A-B-Function in the WPS doesn't seem to work. If you're in A-B-Mode you can push PLAY plus LEFT, but nothing happens.
Can anybody confirm this? Or if not tell me what I did wrong?
hmm... this is odd because it should be working...
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Didgeridoohan on August 22, 2006, 06:40:57 PM
H300: In the bookmark list (both most recent and normal) it's not possible to choose a bookmark or exit the screen. You can only browse through the bookmarks and delete them. The only way to exit the screen is to turn the player of (works as normal) or delete all the bookmarks in the list (not very funny).

This is with the latest daily build, by the way (20060822).
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: dpassen1 on August 22, 2006, 11:08:06 PM
Using latest CVS, scrolling through files and folders while holding the Play button does not stop at the first and last file/folder.  Normal scrolling does.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: psycho_maniac on August 23, 2006, 03:01:10 AM
using Recent CVS in the Pitch screen when pressing left to go -2 it does the opposite +2 and the same goes when pressing right. also where in the menu do you access this ? the only way i  find to access this is the shortcut play+up/down i am using a iriver h120
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: xlarge on August 23, 2006, 03:19:53 AM
using Recent CVS in the Pitch screen when pressing left to go -2 it does the opposite +2 and the same goes when pressing right. also where in the menu do you access this ? the only way i  find to access this is the shortcut play+up/down i am using a iriver h120

Used to be like that in the x5 aswell (plus not repeating buttons at all in pitch "window"), with cvs:060822-1222 it's fixed (again - the x5.. don't know about h120)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on August 23, 2006, 03:34:54 AM
Didgeridoohan: yes, the bookmark screen is still broekn
dpassen1: fixed
phsyno_maniac: how recent? i just checked on my h300 (ame key mapping) and it works fine.. also you can access the screen by holding down the joystick in the wps
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: psycho_maniac on August 23, 2006, 02:22:50 PM
version: 060821-1659
now have current version: 060823-1352
still does the same thing...
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on August 23, 2006, 06:41:11 PM
Grr... Magnus Holmgren refixed the bookmark screen bassically disableing my change, so i have to revert mine for this to work...
Ill do it later today...
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mikerman on August 23, 2006, 07:37:51 PM
By the way, jdgordon, thank you for your Herculean efforts on this.  I get the feeling you have 17 fingers, each one plugging a hole in the dike . . . .
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on August 23, 2006, 11:44:02 PM
woopsies... bookmark screen should be working, i read the patch wrong...
Physco_maniac... Im sorry.. i have no idea why you are having problems... :(
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: psycho_maniac on August 24, 2006, 12:17:25 AM
i even deleted everything then put rockbox on again and still does it. also lost all my settings accidently. whoops
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: bascule on August 28, 2006, 02:09:22 AM
Everything seems to have gone quiet on this thread now, so is the view of the Devs that, as far as possible, all button change bugs have now been caught and fixed?

I'd love to download the latest daily with all the updated TagCache goodness, but really haven't got time to worry about things not working properly... ;)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: xlarge on August 28, 2006, 02:36:29 AM
Iaudio X5; In tagcache when "ok:ing" or cancelling a search i press play or rec and first it executes the search but then tossing me into wps (or in the case of "rec" shows me the menu) instead of showing me my search results.
From the wps i can press joystick-center (select) to go back to tagcache and view my search results... (or press rec to exit the menu)


CVS 060828-0934
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: tspoon on August 28, 2006, 04:11:48 PM


Target: h300

The buttoncombination short press - long press on RIGHT in the WPS to jump to the next directory doesn't work anymore.

that combo is bloody hard to get working now, so its been remmaped to play+next/prev


Also, whatever you end up with for this, could us Archos users get a piece of this action. We've been most patient :-)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: tspoon on August 28, 2006, 04:16:38 PM
 Archos Recorder 20 V1
 Bookmarks - Off to Exit viewing bookmark (doesn't, only way out is to select)
 F2,F3 Quickmenu's (F2,F3 to back out again no longer works - it's now stop - the old way was more convenient)
 While in quickmenus also the Up and Down key both now work - used to only be the Down - not really a big deal.
 
 edit: using CVS from 28th Aug 2006
 
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on August 29, 2006, 08:20:03 AM
"Bookmarks - Off to Exit viewing bookmark (doesn't, only way out is to select)"
fixed...
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: roolku on August 31, 2006, 10:41:08 AM
The scroll buttons for the text_editor plugin don't work. The only way I have found is PLAY+LEFT to scroll down.

Cheers
  Roolku
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Rincewind on August 31, 2006, 01:17:10 PM

The scroll buttons for the text_editor plugin don't work. The only way I have found is PLAY+LEFT to scroll down.

Cheers
  Roolku


confirmed, text editor doesn't behave properly.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on August 31, 2006, 09:54:43 PM
just waiting for the sim to finish building so i can test, but i tinhk ive fixed it... you have to use the menu to delete a line tho :'( (for the moment)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: xlarge on September 01, 2006, 01:44:24 AM

Iaudio X5; In tagcache when "ok:ing" or cancelling a search i press play or rec and first it executes the search but then tossing me into wps (or in the case of "rec" shows me the menu) instead of showing me my search results.
From the wps i can press joystick-center (select) to go back to tagcache and view my search results... (or press rec to exit the menu)


CVS 060828-0934


Could someone confirm this?
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: pabouk on September 01, 2006, 05:20:44 AM
Jpski reported nonfunctional button combinations for directory skipping on H120 here: http://forums.rockbox.org/index.php?topic=6237.0.

I checked it on H120 with the latest build 060901-1056. The results are following:
- The short tap followed by a long tap to the right or left works now.
- The holding PLAY + left or right combination still does not work.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: roolku on September 01, 2006, 07:34:10 AM

I checked it on H120 with the latest build 060901-1056. The results are following:
- The short tap followed by a long tap to the right or left works now.
- The holding PLAY + left or right combination still does not work.


I can confirm these findings.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: volt on September 01, 2006, 09:57:08 PM
please read & respond if you can to post #29, also might i add that myself a few others (jhMikeS, infamis) have randomly had a "button right" press register as a "button center" press, about 10% of the time for me (using 18.08.06 cvs).  

(It is a problem for me because when I am driving, the way I hold my player makes it difficult to press play/pause without two hands.)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: bk on September 02, 2006, 11:49:04 AM
Target: iAudio X5

Bookmark select menu is unusable/unexitable. I'm unable to select or delete bookmarks nor able to exit the bookmark display screen (the only way to exit is to power down). Previously I could play but not delete bookmarks ("ON+Play" seemed to not map to any available keypress or combo) however now the screen is unusable (cvs-060831).
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: fml2 on September 02, 2006, 12:28:16 PM
I experience a problem. Have already filed a bug report (FS#5926). A quote from there:

Quote
Model: iriver H120, Build: 2006-09-01 17:59, Default settings

Installed the build (settings were reset since the settings version was changed)
Changed file view to 'All'
Went to ./rockbox/fmpresets, chose a preset file -> radio is activated
Changed to preset mode
Pressed NAVI -> station list displays
* Pressed DOWN -> *** the cursor doesn't move ***
Pressed DOWN once more -> cursor moves
Left station list screen
Pressed NAVI -> station list displays
* Pressed UP -> *** the cursor doesn't move ***
Pressed UP once more -> cursor moves


Does anybody experience the same?
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: roolku on September 02, 2006, 05:45:11 PM

Does anybody experience the same?


Yes, I also have a similar effect when I leave radio mode with the mode button. The first key is eaten. So:

mode -> menu appears
down -> nothing happens
down -> selection bar moves down

(instead of down up has the same problem)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on September 02, 2006, 09:00:03 PM
the fm screen (espeically the presets screen) has not been fixed yet. hopefulyly today
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: tspoon on September 03, 2006, 12:40:20 AM
V1 Recorder
Keypad Lock (F1 + Down)
No longer operates. The F1 Menu seems to work on Key Down - may need to be Key Up.

Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on September 03, 2006, 12:44:46 AM
F1 + down should work for keylock in the wps only.. does it not work there?
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: tspoon on September 03, 2006, 01:00:03 AM
Had another try - it does, but only if you push them both at exactly the same time, other wise the menu appears, or the volume starts changing.

edit - Formerly it was possible to press the F1 first then the Down - to avoid the volume changing. If you press Down first then F1 it does Keylock but only after maybe the volume has lowered. If you got F1 first the menu appears - basically immediately, no Keylock then.

edit edit - Also - The Remote Keys seem to now work in menus - sometimes. Remote Forward/Back will scroll up and down the menu. Remote Play will enter the next menu level. Remote Stop will back out to a higher menu level. However if you enter a menu level using the remote, the remote keys will no longer work until you have done some navigating using the main keypad. The first keypress from the keypad will no longer work either, but subsequent presses will.
 Up until now the Remote Keys have only worked in the WPS, and in various plugins/games etc.


edit edit edit - Thanks for all the work you've taken on here jdgordan
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on September 03, 2006, 01:30:26 AM
ok,ive just commited a simple fix for the F1 key, you should be able to press F1 then down to lock it like before..

Im not sure what the story with the remote butons is tho.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: RaeNye on September 05, 2006, 05:12:56 PM
OK, here are a couple of X5 remote button related bugs.
(I don't know if they were so before the change)

- No button binding at all on line edit screen
- Pressing right/left to switch FM presets switches two presets instead of one (maybe related to the pitch thing?)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: tspoon on September 10, 2006, 08:14:18 PM
 Me Again
 Archos Recorder V1
 When the keypad lock is on, the Remote Keys have no effect.
 Thx again.... 8-)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on September 11, 2006, 07:49:44 AM
Raynee: line edit screen, you mean the vkeyboard yeah? that got key maps not long ago....

the fm screen needs fixing.. ill try to do that tonight

tspoon, sorry mate, i dont have an archos and untill u can simulate the remote buttons in the sim i cant help you.. the code looks correct. nag amiconn so have a look :D
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: adam917 on September 18, 2006, 03:54:55 PM
So did the button system get fixed already, specifically for the iRiver H140 build(s)?
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: roolku on September 18, 2006, 04:40:38 PM

So did the button system get fixed already, specifically for the iRiver H140 build(s)?

Depends what you mean by fixed. There are still a number of screens that are not converted. The ones I am aware of are:

1) FM screen not converted
2) plugins not converted
3) recording screen? (not sure about this one)

Some result in unpleasant (but harmless) glitches such as ignored button presses (e.g. after exiting a plugin, or when dealing with FM presets). So it is usable, but not as smooth as before the change. Unfortunately jdgordon seems to have lost interest, so I suppose it is up to someone else to take over and finish the job. :(
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on September 18, 2006, 07:39:06 PM
i hvant lost interest... i just keep forgetting...
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: adam917 on September 20, 2006, 11:46:50 AM


So did the button system get fixed already, specifically for the iRiver H140 build(s)?

Depends what you mean by fixed. There are still a number of screens that are not converted. The ones I am aware of are:

1) FM screen not converted
2) plugins not converted
3) recording screen? (not sure about this one)

Some result in unpleasant (but harmless) glitches such as ignored button presses (e.g. after exiting a plugin, or when dealing with FM presets). So it is usable, but not as smooth as before the change. Unfortunately jdgordon seems to have lost interest, so I suppose it is up to someone else to take over and finish the job. :(

Oh wow. Looks like I'm stick with daily build 2006-08-15 for a bit longer then...
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: bascule on September 21, 2006, 01:43:22 AM

Oh wow. Looks like I'm stick with daily build 2006-08-15 for a bit longer then...

Frustrating, isn't it? I'm on the same build for the same reasons, but really want to try the new TagCache features  :-\
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on September 21, 2006, 02:18:33 AM
your both being silly... the fact that thew screens mentined havnt been converted means there is no problems with them!
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: roolku on September 21, 2006, 02:42:49 AM

your both being silly... the fact that thew screens mentined havnt been converted means there is no problems with them!


It may not be a problem on the same scale as, say, crashing the player, it is however still very annoying if your keypresses get ignored! Certainly a step backwards from what it was before with regards to usability.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mmmm on September 21, 2006, 03:12:33 AM
Where do your keypresses get ignored? it all seems to be working fine for me!
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Yotto on September 21, 2006, 03:21:19 AM

Where do your keypresses get ignored? it all seems to be working fine for me!


I'm gonna just take a guess and say...


after exiting a plugin, or when dealing with FM presets
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Lear on September 21, 2006, 04:16:09 AM

your both being silly... the fact that thew screens mentined havnt been converted means there is no problems with them!


Not quite true, actually. Check radio.c; the function handle_radio_presets_cb is currently disabled, because the FM screen isn't yet converted, but the menu system is (the menu callback gets action codes, not the button codes the function expects). Someone even wrote "this screen needs fixing!" there. Don't know if it was Linus or you though. ;)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on September 21, 2006, 04:26:02 AM
that was probably me ;P
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: bascule on September 21, 2006, 04:28:49 AM
So, I'm still a bit confused. If I install the most recent build, is the FM screen likely to work 'OK', 'badly', or 'not at all'?
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on September 21, 2006, 04:33:29 AM
as long as u dont need the presets it works fine
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: pabouk on September 21, 2006, 04:38:39 AM
Presets work for me in the current CVS build but the first keypress is ignored after invoking the list of presets (short press of the Navi button).
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: roolku on September 21, 2006, 04:40:44 AM

as long as u dont need the presets it works fine

...and as long as you don't mind the extra keypress after exiting certain plugins [;)]
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: roolku on September 21, 2006, 04:46:40 AM

Presets work for me in the current CVS build but the firs keypress is ignored after invoking the list of presets (short press of the Navi button).


How do you edit entries? I can scoll and select an entry, but not edit it?
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: pabouk on September 21, 2006, 05:24:20 AM
How do you edit entries? I can scoll and select an entry, but not edit it?
Aaah, I totally forgot about the possibility to edit the presets :D I have not changed my presets for half a year. Sorry about that, it does not work for me. :-[
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mmmm on September 22, 2006, 07:19:44 AM
The radio screen should work now...You need to test it though, I don't use the radio screen much so I'm not sure if it is how it should be...seems good to me though! ;)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: pixelma on September 22, 2006, 08:43:20 PM

The radio screen should work now...


Nope!
Your commit broke the functionality of the radio screen on my device - an OndioFm - almost completely!

The only thing that works is going through the stations (while in Preset mode or seeking through the frequencies while in Seek mode) - which is even mapped to the "Up" and "Down" keys that were used to adjust volume. No other button presses have an effect except a "Long Press on Off" and it does now... reboot rockbox! I cannot adjust volume and cannot reach the Radio "context" menu that is really important on Ondio (there you can manage your presets, change between Preset and Seek mode,...) due to the lack of buttons.

I know you don't own such a device, and there might be only a few Ondio users, but it would be really nice (or maybe necessary?) if you ask someone to gather information on how it works now and to test such important changes before committing. Things will even get worse as Rockbox is ported to more and more targets and then this statement may apply to other daps as well. I would volunteer of course and am often present in IRC (same nick).

Thanks, pixelma
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mmmm on September 23, 2006, 06:02:23 AM
I forgot to add the context types!  ::) How silly. Also, the Ondio settings context doesn't contain all of the buttons that the other targets do, so I've added a couple to the fm context ...  that should fix it...

better now?
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: dropandhop on September 23, 2006, 09:14:15 AM
Thanks for your work Mmmm!

Looking back to roolku's post it looks like these items are still left:
1) plugins not converted
2) recording screen? (not sure about this one)

Is this correct?  
If this is true, I hope some folks are able to find the time to get this going properly.

Thanks everyone,
Aaron
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: RaeNye on September 23, 2006, 09:39:20 AM
I committed some X5 remote key mapping yesterday, and I think I'm going to simply identify each RC button with a main DAP button and have the keymap do the same with both.

Specifically, vol-/+ are mapped to UP/DOWN, rew/ff to LEFT/RIGHT, rec to REC, mode to PLAY, menu to SELECT and play/pause to POWER.
I know these aren't the original 'titles' but it's easier to learn one mapping instead of two different ones.

Any objections/comments?
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mmmm on September 23, 2006, 09:48:06 AM

Thanks for your work Mmmm!

Looking back to roolku's post it looks like these items are still left:
1) plugins not converted
2) recording screen? (not sure about this one)

Is this correct?  
If this is true, I hope some folks are able to find the time to get this going properly.

Thanks everyone,
Aaron

I did the recording screen some time ago, although I think there are still a couple of bugs with the trigger function for the archos..I'll be looking into that later.

So it's really just the plugins, and considering each and every one will have to be done seperately, that is a bit of a daunting task!
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: dropandhop on September 23, 2006, 11:11:24 AM
Mmmm,

Great...thanks for the feedback!

I can't imagine how huge of a task it is to do every plugin seperatly.  It's a bummer, because I am sure there are plenty folks out there that aren't updating to newer builds b/c the buttons don't work properly yet.  

So I was tryna think of a way that we could help break up this work load a little more.  Maybe we could create a page on the wiki dedicated to this process.  It could at least keep track of the progress on each of the plugin button updates.  And maybe we could do a call out to all the original plugin coders, and ask them if they could make some of the updates themselves.  Just some ideas to get the ball rolling.

Let me know what you think about this and if you have any ideas to get this going.

Thanks yet again for your great work!
Aaron
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: roolku on September 23, 2006, 11:49:04 AM
Thanks Mmm for continuing with the conversion. There are still quite a few misbehaving buttons in certain situations, but it usually happens when I am on the move and by the time I am back at the computer I have forgotten about them. One thing I can remember though is:

- assume you are in the dir browser, a few levels down the tree, and you scroll the display with play+right and then play+left. When you reach the original position again and keep holding play+left it will go up in the tree until it reaches the root.

Quote
... there are plenty folks out there that aren't updating to newer builds b/c the buttons don't work properly yet.


Seems a bit of a selfish attitude? Testing and reporting problems is a good way a non-programmer can contribute to the project and speed up the process.

Quote
Maybe we could create a page on the wiki dedicated to this process.  It could at least keep track of the progress on each of the plugin button updates.


I think guidelines would be good or at least an example conversion of a single plugin. From the existing Wiki page I gather there are still a few unresolved problems with regards to plugins. (for example - do they create their own contexts? How is this handled?).



Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on September 24, 2006, 04:19:33 AM
thanks mmmm :)

plugin havnt been converted, and most probably wont be for some time for a few reasons, mainly because there are so many, but also because a proper way to do it has not been figured out yet.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: nls on September 24, 2006, 09:23:37 AM
It seems there's leftover button defines in gwps.h a minor thing but hey why not complain when you can  ;)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mmmm on September 25, 2006, 06:32:16 AM


- assume you are in the dir browser, a few levels down the tree, and you scroll the display with play+right and then play+left. When you reach the original position again and keep holding play+left it will go up in the tree until it reaches the root.

This should be sorted now... please test...
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on September 25, 2006, 06:36:53 AM


- assume you are in the dir browser, a few levels down the tree, and you scroll the display with play+right and then play+left. When you reach the original position again and keep holding play+left it will go up in the tree until it reaches the root.

i put this in because it was requested earlier in the thread...
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mmmm on September 25, 2006, 06:45:10 AM



- assume you are in the dir browser, a few levels down the tree, and you scroll the display with play+right and then play+left. When you reach the original position again and keep holding play+left it will go up in the tree until it reaches the root.

i put this in because it was requested earlier in the thread...

I've fixed it so that when you are scrolling left the scrolling stops at the end. if you want to get back to the root you must then release the key and the re-apply the key...so JDGordon, your functionality is still there, I've just got rid of the bug!
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: dropandhop on September 25, 2006, 07:03:34 AM
Anyone else think that making a wiki page like roolku and I talked about would be helpful to get the plugins converted?

Any other ideas?

Thanks!
Aaron
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on September 25, 2006, 07:26:38 AM
Mmmmm: ah ok, :)

dropandhop: your more than welcome to... but like i said, there are code considerations that need to be figured out first befoee plugins get done...
If there are plugins which use the standard menu and list which dont work, list them and they can be fixed.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Quazgaa on September 25, 2006, 07:50:17 PM
Hi, the controls for the radio on x5 seem to be messed up (9/25 build).  Can't scan, and hitting right on the joystick doesnt work at all (can only go left).  Also I've noticed that "key on" and "key record" seem to be inverted in doom if that's relevant or anyone cares.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mmmm on September 26, 2006, 03:26:58 AM

Hi, the controls for the radio on x5 seem to be messed up (9/25 build).  Can't scan, and hitting right on the joystick doesnt work at all (can only go left).

Try it now...
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: AlexP on September 27, 2006, 05:26:08 AM
Another couple for you!

When using the virtual keyboard on the H1x0 remote, when you press right on the record toggle switch (in order to move the cursor up and down), it also deletes the currently entered letter as if you had pressed the record switch in.  Pressing it left moves the cursor without deleting as it should.

When loading a long playlist such that you get the loading splash, the splash says to press OFF to quit loading the playlist.  I assume off means stop (which you hold to turn off), but when you press it nothing happens, therefore it is impossible to quit loading a playlist.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mmmm on September 27, 2006, 09:26:59 AM

Another couple for you!

When using the virtual keyboard on the H1x0 remote, when you press right on the record toggle switch (in order to move the cursor up and down), it also deletes the currently entered letter as if you had pressed the record switch in.  Pressing it left moves the cursor without deleting as it should.

 You mean the Source button right? It seems to be fine for me.... anyone else having problems with this?
Quote

When loading a long playlist such that you get the loading splash, the splash says to press OFF to quit loading the playlist.  I assume off means stop (which you hold to turn off), but when you press it nothing happens, therefore it is impossible to quit loading a playlist.

This too... I inserted my root directory and pressed stop afer about 300 tracks and it stopped inserting and started playing the playlist so far!

Whats going on?  :-\ wierd...
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: AlexP on September 27, 2006, 12:17:06 PM

 You mean the Source button right? It seems to be fine for me.... anyone else having problems with this?

Yep, it moves the cursor but also deletes characters, although not every time, just most.  I've checked in the IO screen and the value changes from FF to 68 (with no exceptions, it does this reliably)

The thing with the playlist isn't inserting, it's loading an already existing playlist.

This is with build 060926 - 1300.  I'll try with brand new when I get home.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: AlexP on September 27, 2006, 01:33:22 PM
OK, I've just tried with the current CVS build (2006-09-27 15:24 on the site) and reset settings, and the problem with the remote virtual keyboard is still there.

The problem with the loading of playlist I can't try again, as my massive playlist (7,000) items is now loading instantly rather than taking ages - it was the cancelling the loading not the creating that I couldn't do before.  This must have been a weird glitch, as it was on a new install on a brand new disk (I broke my last one and had to replace it), so never mind.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mmmm on September 27, 2006, 02:41:15 PM
well, here are the figures you should get from those buttons

Bitrate between  5a and 73
Record between 73 and 8c
Source between  8c and a8

So it looks as if you are pushing the Bitrate button and it is detecting it just fine. This button should move the highlight down as you say. So the problem is elsewhere... unfortunately my player is having a bath at the moment so I can't do more testing... maybe I didn't hold it for long enough.. I'll have a closer look at the code... Does it happen only when holding the button or when doing short presses too or only short presses?

Yes, the playlist loading was instant on mine, that's why I thought you must mean making a playlist! :)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mmmm on September 27, 2006, 03:01:47 PM
Hmmmm, my player is out of the bath and I've been testing the bitrate button like mad but I can't reproduce it, I also can't see anything wrong with the code....Are you sure you're not pressing the button in by mistake sometimes (easy to do, especially when trying to rock the switch right)? It's the only thing I can think of....
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: AlexP on September 27, 2006, 03:55:10 PM
Thanks for looking into this for me!

It's really very odd - I'm definitely not pressing it in (although I agree that is easy to do).  If I hold the direction it deletes one character as I push it then another when I release.  Short pushes likewise.

I can't think of anywhere else the record button is used so I can try there and see if it hardware and detecting a press even when I'm not (if you see what I mean).  It might be hardware and be sending such a short event that I can't see it in the I/O screen.  I'll (shudder) boot up the OF and see if it happens in that, but this looks like it's going more towards a hardware issue :(

Edit:  Well, it doesn't happen in the OF, i.e. pressing right on the source switch doesn't trigger the action that pressing down on it does, so maybe it isn't hardware  ???

Any ideas?  I'm a bit stumped if it isn't reproducable with anyone elses!  It isn't a huge deal actually, as I can use left to scroll up the virtual keyboard, and the record button is hardly used anywhere else, but it's still a mystery...
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Quazgaa on September 28, 2006, 04:18:14 PM


Hi, the controls for the radio on x5 seem to be messed up (9/25 build).  Can't scan, and hitting right on the joystick doesnt work at all (can only go left).

Try it now...


OK, looks good, thanks
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: adam917 on September 28, 2006, 05:42:16 PM
BTW, anyone think that when not playing audio, the Record button should take you to the record screen, to be ready to record (and pre-recording, if you have that setting on)?
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: breizjb on September 29, 2006, 10:29:26 AM
Player: iHP 120 + H100 lcd remote + 060926 build

hello

I had some probleme turn on my player with the remote. It's not a mechanical probleme with the play button of the remote because it work perfectly when the player is switch on. I think it's in relation with the hold switch. This problem appear when the hold button of the remote is switch on and then i try to press the play button. The screen of the remote turn on and turn off without showing nothing ( that s normal the hold button is switch on). Then you press again the play button and nothing appear ( that s weird the screen turn on ones and after not). Then you switch off the hold button and try the start the player with the remote: Nothing happen the the player seems to be block. But you can start from the main unit.

i hope that it is clear and new. Just let's try on my player it is reproductive.
Have a nice day
jb
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Davide-NYC on September 30, 2006, 07:28:33 PM

The screen of the remote turn on and turn off without showing nothing ( that s normal the hold button is switch on). Then you press again the play button and nothing appear ( that s weird the screen turn on ones and after not). Then you switch off the hold button and try the start the player with the remote: Nothing happen the the player seems to be block. But you can start from the main unit.


I am unable to reproduce this bug with iHP-140 + H100 remote, RB build 061001-0321
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: breizjb on October 02, 2006, 05:03:00 AM
ok i will try a newer build.
If i always have the probleme i will describe more precisely.
good appetit for all european people
jb
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: breizjb on October 03, 2006, 10:47:21 AM
So i test it with a new build and i had always the same problem.
I think now that it is a problem with my player because, when i block the player like i say before, it work again when i unpplug and plug again the remote. It is maybe some dust into the connector.
Sorry for this false report, but it really seems like a bug.

jb
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: mattzz on October 03, 2006, 03:47:07 PM
Hi,

on Archos Jukebox Recorder 20 w/ CVS of 03-Oct-2006:

 - double tapping OFF (safe power down) does not work
 - long pressing play to get into playlist mode pauses playback
 - navigating page up/down  ON+up, ON+down does not work

Regards,
  /mattzz
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on October 03, 2006, 08:08:18 PM
mattzz: please try http://jdgordon.mine.nu:8080/ajbrec.ajz and test the shutdown and page up/down. (I'm assuming your recorder is the plain ecoder target? not FM recorder, or recorder v2 ? )

and lastly, what do you mean by "long pressing play to get into playlist mode pauses playback"? are you talkking about going to the screen with "Insert" and "inseert next" from the file/db browser?
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: mattzz on October 04, 2006, 11:21:20 AM

mattzz: please try http://jdgordon.mine.nu:8080/ajbrec.ajz and test the shutdown and page up/down. (I'm assuming your recorder is the plain ecoder target? not FM recorder, or recorder v2 ? )


Hey, thanks for the quick response. I am talking about the old Archos recorder, correct.

I tried the ajz an this is the result:

- Pressing "off" once brings up the "Press OFF to shut down" for about 2 seconds now. But pressing "off" a second time while the off-message is displayed has no effect at all.

- navigating with on+up / on+down still leads to resuming the last title (which is the function of the "on" button pressed as a single key).


Quote

and lastly, what do you mean by "long pressing play to get into playlist mode pauses playback"? are you talkking about going to the screen with "Insert" and "inseert next" from the file/db browser?


Pressing "play" a long time during playback should get you to the wps context menu. This works, but also playback is paused, which should not occur (e.g. to be able to extend your playlist while listening to music).

Regards,
  /mattzz
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: mattzz on October 05, 2006, 03:50:47 PM


- navigating with on+up / on+down still leads to resuming the last title (which is the function of the "on" button pressed as a single key).

Pressing "play" a long time during playback should get you to the wps context menu. This works, but also playback is paused, which should not occur (e.g. to be able to extend your playlist while listening to music).



Hey Jonathan,

wps context menu activation and page up/down have been fixed by your last CVS commit

   apps/keymaps/keymap-recorder.c 1.21

Great - thanks!

I'd like to fix the power-off issue in screen.c but actually I don't get it - the condition where "done" is set to true does not work the way it is supposed to.

(screen.c, line 1008)
Code: [Select]

                /* Is this still needed? commenting out so it compiles..
                    CHECK ME!!
                if(!(button & (BUTTON_REL | BUTTON_REPEAT)))
                */   done = true;
                break;


So - this is still needed but after the button changes I guess the condition has to be modified in some way.

Regards,
  /mattzz



Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on October 05, 2006, 06:26:14 PM
yes, something funny happens on the recorder with the stop button, and because i dont have one its really hard to code for it. I've tried a few things with Scorche in irc but we havnt got anywhere.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: mattzz on October 07, 2006, 07:16:48 AM

Regarding the incorrect OFF button behaviour there is a patch from Markus Braun in the mailinglist:

http://www.rockbox.org/mail/archive/rockbox-archive-2006-10/0160.shtml

Is it worth commiting to CVS?

Regards,
  /mattzz
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on October 08, 2006, 04:38:10 AM
if that patch works then sure its commitable
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: mattzz on October 08, 2006, 01:06:58 PM
As I have no write access to CVS could you please check and submit the patch?

Regards,
  /mattzz
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on October 08, 2006, 05:08:07 PM
i dont have any archos's so i cant test it, if someone else tells me the patch works ill comit it
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on October 09, 2006, 07:16:10 AM
commited... anything else?
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: bascule on October 10, 2006, 02:12:44 PM

commited... anything else?


Yes, I can no longer use the REC button on my H120 (CVS-060927-0216) to delete a line in the Text Editor.

Whilst editing a line, it works fine for character delete, but when viewing the whole file, the previous functionality to delete a whole line using the REC button is no longer working.

I am making an assumption that it's the button code change that has done it ;)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on October 10, 2006, 05:06:47 PM
yes, we havnt figureed out how to use actions in pluins properly yet... i dont tihnk thats really a big deal
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: tspoon on October 11, 2006, 10:54:01 PM
CVS Build 061012 - 228
Archos Player
- and + key are vice versa in menus. - increments values and + decrements.

Cheers
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on October 11, 2006, 10:56:37 PM
just in the menus? or all lists? (that includes the menus, tree, setting windows)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: tspoon on October 11, 2006, 11:00:27 PM
 File tree - OK
 Menu list - OK
 pretty much just in the setting window.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on October 11, 2006, 11:13:25 PM
k, noted.. ill fix that when i get some time later
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on October 12, 2006, 02:25:56 AM
fixed
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: PaulJam on October 20, 2006, 09:07:18 AM
(sorry if this has been reported earlier, i haven't read the whole thread)

Device: H300
Problem: When exiting the virtual keyboard with the STOP button (BUTTON_OFF) while music is playing this stops playback. This happens for example when canceling the rename or the save playlist dialogue.

This can be fixed by changing the button code for ACTION_KBD_ABORT to BUTTON_OFF|BUTTON_REL .
Maybe this needs to be fixed for the LCD-remote and for other targets too.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: dunno on October 20, 2006, 12:04:50 PM
Archos Studio player:

There is a 25 second delay between selecting off and Player powers down, this is way to long, it should surely be quicker.

thanks.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on October 21, 2006, 04:44:16 AM
PaulJam: ta, im about to commit the fix.
dunno: amiconn (who has more knowledge about the player than me) doesnt know why that would happen and its probably not related to the buttons
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: dunno on October 21, 2006, 04:47:46 AM
thanks jdg, guess I'll have to live with it then.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: amiconn on October 21, 2006, 04:49:12 AM

Archos Studio player:

There is a 25 second delay between selecting off and Player powers down, this is way to long, it should surely be quicker.


Do you use any special settings that might cause this? I can't make it happen on my player; shutdown takes 4..5 seconds (from selecting Shutdown to green LED off), most of which is the hardware delay caused by power capacitors discharging. Display is off way before that.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: dunno on October 21, 2006, 07:52:58 AM
thanks for resolving the issue amiconn.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: dunno on October 21, 2006, 10:16:45 AM
JdGordon: Archos Studio

'Scroll speed settings' are transposed, + decreases value and vice versa.
'Scroll start delay' is also tranposed.
'Bi directional scroll limit', also transposed.
'Jump scroll delay' also transposed.

LCD Settings>Contrast, settings transposed (+ decreases value)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: nls on October 21, 2006, 02:50:36 PM
Found something strange in the pitch screen on h300. All the normal stuff works as it should but.
Holding down play and pressing Left increases pitch 2% and if pressed repeatedly will continue increase in steps of 2%
Pressing Right while holding Play does the opposite, decreases gain in 2% steps.
This change stays when Play is released but is reset when Play is pressed again.
If this is a feature the buttons are reversed, Left usually decrease and Right increase, but I really think this is unintentional.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on October 21, 2006, 06:49:28 PM
dunno: wha? numbered settings are alwys in decending order..

nls: dont touch play while you are in te pitch screen is the simple answer :D
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: dunno on October 22, 2006, 01:22:03 AM

dunno: wha? numbered settings are alwys in decending order..

Not on the Archos player, it doesn't have the screen space to display all the values as the other targets, its only a 2 line display, so it displays values one at a time, hence the transposed numbers when selecitng + to increase and vice versa in those menus.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on October 23, 2006, 07:35:46 AM
fixed.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Llorean on November 05, 2006, 11:07:38 AM
Pressing Left in the context menu on H100 or H300 (at least) exits the context menu (no matter how deep in the menu you are) rather than simply going up a level as it should.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on November 05, 2006, 06:47:58 PM
hmm... i never noticed that before... anyway, looking at the code i think it has always worked like this. I dont think this has anything to do actions but with the way the menu sub-functions are coded.. (i hope that makes sense)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: roolku on November 17, 2006, 05:21:03 AM
Not sure if this is the right place to report it, but after your actions for plugins the play and the pause keys are swapped and the stop key doesn't work on h120.

Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: pixelma on November 17, 2006, 08:49:38 AM
JdGordon,

your latest "fix ondio keymaps" has no effect at all. Still "up" and "down" have no function in the game menu as well as in the game (would be "show highscores/resume" and "fire bubbles/save game"). Also bubbles don't get automatically shot after a certain timeout anymore and this is a general problem for all targets as it seems (testet on H300-Sim, too). The time itself presumably is counted because after this time I'm able to "fire" a bubble on Ondio as it accepts any button press as fire then (except "off" still exits the game). By the way... these problems are already noticable in the simulator! ;)  ;)

On a related note I do think that button actions aren't very helpful for plugins as there can be great differences in intuitive controls for the variety of plugins - and there will always be certain game specific "actions" that you wouldn't need in any other plugin.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Atheistic Freedom on November 17, 2006, 10:28:47 AM
I agree, now Bubbles and the Metronome (on the iPod, at least) are pretty much broken, because what one simply used the scrollwheel for (i.e. moving the "cannon" in Bubbles), you now have to KEEP PRESSING LEFT OR RIGHT just to move it and then fire; very tedious.  Also, you can't exit out of the two plugins with Menu like before.  Not even Menu+Select with Bubbles easily; I had to keep doing that button combo 204 times before I must've tripped something and it finally took me out of there.

To make a long story short, I say the recent re-button mapping should be reversed.  There was nothing wrong with it before , but there certainly is something wrong with it now.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on November 18, 2006, 05:38:22 AM
pixelma, damn, I thought it was fixed.
The reason acitons are needed in plugins (to at least be able to be used) is that as each new target comes along it is a massive pain to get a working keyboard layout for each target. There are 9 target layouts at the moment I think, So thats 9 different layouts a new plugin needs to have figure out.. This gets very much harder when the person developing the new plugin only has one or two targets...

My personal gripe (not pointing to anyone in particular) is that not enough help is given in IRC. Look in the logs.. I always ask for people who has a target I dont have to test and most of the time no-one has, posting to the tracker is a waste because in the nearly a week this patch was up before being commited I had one response from Linus who said it looked good, and noone mentioned it in irc negativly...
So, I'm stuck with commiting and enduring the crtisism and fix the reported bugs (which I think I have done adequatly).

So unless I'm told by someone in charge to revert Im going to fix the problem.


(PS, Ive had a long day and im in a shitty mood, this is not the normal me..)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on November 18, 2006, 06:17:30 AM
and according to the sim, bubbles now works correctly again.

HURRY seems to be displayed for quite a while, but it does automatically shoot, so i assume its working corectly.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: roolku on November 19, 2006, 05:51:20 AM

Not sure if this is the right place to report it, but after your actions for plugins the play and the pause keys are swapped and the stop key doesn't work on h120.


Whoops. I just realised that I completely messed that posting up. So I'll try again:

In the metronome plugin on h120:

* the stop key doesn't exit the plugin
* select and play have their functionality swapped (select works as start/pause and play works as Tap)


Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Atheistic Freedom on November 20, 2006, 10:17:58 PM
Sorry, but Bubbles does not work.

It was seriously perfect before whoever decided to mess with it, and I can only fear the same with the Metronome (I'll check up on later).

To move the "cannon," one must now move it by flicking their thumb damn fast in short strokes, because it will only take the scrolling in short increments, not a continuous sweeping motion like before.  And even with the "flicking," the cannon moves literally a hair's width side to side.

In short, it's still (very) broken, and I do not see why the button changes were implemented in the first place.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on November 20, 2006, 10:28:48 PM
how about saying which target the problem is with?
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Atheistic Freedom on November 21, 2006, 12:39:59 AM
Darn it, I knew I forgot something vital.

iPod - 5G.

Thank you for looking into it.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on November 26, 2006, 03:50:40 AM
metronome fixed, fixing my dads laptop then ill grab my sisters nano and sort out the bubbles problem
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: MichaelG on November 26, 2006, 03:55:25 AM
Iriver H120.

In Bookmark History you can delete Bookmarks with Buttons On+Navi. That doesen't work. I have the Last Build working.

MfG Michael
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on November 26, 2006, 04:19:04 AM
yes, bookmark screen is horrible and (imho) needs to be completly refactored.... it will get done when someone can figure out a nice way to do it

bubbles is fixed for the ipod in cvs as of now
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Atheistic Freedom on November 26, 2006, 08:05:13 AM
Thank you jdgordon for the fixes of both the Metronome and the Bubbles plugins.  I am uploading it on my iPod right now so I can test them out while I wait out in the cold for a Wii  :D
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mmmm on November 27, 2006, 04:54:39 AM
Iriver H120.

In Bookmark History you can delete Bookmarks with Buttons On+Navi. That doesen't work. I have the Last Build working.

MfG Michael
The record button deletes bookmarks, as it says on the screen.

EDIT: Ahh, I see you have sorted your problem here:
http://forums.rockbox.org/index.php?topic=7480.0
Your lang file is out of date.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: slash14 on December 02, 2006, 09:25:37 AM

Thank you jdgordon for the fixes of both the Metronome and the Bubbles plugins.

Hi everyone.

Seems that the Rec button has been disabled in the Metronome plugin, so synchronization can't be performed anymore (latest Rockbox edition and metronome.c v1.34)

Any way to fix this please ? I'm not used to the Rockbox development to correct this myself right now.

Thank you.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: slash14 on December 02, 2006, 11:51:17 AM
An answer to my own previous question:
With the following trick, it works (refers to the very end of metronome.c):
Code: [Select]

#ifdef  METRONOME_TAP
            case METRONOME_TAP:
                tap();
                break;
#endif

#if METRONOME_SYNC
            case METRONOME_SYNC:
                minitick = period;
                break;
#endif

            default:


to become as follows:

Code: [Select]

#ifdef  METRONOME_TAP
            case METRONOME_TAP:
                tap();
                break;
#endif

            case METRONOME_SYNC:
                minitick = period;
                break;

            default:


Do you think it was an error in the original source code, or should I consider myself lucky wih this trick to make it work ? I'm not a very good developper / coder, sometimes I make things work without understanding why ;)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: pabouk on December 02, 2006, 02:43:18 PM
Your correction works but the correct way should probably be:
Code: [Select]
#ifdef  METRONOME_TAP
            case METRONOME_TAP:
                tap();
                break;
#endif

#ifdef METRONOME_SYNC
            case METRONOME_SYNC:
                minitick = period;
                break;
#endif

            default:

I.e. support the option only if the symbol is defined.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: slash14 on December 02, 2006, 02:47:06 PM
Yeah, I also tested it, but it didn't work.

My device is an iHP120.

I also removed the previous #ifdef just before the METRONOME_TAP and it didn't change anything : with or without this #ifdef, tapping the tempo will work ...

Thanks for your answer anyway.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on December 02, 2006, 07:17:45 PM
Ive just replaced the #if with #iifdef, it should work...
It cant be completly removed because it will causee builds errors in the other targets.

actually, that change shouldnt make any differenece... iif it still doesnt  work let me know and ill try agaain
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: pabouk on December 03, 2006, 09:30:24 AM
Slash14 was right. Unfortunately it still does not work.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mmmm on December 03, 2006, 11:36:51 AM
Not surprising really seeing as METRONOME_SYNC is never defined...
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: slash14 on December 03, 2006, 01:41:08 PM
Might sound as a stupid question but isn't it a declaration (at the very beginning of the file) ?
Code: [Select]
enum {
    METRONOME_PLAY_TAP = LAST_PLUGINLIB_ACTION+1,
#if CONFIG_KEYPAD == ONDIO_PAD
    METRONOME_PAUSE,
#endif
#if (CONFIG_KEYPAD == IRIVER_H100_PAD) || (CONFIG_KEYPAD == IRIVER_H300_PAD)
    METRONOME_SYNC
#endif
};

Without proper declaration, I think that compilation would not succeed, is it ?
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Mmmm on December 03, 2006, 03:27:07 PM
For an #ifdef to trigger, it must have been #define 'd first.
With the new button code for plugins you can't do this as it is using a button that is specific to one set of players only (ie the record button doesn't have a general keymap).
You could give it a general keymap and call it BUTTON_RECORD or something

or you could use
#if (CONFIG_KEYPAD == IRIVER_H100_PAD) || (CONFIG_KEYPAD == IRIVER_H300_PAD)
instead of the #ifdef but that would make adding this functionality to other players, if you wanted to, a real pain.

or you could have something like
#if (CONFIG_KEYPAD == IRIVER_H100_PAD) || (CONFIG_KEYPAD == IRIVER_H300_PAD)
#define MET_SYNC
#endif
at the beginning and then have lots of #ifdef MET_SYNC instead.

Not being too familiar with (and being too lazy to look at) the Plugin button system I think I'll leave it to JDGordon who I'm sure will really enjoy deciding which is best :D ;)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on December 03, 2006, 07:35:18 PM
? I thought #ifdef worked for all names in the file, so enum and function names and such...
ok, ill fix that then
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: Genre9mp3 on December 30, 2006, 05:18:34 AM
A minor problem I noticed yesterday. In the menu of VU Meter plugin, Up acts like Down and vice versa. Everything else seems OK. Tested on H300.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on December 30, 2006, 10:01:19 PM
just checked the code for that menu and its using a custom menu, which means that the button changes of 6 months ago had no effect on them. BUT it does look like up/down are switched which is odd...
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: nls on January 02, 2007, 08:27:40 AM
I have found a minor annoyance in the WPS context menu. If I press right on the reshuffle playlist item in the menu it just goes back to the WPS and does not reshuffle, works fine if I press NAVI though...
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on January 09, 2007, 10:34:20 PM
nls: ok thats wierd.. I seem to be getting the opposite here (h300). righ works, navi doesnt..

actually.. no, i tihnk both work, but for some reason its more instant with right!
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: nls on January 11, 2007, 05:50:38 AM
Yes you're right both works for me now but it takes a good 10 seconds for the wps nex song and the playlist viewer to update even with a playlist of about 15 tracks... guess it's not a button problem then!  ;)
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: roolku on January 11, 2007, 10:21:26 AM
Following on from our discussion on IRC regarding button presses being eaten after exiting certain plugins I have done more experiments.

A plugin only containing:

Code: [Select]
while (rb->button_get(false) != BUTTON_OFF);
is okay

Code: [Select]
   while (rb->button_get(false) != (BUTTON_OFF | BUTTON_REL));
is not okay

Code: [Select]
while (rb->button_get(false) != BUTTON_OFF);
rb->splash(HZ/3, true, "Bye now!");

is not okay for a short press

Code: [Select]
while (rb->button_get(false) != BUTTON_OFF);
rb->splash(HZ/3, true, "Bye now!");

is okay if I hold the button long enough for the splash to disappear

So I am guessing that there needs to be a button code in the queue (i.e. the button release) when exiting the plugin that is then eaten by the action code. If there isn't a "victim" left, the action code will eat the next intentional press available.

I tried to 'repair' calculator.rock by removing the splash screen at the end and it 'fixed' it. However this is not the correct way of solving it, it needs to be fixed outside the plugin.

EDIT:

I found a call to button_clear_queue(); in plugin_load(); immediately after the plugin returns. Removing it fixed the problem for the vast majority of plugins. Some (including the calculator) still have the problem though. Also this call was probably there for a reason, so I don't know what side-effect its removal will have on other targets.



Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: JdGordon on March 31, 2007, 07:18:07 PM
fix committed
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: tspoon on October 14, 2007, 02:19:21 AM
 I know I posted this exact same problem here earlier - and I'm sure it was resolved too, but it seems to be back, or still present, in todays (r15102m-071013) build.

 Platform : Archos Player
 Problem : + and - keys transposed when incrementing/decrementing settings, or scrolling through lists of setting choices - at the bottom level. There is no problem in the top levels, on the volume adjust key sequence, or in file browser, or virtual keyboard.
 
 I don't use the player much, so I don't know if this problem has only just popped up, but I seem to recall (90% sure) it was fixed last time.

Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: ONE_HUMAN on November 06, 2007, 10:54:59 PM

fix committed


Too bad.  Preferred the way it was.  Would be nice if we could map the buttons ourselves, and I don't mean with a patch.
Title: Re: BUTTON CHANGES - REPORT PROBLEMS HERE
Post by: AlexP on November 07, 2007, 03:28:40 AM
This is nothing to do with the change in Sansa keymap.  It was 7 months ago and regarded to an internal change in how Rockbox handled buttons.

Will you please read threads before replying and stop spamming unrelated threads with your dislike of the button change.