Rockbox Technical Forums

Support and General Use => User Interface and Voice => Topic started by: bahus on September 25, 2019, 12:47:32 AM

Title: Time Menu doesn't revert when canceled
Post by: bahus on September 25, 2019, 12:47:32 AM
Found menu that you can't quit on Rocker without saving results: Settings -> Time & Date -> Set Time/Date
It seems Power button here should work as quit without saving results.
Title: Re: Time Menu doesn't revert when canceled
Post by: Bilgus on September 25, 2019, 02:47:44 AM
That is across all of rockbox not just the Rocker -- generally when you run into something that acts this way its for a reason
sometimes its just someone didn't bother to implement it other times it takes too much code
Title: Re: Time Menu doesn't revert when canceled
Post by: bahus on September 25, 2019, 03:44:35 AM
I have Sansa Clip where pressing Power button does quit without saving. So I'm pretty sure it's device specific mapping issue.
Title: Re: Time Menu doesn't revert when canceled
Post by: Bilgus on September 25, 2019, 12:22:35 PM
The Rocker has a button list for the time menu

Code: [Select]
static const struct button_mapping button_context_settings_time[] = {
    { ACTION_STD_PREV,        BUTTON_LEFT|BUTTON_REL,             BUTTON_LEFT },
//    { ACTION_STD_PREVREPEAT,  BUTTON_LEFT|BUTTON_REPEAT,          BUTTON_LEFT },
    { ACTION_STD_NEXT,        BUTTON_RIGHT|BUTTON_REL,           BUTTON_RIGHT },
    { ACTION_STD_NEXTREPEAT,  BUTTON_RIGHT|BUTTON_REPEAT,        BUTTON_RIGHT },
    { ACTION_STD_CANCEL,      BUTTON_LEFT|BUTTON_REPEAT,        BUTTON_LEFT },
    { ACTION_STD_OK,          BUTTON_SELECT|BUTTON_REL,          BUTTON_SELECT },
    { ACTION_SETTINGS_INC,      BUTTON_UP,                BUTTON_NONE },
    { ACTION_SETTINGS_INCREPEAT,BUTTON_UP|BUTTON_REPEAT,  BUTTON_NONE },
    { ACTION_SETTINGS_DEC,      BUTTON_DOWN,                BUTTON_NONE },
    { ACTION_SETTINGS_DECREPEAT,BUTTON_DOWN|BUTTON_REPEAT,  BUTTON_NONE },

    LAST_ITEM_IN_LIST
    //LAST_ITEM_IN_LIST__NEXTLIST(CONTEXT_SETTINGS)
}; /* button_context_settings_time */

Have you tried holding left?

If not it is indeed a failure of the keymap on the rocker and I apologize
Title: Re: Time Menu doesn't revert when canceled
Post by: bahus on September 25, 2019, 01:07:57 PM
It works! Thanks! Not super intuitive though..