Rockbox Technical Forums

Support and General Use => Hardware => Topic started by: Mmmm on June 29, 2006, 03:38:40 AM

Title: 3.0 release: remote support for h1xx
Post by: Mmmm on June 29, 2006, 03:38:40 AM
One of the conditions for 3.0 release is that complete remote support for the irivers is implemented.....I thought I might (no promises on results though ;)) give this a go.

I was wondering if anyone knows exactly what isn't supported yet, just to save me a bit of time mucking about on my player until something doesn't work.

Anyone know/anyone noticed something that doesn't work?
Title: Re: 3.0 release: remote support for h1xx
Post by: Mr. Brownstone on June 29, 2006, 03:49:28 AM
I can only tell you that the iRiver H300 LCD Remote buttons are bugged in the CVS, but are fixed with a patch already in Flyspray.

I don't know about the other remotes.
Title: Re: 3.0 release: remote support for h1xx
Post by: AlexP on June 29, 2006, 04:50:50 AM
I haven't got it in front of me, but bookmarks is one that springs to mind - you can select the menu item, but them the remote is of no more use, you have to actually select the bookmark on the main unit.

There are also some things that clearly can't fit on the remote screen, but it'd be really good if you could at least exit them without having to get the main unit out of your bag.

Good work Mmmm, if only I had the skills to help...  :-\
Title: Re: 3.0 release: remote support for h1xx
Post by: Mmmm on June 29, 2006, 04:58:19 AM
I can only tell you that the iRiver H300 LCD Remote buttons are bugged in the CVS, but are fixed with a patch already in Flyspray.

I don't know about the other remotes.

Bugged all the time in all screens? OK, well, if there's already a patch that's ok.

I haven't got it in front of me, but bookmarks is one that springs to mind - you can select the menu item, but them the remote is of no more use, you have to actually select the bookmark on the main unit.
ok then, I'll attempt a look into bookmarks... :)
Quote
There are also some things that clearly can't fit on the remote screen, but it'd be really good if you could at least exit them without having to get the main unit out of your bag.

In which screens does this happen?

Quote
Good work Mmmm, if only I had the skills to help...  :-\
Heh heh..well, maybe a bit premature....Saying I'll give it a go and actually coming up with the goods are two entirely different things! :) Oh, and you are helping already!

I have just completed the new display gui code in the recording screen/peakmeter (i think) though so that's a start! :D I'll post it on the tracker now....

http://www.rockbox.org/tracker/task/5613 (http://www.rockbox.org/tracker/task/5613)
Title: Re: 3.0 release: remote support for h1xx
Post by: Mmmm on June 29, 2006, 06:32:58 AM
OK, bookmarks screen is sorted

http://www.rockbox.org/tracker/task/5614 (http://www.rockbox.org/tracker/task/5614)

Any more?  :D

I think I'll take a break for today while I wait for more suggestions... there are only so many 'FOR_NB_SCREENS(i)' and 'screens(i).' you can do in one day you know! :D
Title: Re: 3.0 release: remote support for h1xx
Post by: Mmmm on June 29, 2006, 06:57:03 AM
Aha...I found a list...

- A-B | Sound Settings | Equalizer | Graphical EQ
 - A-B | Sound Settings | Equalizer | Save EQ Preset (the virtual keyboard)
 - A-B | Manage Settings | write .cfg file (the virtual keyboard again)
 - A-B | Playlist Options | View Current Playlist | A-B | Save Current Playlist (virtual keyboard)
 - A-B | Playlist Options | Save Current Playlist (virtual keyboard)
 - A-B | Info | Rockbox Info
 - A-B | Debug | View I/O Ports
 - A-B | Debug | CPU frequency
 - A-B | Debug | S/PDIF analyzer
 - A-B | Debug | View OS stacks
 - A-B | Debug | View battery
 - A-B | Debug | View HW info
 - A-B | Debug | View partitions
 - A-B | Debug | View disk info
 - A-B | Debug | View dircache info
 - A-B | Debug | View tagcache info
 - A-B | Debug | View audio thread
 - A-B | Debug | View runtime
 - A-B | Debug | FM radio
 - NAVI (long) | Sound Settings | Equalizer | Graphical EQ
 - NAVI (long) | Playlist | Seach in Playlist (the virtual keyboard)
 - NAVI (long) | Show ID3 Info
 - NAVI (long) | Graphical EQ
 
Looks like I could be some time! :D
Title: Re: 3.0 release: remote support for h1xx
Post by: fairf on June 29, 2006, 07:01:24 AM
Good luck Mmmm - having to dig my iriver out of my bag to exit a plugin or menuscreen is the only thing that bugs me about Rockbox.

Some of the plugins will cause this to happen, such as jpeg viewer, but I don't know if sorting them counts are release critical.

I can't program for toffee, so many thanks to yourself and others making RB so good on the H1xx.

Fairf
Title: Re: 3.0 release: remote support for h1xx
Post by: lowlight on June 29, 2006, 08:04:48 AM
I did the "Show ID3 Info" screen a while ago:
http://www.rockbox.org/tracker/task/3025
Title: Re: 3.0 release: remote support for h1xx
Post by: Assimalyst on June 29, 2006, 08:35:45 AM
Think some of the eq stuff was recently added to CVS by Dan too.

Quote
Add LCD remote interface for the graphical equalizer. Patch #5585 from jdgordon.
Title: Re: 3.0 release: remote support for h1xx
Post by: Mmmm on June 29, 2006, 08:54:09 AM
Thanks for the updates

I've just finished the rockbox info screen, so its just the virtual keyboard left.... (and the debug entries..they're not so important though).

I think I'll leave that one till tomorrow....I need my lunch! :D

lowlight: I changed the Category of your patch to 'remote' so now it's nice and easy to find
Title: Re: 3.0 release: remote support for h1xx
Post by: Llorean on June 29, 2006, 09:35:53 AM
The H300 buttons aren't entirely bugged. People seem to like to report them being bugged, when really the assignments aren't what they expected, and they never clarify.

To my understanding, in the filetree, the buttons on the remote that are labelled the same as the main unit don't do the same things as the main unit. To my understanding it's just in the browser/menus. But as he said, there's a patch, and I believe someone looking into fixing it up
Title: Re: 3.0 release: remote support for h1xx
Post by: AlexP on June 29, 2006, 12:08:37 PM
Blimey, good work already!  When I said some screens wouldn't fit on the remote and could do with just being able to quit, I was probably thinking of plugins, which I guess would need to be altered themselves.  They aren't a huge deal however, as long as the main stuff works!

That's a nice long list you have there though, good luck...  :o
Title: Re: 3.0 release: remote support for h1xx
Post by: Mmmm on June 29, 2006, 03:25:45 PM
The H300 buttons aren't entirely bugged. People seem to like to report them being bugged, when really the assignments aren't what they expected, and they never clarify.

To my understanding, in the filetree, the buttons on the remote that are labelled the same as the main unit don't do the same things as the main unit. To my understanding it's just in the browser/menus. But as he said, there's a patch, and I believe someone looking into fixing it up


Ahhh......... there is no specific definition of the H300 remote in the code, It just uses the same as the H100 remote...So I suppose it's quite likely that the buttons are a bit muddled! But as you know, if no-one clarifys, it ain't gonna get fixed! I can't find the patch either ::) Oh well...

Quote from: BigBambi
That's a nice long list you have there though, good luck...
I've nearly finished now.... just one to go...but it's the hard one..I've been saving it especially! :D
For the virtual keyboard I'm going to have to display different things on the main screen and the remote because of the sizes...aahhhh it takes me back to those peak-meter days! :D
Title: Re: 3.0 release: remote support for h1xx
Post by: Llorean on June 29, 2006, 03:29:16 PM
Well, a list of what keys needed to be fixed is *somewhere* on the Patch Tracker.
Actually, it's here: http://www.rockbox.org/tracker/task/4860
There's a patch that goes with it, and I'm not sure how much it fixes, but the keymappings that are wrong are listed in one of the comments.
Title: Re: 3.0 release: remote support for h1xx
Post by: Mmmm on June 29, 2006, 03:44:16 PM
Well, a list of what keys needed to be fixed is *somewhere* on the Patch Tracker.
Actually, it's here: http://www.rockbox.org/tracker/task/4860
There's a patch that goes with it, and I'm not sure how much it fixes, but the keymappings that are wrong are listed in one of the comments.
Ooh ta Llorean... I may look at that after the virtual keyboard.... :)
Title: Re: 3.0 release: remote support for h1xx
Post by: TiMiD on July 01, 2006, 01:01:47 PM
For the virtual keyboard, I think a complete rewrite would be the best option, using same code for both screens of course with the list of letters scrolling when the screen is too small.

As for the missing screens, it's very simple to guess where some work is needed ; doing a "grep -r lcd_ *|grep -v plugin" gives the list of the applications still using the old display functions

There are also some displays done in the firmware part of the code (for example rolo).
In that case I think the better way would be to rewrite the application to split it into a kernel code part and user space code part since anyway kernel code doesn't have to interract directly with the user, this is a conception error.
Title: Re: 3.0 release: remote support for h1xx
Post by: Hansmaulwurf on July 02, 2006, 08:29:04 AM
"2 Jul 12:28   Kevin   added support remote support for the id3 infos screen (had to slightly change the list engine to use it here as well), corrected a mistake in the french translation"


I cant exit the id3 info screen with remote Buttons. I can scroll the list, and shut down the Player with remote-buttons, but cant exit the screen.

Using CVS build 2006-07-02 12:28:46 with H120 Player and remote.
Title: Re: 3.0 release: remote support for h1xx
Post by: TiMiD on July 02, 2006, 10:41:54 AM
Ooops I forgot remote buttons :)
Title: Re: 3.0 release: remote support for h1xx
Post by: PPP on July 03, 2006, 04:21:02 AM
I don't know, if it would be a new feature and if it's possible, but it would be great to have an own font for the remote.
i use the player primarly in my car, and the small fonts for the WPS are too small. If i change the font to a big one,
the standard WPS looks broken.
Title: Re: 3.0 release: remote support for h1xx
Post by: Mmmm on July 03, 2006, 07:30:26 AM
Woo hoo...remote support for virtual keyboard done!!! ::)

PHEW!!! That was a challenge! :D

http://www.rockbox.org/tracker/task/5628 (http://www.rockbox.org/tracker/task/5628)

The only thing missing is page flip while in morse mode but that isn't that important I don't think.....or maybe it is.....Anyway, I need a breather before I think about that...

So that should complete remote support for V3.0 I think.... :)  8)
Title: Re: 3.0 release: remote support for h1xx
Post by: TiMiD on July 03, 2006, 08:40:13 AM
I looked at your patch and I don't think it's the way to go
first it adds code a lot of complexity and reduces lisibility a lot (there are more clever ways to implement the remote support for a module (in my opinion) than to "just" wrap drawing related instructions with a FOR_NB_SCREENS, even if this would of course requires to change the code structure a lot more)
also I don't like the fact to have the 2 keyboards desynchronized, I mean differents layouts for each screen

PS : Don't take this personnaly, but I really think it's important for this project to have a readable and reusable code over all.
Title: Re: 3.0 release: remote support for h1xx
Post by: Mmmm on July 03, 2006, 10:08:43 AM
also I don't like the fact to have the 2 keyboards desynchronized, I mean differents layouts for each screen
But surley if the screens are the same then we are loosing the advantage of having a large main display. The way I have done it the main screen and the remote behave as if they are different players -but giving the same output  (the small remote screen being dealt with just as any other small screened unit).

Or maybe you mean the fact that each screen doesn't necessarily have the same letter highlighted? The select button on the unit/remote only 'looks' at the screen the button is on, so there would be no confusion whichever screen you were using....only if you were looking at one screen and using the buttons on the other! :D

Quote
PS : Don't take this personnaly, but I really think it's important for this project to have a readable and reusable code over all.
Don't worry I'm not offended.... I did my best but I don't think I would be able to totally re-write the code from scratch so I won't be trying! :)
Title: Re: 3.0 release: remote support for h1xx
Post by: Dwyloc on July 03, 2006, 06:47:34 PM
So that should complete remote support for V3.0 I think.... :)  8)

Thanks for putting the required effort into remote support, as someone how uses the remote a lot it is very frustrating when I have to use the main unit to load bookmarks when I am out and about so I am really looking forward to your remote bookmark support patch being committed.

I am also very happy to see your other remote patches being added as each one that is committed reduces the chance of me and other users getting stuck in an unsupported screen when we are using our remotes and also makes Rockbox look even more professional to other potential users.
Title: Re: 3.0 release: remote support for h1xx
Post by: TiMiD on July 03, 2006, 09:25:44 PM
For the virtual keyboard, I think it would be nice to have a scrolling keymap, to display large alphabets on smalls screens (I'm thinking about japanese kanas on the remote for example)

Also about your patch, it can be commited, as it would be good for the users anyway.

If I find some willpower I will try to rewrite this part from scratch (it was the solution I choosed for some other gui component) but somehow I feel boring when coding ...

So let's see what will happen :)
Title: Re: 3.0 release: remote support for h1xx
Post by: Mmmm on July 04, 2006, 03:25:58 AM
Thanks for putting the required effort into remote support, as someone how uses the remote a lot it is very frustrating when I have to use the main unit to load bookmarks when I am out and about so I am really looking forward to your remote bookmark support patch being committed.

I am also very happy to see your other remote patches being added as each one that is committed reduces the chance of me and other users getting stuck in an unsupported screen when we are using our remotes and also makes Rockbox look even more professional to other potential users.

Glad this is going to make things easier for you Dwyloc, and glad you like the patches, Cheers! :)

For the virtual keyboard, I think it would be nice to have a scrolling keymap, to display large alphabets on smalls screens (I'm thinking about japanese kanas on the remote for example)
If you press the mode button on the remote (and on the main screen if the character set is large) it will flip screens! So if you were to load japanese Kanas it should work already!

Quote
Also about your patch, it can be commited, as it would be good for the users anyway.

Good stuff!

Quote
If I find some willpower I will try to rewrite this part from scratch (it was the solution I choosed for some other gui component) but somehow I feel boring when coding ...

So let's see what will happen :)

I know what you mean...It's hard to get started, but once you start it's hard to stop and once you stop (and it works), it feels oh so good! :D
Title: Re: 3.0 release: remote support for h1xx
Post by: Mmmm on July 04, 2006, 05:49:24 AM
Hmmm I've been compiling with the virtual keyboard for all targets just to test if everything is ok...Found a few bodge ups and fixed them but for the Archos FM Recorder (3) and  the Archos Recorder V2 (4) I get the following compiling error:

Code: [Select]
LD rombox.elf
/home/Martin/crscomp-sh1/bin/../lib/gcc-lib/sh-elf/3.3.6/../../../../sh-elf/bin/ld: region FLASH is full (/home/Martin/build/rockbox/compiled/apps/rombox.elf section .rodata)
collect2: ld returned 1 exit status
make[1]: *** [/home/Martin/build/rockbox/compiled/apps/rombox.elf] Error 1
make: *** [all] Error 2

At a guess I'd say it looks like the code is just too much for their tiny flash memories! How on earth are you supposed to get around this? Does anybody know?
Title: Re: 3.0 release: remote support for h1xx
Post by: petur on July 04, 2006, 06:28:21 AM
didn't know they had remotes... ?

amiconn will be pleased to see you're filling the flash, good for you he doesn't read the forums much :p

I'd say, try to optimize the code a bit?
Title: Re: 3.0 release: remote support for h1xx
Post by: Llorean on July 04, 2006, 07:49:28 AM
How much does your code increase the size by, that it pushes rombox over?
Title: Re: 3.0 release: remote support for h1xx
Post by: Mmmm on July 04, 2006, 08:27:42 AM
Ta for the suggestions...Amiconn came up with the answer: I was using an old cross compiler which churns out elephant binaries!  :-[ Shame on me! :D

So it was a false alarm, the patch is fine...hoorah! \0/
Title: Re: 3.0 release: remote support for h1xx
Post by: fizze on July 05, 2006, 03:34:49 AM
well I use a H300, but the H100 LCD remote. its working like a charm, with paulheu's experimental build and some patches, albeit.
I donno how many of those patches made it into CVS recently.
Title: Re: 3.0 release: remote support for h1xx
Post by: Mmmm on July 05, 2006, 04:35:09 AM
well I use a H300, but the H100 LCD remote. its working like a charm, with paulheu's experimental build and some patches, albeit.
I donno how many of those patches made it into CVS recently.
Go into mode->manage settings->write .cfg file

 I bet your remote isn't working now eh? ;)
Title: Re: 3.0 release: remote support for h1xx
Post by: Dwyloc on July 09, 2006, 01:49:48 PM
Any idea then we can expect to see the remote support for bookmarks committed?

It feels like I have been waiting for it for this fix/addition of missing functionality for ever. ;)
Title: Re: 3.0 release: remote support for h1xx
Post by: Mmmm on July 10, 2006, 05:28:45 AM
Any idea then we can expect to see the remote support for bookmarks committed?

It feels like I have been waiting for it for this fix/addition of missing functionality for ever. ;)

Who knows...linuxstb committed the info screen support and kevin (dont know his nick) committed the Id3 screen support....
I suppose whenever someone with commit access gets interested...you should go on IRC and try nagging a bit! :D

It is part of the 3.0 release requirements so it will definitely be before then.
Title: Re: 3.0 release: remote support for h1xx
Post by: TiMiD on July 10, 2006, 08:51:04 AM
I'm kevin  :)
And yes I wrote (in an sudden excess of motivation) and commited the id3 screen support patch  :P

About your patch, I really don't know, I'm the kind of guy that prefer to rewrite from scratch when I think it can be done in a better way that what is done now, but on the other hand almost everyone else working on the remote has been using an approach like your so ...
Title: Re: 3.0 release: remote support for h1xx
Post by: Dwyloc on July 10, 2006, 09:17:38 AM
OK thanks for the update.  I was aware that there was some debate over whether the patch was the best approach to adding virtual keyboard support for the remote, but I was not aware of any issues with the book marking patch.

As the feature freeze has resulted in a massive increase in the stability of Rockbox I am quite happy to wait on the best approach being worked out.
Title: Re: 3.0 release: remote support for h1xx
Post by: Mmmm on July 19, 2006, 07:30:56 AM
Remote support for bookmarks and VK is committed!
Title: Re: 3.0 release: remote support for h1xx
Post by: Dwyloc on July 19, 2006, 07:48:38 AM
That’s excellent news thanks, keep up the good work.
Title: Re: 3.0 release: remote support for h1xx
Post by: Techy_Bloke on July 19, 2006, 11:30:35 AM
where can i buy a Remote for my H120 ??
Title: Re: 3.0 release: remote support for h1xx
Post by: Dwyloc on July 19, 2006, 11:34:34 AM
where can i buy a Remote for my H120 ??

Most h120 were supplied with them but you can buy a replacement on ebay, quite a few are being listed at the moment.
Title: Re: 3.0 release: remote support for h1xx
Post by: Llorean on July 19, 2006, 12:48:02 PM
And if that fails, iRiver America still offers them for $35 I believe.
Title: Re: 3.0 release: remote support for h1xx
Post by: adam917 on July 22, 2006, 12:06:53 AM
And if that fails, iRiver America still offers them for $35 I believe.
I got mine on eBay for 20 USD + shipping & handling.
Title: Re: 3.0 release: remote support for h1xx
Post by: Davide-NYC on July 24, 2006, 07:11:15 PM
Just for clarity: There are three types of iRiver remotes (that I know of) that will work with the H series sockets. I.E. the iHP-1xx (H1xx) and the H3xx series of players.

1. The original H1xx remote (LCD)
2. The 'blind' remote. (no LCD)
3. The Joystick remote (LCD) <-- rare and SUPER cool IMO

(http://www.misticriver.net/photos/albums/userpics/12230/remotes.jpg)
(http://www.misticriver.net/photos/albums/userpics/20561/Remote%20front.JPG)

The ultimate in Rockbox sweetness would be full functionality of all three remotes on both players.

When support for functionality is commited to CVS what remotes are supported? Which players?
Title: Re: 3.0 release: remote support for h1xx
Post by: adam917 on July 26, 2006, 05:30:00 PM
Just for clarity: There are three types of iRiver remotes (that I know of) that will work with the H series sockets. I.E. the iHP-1xx (H1xx) and the H3xx series of players.

1. The original H1xx remote (LCD)
2. The 'blind' remote. (no LCD)
3. The Joystick remote (LCD) <-- rare and SUPER cool IMO

(http://www.misticriver.net/photos/albums/userpics/12230/remotes.jpg)
(http://www.misticriver.net/photos/albums/userpics/20561/Remote%20front.JPG)

The ultimate in Rockbox sweetness would be full functionality of all three remotes on both players.

When support for functionality is commited to CVS what remotes are supported? Which players?
Right. I believe certain regions of H300-series models got the joystick remote. My iMP-900 CD player coems with that remote and it works perfectly on my iMP-550 (H100-generation) CD player as well. The 'blind' remote included with US H300-series models, the iMP-1100, and some of iRiver's current PMP models sucks for any serious navigation, but may be OK for users who just put their music on random and wish to just pause/stop/volume change/power on/off here & there...

PS: Adding to that sweetness would be at least some plug-in support on the remotes (especially the plug-ins that don't need or use the entire screen).
Title: Re: 3.0 release: remote support for h1xx
Post by: MU4L on July 29, 2006, 02:23:33 PM
My iMP-900 CD player coems with that remote and it works perfectly on my iMP-550

Yes, and it'll work with both the H100 and H300 Series, too, IIRC.

I've been looking for an iMP-900 (for said remote), but they're like gold dust  ::)
Title: Re: 3.0 release: remote support for h1xx
Post by: Davide-NYC on July 29, 2006, 03:10:13 PM
Ebay Item number: 180012132220
Or ebay seller 95prober
They're $60, but as you said... gold dust...
http://cgi.ebay.com/NEW-IRIVER-H320-H340-H120-H140-JOYSTICK-REMOTE-CONTROL_W0QQitemZ180012132220QQihZ008QQcategoryZ48683QQssPageNameZWDVWQQrdZ1QQcmdZViewItem (http://cgi.ebay.com/NEW-IRIVER-H320-H340-H120-H140-JOYSTICK-REMOTE-CONTROL_W0QQitemZ180012132220QQihZ008QQcategoryZ48683QQssPageNameZWDVWQQrdZ1QQcmdZViewItem)
Title: Re: 3.0 release: remote support for h1xx
Post by: mattross on August 01, 2006, 04:13:26 AM
Is viewing of text files on the remote supported in 3.0? On the daily snapshot from some time last week it wasn't. When I tried viewing a text file it tried to read it as a configuration settings file.

Also is there any chance of an option to reverse the rocker buttons? I use my H100 remote upside down [with the upside down RLCD option] but have to remember the buttons are reversed as well.