Rockbox Technical Forums

Third Party => Unsupported Builds => Topic started by: shoe on April 24, 2012, 07:56:37 AM

Title: Sansa Clip+: Shoe Build
Post by: shoe on April 24, 2012, 07:56:37 AM
Build for Clip+ with 2 improvements to the radio.

rockbox-full.zip (http://www.fileden.com/files/2012/6/18/3317732/rockbox-full.zip)

1) FS#12610 - Clip+ Ticking Noise Fixed in Radio.

2) FS#12616 - Clip+ Radio Keymap More Consistent
Changes:
-Power Stop the radio and return to Main Menu. *(now behaves similarly to WPS)
-Home Leave the radio screen with the radio playing. *(now behaves similarly to WPS, bringing you to root menu, then back to Radio screen)
-Long Select Switch takes you to the radio menu.
-Submenu toggles between SCAN and PRESET mode. *(used to be of home key)

Here is the comparison with the WPS buttons:

ACTION                 WPS                                     RADIO
Volume Up /Down  -Volume up/down                 -Volume up/down
Left/Right              -Change track                     -Change station
Long Left/Right      -Rewind/Fast forward.          -Next station in SCAN mode.
Play                       -Toggle pause                     -Toggle mute
Long Play              -Pitch screen                       -N/A
Power                   -Stop playback                    -Stop Radio (goes to main menu)
Select                    -File Browser/Database        -Radio Presets
Long Select           -Enter WPS Context Menu    -Radio Menu
Home                     -Main Menu (still playing)     -Main Menu (still playing)
Long Home            -Switch to the Quick Screen -N/A
Home+Select Key   -Toggle hold                         -N/A
Submenu                -N/A                                   -Switch between SCAN and PRESET
Long Submenu       -Show current Playlist          -N/A

EDIT: Download now has the full .zip of the .rockbox folder needed, the correct patch file is attached.

EDIT: 6/16 Reposted the fullzip file
Title: Re: Sansa Clip+: Shoe Build
Post by: torne on April 24, 2012, 09:18:31 AM
The diff you attach is against svn revision 30825, which is not even the last version in SVN, and we stopped using svn some time ago in favour of git, so either the patch is very old (and thus probably doesn't match the binary) or your binary is built from a very old version of the source.

Also, it looks from the filename like you've only uploaded the main rockbox binary, which means that anyone who wanted to use it would have to find the matching standard build to get plugins and codecs and so on, which is not a good way to distribute it, especially if you aren't specifying what build it's actually based on. You probably want to upload the zip instead.

Also also, you should provide a copy of the complete source you used, not just a diff, in order to comply with the license.
Title: Re: Sansa Clip+: Shoe Build
Post by: saratoga on April 24, 2012, 10:18:03 AM
If its just standard code he got from our tracker, I think including the diff is fine.  Anyone would probably be more interested in the FS numbers rather then his diff anyway.
Title: Re: Sansa Clip+: Shoe Build
Post by: shoe on April 24, 2012, 10:47:39 AM
Ok I see I attached the wrong patch file, it should have been from current git build.  I will fix it after work.  I'll also put the entire fullzip for download.

Post Merge: April 24, 2012, 10:16:36 PM
Fixed!
Title: Re: Sansa Clip+: Shoe Build
Post by: driveX on June 15, 2012, 06:07:05 PM
The file is deleted, could you please modify current build and upload it? thank you very much.
Title: Re: Sansa Clip+: Shoe Build
Post by: shoe on June 18, 2012, 10:51:56 PM
Just re-posted the file, since the link had expired.