Rockbox Technical Forums

Rockbox Development => Feature Ideas => Topic started by: jaylee on March 06, 2011, 04:26:07 AM

Title: Stop after current
Post by: jaylee on March 06, 2011, 04:26:07 AM
Foobar2000 has a menu item called "Stop after current", which simply stops playback when the currently playing track ends.
I wonder whether a DAP needs this feature...
Title: Re: Stop after current
Post by: AlexP on March 06, 2011, 06:52:46 AM
I don't know, does it?
Title: Re: Stop after current
Post by: sideral on March 06, 2011, 04:07:17 PM
My Squeezebox players have this feature as well, and I've used it numerous times (for example when leaving the house or when going to sleep). I indeed have been noting Rockbox's lack of this feature myself, but so far my degree of suffering hasn't been big enough to care to implement it.
Title: Re: Stop after current
Post by: Chronon on March 06, 2011, 04:22:41 PM
As a workaround, you could just keep a track of silence and choose to "Play next".
Title: Re: Stop after current
Post by: Llorean on March 06, 2011, 06:10:35 PM
Wouldn't it make more sense, when going to sleep, to have a playlist that stops some generic time in the future (say, 30 minutes, or 7 songs) rather than "at the end of this song?"

I find I rarely know exactly when I'm going to fall asleep once I'm in bed.

I also don't get the usefulness when leaving the house. If you can do that, can't you just press stop? And if you want it to keep playing for a little while after you leave, why again exactly one song?

I can see a "pause at the end of this track" feature as being useful, for example, when doing sound effects or other stuff for a performance, or for when practicing something and having it repeat but wanting it to pause each time so that you're not finding yourself waiting on spinups / buffers or whatnot. But I'm not really sure I get the full "stop" for this track, rather than a regular end of playlist stop.

Maybe if we knew the use cases (and in the case of the ones expressed already, the reasons why "stop at the end of this track" is expected to be the best solution) to see if maybe there's something that makes more sense, or an existing feature that already addresses them?
Title: Re: Stop after current
Post by: sideral on March 06, 2011, 06:46:56 PM
I find I rarely know exactly when I'm going to fall asleep once I'm in bed.

I also don't get the usefulness when leaving the house. If you can do that, can't you just press stop? And if you want it to keep playing for a little while after you leave, why again exactly one song?

Good question. I don't fully remember what I thought when I used the feature, but I think it usually has to do with implicitly programming what will be resumed when I next power on the player: When I know the player turns off after the current track, I also know that it will play the next track when next powered on.
Title: Re: Stop after current
Post by: Llorean on March 06, 2011, 07:00:22 PM
It seems that would also be accomplished by "pause at end of track" since there's already an idle poweroff.
Title: Re: Stop after current
Post by: bluebrother on March 07, 2011, 02:08:46 AM
There's also a patch in the tracker for pause after track.
Title: Re: Stop after current
Post by: Llorean on March 07, 2011, 03:36:09 AM
Yeah, I think pause after track is a good feature since I'm pretty sure it would address most (if not all) use cases for stop after track, and a whole lot more of its own use cases.
Title: Re: Stop after current
Post by: JdGordon on March 07, 2011, 07:47:57 AM
except that patch is very dangerous (unless its changed since i last looked?) (i.e using the track changed events to stop playback)
Title: Re: Stop after current
Post by: Gyro on March 11, 2011, 05:04:43 AM
By "pause at the end of this track", do we mean the same as pause at the beginning of the next track? 
That's the feature I'm looking for. 
Title: Re: Stop after current
Post by: Dynamic on March 14, 2011, 11:31:45 AM
Another use case that led me to search for "Stop after current" and finally get round to registering here:

A friend of mine would like to use this feature for backing tracks over which he sings and sometimes plays guitar when performing for audiences without an sound engineer. He already has an iPad for the resumption of his singing career (plugged into his mixer/effects box) and has to use a workaround of putting each track as a separate album with its own playlist in iTunes before  synchronizing. We've had to do a good deal of preparation and editing anyway - 2 second lead-in per track, no lead-out and some other edits, so that's a minor inconvenience and it doesn't require a change of mode to play a multitrack playlist/album of recorded music during the interval, so we might consider using the same workaround on a device like a Sansa Clip with or without Rockbox.

After each track he can then bypass his mic effects at the press of a button and talk to the audience and select the next backing track from the iPad (as an album/playlist) ready to start the next song. He'd like a backup music player in case the iPad fails or goes into some mode like zoomed-in display he can't get out of thanks to an inadvertant touch gesture (this has happened, delaying the start of a gig for 10 minutes!) and it might supercede the iPad, relegating that to be the backup device, especially if it's possible to pre-plan the likely running order in a playlist so the next track is already selected, waiting for him to press play or change track if there's a change in running order.
Title: Re: Stop after current
Post by: Chronon on March 14, 2011, 01:17:03 PM
"Pause between tracks" seems to address this use case too.
Title: clear playlist button
Post by: guttersnipe098 on March 17, 2011, 12:24:17 PM
Hi!

I'd like to see a 'clear dynamic playlist' option in the Playlist menu (which currently has the following options: View Current Playlist, Search In Playlist, Saver Current Playlist, Reshuffle).

I've been using Rockbox for over a year, but I've yet to figure out how to clear the current playlist. In that year, several times I was away from a computer (couldn't pull up the documentation) and spent a half-hour searching through the menu for this option! Today I was so frustrated that finally had a chance to google this feature (and realized I'm not alone in this frustration).

I know now (not intuitively, but through Google) that I can press 'stop' to clear the playlist--but WHERE IS THE STOP BUTTON? My Sansa Fuze has a toggle play/pause button, but no built-in stop button. Yes, I realize that I can read the documentation to find how to 'stop,' but I shouldn't *have* to (for such a simple feature). I'm not asking for someone to tell me how to do this; I'm requesting that Rockbox add an obvious 'clear dynamic playlist' button to the Playlist menu. I feel that this change will improve the intuitive nature of this project, which will improve Rockbox as a whole.

I love FOSS, but this functionality is incredibly unintuitive, which is a common complaint against FOSS. Don't let rockbox fall into this stereotype! Good software is at least functional, documented, *and* intuitive.

Meta request: Please create a uservoice or similar idea/feature submission application as it would provide much better organization and prioritization of feature requests.


Cheers,
Michael
Title: Re: clear playlist button
Post by: saratoga on March 17, 2011, 01:11:30 PM
Meta request: Please create a uservoice or similar idea/feature submission application as it would provide much better organization and prioritization of feature requests.

Just a reminder, we don't accept feature requests, so please do not post them on our patch tracker anymore. 
Title: Re: clear playlist button
Post by: evilnick on March 17, 2011, 01:12:49 PM
Simply playing a file from a new directory will clear the dynamic playlist and create another.

Is there a reason why you would want to clear the playlist *without* playing a new file?
Title: Re: clear playlist button
Post by: Chronon on March 17, 2011, 01:48:38 PM
Please consult the manual for the key map for your player.  Chapter 4 will tell you the functions of various keys (and key combinations).

I have wanted to be able to clear the playlist (or stop/pause after current) in the past.  (For example, you may wish to end the set of music currently playing without abruptly ending the current track or needing to pay close attention to when the track ends.)  A workaround for now is to choose "Play next" on a track of silence. 
Title: Re: clear playlist button
Post by: nls on March 17, 2011, 06:17:59 PM
"Clear playlist" would have the same function as the recently proposed "Stop after current" so i don't think we need both of those :)
Title: Re: Stop after current
Post by: Chronon on March 17, 2011, 09:57:09 PM
Merged.   :)
Title: Re: Stop after current
Post by: bluebrother on March 18, 2011, 12:35:58 PM
"Clear playlist" would have the same function as the recently proposed "Stop after current" so i don't think we need both of those :)

I don't agree with that -- why should someone wanting to stop playback after the currently playing track also want to clear the playlist the same time? I'm using stop after playback with media players every now and then, and I usually want to keep the playlist.

Clearing the playlist would of course also stop playback after the currently playing track, but it's still not the same :)
Title: Re: Stop after current
Post by: Chronon on March 18, 2011, 01:42:08 PM
I think "stop after current" should satisfy those who want to clear playlist.  Is there another reason to clear the playlist other than wanting to stop after the current track?  If one wants to replace the current playlist with different content the "play next" option can be used. 

Once playback is stopped, a user can choose to resume later or create/load a new playlist.
Title: Re: Stop after current
Post by: Llorean on March 18, 2011, 02:02:07 PM
Why wouldn't "pause after current" work, though?

You can already clear a playlist by explicitly stopping, by selecting a new file, or by using "play next." All three of these can also be used after a "pause after current" to duplicate the effects of a "stop after current." What's the advantage of having both "pause after current" and "stop after current?"
Title: Re: Stop after current
Post by: nls on March 19, 2011, 05:06:24 AM
Yes stopping does clear the playlist so stop after current and clear playlist are functionally the same thing. Although a cleared playlist can be resumed making this a little non-obvious most of the time.
Title: Re: Stop after current
Post by: bluebrother on March 19, 2011, 06:25:17 PM
Yes stopping does clear the playlist so stop after current and clear playlist are functionally the same thing.

I can't confirm that:
Create a dynamic playlist by playing a file in a folder. Let it play for a bit. Press stop. Playback is now stopped, so the dynamic playlist should be cleared. Press Play. The dynamic playlist resumes.

The dynamic playlist is cleared when playback is stopped at the end of the playlist, but inserting a "stop after this track" is something different than "the playlist ended".
Title: Re: Stop after current
Post by: jaylee on March 19, 2011, 09:58:01 PM
Translating "Stop after current" to rockbox, it's almost a playback mode, which means: single track play without repeat, keep the playlist.
Title: Re: Stop after current
Post by: Chronon on March 19, 2011, 10:35:23 PM
Why wouldn't "pause after current" work, though?

You can already clear a playlist by explicitly stopping, by selecting a new file, or by using "play next." All three of these can also be used after a "pause after current" to duplicate the effects of a "stop after current." What's the advantage of having both "pause after current" and "stop after current?"
I agree.  "Stop after current" doesn't offer anything tangible in addition to "pause after current".
Title: Re: Stop after current
Post by: Llorean on March 20, 2011, 09:50:14 AM
I think the most noticeable difference between "stop" and "pause" after current would be if a song ended, then you chose "insert next" on a file.

If it were stopped, "insert next" would create a new single-song playlist and begin playing immediately. If it were paused, the song would be inserted, but playback would not be started, and the old playlist would not be discarded.
Title: Re: Stop after current
Post by: nls on March 23, 2011, 04:10:13 AM
Yes stopping does clear the playlist so stop after current and clear playlist are functionally the same thing.

I can't confirm that:
Create a dynamic playlist by playing a file in a folder. Let it play for a bit. Press stop. Playback is now stopped, so the dynamic playlist should be cleared. Press Play. The dynamic playlist resumes.

As i said:
Although a cleared playlist can be resumed making this a little non-obvious most of the time.
Title: Re: Stop after current
Post by: gbl08ma on March 23, 2011, 10:03:42 AM
I think the difference between stop and pause are that pause keeps the playback buffer in memory while stop does clear it (although it allows playback to be resumed from the point it was before, but it'll need to re-buffer the playlist).

I like it this way as I can use plugins which need to use the playback buffer (e.g. large images on the imageviewer) and that ask to stop playback, without Rockbox "forgetting" what it was playing before.

Perhaps a setting called "Clear playlist on stop" is missing? (and yes, I know, I know, there are some developers that think that we have too many settings already...)
Title: Re: Stop after current
Post by: Chronon on March 23, 2011, 10:21:38 AM
I don't see a need for this setting.  Once playback is stopped you can easily just create/play a new playlist.  It seems to me that the only compelling reason to clear a playlist is to achieve silence after the currently playing track.  If you are just going to add new tracks afterward then you can just use "Play next" to replace the current playlist with those tracks.
Title: Re: Stop after current
Post by: gbl08ma on March 23, 2011, 10:54:16 AM
I don't see a need for this setting.

Nor do I, my proposal was only to have a way to get the old (actual) behavior if this feature idea ever gets implemented.
Title: Re: Stop after current
Post by: sideral on May 10, 2011, 05:10:49 PM
Translating "Stop after current" to rockbox, it's almost a playback mode, which means: single track play without repeat, keep the playlist.

I agree with jaylee here: “Pause after current” could be configurable as another repeat mode (alongside “Repeat 1”, “Repeat A–B”, “Repeat All”, “Shuffle”, “Off”). 

The current implementation of FS#9114 instead introduces a separate option for this function.  To me the major disadvantage of having two separate options is that two quickscreen buttons would have to be wasted on two interdependent options.
Title: Re: Stop after current
Post by: saratoga on May 10, 2011, 09:38:53 PM
I'm not the biggest fan of adding still more playback modes. 
Title: Re: Stop after current
Post by: JdGordon on May 10, 2011, 09:50:32 PM
i agree. This doesnt make sense (to me) as a playback mode. The sensible way to do this is with a context menu option from the WPS which causes it to pause after the current track.
If people want to pause between every track (which I honestly dont see happening very often) they could assign that as the hotkey and do it each track change (they have to press buttons to resume at each track anyway so it isnt a big deal). Needing to change repeat mode to this to do it once is a really bad UI choice.

Title: Re: Stop after current
Post by: sideral on May 11, 2011, 01:33:09 AM
i agree. This doesnt make sense (to me) as a playback mode. The sensible way to do this is with a context menu option from the WPS which causes it to pause after the current track.

I could live with that as well.

If people want to pause between every track (which I honestly dont see happening very often) they could assign that as the hotkey and do it each track change (they have to press buttons to resume at each track anyway so it isnt a big deal).

I agree, but AFAICT, the list of functions that can be put on the hotkey seems rather restricted right now.  It would help if the WPS hotkey could be assigned any context-menu function; but that would probably be wishlist item by itself. :)
Title: Re: Stop after current
Post by: JdGordon on May 11, 2011, 01:36:39 AM
I was under the impression any wps context menu item could be added as a hotkey?
Title: Re: Stop after current
Post by: sideral on May 11, 2011, 01:47:29 AM
Sadly, that's not the case (yet?).
Title: Re: Stop after current
Post by: JdGordon on May 11, 2011, 02:00:34 AM
LAME! ok, go fix it! :D
Title: Re: Stop after current
Post by: [Saint] on May 11, 2011, 02:57:40 AM
I was under the impression any wps context menu item could be added as a hotkey?

Every hotkey action needs to be added manually (before compile time) at present.
IIRC Blue Dude *did* want to be able to add items to the hotkey in exactly the same fashion as quickscreen...but if you'll remember the development of hotkey turned out to be a lot more than Blue Dude intended it to be in the end and I think he was happy just to get it in a committable state.

For now, there's a pre-defined list of hotkey options.
Last added to that was me convincing him to add "Insert Shuffled" to it.

But yeah, ...I'd welcome being able to define hotkey options for the Filebrowser/WPS(/Database too?) from the context menu...that would be awesome.


[St.]