Rockbox Technical Forums

Support and General Use => Recording => Topic started by: Mmmm on January 31, 2006, 11:41:40 AM

Title: Recording Enhancements Pack
Post by: Mmmm on January 31, 2006, 11:41:40 AM
I thought that this deserved its own thread... :-)

Already committed enhancements of the R.E.P.:

i) Petur's and my Gain control patch (no more gain in menu's, all on main screen, digital and analogue combined).
ii) Cliplight.
iii) Remote support for recording screen and peakmeter.
iv) Track split. The record button now acts as a real-time track split button (seamlessly starts to record into a separate file). To pause recording press the play/pause button. Also the track name is displayed on the main unit
v) Extra filesplit options - now you can split or stop at a given time or filesize. Options in recording settings menu.
vi) Statusbar shows recording status
vii) Switch off remote display by pressing vol- on remote (stops recording interference when remote plugged)
viii) Vinylivo's AGC patch (see http://www.rockbox.org/tracker/task/4748 (http://www.rockbox.org/tracker/task/4748) for more info)
ix) Samplerate and channels displayed in the statusbar in the recording screen in place of the redundant repeat mode and shuffle icons. File type and bitrate displayed in place of the volume icon.

The Uncommitted (included in the patch below) enhancements are:

i) The recording screen will display the user font if it will fit but any smaller screen for which it will not fit will remain in the system font. Also, in the menu there is now the option to change the size of the peakmeter to n x the font height If the default font won't fit with this height it will try the height below for each screen, so you can simultaneously have different sized peakmeters.

ii) Vinylivo's histogram patch. Extra: long press mode to turn histogram off and option in settings to set default on/off (see http://www.rockbox.org/tracker/task/5021 (http://www.rockbox.org/tracker/task/5021))

iii) Rincewind's patch for a customisable record button, includes rec+play enter record screen and start recording (To enable go to: General settings->System->Button Config).  (see http://www.rockbox.org/tracker/task/5555#comment8661 (http://www.rockbox.org/tracker/task/5555#comment8661))

iv) New Menu option "Timer options" contains all timer settings (including split timers)
 Â a) Countdown timer. Set in the settings menu. Max countdown time is 1 week. Press play/pause in recording screen to start/pause timer. Press record to override timer and start recording. If you are in the recording screen when the timer finishes, recording will start automatically. If you are not in the recording screen, the timer display will flash to inform you the timer has finished, on returning to the recording screen recording will start instantly.
 Â b) Repeat timer. Set this and make sure that split time < repeat time and your unit will start a new recording at regular intervals depending on the setting. So eg it is now possible to record every day between 3 and 4 o'clock without touching your recorder. Use this in conjunction with the Countdown timer to start the first recording at a specific time.
 (see http://www.rockbox.org/tracker/task/6297, Countdown timer forum thread (http://forums.rockbox.org/index.php?topic=6297.0), Repeat timer forum thread (http://forums.rockbox.org/index.php?topic=7610.msg60037#msg60037))

*****************************************************************
        PATCH: Recording Enhancements Pack (all targets) (latest version) (http://homepage.ntlworld.com/martin.scarratt/Rockbox/recordingenhancementspack.patch)

*****************************************************************
                         BUILD: My build for H120/H140 (http://homepage.ntlworld.com/martin.scarratt/Rockbox/rockbox.zip) (also in my sig)

*****************************************************************
                             BUILD:  Paulheu's Build for H3xx (http://www.misticriver.net/showthread.php?t=38915)

*****************************************************************

Build and patch updated to svn as edit time below.
Title: Re: Recording Enhancements Pack
Post by: fizze on January 31, 2006, 12:52:44 PM
wow the idea of a peak light is awesome :)
I guess those patches will work on a H300 as well ?
Title: Re: Recording Enhancements Pack
Post by: Mmmm on January 31, 2006, 01:04:04 PM
wow the idea of a peak light is awesome :)
I guess those patches will work on a H300 as well ?

Should do... I havent tested it though!
Title: Re: Recording Enhancements Pack
Post by: Mmmm on January 31, 2006, 01:08:58 PM
Remember that strange behaviour I mentioned in my first post? I found the culprit and stamped on it! :-)

Here's the new patch...

[attachment deleted by admin, too old]
Title: Re: Recording Enhancements Pack
Post by: NK-A on January 31, 2006, 02:43:22 PM
Hello Mmmm! (and all you others)

I'm very impressed by the work you have been doing to improve recording on the h1xx! I'm currently using your build and I'm very happy with it. Even though I know it's a bit off thread I have a question for you (since I'm still not a programmer and I have seen you doing good work with this and also quite recently on the metronome). In my opinion recording on the h1xx would be complete if some kind of line in mixer could be added (I know that it has been discussed elsewhere). There is a patch already, but it doesn't work on the h1xx. I asked some questions about the patch a while ago and "lokki" apparently had a look at it, but he said that it was for hwcodec platforms and not for swcodec. So my questions are (and I know I might be asking too much): What's the difference between the two codecs? and: How much work would it be for someone smart to make the patch work on the h1xx?
Since you seem to know quite a lot on how  the recording works maybe you are someone who could answer my questions and/or even make the changes that needs to be done to make it work. As I said before I know I might be asking too much and I have no idea about how many hours of work this would take, but I think that many h1xx users would be very happy if someone made it work.

Thank you Mmmm and all you other guys for the work you have done already to make recording what it is today! (even if nothing will ever happen on this one, you have done great work)
Title: Re: Recording Enhancements Pack
Post by: AGI on January 31, 2006, 03:04:21 PM
auto backlight on when clipping...
what a brilliant idea!

Thanks Mmmm!
Title: Re: Recording Enhancements Pack
Post by: AlexP on January 31, 2006, 03:45:17 PM
I'll preface this by saying I'n not a programmer, however:

Hello Mmmm! (and all you others)
So my questions are (and I know I might be asking too much): What's the difference between the two codecs?

hwcodec means hardware codec, i.e. the decoding and coding of audio files are done in hardware (a dedicated chip in the player), and any functions available are due to this hardware.  swcodec means software codec, i.e. the player has a cpu that is fast enough to handle the coding/decoding and the work is done by software, as on your pc/mac.

This can mean more opportunity on swcodec, as (to an extent) many more functions can be added by someone coding them - to do that on a hwcodec player you would have to add chips!

As to the second question on whether is is possible/how hard on a swcodec platform, I have no idea!
Title: Re: Recording Enhancements Pack
Post by: toolmanwill on February 02, 2006, 04:44:11 PM
I have a tiny request if it is possible, Can the recording screen have bigger fonts? i'm sure this has been asked before but i got a show coning up on march 10th and it owudl be great to have things a lil' bigger to record with.
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on February 02, 2006, 05:24:53 PM
Pardon my ignorance, but will this get rolled into the regular release or will it always remain a plugin?

If it's always going to remain a plugin I need to learn more about plugins.

This sounds like an amazing patch. Thanks!
Title: Re: Recording Enhancements Pack
Post by: Meow on February 02, 2006, 07:59:52 PM
I second that. This should ALL go into the main releases, stat.

And yes, a slightly bigger font would be even greater.

Thanks for your astonishing work for my iHP-140. Life has gotten so much better with rockbox!
Title: Re: Recording Enhancements Pack
Post by: AlexP on February 03, 2006, 03:22:13 AM
Pardon my ignorance, but will this get rolled into the regular release or will it always remain a plugin?

If it's always going to remain a plugin I need to learn more about plugins.

They aren't really plugins - the plugins are things like snake or sudoku, and once included in cvs appear in the regular release for all units that support them.  These are patches, and if they are written in rockbox approved style, don't break anything, and don't make any changes a dev disagrees with, will probably make it in the end once a dev has had time to review and commit them.  A patch can be written to provide a plugin btw!

In the meantime, either use Mmmm's build, or look at the other link is his sig for an excellent guide to patching.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 03, 2006, 10:27:14 AM
Listen to BigBambi...He/she knows what he/she's talking about ! :-D

About enlarging the font:

I suppose it would be possible to use the same font in the recording screen as for the filebrowser/WPS, but the reason for not doing this is because of the non-customisability of the recording screen. Using a font that is too big would make the text run off the edge of the screen!

You may find that your chosen font for the WPS and filebrowser is just too big for the recording screen! Changing fonts each time would be annoying I think. It would also cause havoc with the other targets with different sized screens.

As far as I know, as it stands, rockbox has only two fonts that can be used within the program, the default font (which the recording screen now uses) and the user font. With the default font you are guaranteed to have the whole of the recording screen displayed every time you enter it.

Please feel free to correct me if I'm talking rubbish! :-)
Title: Re: Recording Enhancements Pack
Post by: Meow on February 03, 2006, 12:25:08 PM
I agree, it's also just a matter of getting used to.
Like on my PC, the more you use it, the less important the size becomes, since you know what it is saying anyway.

I don't really mind the small size, in fact, before it got mentioned here I wouldn't have asked either..
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 03, 2006, 01:14:56 PM
Ok... Petur has modified the patch so that each mode now has its own digital setting. This means that when you change between Mic in and Line in, the settings are saved and your previous settings for that mode remain.

I've merged it into the Recording Pack and I've decided to put a link in the first post in this thread to make it easier to find the latest version. So you'll find the new patch there.

I've updated the build in my sig too...
Title: Re: Recording Enhancements Pack
Post by: AGI on February 03, 2006, 01:26:40 PM
Like on my PC, the more you use it, the less important the size becomes, since you know what it is saying anyway.

that is very true, but...
for people with old and tired eyes like me (ok now you know I'm not a kid anymore ;-)) it's almost impossible to see if it is still recording specially when you are in a dark club taping the band of your choice. I use to check the increasing file size and/or the time elapsed for that. After all I woudn't care too much about bigger fonts (even if it would be better IMO) as long as I could have some feedback of what is happening, I think some sort of flashing icon would do the job too.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 03, 2006, 02:59:12 PM
OK then, as a sort of experiment here's a patch that allows you to change the font in the recording screen..It will show the same font as WPS and filebrowser... :-)

Post the font you think works best.

(it also includes the rest of the pack)

[attachment deleted by admin, too old]
Title: Re: Recording Enhancements Pack
Post by: Tenn Man on February 03, 2006, 04:43:45 PM
OK then, as a sort of experiment here's a patch that allows you to change the font in the recording screen..It will show the same font as WPS and filebrowser... :-)

Post the font you think works best.

(it also includes the rest of the pack)

Is this included in your rockbox.zip file?

Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 03, 2006, 05:14:28 PM

Is this included in your rockbox.zip file?


No, but here's a link to a build that includes it...

Build with Changeable fonts in rec screen (http://homepage.ntlworld.com/martin.scarratt/recfontsrockbox.zip)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 04, 2006, 07:46:45 AM
Right.. If you have tried the patch above with the changeable fonts you may have noticed that this messes up the peakmeter on the remote...
This is because the remote peakmeter shares the coordinates of the main unit peakmeter. So if you use a different size font the peakmeter moves on the remote!

the possible solutions I can think of are
i) Have the same font on the remote as on the main unit.
   But the remote screen is filled with the default font and any larger font wouldn't fit and we would have the same problem!
ii) Pass special coordinates to the peakmeter draw function for the remote.
 Â  But then any targets that don't use a remote would get confused and not compile.
iii) Hardcode the coordinates of the remote peakmeter into the peakmeter code.
   But then if you wanted to use the peakmeter in your rWPS you wouldnt be able to place in the desired location, it would always appear  in the same place.
iv) Make the recording screen customisable like a WPS.
ermm... bit beyond my ability that one.
v) Totally rewrite the rockbox code so it can be done easily.
I don't think so! :-D

So....do you begin to see why you cant have customisable fonts in a non-customisable screen when at least two different sized screens have to be catered for, not to mention all the screens of the numerous targets that rockbox has to be compatible with? :-)
Title: Re: Recording Enhancements Pack
Post by: qpwoei on February 04, 2006, 07:55:46 AM
OK then, as a sort of experiment here's a patch that allows you to change the font in the recording screen..It will show the same font as WPS and filebrowser... :-)

Post the font you think works best.

(it also includes the rest of the pack)

Hi, first post here

Mmmm, May God Bless You for helping short-sighted people... like myself :-)
My approach: I Browse Themes, select Marquee. The recording screen becomes soooooooo clear and easy to read... big THANK YOU!
As for the remote, yes, The Volume and Gain lines dissapear with the large font, but I don't care much about this because the meters are visible and clip backlight works ok

cheers
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 04, 2006, 10:22:29 AM
Oooh , I've just thought of an option (vi) !!

and I think it'll work..

In fact, it would be better than the current (non changeable font) version as it would make the remote peakmeter totally independent of the main unit one! Great! This would also work for rWPS's hmmmm...

I just call the peak meter code twice. Once for main unit and once for remote, passing a boolean to tell the peakmeter code which it is for. This would work for non-remote targets too....
Cor....I'll try implementing it later....

Fingers crossed! :-D

Title: Re: Recording Enhancements Pack
Post by: dropandhop on February 04, 2006, 10:47:42 AM
Mmmm,

As usual, great idea!

Have any of the devs commented on your work?  What I am getting at is if there some things that you know are stopping it from making it into the cvs?  Cause that would be splendid!

Keep up the great work!
A
Title: Re: Recording Enhancements Pack
Post by: AGI on February 04, 2006, 11:22:34 AM
Mmmm,

just tried it with Chicago12 and it is what I've dreamed of :-)
I can see what the problem with the remote is. I really hope your idea of a double code will work, fingers crossed here too!

I think you will also like to know that after I loaded the 'Build with Changeable fonts in rec screen' on my h120 I got again the strange different channel gains problem which I got rid of by deleting settings. I am also now having problems playing back files: I get 'codec failure' messages and a lot of HD activity. Not sure, but this could be related to me having played too much with different builds lately :-). I dont have the time to get back to a fresh build now. I'll try to do it tomorrow and I let you know if I get those problems again.

Once more, great work! Thanks a million!
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 04, 2006, 07:15:11 PM
Wow...it works...!!

Even though i've just spent about 4 hours unwriting and rewriting,testing, retesting, unwriting again and then starting from scratch...I am now almost bald and there are teeth marks in my desk! :-D

and then I realized that it will only work if you reset the settings first! I had actually got it completed in about 15 mins!
I don't believe it ......................HA..

anyway, give this patch a go.. now the remote stays the same while you can change the font on the main unit..

and here's the build... (patch attached below)
Remember to reset your settings as soon as your player starts
Same link as before: Changable fonts build (http://homepage.ntlworld.com/martin.scarratt/recfontsrockbox.zip)


Quote from: dropandhop
Have any of the devs commented on your work?  What I am getting at is if there some things that you know are stopping it from making it into the cvs?  Cause that would be splendid!
well..me and Petur are waiting for the gain settings patch to get committed (hopefully soon) and then we go to the next step.

 I'll have to rewrite the remote patch, or maybe i'll have to try to implement the peakmeter all by itself on the remote (as it doesn't work at all at the mo) and after that, recording on the remote.

Cliplight? don't know, could be put on at any time as it is quite separate from the other code.

It's really just a question of whether I have done it in the right way!
I'm very new to this coding malarky so I'm not really totally confident about whether the way I'm doing things is right or not, even though it works!
and I think that it will be just one slow thing at a time if it does get committed..

AGI: I haven't had any of the codec errors you mentioned... and I thought I had sorted the channel gains prob..(I haven't had it since but you never can tell eh?) :-)
Give this new build a go and see what happens.

[attachment deleted by admin, too old]
Title: Re: Recording Enhancements Pack
Post by: Dick on February 04, 2006, 08:47:30 PM
Thanks man. This was the last thing I was missing in Rockbox: Just one button to adjust gain. And seperate settings for Mic and line-in is great, too.
Title: Re: Recording Enhancements Pack
Post by: Tenn Man on February 04, 2006, 09:14:45 PM
Has your rockbox.zip been updated to include this latest work?
Title: Re: Recording Enhancements Pack
Post by: renho3k on February 05, 2006, 01:55:16 AM
Mmmm, i will donate a bottle of rogain for your sacrifices :D

*chants*
COM-MIT! COM-MIT! COM-MIT!
Title: Re: Recording Enhancements Pack
Post by: mlind on February 05, 2006, 03:22:33 AM
I'm still not able to compile myself, so I downoaded the build in Mmmm's sig.

The recording patches are great, but I also noticed:

- The startup screen does not show at all. No big deal, but it probably means something.
- I can't use "browse .wps files" because the first wps in the list immediately gets chosen for use. So to use my own wps I must switch "Show files" to "All" go to .rockbox/wps/ with the normal browser instead.

Something I that might be in the unpatched builds, but I haven't noticed before:
- I listen to a wav (my own recording), turn off the payer, turn it on again, press play. The playback does not resume where I was but starts over from the beginning of the recording.

Finally a microscopical suggestion concerning the Gain Change Patch:
- It's showing (A) or (D) if the gain is changed in the Analog or Digital domain. From 0 to +24 it says (A), but from +24.5 it says (D). Could it be worth the space to have it say (A+D) - as I'm sure is the case.

And! I would like to have the settings for the peak meter duplicated in the recording settings screen.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 05, 2006, 06:49:05 AM
Has your rockbox.zip been updated to include this latest work?
No the changeable fonts isn't included, as I'm not happy with having the same font in WPS as in the recording screen. This means you may have to change fonts to go into recording and then change them again when you play a track! It's just an experiment at the moment.
If I could get a special recording screen font menu then it would be in like a shot, but I was coding all day yesterday to get the peakmeter sorted and need a break! :-)

I have put a link to a build with this in posts #23 and #17. So look there for compiled builds with changeable recording fonts.

Quote from: renho3k
Mmmm, i will donate a bottle of rogain for your sacrifices
Ooh...I'm looking forward to it! :-) ......What's rogain? :-D

Quote from: mlind
The startup screen does not show at all. No big deal, but it probably means something.
Yep, mine did that too but when I reinstalled my settings it seemed ok! I don't understand it either. But it doesnt half boot up fast eh? :-D
Quote from: mlind
- I can't use "browse .wps files" because the first wps in the list immediately gets chosen for use. So to use my own wps I must switch "Show files" to "All" go to .rockbox/wps/ with the normal browser instead.
Mine seems fine...no problems at all :-s
Quote from: mlind
- I listen to a wav (my own recording), turn off the payer, turn it on again, press play. The playback does not resume where I was but starts over from the beginning of the recording.
Yep same here, ogg and mp3 ok though. I reckon thats in the normal builds but I haven't tested.

Quote from: mlind
- It's showing (A) or (D) if the gain is changed in the Analog or Digital domain. From 0 to +24 it says (A), but from +24.5 it says (D). Could it be worth the space to have it say (A+D) - as I'm sure is the case.

And! I would like to have the settings for the peak meter duplicated in the recording settings screen.
The A or D is just supposed to say whether the digital gain is being used or not. A if it's not and D if it is. You are right that the digital gain is on top of the analogue but isn't that fairly obvious? .....maybe not... :-)
You are probably right about the peakmeter settings...I think it would be good here too.. but would we then have the same settings in two places?

Blimey I'm writing some long posts these days :-D
Title: Re: Recording Enhancements Pack
Post by: toolmanwill on February 05, 2006, 07:54:38 AM
WOW, I'm really liking ur patch Mmmm!. I loade3d your already patched build and am loving the bigger font on rec screen. I use 6x13B font size and it makes it fit the whole screen. Peakmeters even get alot larger which is good cause thats prolly the most important thing you'll need to look at while recording. I agree with any others that these changes should be added to cvs for daily builds if possible
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 05, 2006, 08:28:41 AM
The bug with the change fonts patch doesn't go away when you reset settings! what happens is that it make the volume display in the status bar a graphic instead of numeric display (I always have it on numeric), which seems to fix it but doesn't.

if you change the volume when in graphic display, the display momentarily changes to numeric and the bug appears...and then it goes again when the graphic comes back! Weird eh?

It seems that a numeric volume makes the main screen peakmeter draw on the remote! :-S
 Very odd! ahh well...
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 05, 2006, 12:49:45 PM
Right, this time I have the culprit...

In the statusbar code it changes the font to the user font if you have the numerical volume displayed! So straight after the call to the statusbar I have reset the font on the remote to the system font...et voila... it works...phew....
So changeable fonts are now working quite well...!

can I have that rest I was talking about earlier now? :-D

For the ready built version look at the last link I provided.... (post #23)



[attachment deleted by admin, too old]
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on February 05, 2006, 04:09:35 PM
Quote from: mlind
- It's showing (A) or (D) if the gain is changed in the Analog or Digital domain. From 0 to +24 it says (A), but from +24.5 it says (D). Could it be worth the space to have it say (A+D) - as I'm sure is the case.

And! I would like to have the settings for the peak meter duplicated in the recording settings screen.

Quote from: Mmmm
You are probably right about the peakmeter settings...I think it would be good here too.. but would we then have the same settings in two places?

Just thought I'd quickly mention here that the range on the remote, last time I checked (a few days ago), isn't actually accurate.  If you have a peakmeter range of say -30 to 0 set, while the main screen might be peaking at -30, it doesn't show on the remote until say -25.  I imagine its simply because the  remote screen is thinner.  So I guess what I'm saying is I won't be averse to having a 'remote peak meter settings' option.  But UI's never been my forte. :)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 05, 2006, 04:47:59 PM
Just thought I'd quickly mention here that the range on the remote, last time I checked (a few days ago), isn't actually accurate.  If you have a peakmeter range of say -30 to 0 set, while the main screen might be peaking at -30, it doesn't show on the remote until say -25.

Do not fret.... I have a fix for this.... I'm just trying to get the scale marks correct on the remote...
With my new independent peakmeter for the changeable fonts build, fixes like this are just so much easier to do. I'll merge the new peakmeter and fixed remote range into the main build tomorrow (if i get those dots sorted!) :-)
Title: Re: Recording Enhancements Pack
Post by: mlind on February 05, 2006, 06:08:53 PM
Quote from: mlind
- I can't use "browse .wps files" because the first wps in the list immediately gets chosen for use. So to use my own wps I must switch "Show files" to "All" go to .rockbox/wps/ with the normal browser instead.
Mine seems fine...no problems at all :-s

Reloaded my settings, but still the same behaviour

Quote from: mlind
And! I would like to have the settings for the peak meter duplicated in the recording settings screen.
You are probably right about the peakmeter settings...I think it would be good here too.. but would we then have the same settings in two places?

That was my thought... Or perhaps different settings for playback/recording peak meter...
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 06, 2006, 11:50:09 AM
Right then...an update...

I got the remote peakmeter working accurately now it starts and ends at the same points as the main unit (even though it's a different size) and the scale markings are now correct too...

New build in my sig and the link to the patch is in post #1

==============================================================================

For all you customisable font fans, there is a new working build in the link in post #23 and the patch is attached below.

The two patches are now almost identical.
The way it is now coded means that it is incredibly easy to change the font in the code on either of the displays! :-)

Maybe I could try to hardcode a font in for h1xx/h3xx.  But I would need to know which font you think is best! (I haven't tried to do this yet though so don't get too excited, it may not be possible! :-D )

[attachment deleted by admin, too old]
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on February 07, 2006, 03:54:30 AM
Mmmm: Thanks again for all your work.

I downloaded the build from post #23.  Am I correct in thinking that the recording screen font on the remote does not get updated, when the fonts/themes are changed?

Also, are the peakmeter changes checked in to that build?  It looks like the max range of the remote peak meter is less than the max range of the main unit.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 07, 2006, 08:25:47 AM
Mmmm: Thanks again for all your work.

I downloaded the build from post #23.  Am I correct in thinking that the recording screen font on the remote does not get updated, when the fonts/themes are changed?
Remote font doesn't change as any larger font wouldn't fit...It is totally filled up with the default font as it is...Clever eh? :-)
Quote
Also, are the peakmeter changes checked in to that build?  It looks like the max range of the remote peak meter is less than the max range of the main unit.
Should be.... I'll check when I get home though....
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 07, 2006, 12:35:03 PM
Also, are the peakmeter changes checked in to that build?  It looks like the max range of the remote peak meter is less than the max range of the main unit.
Oops...a bug crept in there!
Ta for reporting it...I've just managed to fix it... try it now.

All builds/patches in the usual places :-D

[attachment deleted by admin, too old]
Title: Re: Recording Enhancements Pack
Post by: Raptor on February 07, 2006, 02:25:03 PM
Mmmm,

Would you be able to compile the recfontsrockbox build with all the patches in your rockbox build?

Also, just throwing the idea out there... if you had the time, you should start compiling the H100 Optimized Daily Builds, just like what needleboy does in the misticriver forums.

Thanks for all your work.. the patches and the recording enhancements are amazing!
Title: Re: Recording Enhancements Pack
Post by: renho3k on February 07, 2006, 04:51:48 PM
rogain = hair rejuvenating forumula *wink*

i tried to patch your recordingenhancementspack.patch with daily build 02/07/06 and i got a HUNK #2 failed error. this is my first time patching. i put the patch file in the root of the source. did i do something wrong or is the patch not compatible w/build 20060207?

$ patch --binary -p0 < recordingenhancementspack.patch

patching file apps/menu.c
patching file apps/menu.h
patching file apps/settings.c
Hunk #4 succeeded at 516 with fuzz 2 (offset -22 lines).
patching file apps/settings.h
Hunk #1 succeeded at 216 (offset -1 lines).
Hunk #2 succeeded at 233 (offset -1 lines).
patching file apps/sound_menu.c
Hunk #1 succeeded at 51 (offset -1 lines).
Hunk #2 succeeded at 241 (offset -1 lines).
Hunk #3 succeeded at 255 (offset -1 lines).
Hunk #4 succeeded at 338 (offset -1 lines).
Hunk #5 succeeded at 782 (offset -2 lines).
Hunk #6 succeeded at 794 (offset -2 lines).
Hunk #7 succeeded at 804 (offset -2 lines).
patching file apps/gui/gwps-common.c
patching file apps/lang/english.lang
Hunk #2 FAILED at 3701.
1 out of 2 hunks FAILED -- saving rejects to file apps/lang/english.lang.rej
patching file apps/recorder/peakmeter.c
patching file apps/recorder/peakmeter.h
patching file apps/recorder/radio.c
patching file apps/recorder/recording.c
patching file firmware/sound.c
patching file firmware/drivers/uda1380.c
patching file firmware/export/audio.h
patching file firmware/export/sound.h
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 07, 2006, 04:58:30 PM
Don't worry the build you are trying to patch is too old! it's nothing you have done! You should use the bleeding edge build.
or you could have a look in the patch and at english. lang, you should be able to input the changes manually, english.lang is fairly easy! :-)
Title: Re: Recording Enhancements Pack
Post by: renho3k on February 07, 2006, 06:15:07 PM
wow. i posted at 04:51:48pm and got a reply by 4:58:30pm. now that's service with a smile!

k, now i got the bleeding edge built and successfully patched it (just the enhancement pack, not the font changing one). everything more or less fits in the remote now as compared to thomas's patch that i was using before. the clip light also works fine. however, question about functionality of the clip light. once it clips, it turns on (duh) and stays on. what determines when the clip light turns off? is it just timed?
Title: Re: Recording Enhancements Pack
Post by: mlind on February 07, 2006, 07:01:57 PM
When clip indicator in peak meter goes off the light goes off.
You adjust this time in the settings for peak meter.
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on February 07, 2006, 11:12:54 PM
When clip indicator in peak meter goes off the light goes off.
You adjust this time in the settings for peak meter.

When stealthing I set it to like 5 mins so that i just have a peek at the remote @ the end of particularly loud songs, and if the light ain't on, I'm laughing.

Something worth mentioning on the clipping indicator though...its not an exact tool...hence neither is the cliplight.  It is possible to clip without triggering the indicator.  The issues are at least twofold...but I'm running off memory here, which is unreliable at best.  I believe clipping needs to exist over two samples before its triggered (eg one loud clap won't trigger it).  Apparently it can also get false positives, and just not fire other times.  In other words, don't put complete faith in it.  Is that fair Mmmm?
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 08, 2006, 09:53:39 AM
Yep whataboutbob, that sounds about right!

In case you hadn't noticed the gain patch got committed today HOOORAHHH....... so the patch will now fail until I make a new and much shorter one...BOOOOOOO... ;-)

Better get my coding gloves back on again :-)

I get the feeling though that before The remote patch gets committed I'll have to submit a patch for general peakmeter support on the remote (for rWPS). and I haven't even looked at how the WPS code works at all....hmmmm..

We may be able to get the cliplight in first though, it should only take a small amount of tweaking to repair that patch!....Who knows...

I wouldn't hold your breath about changeable fonts though. That's going to take a lot more thinking about.....

Ahh well...one step at a time eh? :-)



Title: Re: Recording Enhancements Pack
Post by: whatboutbob on February 08, 2006, 04:06:06 PM
Congrats Mmmm & Petur!
Title: Re: Recording Enhancements Pack
Post by: renho3k on February 08, 2006, 04:22:26 PM
ahh, thx for clearing that up RE: clip light.

congrats Mmmm/petur/thomas & whoever else worked on this patch. one small step for patchers and one big step for rockbox recording! it's a good thing i just learned how to patch... ;)
Title: Re: Recording Enhancements Pack
Post by: keytotime on February 08, 2006, 04:32:35 PM
This is my favorite part of project like rockbox. They really do appreciate there user's. It's really great to have this patch commited.
Title: Re: Recording Enhancements Pack
Post by: AGI on February 09, 2006, 02:25:46 AM
congratulations Mmmm and Petur!
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 09, 2006, 12:57:05 PM
Ta for all the Congrats :-)
I hope everybody went and had a beer to celebrate! :-D
Lets hope we can get the rest committed...

I've updated the patch and the builds and put them all in post#1 (including changeable fonts patch and build)...
Title: Re: Recording Enhancements Pack
Post by: petur on February 10, 2006, 07:13:49 AM
Lets hope we can get the rest committed...

Lets see what we can do :)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 10, 2006, 11:22:49 AM
Another update...
The cliplight now also has the settings:

Off
Main unit only
Remote only
Remote and main unit

Just in case you have a hamster in your pocket and it doesn't like being woken up all the time by the annoying flashing of your clipping recorder!

You see...I think of everything :-D

Updates in post#1
Title: Re: Recording Enhancements Pack
Post by: LurkAzusa on February 10, 2006, 10:43:15 PM
You really do think of everything!  Thanks so much for keeping the build up to date for the H1XX.  Hopefully the rest of your enhancements will be committed soon.
Title: Re: Recording Enhancements Pack
Post by: Erithacus on February 13, 2006, 05:03:24 PM
A big thank you to Mmmm for his huge advances in the recording facilities.  I've been using the H140 to record birdsong, and his enhancements have taken the guesswork out of estimating volume and distance by ear. At this time of year most song is at dawn and dusk, so the ability to increase font size in poor light conditions has really helped.  The ability to switch from locked L/R gain to separate L and R using the joystick is ingenious too.

I'm puzzled though by the dots indicating scale for the peak meters. My range is set to -40 to 0 dB, scale is logarithmic, but the first five dots are equally spaced as are the last five dots (which are closer).  This means that they are not spaced logarithmically, so does that mean that they have no actual interpretation as dB?

Finally, I'd like to support the proposal in an earlier post to have the peak meter settings available from the recording settings menu. Optimal settings vary between bird species, and quick access would speed up adjustments before the bird flies off!

Please keep up the excellent work.
Title: Re: Recording Enhancements Pack
Post by: toolmanwill on February 13, 2006, 10:46:36 PM
Mmmmm, is it possible for you to make a new build with the newest build since the thump during playback has been fixed? (RE: after this commit - 13 Feb 16:55   Brandon   apps/pcmbuf.c 1.29     Don't boost from inside the DMA interrupt, ever )

 I would patch it myself but i cant seem to get the dev stuff to work right on my machine.
Title: Re: Recording Enhancements Pack
Post by: ericzang on February 14, 2006, 02:47:32 AM
I also second the request to make a new build with the "thumpless" version. Thanks!
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 14, 2006, 12:51:52 PM
I will make a new build but i'm on holiday at the mo so no dev environment to do building on I'm afraid  :(
But give it a few days and i'll be back... :) and I'll compile all the builds you want!  :D
Title: Re: Recording Enhancements Pack
Post by: toolmanwill on February 14, 2006, 02:55:32 PM
Great, Thanx!! BTW, how come your builds dont include the themes and wps folder contents? Is there problems when including these files with your patched build?
Just curious.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 15, 2006, 03:00:39 PM
No probs, it's just quicker when I'm testing as it takes ages unzipping all those bmp files, and seeing as it doesnt change very often (and I never use it at all) I didn't think it was that important! The build in my sig has them I think.... but no changeable font...would you like them in the changeable font version?
Title: Re: Recording Enhancements Pack
Post by: toolmanwill on February 15, 2006, 03:27:22 PM
you dont have to add it cause i can do that myself afterwards, i'd rather keep it easier for you.  ::)
Title: Re: Recording Enhancements Pack
Post by: Erithacus on February 15, 2006, 04:52:49 PM
No probs, it's just quicker when I'm testing as it takes ages unzipping all those bmp files, and seeing as it doesnt change very often (and I never use it at all) I didn't think it was that important! The build in my sig has them I think.... but no changeable font...would you like them in the changeable font version?

If I may make so bold - yes please!
Title: Re: Recording Enhancements Pack
Post by: petur on February 15, 2006, 05:38:06 PM
The cliplight now also has the settings:

Off
Main unit only
Remote only
Remote and main unit

You see...I think of everything :-D
hey thanks for the credits :P
Title: Re: Recording Enhancements Pack
Post by: petur on February 15, 2006, 05:51:25 PM
I think I found out why clip detection isn't always doing what it should: in the dma callback, only the last buffer gets checked for clipping :(

time for a fix, me thinks....
Title: Re: Recording Enhancements Pack
Post by: paulheu on February 16, 2006, 06:21:40 AM
I get an error when applying these patches, when I do the patch by hand (I use needleboys optimized H300 build) I get two errors, both in recording.c ..

the error is 'too few arguments to function 'lcd_remote_setmargins'

the line reads (in both cases):

lcd_remote_setmargins(global_settings.invert_cursor ? 0 : w_rc, 8);

as far as I can figure the function need three arguments and gets two, but then I am an extreme noob at c.. ;^)


EDIT: I took the LCD remote code out and it compiles fine then. I'll check it as soon as I get home.
Title: Re: Recording Enhancements Pack
Post by: paulheu on February 16, 2006, 09:46:40 AM
Also the patch works fine against the CVS.. so I guess I'll be talking to Needleboy ;)
Title: Re: Recording Enhancements Pack
Post by: petur on February 16, 2006, 10:32:26 AM
though I can understand the reasons behind the versions needleboy and Mmmm build, they are in the end a pain to support and maintain.

be patient, most stuff will make it into the official version somehow one day ;)
Title: Re: Recording Enhancements Pack
Post by: paulheu on February 16, 2006, 10:44:54 AM
Well the (needleboy) build I did without the remote LCD code works fine here, including the remote.. ;)

So I guess I am happy as-is..
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 16, 2006, 03:07:34 PM
hey thanks for the credits :P

Oh yeah....I forgot to metion that the new cliplight settings and in fact, the cliplight itself, were petur's idea!  But he never mentioned the hamsters! :D

But I did all the hard work!  :P
Heh Heh....  :)
Title: Re: Recording Enhancements Pack
Post by: larry_llama on February 17, 2006, 04:26:06 PM
This is awesome. The h1xx as the one-stop recording machine!

I have a suggestion about the peaklight... it's a great idea and I think it would be even cooler if you could choose for it to light up before the peak is reached.. at a level slightly below peak. Then it's more of a warning that a peak is imminent instead of "too late cause it already peaked"

I don't know if it's possible but it could be handy

Thanks again, I can't wait for my next concert to record!
Title: Re: Recording Enhancements Pack
Post by: petur on February 18, 2006, 04:07:24 AM
fyi, cliplight was committed last night  ;D
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 21, 2006, 09:45:36 AM
All new patches and builds in post #1 now up to date with latest CVS...
Title: Re: Recording Enhancements Pack
Post by: renho3k on February 22, 2006, 10:20:42 AM
hey Mmmm, in your build...whenever i click into the browse themes, it auto-selects the first theme and exits the theme menu. the workaround i use is to hold the up or down while it's entering that menu. not a major issue but not sure why it's doing that. only that menu too it seems. i can access the others fine.
Title: Re: Recording Enhancements Pack
Post by: mlind on February 22, 2006, 01:11:40 PM
hey Mmmm, in your build...whenever i click into the browse themes, it auto-selects the first theme and exits the theme menu. the workaround i use is to hold the up or down while it's entering that menu. not a major issue but not sure why it's doing that. only that menu too it seems. i can access the others fine.

That also happened me before (but with the WPS menu), but I noticed that things work as they should if you use <right> instead of <click>. Just a temporary workaround though.
Title: Re: Recording Enhancements Pack
Post by: dr.pheel on February 22, 2006, 02:51:14 PM
hi - somebody please help me on this:

I must be  missing something important here, cause I can't get my h120 to do what I think it should do... ???

do I understand correctly that if I set clipping light to "main unit only" I should see the light go on as soon as the input gets too high (clips)?

I tried using my external mic - gain high as hell and I clapped right into the mic - it clearly shows on my pc that the wavefile  is clipped...but there was no light on my iriver...

what am I doing wrong, or did I miss the whole thing here?
(honestly I have to admit that I didn't read through all  the posts here, so excuse me if it has all been explained before...and let me know where to look...)

thanks and greets-phil

(by the way I'm using Hmmm's 21.feb bulid)
Title: Re: Recording Enhancements Pack
Post by: simon142857 on February 22, 2006, 06:38:19 PM
Been lurking here for quite a while- thought I would finally dip into the discussion to most importantly offer thanks to Mmmm, Petur, and the entire Rockbox crew of Devs for this brilliant enhancement to my Iriver!
Yeah Baby!
I'm a live recording kook- from Gospel Churches to Rock concerts to Poetry readings. For a decade my MD and me were best buds!
Then I heard about Rockbox- got an Archos, and now the Iriver. These recording enhancements are a dream come true!

OK! Now with that in mind, I'm posting to echo Dr. Pheels dilemma. My h120 is also not responding to the clip light function. I'm using the latest build from Mmmm.
I read the mature, wise admonition from Petur to be patient- and that all this would settle out eventually in the CVS.

But I'm a BRAT!
cliplight cliplight cliplight!
 :'( Wah! :'(

 ::)
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on February 23, 2006, 12:22:07 AM
dr.pheel & simon142857:  I've not tested the backlight function in a while, but my post back a couple of pages may explain the issues you're having:

Something worth mentioning on the clipping indicator though...its not an exact tool...hence neither is the cliplight.  It is possible to clip without triggering the indicator.  The issues are at least twofold...but I'm running off memory here, which is unreliable at best.  I believe clipping needs to exist over two samples before its triggered (eg one loud clap won't trigger it).  Apparently it can also get false positives, and just not fire other times.  In other words, don't put complete faith in it.

So in short, a clap will not trigger the backlight, regardless of whether it clips.  Extended clipping will trigger the backlight...scream into the mics...see what happens. Warn your neighbours first maybe...you don't want cops turning up at your door wondering who's being murdered.  :)
Title: Re: Recording Enhancements Pack
Post by: ericzang on February 23, 2006, 01:41:01 AM
For the H300 series, is it ok to load the entire enhancements build, or is it necessary to load the general H300 build then patch it with the enhancement patch? Thanks.
Title: Re: Recording Enhancements Pack
Post by: petur on February 23, 2006, 02:39:26 AM
not all samples are being checked for clipping, which most probably causes this. I know where exactly in the code this is, just need some time to do it and also test how this affects performance...
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 23, 2006, 07:08:14 AM
hey Mmmm, in your build...whenever i click into the browse themes, it auto-selects the first theme and exits the theme menu. the workaround i use is to hold the up or down while it's entering that menu. not a major issue but not sure why it's doing that. only that menu too it seems. i can access the others fine.

That also happened me before (but with the WPS menu), but I noticed that things work as they should if you use <right> instead of <click>. Just a temporary workaround though.
Ahhh right mlind, if that is the case then I would say that it is something to do with the joyclick patch! I always use 'right' to select, this is why I couldn't reproduce the bug!  :D (this is assuming that you and  renho3k are both using the build in my sig and not the changeable fonts version).

There should be a check to make sure that that particular function only  works in the filebrowser...I'll see what I can do!

Quote from: ericzang
For the H300 series, is it ok to load the entire enhancements build, or is it necessary to load the general H300 build then patch it with the enhancement patch? Thanks.
Neither build will work on the h3xx but the patches will work fine!
I did do a build for h3xx which I havent updated for a while, but it will still work HERE IT IS (http://homepage.ntlworld.com/martin.scarratt/H3xxrockbox.zip)

Quote from: simon142857 & drpheel
My h120 is not responding to the clip light function.
What petur and whataboutbob said.

....and I have also noticed Petur, that the version you have committed only works while the unit is actually recording, whereas mine worked at all times in the recording screen!
It is the fix you made so that it compiled for all units. Your condition checks for recording whereas mine just checked that no file was being played (and so disabled the function in the WPS!)
Title: Re: Recording Enhancements Pack
Post by: Metrophage on February 23, 2006, 09:04:28 AM
Any chance that one of you folks might be so kind as to send to me a zipped copy of a working bootloader for this? I have spent hours looking for the "normal" Linux patching tools for my mac but not gotten it working yet. No windoze box here so as of yet no Rockbox for me. I will still try to collect the proper tools and wrap them into a patching application for other mac users, but this will likely take me a little while.

I bought my h120 recently because of its codec support and recording capabilities. This version from Mmmm addresses most of my wants, so I am really looking forward to this. I am trying to make some basic microphones from Panasonic electret capsules for recording various ambient location sounds - something I have always wanted to do.

Thanks much!
CJ
Title: Re: Recording Enhancements Pack
Post by: petur on February 23, 2006, 10:06:59 AM
....and I have also noticed Petur, that the version you have committed only works while the unit is actually recording, whereas mine worked at all times in the recording screen!
It is the fix you made so that it compiled for all units. Your condition checks for recording whereas mine just checked that no file was being played (and so disabled the function in the WPS!)
I know.
When changing, I thought about this for some time, and couldn't come up with a reason to have this on unless you're actually recording...

Tell me what the reason is and I'll change it ;)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 23, 2006, 10:13:01 AM
....and I have also noticed Petur, that the version you have committed only works while the unit is actually recording, whereas mine worked at all times in the recording screen!
It is the fix you made so that it compiled for all units. Your condition checks for recording whereas mine just checked that no file was being played (and so disabled the function in the WPS!)
I know.
When changing, I thought about this for some time, and couldn't come up with a reason to have this on unless you're actually recording...

Tell me what the reason is and I'll change it ;)
You're in a dark room waiting for a concert to start.....you've got your recorder alll ready to go but, as yet, you are not really sure whether your levels are right.... before the gig begins, there is a quick warmup by the band It's too dark to see whether its clipping or not and you don't want to start recording until they start the set properly.. cor, you think...a cliplight would be really handy now!  :D
Title: Re: Recording Enhancements Pack
Post by: paulheu on February 23, 2006, 10:40:48 AM
Here's another one:

I use my iRiver to record live from the board, I do not want the display on all the time..

If I get a bit too enthusiastic while setting up :) I will see the LCD flash if the level gets too hot..

VERY USEFUL INDEED
Title: Re: Recording Enhancements Pack
Post by: mlind on February 23, 2006, 11:12:54 AM
Tell me what the reason is and I'll change it ;)

–Because!!   ;)
Title: Re: Recording Enhancements Pack
Post by: petur on February 23, 2006, 11:21:58 AM
3 against 1, I surrender :D
Title: Re: Recording Enhancements Pack
Post by: AGI on February 23, 2006, 11:55:05 AM
4 against 1 ;)
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on February 23, 2006, 04:17:05 PM
5 against 1...now we're just ganging up on him. :)
Title: Re: Recording Enhancements Pack
Post by: renho3k on February 23, 2006, 04:40:36 PM
7 vs 1...
(gerbil in sleeping in my pocket woke up just to vote in this poll too)
Title: Re: Recording Enhancements Pack
Post by: petur on February 24, 2006, 04:30:24 AM
all right all right... code changed and partially tested, will commit tonight if possibe (that is: if I get the time and test the other platforms)

then I'll fix the peakmeter missing clipped samples as well, ok?
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on February 24, 2006, 09:51:57 AM
Thanks Petur. :)
Title: Re: Recording Enhancements Pack
Post by: petur on February 24, 2006, 03:35:56 PM
latest builds now have cliplight when only monitoring...
Title: Re: Recording Enhancements Pack
Post by: petur on February 24, 2006, 04:50:56 PM
dr.pheel & simon142857:  I've not tested the backlight function in a while, but my post back a couple of pages may explain the issues you're having:

Something worth mentioning on the clipping indicator though...its not an exact tool...hence neither is the cliplight.  It is possible to clip without triggering the indicator.  The issues are at least twofold...but I'm running off memory here, which is unreliable at best.  I believe clipping needs to exist over two samples before its triggered (eg one loud clap won't trigger it).  Apparently it can also get false positives, and just not fire other times.  In other words, don't put complete faith in it.

So in short, a clap will not trigger the backlight, regardless of whether it clips.  Extended clipping will trigger the backlight...scream into the mics...see what happens. Warn your neighbours first maybe...you don't want cops turning up at your door wondering who's being murdered.  :)

it's worse than I thought: not only is only the first recorded chunk checked for peaks (skipping many recorded chunks every time), it also only checks every third sample in that chunk....

however, first tries to fix this have shown a performance problem, so it will required a bit of optimization to get it perfect.
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on February 24, 2006, 06:48:07 PM
Good to see it in CVS petur.  Will test it out this afternoon.

What sort of 'performance problem' are you referring to?  Just battery drain, or something riskier?

Don't spose you feel like tackling optical recording?  I'm hanging out for it, along with quite a few others, but it doesn't seem like any of the devs want a bar of it. :)
Title: Re: Recording Enhancements Pack
Post by: westkc3 on February 24, 2006, 07:10:57 PM
I've downloaded the 2/22/06 build but can't see the clip light setting option in recording settings.  I verified the cvs is 2/22/06 so the files were extrated ok.  Is there something more I need to do?
Title: Re: Recording Enhancements Pack
Post by: petur on February 25, 2006, 02:50:19 AM
I've downloaded the 2/22/06 build but can't see the clip light setting option in recording settings.  I verified the cvs is 2/22/06 so the files were extrated ok.  Is there something more I need to do?
Very strange... it should be there  ???
Title: Re: Recording Enhancements Pack
Post by: petur on February 25, 2006, 02:56:02 AM
What sort of 'performance problem' are you referring to?  Just battery drain, or something riskier?
Doing the peak metering on all samples and then loop them all again for sample conversion proved to be too much activity to handle. So I combined both functions, which *seems* to work ok.

Would like to get feedback if everything is working ok. Make sure to use the latest bleeding edge build as this was only committed last night.

Don't spose you feel like tackling optical recording?  I'm hanging out for it, along with quite a few others, but it doesn't seem like any of the devs want a bar of it. :)

I'm a h340 user, so I don't have any means to test. I also don't have any use for it, and do have uses for other features I want (but not on recording front), so this feature will wait for an h1xx developer to implement. Sorry.
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on February 25, 2006, 08:49:30 AM
Petur: Sorry to report that using the bleeding edge build I can still clip without triggering the backlight...both with short bursts (eg clapping) or more prolonged clipping (~5 seconds). I'm sure there's a method to the madness but it seems completely random as to whether or not the backlight's triggered. Lemme know if you have any q's.
Title: Re: Recording Enhancements Pack
Post by: petur on February 25, 2006, 10:26:10 AM
Petur: Sorry to report that using the bleeding edge build I can still clip without triggering the backlight...both with short bursts (eg clapping) or more prolonged clipping (~5 seconds). I'm sure there's a method to the madness but it seems completely random as to whether or not the backlight's triggered. Lemme know if you have any q's.
just a quick check: was the harddisk spinning as you tested this? because it won't do anything while writing to disk.

I'll try to dive into the code again...  somebody donate me some time ;)
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on February 25, 2006, 07:07:39 PM
just a quick check: was the harddisk spinning as you tested this? because it won't do anything while writing to disk.

I'll try to dive into the code again...  somebody donate me some time ;)

The hdd was spinning on some of the occassions, but not all.
Title: Re: Recording Enhancements Pack
Post by: petur on February 26, 2006, 06:27:14 PM
Can you try the latest bleeding edge, I think I found the reason and committed the fix. If you're reading this within 1 hour of this writing, wait a bit to make sure the bleeding edge build is done before downloading.

If you build your version yourself, cvs is up to date...

Let me know the results
Title: Re: Recording Enhancements Pack
Post by: vinylivo on February 27, 2006, 12:04:46 AM
Hi petur!

Your changes in pcm_record work like a charm. Now it really detects any single clip, at least on the build I'm running now (base is 060214 with rec enhancement patch and modifications by me).
I'm writing an AGC (automatic gain control) at the moment. It's mostly finished and just needs some more tests until I'll provide a patch. Now the AGC works even better with the new version of pcm_record, much more accurate leveling. Thanks alot!
Title: Re: Recording Enhancements Pack
Post by: fizze on February 27, 2006, 02:57:15 AM
petur, you are a H340 user ?

Shouldnt that enhacements pack work on a H300 too, after slight tweaking ? *scratches head*
Title: Re: Recording Enhancements Pack
Post by: petur on February 27, 2006, 03:33:42 AM
petur, you are a H340 user ?

Shouldnt that enhacements pack work on a H300 too, after slight tweaking ? *scratches head*

Yes, I only have a H340.
The builds for H1xx and H3xx are not compatible, so that won't work...
Title: Re: Recording Enhancements Pack
Post by: petur on February 27, 2006, 03:34:44 AM
Your changes in pcm_record work like a charm. Now it really detects any single clip, at least on the build I'm running now (base is 060214 with rec enhancement patch and modifications by me).
I'm writing an AGC (automatic gain control) at the moment. It's mostly finished and just needs some more tests until I'll provide a patch. Now the AGC works even better with the new version of pcm_record, much more accurate leveling. Thanks alot!

glad I nailed that bug :)
looking forward to your patch!
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 27, 2006, 10:03:56 AM
petur, you are a H340 user ?

Shouldnt that enhacements pack work on a H300 too, after slight tweaking ? *scratches head*

Yes, I only have a H340.
The builds for H1xx and H3xx are not compatible, so that won't work...

But the patch will work for the h3xx!
Title: Re: Recording Enhancements Pack
Post by: petur on February 27, 2006, 10:21:25 AM
as you've probably read, I managed to break pre-recording... will try to fix it asap. Sorry!
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 27, 2006, 01:34:20 PM
as you've probably read, I managed to break pre-recording... will try to fix it asap. Sorry!

Heh heh.... Never mind...worse things happen at sea!  :D
Title: Re: Recording Enhancements Pack
Post by: petur on February 27, 2006, 02:39:44 PM
fixed, I think...
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on February 28, 2006, 06:43:02 AM
Pre-recording seems to be back in working order now.

The clip meter is far more sensitive...great work Petur!

The only bugger is that the meter doesn't operate during hdd writes (as you 've mentioned previously...i figure this equates to about 10% of the time, but i imagine there's nothing that can be done about that.

Also, I'm not sure if this will make any sense, but I suspect that it only checks one 'side' of each channel for clipping....do you know if this is the case?

If you're looking at the left channel of a stereo wav for example, it seems only clipping on the top of the wav triggers the backlight, while clipping on the bottom of the wav slips through.  Not a major issue...I'm just curious.

I hope I don't sound ungrateful with all of this feedback...the hxxx is a lean, mean recording machine thanks largely to the efforts of the developers involved in this thread.  But seeing as I can't code for peanuts I see the only constructive efforts I can make towards rockbox is as a tester.  Lemme know if I'm just being annoying. :)
Title: Re: Recording Enhancements Pack
Post by: petur on February 28, 2006, 06:56:27 AM
Also, I'm not sure if this will make any sense, but I suspect that it only checks one 'side' of each channel for clipping....do you know if this is the case?

It shouldn't. The peak search loop compares the current peak value with the sample and its negative version and keeps whatever is biggest.

Got any suspicion this isn't working ok?
Title: Re: Recording Enhancements Pack
Post by: vinylivo on February 28, 2006, 09:26:11 AM
Hi Mmmm!

I added automatic gain control and histogram view to your enhancement pack. The patch is available at the patch tracker: http://www.rockbox.org/bugs/task/4748
Title: Re: Recording Enhancements Pack
Post by: kuuan on March 01, 2006, 12:43:59 AM
does this enhancement pack only work for the H100 or for the H300 series as well?
Title: Re: Recording Enhancements Pack
Post by: Dick on March 01, 2006, 02:59:02 AM
asked and answered 2 days ago (http://forums.rockbox.org/index.php?topic=2513.msg19745#msg19745)
Title: Re: Recording Enhancements Pack
Post by: kuuan on March 01, 2006, 04:47:31 AM
...answered 2 days ago (http://forums.rockbox.org/index.php?topic=2513.msg19745#msg19745)
sorry, had read the first 4 pages and skipped the end when I decided to ask.
I hope I understand right that Mmmm's last comment saying
Quote
But the patch will work for the h3xx!
means a 'yes' to my question.
( sorry, I am not even sure, - my limited understanding of English/technical terms. I am about to get an iH, recording is my main purpose, would prefer the H320, but would opt for the H120 instead if it's Rockboxed recording features are superior )
Title: Re: Recording Enhancements Pack
Post by: petur on March 01, 2006, 08:46:04 AM
The following was actually written by Mmmm:

I have changed post#1 so that it is a little more obvious which targets the patches/builds work for.

Quote from: vinylivo
Hi Mmmm!

I added automatic gain control and histogram view to your enhancement pack. The patch is available at the patch tracker: http://www.rockbox.org/bugs/task/4748
Sounds good, although I haven't tried it yet.   :)

If you want it committed I think you'll have to make sure that the settings are saved, (by using settings.c) and it would make more sense if the option was in the recording menu I think, (soundmenu.c) ... Also you'll have to make sure any words for options etc are used from the language files so that a translation can be done, (english.lang).

After all that and when you know that it doesn't break any other target builds you have to be really nice to petur because he has cvs access! (I think you'll find a few beers may do the trick!  :D)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 01, 2006, 10:13:13 AM
WOW....what happened there.... Petur it looks like I modified your post by mistake...sorry...weird...I didn't know I could do that!  ???


Damn....and I cant reamember what you said either!

Oh...I remember, Petur said: The h140 and h320/40 have the same audio chip, so they are capable of recording in exactly the same way. The only difference is that the h140 has an optical input (which isn't yet supported by rockbox).

Sorry about that again Petur!
Title: Re: Recording Enhancements Pack
Post by: petur on March 01, 2006, 12:08:35 PM
WOW....what happened there.... Petur it looks like I modified your post by mistake...sorry...weird...I didn't know I could do that!  ???
Maybe they made you mod without telling you ;) Do you have the modify button next to all posts?

Nice tip about buying beer for me :D I should make a note that I'm from Belgium so my standards are pretty high :P
Title: Re: Recording Enhancements Pack
Post by: toolmanwill on March 01, 2006, 01:10:11 PM
heh, you definitely dont want the crap american domestic we got here.   :'(
Altho i'm 5 minutes from canada and they brew some good beer!
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 01, 2006, 01:47:00 PM
WOW....what happened there.... Petur it looks like I modified your post by mistake...sorry...weird...I didn't know I could do that!  ???
Maybe they made you mod without telling you ;) Do you have the modify button next to all posts?
Yep I could get up to all kinds of mischief couldn't I? :D

Ahh..I see, Its only on threads that I have started!
Quote
Nice tip about buying beer for me :D I should make a note that I'm from Belgium so my standards are pretty high :P

Heh heh...I wish I had cvs access so I could get free beer too!  ;)
Title: Re: Recording Enhancements Pack
Post by: larry_llama on March 01, 2006, 04:40:18 PM
heh, you definitely dont want the crap american domestic we got here.   :'(
Altho i'm 5 minutes from canada and they brew some good beer!

I'm zero minutes from Canada, and you're right!

To the devs in this thread: Thanks so much for bringing out the best in this little piece of hardware that the uninformed simply call "an mp3 player". All of us recording nuts appreciate it!
Title: Re: Recording Enhancements Pack
Post by: kuuan on March 01, 2006, 09:33:41 PM
more dumb questions from the uninitiated:





Title: Re: Recording Enhancements Pack
Post by: Llorean on March 01, 2006, 09:35:37 PM
Yes, the enhancement pack just enhance's *rockbox's* recording features.

This does mean that whenever Rockbox does support recording on iFP players (still a long time off probably) that it will affect them too in most probability.
Title: Re: Recording Enhancements Pack
Post by: vinylivo on March 02, 2006, 05:40:06 PM
@ Mmmm:
Yeah I know about localization (language support) and menus and everything. I just have to code it and this takes some time (as you know), and of course I'll do it because I'm interested too that more people can profit from the work...

About the beer, my home is little switzerland. So there are some special ones too but I don't believe they're a concurrence to the belgium stuff (I just recently was there so I know :-)
Title: Re: Recording Enhancements Pack
Post by: petur on March 03, 2006, 03:35:35 AM
About the beer, my home is little switzerland. So there are some special ones too but I don't believe they're a concurrence to the belgium stuff (I just recently was there so I know :-)
If you live near a ski-area, I'm sure we could arrange something else :D :D
Title: Re: Recording Enhancements Pack
Post by: dr.pheel on March 03, 2006, 05:46:53 PM
hi

I am using the  Mmmm build (downloaded 22nd feb) - sorry to say I just noticed that i  having serious troubles with recording. I get these real bad clicks in my recording from time to time, no idea what is going on there, sounds like digital dirt though...
anybody else have any troubles? is that a know bug that has been fixed, or is my iriver going bad ????

greetz phil
Title: Re: Recording Enhancements Pack
Post by: petur on March 04, 2006, 04:48:06 AM
Are you using it in combination with voice menus? An issue with that was recently reported...

If not: any more details? How to reproduce, gain settings, a part of the file to look at perhaps?
Title: Re: Recording Enhancements Pack
Post by: dr.pheel on March 04, 2006, 05:49:43 AM
hi,

as far as I remember I had the rec volume quite high (somewhere round 27db) - it seems to happen rather at the beginning of a file (about 20-30 sec into the file - noising for bout 1min), but then stops and doesn't happen again til the end (whole file about 7min long)
I recorded with an external mic (sonyecm-ms907)
I had that problem at least three times (and I'm quite sure it had aslo happened with an earlier Mmmm build) - I did also have a few files without that problem too.

no voice menues, the only thing I could mention that I had used the metronome before recording...maybe that's really the problem, as I think about it now...

(I used to do recordings without problems befor the rec enhancement pack)

how do I attach a file that is larger (I tried attaching a 700kb mp3 file, but it was obviously too large...)? - now I tried shorter mp3 files, but it tells me mp3 is not alowed??? how can I attach a sample??

hope those details will do...thanks a lot for trying to help!

greetz phil
Title: Re: Recording Enhancements Pack
Post by: pabouk on March 04, 2006, 06:18:12 AM
how do I attach a file that is larger (I tried attaching a 700kb mp3 file, but it was obviously too large...)? - now I tried shorter mp3 files, but it tells me mp3 is not alowed??? how can I attach a sample??

This forum has a stupid limitation. You have to rename the file for example to *.txt.
Title: Re: Recording Enhancements Pack
Post by: dr.pheel on March 04, 2006, 06:27:06 AM
ok

so here are two mp3 samples of the noise i had on my recording.


[attachment deleted by admin]

[attachment deleted by admin, too old]
Title: Re: Recording Enhancements Pack
Post by: dr.pheel on March 04, 2006, 06:30:30 AM
well...that didn't work, didi it? if i download the .txt files and rename them to mp3 - they are broken...

Title: Re: Recording Enhancements Pack
Post by: larry_llama on March 04, 2006, 09:44:09 AM
well...that didn't work, didi it? if i download the .txt files and rename them to mp3 - they are broken...



Try re-uploading them as "doc" files instead of txt.
Title: Re: Recording Enhancements Pack
Post by: petur on March 04, 2006, 11:11:20 AM
as far as I remember I had the rec volume quite high (somewhere round 27db) - it seems to happen rather at the beginning of a file (about 20-30 sec into the file - noising for bout 1min), but then stops and doesn't happen again til the end (whole file about 7min long)
hmmmm... I just remember I recently broke pre-recording, this happened around the time you described in your original post. The effect was that it would do the endian conversion twice during prerecording, making it sound as noise. I fixed my error 27 feb in the evening. I'm not sure if it causes noise at the end as well.

So: do you have pre-recording on, and could you try with a recent official build - not the enhanced recording pack?
Title: Re: Recording Enhancements Pack
Post by: dr.pheel on March 04, 2006, 11:15:26 AM
I'll try what you just posted, here a nother try on the files...
might have had pre recording on...
so the official build contains all teh new rec features now?

greetz phil






[attachment deleted by admin]

[attachment deleted by admin, too old]
Title: Re: Recording Enhancements Pack
Post by: petur on March 04, 2006, 01:40:56 PM
so the official build contains all teh new rec features now?
I don't know what the rec features of Mmmm are, but the official build has
And I'm going to use it tonight to record a show...
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 04, 2006, 05:48:33 PM
The build in post#1 now only has remote support and changeable fonts as extras. If you look at vinylivo's patch he has also put in automatic gain control and histograms and some other things...

In the original Iriver firmware there was a ticking sound when you recorded with the remote plugged in... drpheel, is this what you are hearing? I can hear it with remote support and high gain levels.
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on March 04, 2006, 07:02:40 PM
Mmmm: That's not it.

dr.pheel: Just for giggles, try resetting your config settings, and see if you can replicate the issue.  If that fixes it, kick off the metronome and test again.

Are you sure its not your mics? (just have to cross it off the list of possibilities)
Title: Re: Recording Enhancements Pack
Post by: dr.pheel on March 05, 2006, 05:32:51 AM
ok,

I am running yesterday's build now, and seem to be having no problems so far.

Mmmm:
it definitly had nothing to do with the remote cause I never use it. I also tried with using the metronome before recording again, and there was no ticking sounds so far...

whatboutbob:
it definitly didn't sound like anything with my mic was wrong.

it must have been some bug in that build I was using (and I think it must have been something about using the metronome before recording)

I'll let you guys know if there are any further problems.

thank you all - phil
Title: Re: Recording Enhancements Pack
Post by: toolmanwill on March 05, 2006, 12:39:47 PM
is it possible for someone to patch Mmmm's latest build with vinyl's patch for me as i cant get the utilities to work on my PC.
Thanx in advance to the kind soul!
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 05, 2006, 02:40:48 PM
Just in case anyone is thinking I've stopped working on this, I thought I would set your minds at rest..

I have finally, with much gnashing of teeth and pulling of hair, managed to work out how the gui system works and have managed to implement the WPS peakmeter into the remote....Hooorraaaaaaaaaaaaaaaaahhhh.... :o

Now that I have managed this, the rest (implementing the recording screen on the remote) is the easy part!

So sometime this week (hopefully), I should have a commitable patch for remote support for the recording screen... ooh..it's so exciting.....   :D

I think I'll take the rest of the night off.... cool beers in the fridge!  ;) ...Cheers!....
Title: Re: Recording Enhancements Pack
Post by: vinylivo on March 05, 2006, 11:30:01 PM
I just updated the AGC patch: http://forums.rockbox.org/index.php?topic=2841.msg20404#msg20404
Title: Re: Recording Enhancements Pack
Post by: paulheu on March 06, 2006, 06:08:23 AM
I have finally, with much gnashing of teeth and pulling of hair, managed to work out how the gui system works and have managed to implement the WPS peakmeter into the remote....Hooorraaaaaaaaaaaaaaaaahhhh.... :o
But.. but I have had the recording screen on my remote from the start..
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 06, 2006, 06:53:46 AM
I have finally, with much gnashing of teeth and pulling of hair, managed to work out how the gui system works and have managed to implement the WPS peakmeter into the remote....Hooorraaaaaaaaaaaaaaaaahhhh.... :o
But.. but I have had the recording screen on my remote from the start..

You mean with the patch in post#1 right?
The recording screen isn't implemented on the remote with the normal build yet!

What I meant is...
The patches in post#1 are hacks that won't ever get implemented into CVS, so you will always need to use a special build or a patch to record from the remote screen. They work fine but they don't mesh with the rest of the rockbox code very well (meaning that a peakmeter for the recording screen is all very nice but what if you want to use it in the rwps or for the radio? You just can't get it to work with my code...well, not without a total rewrite and downgrading of the current WPS code anyway..... So therefore not an acceptable solution).

I am working on a version that will work for any target, (without using any preprocessing(#if/#ifdef)) and blends in with the already present methods of using the display...much harder to do but I'm nearly there now!

It will be more flexible, robust and just generally easier to maintain/alter. Of course any non programmers won't notice the difference, it's just that more will be possible with the new code! It is so flexible that even if a player is introduced that has 3 screens it would automatically support the 3rd screen no matter what size it is! Without changing any code at all!!!!! [/advert]  :D

When I've finished, with a bit of luck someone will decide to commit it so that you no longer need a patch! (I get the feeling this will be the most difficult bit!)

I hope that explains what I'm up to a bit more clearly!  :)

When I do get it finished i'll post the patch/build here and it would really great it if everyone could test it, (if it works properly you should notice no difference whatsoever (apart from %pm working in rWPS). Then I can fine tune it just like I did with the hack patch to get it really perfect.
Title: Re: Recording Enhancements Pack
Post by: petur on March 06, 2006, 08:34:10 AM
When I've finished, with a bit of luck someone will decide to commit it so that you no longer need a patch! (I get the feeling this will be the most difficult bit!)
Nice to see you're writing code that is committable :P
 
The problem is I don't have a remote (actually the bigger problem I don't have time), so this will be hard for me to test before commit - I may have to trust you :P :P
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 06, 2006, 09:42:10 AM
Damn...there I go modifying your posts again.... :D
I think I put it all back in place....
Quote
When I've finished, with a bit of luck someone will decide to commit it so that you no longer need a patch! (I get the feeling this will be the most difficult bit!)
Nice to see you're writing code that is committable :P
:P
Quote
The problem is I don't have a remote (actually the bigger problem I don't have time), so this will be hard for me to test before commit - I may have to trust you :P :P
I promise I will test till I'm blue in the face..... :D
should I compile and test for all targets or are there just a select few that will do the trick?
Title: Re: Recording Enhancements Pack
Post by: petur on March 06, 2006, 01:48:54 PM
should I compile and test for all targets or are there just a select few that will do the trick?
depends on the changes, I always build for all targets to be sure... Now with the crosscompilers available it's quite easy to check...
Most important is that it works on the possibly used remotes (h1xx, h3xx,...)
Title: Re: Recording Enhancements Pack
Post by: vinylivo on March 07, 2006, 06:27:42 AM
Not shure if this is related to the enhancement pack or not.

There is a problem with automatic file splitting during recording if it should split at max. file size (max. 2GB FAT file size - 1MB). Yesterday I recorded a Jazz concert and this was the first time I didn't set auto time split and I really regret it now because the last quarter hour is missing.  :(
The recorded file is actually 2'147'475'500 bytes (3h22m) and this is 2047.992MB and NOT 2047MB as it should be. Really very very close to the FAT limit (only 8148 bytes left).
The bad thing is after this the jukebox didn't continue to record but shut down! There is a following file but the file size is ZERO. And I tried Scandisk and PC-Filerecovery and there is no lost data!  >:(

Pre-recording was set to 20s. And I made the observation that if pre-recording is on not all the prerecorded bytes are counted for the file size display. You see this clearly if e.g. at 1min the file size is not 10MB as it should be.

I really have to find out what exactly happened here, I never want this again! And perhaps we should set the limits for max file size less critical, e.g. leaving 10 to 30MB left instead of just 1MB. This would be more save. Aaaah I really hate that I didn't restart the recording during the concert pause! But sometimes bad things happen...


Otherwise I tested my AGC implementation for the 'Live Limiter' preset and this worked fine. Good levels for the recording, some very occasional clips during fortissimo parts but that's no problem. The performance was very dynamic, sometimes more than 40dB from quiet to loud parts.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 07, 2006, 10:36:33 AM
Quote from: Mmmm
Now that I have managed this, the rest (implementing the recording screen on the remote) is the easy part!
Did I really say that???

I take it back!  :D

Might take a bit longer than I thought!... ::)

Got it all coded but doesn't quite work as it should...hmmmm
I'll keep plugging away at it....
Title: Re: Recording Enhancements Pack
Post by: vinylivo on March 07, 2006, 07:24:03 PM
Not shure if this is related to the enhancement pack or not.

There is a problem with automatic file splitting during recording if it should split at max. file size (max. 2GB FAT file size - 1MB).

I found the bug. It's not related to the enhancement pack at all. The bug is in 'pcm_recrd.c' in function 'pcmrec_start()':

Line 644 is wrong:
Code: [Select]
    num_rec_bytes = 0;

it should be:
Code: [Select]
    num_rec_bytes = pre_chunks * CHUNK_SIZE;
to take the prerecorded chunks into account.
Title: Re: Recording Enhancements Pack
Post by: petur on March 08, 2006, 04:45:04 AM
I found the bug. It's not related to the enhancement pack at all. The bug is in 'pcm_recrd.c' in function 'pcmrec_start()':

Line 644 is wrong:
Code: [Select]
    num_rec_bytes = 0;

it should be:
Code: [Select]
    num_rec_bytes = pre_chunks * CHUNK_SIZE;
to take the prerecorded chunks into account.
That will be my bug then, as I did the prerecording :(

thanks for finding that one!
Title: Re: Recording Enhancements Pack
Post by: NPswimdude500 on March 08, 2006, 02:57:06 PM
I haven't read all of this thread, so this might have been suggested already, but since there's space, would it be possible to include the name of the recorded file in the recording screen?

(http://homepage.sunrise.ch/mysunrise/remartinelli/assets/images/rb-rec02.jpg)
^since there's room, how 'bout a line that says something like "Name: rec_0001.wav" ?
Title: Re: Recording Enhancements Pack
Post by: petur on March 08, 2006, 04:25:10 PM
Not shure if this is related to the enhancement pack or not.

There is a problem with automatic file splitting during recording if it should split at max. file size (max. 2GB FAT file size - 1MB).

I found the bug. It's not related to the enhancement pack at all. The bug is in 'pcm_recrd.c' in function 'pcmrec_start()':

Line 644 is wrong:
Code: [Select]
    num_rec_bytes = 0;

it should be:
Code: [Select]
    num_rec_bytes = pre_chunks * CHUNK_SIZE;
to take the prerecorded chunks into account.

Right. I wrote a long answer on this and reviewed the code while writing. As a result I got logged out before posting and my answer is lost. Damn.

To keep the long answer short: the bug is that num_rec_bytes is used in the recording screen (imho the wrong place) to determine file splitting.

I'll keep it like that for now as it involves too much rewriting... your bugfix should do.

I'll also increase the margin while I'm at it ;)

edit: I think I messed this one up as well when trying to increase peak detection sensitivity...

edit2: margin is fine I think, so I'll leave it like that
Title: Re: Recording Enhancements Pack
Post by: vinylivo on March 09, 2006, 07:25:01 PM
Thanks for comitting fix, other users will be even more thankful than me because I can always use a patch otherwise.

I don't know what you mean by 'the bug is that num_rec_bytes is used in the recording screen (imho the wrong place)...' because in my thinking this variable should reflect the number of recorded bytes. And the prerecorded bytes are a part of it in the event of starting an actual recording.
I agree there could be other ways of determining file splitting, perhaps by a get_file_size function or something similar.
Title: Re: Recording Enhancements Pack
Post by: petur on March 10, 2006, 05:17:47 AM
I don't know what you mean by 'the bug is that num_rec_bytes is used in the recording screen (imho the wrong place)...' because in my thinking this variable should reflect the number of recorded bytes.
Well, there is also a variable that holds the number of bytes written to file, and somehow I feel that variable (and location) is more suited for file splitting. Now the gui thread decides this...
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 10, 2006, 02:48:19 PM
By jove...you know what? I think I've done it!!!..........

Although, I am very excited, and when I'm excited I say things that I regret later because I then find that I haven't done it at all!!  :D

I also talk a lot of rubbish!
 :D

I must now eat, then I'll look again to check whether I really have done it and do a spot of tidying up and re-naming of strange variables. Then I'll put a patch up that you can all test and tell me of any problems you find.

And Petur, I'll start the long process of compiling for all those targets  ;)
Title: Re: Recording Enhancements Pack
Post by: groovetube66 on March 10, 2006, 03:21:40 PM
Hi all.  Just got my ihp-120 and have been following these threads about recording for a while.  Got a couple of questions:


This Rockbox and iRiver is cool stuff.  If someone ever writes the code for multitrack recording with sync it will be even more amazing.
Title: Re: Recording Enhancements Pack
Post by: NPswimdude500 on March 10, 2006, 03:30:36 PM
Is there a build that contains the Recording Enhancements with the multiple AGC settings and peak metering?

There most certainly is!
http://homepage.sunrise.ch/mysunrise/remartinelli/html/rockbox.html

pilot000 from Misticriver compiles an "optimized" version of the bleeding edge builds. It's more of an experimental build, but it includes that patch as well as a few other neat todbits....
(discussion on MR: http://www.misticriver.net/showthread.php?t=36943)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 10, 2006, 05:55:23 PM
Ok then.... It appears that I really have done it! I wasn't dreaming.

So here is the (hopefully) CVS commitable version of the remote support patch.

It would be fantastic if some people could test it and tell me if they notice anything odd or give any other comments. (whataboutbob how about it? ;))

The peakmeter is enabled in the rWPS now too (just type %pm in your chosen position)

I haven't made any pre-compiled builds yet for you non-patchers to try and I won't replace the patches in post#1 yet either... not until I'm convinced nothing is amiss with it!  :)
also no changeable fonts version yet (although I couldn't resist doubling the peakmeter size  :D)

I've still got to do loads of testing to make sure it compiles and runs on all the other targets too before it can be committed...

Enjoy...  :)

[attachment deleted by admin, too old]
Title: Re: Recording Enhancements Pack
Post by: bennis on March 11, 2006, 04:02:09 AM
Wow! I have installed the new build with the agc functions on it. I will be testing today during a concert:) so far looks good! On inputs I can;t however choose for mic input ... only line and buildin mic...

I like the histogrammy thing...gives a smooth idea about the levels .. even without recording it works:) GREAT tool
Title: Re: Recording Enhancements Pack
Post by: petur on March 11, 2006, 08:36:38 AM
mic = internal mic (mono)
line-in = line-in connector

However, the line-in connector supplies power for an external mic, in fact the iriver firmware 'line-in' and 'ext-mic' are nothing more than the line-in with a different gain range.

I don't know what voltage the h1xx puts on the line-in connector but my h340 gives a bit more than 3V (so better than external 1,5V power!)
Title: Re: Recording Enhancements Pack
Post by: paulheu on March 11, 2006, 02:09:31 PM
Am I right to assume the new peakmeter patch will require a new agc patch as well? it seems at first glance some stuff changed enough to break the current agc patch..
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 11, 2006, 02:29:56 PM
New version...now compiles under every target (except the ones that won't compile anyway (12 & 20).

Oh and I haven't tested 5 or 6 because I couldn't get the versions of binutils and gcc to make the crosscompiler to test them with...

But apart from that it is just about perfect I think... Anyone found any problems yet?

paulheu: Yes I think it will break the present AGC patch..but that's life eh?  :)

[attachment deleted by admin, too old]
Title: Re: Recording Enhancements Pack
Post by: paulheu on March 11, 2006, 04:00:55 PM
paulheu: Yes I think it will break the present AGC patch..but that's life eh?  :)

It is.. but since I prefer to have agc available I will have to hold off on a test run..  ;)
Title: Re: Recording Enhancements Pack
Post by: paulheu on March 12, 2006, 06:51:09 AM
I've been fiddling with the agc patch and actually have it working with the new peakmeter/remote patch. Oddly though I only get two letters and some (gain) values in the AGC mode display on the screen.. Things seem to work fine it's just the  display that's odd..

I've attached the patch I've done. As this is my first 'actually change code' patch I hope I'm not breaking anything .. ;) I'm only trying to learn something here.. so shoot me if I am being silly..;)

EDIT: removed the patch.. It's no longer valid..
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 12, 2006, 06:31:09 PM
Paulheu...just quickly looking at your patch... I think that for the following part:

Code: [Select]
+                    lcd_puts_style(0, 7, buf, STYLE_INVERT);
+                else
+                    lcd_puts_style(0, 6, buf, STYLE_INVERT);
+ }
+            else
+            {
+                if(global_settings.rec_source != SOURCE_MIC)
+                    lcd_puts(0, 7, buf);
+                else
+                    lcd_puts(0, 6, buf);
             }
instead of using 6 & 7, try using 7 & 8...

(looks as if the gain settings and AGC mode are printing on the same line!)
Could be wrong though....   :D
Title: Re: Recording Enhancements Pack
Post by: paulheu on March 12, 2006, 06:45:31 PM
That was not it actually, as it turns out the 'shortcuts' for the agc modes are in the code (line 180 of recording.c)

I just changed them to the full names and that worked just fine. Although I guess these should be in the/from the language file.. but for now I got it working as I like it.. I include the new patch. Now I only have to figure how to use the system font on the remote while the main lcd still uses the custom font..

But sofar so good.. you learn a bit every day.. ;)

EDIT: removed the patch as it is no longer valid..
Title: Re: Recording Enhancements Pack
Post by: paulheu on March 13, 2006, 09:10:39 AM
About the font 'thing'  ;D

would this work (use set font on player lcd, system font on remote LCD):

Code: [Select]
    FOR_NB_SCREENS(i)
    {
        if (i==0)
            screens[i].setfont(FONT_UI);
        else
            screens[i].setfont(FONT_SYSFIXED);
        screens[i].getstringsize("M", &w, &h);
        screens[i].setmargins(global_settings.invert_cursor ? 0 : w, 8);
    }

or did I misunderstand the FOR_NB_SCREENS part (as a defined for-next loop of sorts..;) )
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 13, 2006, 11:58:16 AM
This is from screen_access.h so you can see exactly what FOR_NB_SET_SCREENS(i) does
Code: [Select]
#define FOR_NB_SCREENS(i) for(i = 0; i < NB_SCREENS; i++)So your assumption was correct!  :)

I don't think that your code will work though!

It will store the dimensions for a user font in the variables w and h and then it will store the dimensions for the system font in w & h overwriting the originals. even if this did work you would then have to do a similar thing when calling the peakmeter as it would need the correct h value for the specific screen.

The only way that I can think of to do this using the gui system is to make a new struct for recording.c that contains w and h and possibly also the font settings. That should keep you thinking!  ;)
Title: Re: Recording Enhancements Pack
Post by: paulheu on March 13, 2006, 02:08:19 PM
Well, it works for the text, but the peakmeter is in the wrong place (as you expected..)

Oh well. It's fun enough to poke around and figure this stuff out anyway.. :^)
Title: Re: Recording Enhancements Pack
Post by: paulheu on March 13, 2006, 02:28:38 PM
Fixed it!! ..

Code: [Select]
    FOR_NB_SCREENS(i)
    {
        if (i==0) {
            screens[i].setfont(FONT_UI);
            screens[i].getstringsize("M", &w, &h);
            screens[i].setmargins(global_settings.invert_cursor ? 0 : w, 8);
}
        else {
            screens[i].setfont(FONT_SYSFIXED);
            screens[i].getstringsize("M", &rc_w, &rc_h);
            screens[i].setmargins(global_settings.invert_cursor ? 0 : rc_w, 8);
        }
    }

I'm sure there's a better way to do this.. but it's making me proud..  ;D
Title: Re: Recording Enhancements Pack
Post by: paulheu on March 13, 2006, 03:59:02 PM
Here's the patch including the AGC code, custom font and remote/peakmeter..

Works fine for me.. anyone willing to try?! please do!

[attachment deleted by admin, too old]
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 13, 2006, 04:20:49 PM
AHA! good thinking paulheu...  :)

Good stuff but I'm not happy with this sharing the same font as for everything else, how about a menu in the recording settings screen so that you can choose the font you want just for the recording screen? I think that is the next  big challenge!    :D
I think bk has been working on something similar for the WPS screen... might be a good place to start!  ;)
Title: Re: Recording Enhancements Pack
Post by: paulheu on March 14, 2006, 06:12:03 PM
(small) problem..

I found the peakmeter is actually drawn twice, once in peakmeter.c and once again in recording.c..  In peakmeter.c the hight and position for the meter appear to be set in line 1190:

int peak_meter_draw_get_btn(int x, int y, int height)

Now as I see it is not possible to get the different positions/sizes for screens with different fonts using this as there is nothing to identify the screen.

I have been browsing the source, but cannot find anything that would help me here, but I might miss something..

any ideas..?
Title: Re: Recording Enhancements Pack
Post by: larry_llama on March 14, 2006, 08:10:09 PM
Hey.. sorry to interrupt the coding brianstorm (keep it going, I'm enjoying following it). I have a quick side question: Is there a button (or button combo) while you are on the recording screen that sets a file split? I know you can set it to split at a certain interval, but can you force a split (and have two wave files that are contiguous)? If not, it's no biggie but I just want to make sure I'm not missing anything :-)
Title: Re: Recording Enhancements Pack
Post by: paulheu on March 15, 2006, 06:33:35 AM
I'm not sure, but try pressing play. I believe that is what does it on the archos..
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on March 15, 2006, 07:20:46 AM
Last time i checked on my h120 (admittedly a while ago), pressing play while recording pauses the recording.  Not sure about the file split...i guess i never saw the point to it.

By-the-by, last night i re-tested the 2 gig auto-split for the first time in months and am pleased to report that it is still seamless.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 15, 2006, 10:09:00 AM
(small) problem..

I found the peakmeter is actually drawn twice, once in peakmeter.c and once again in recording.c..  In peakmeter.c the hight and position for the meter appear to be set in line 1190:

int peak_meter_draw_get_btn(int x, int y, int height)

Now as I see it is not possible to get the different positions/sizes for screens with different fonts using this as there is nothing to identify the screen.

I have been browsing the source, but cannot find anything that would help me here, but I might miss something..

any ideas..?

peak_meter_draw_get_btn (which is a function in peakmeter.c) calls peak_meter_screen and specifies there which screen to display. So you will have to have another h_rc and w_rc in this function to pass to peak_meter_screen.....

The peakmeter is actually drawn a lot more than twice...there is one big update (done in recording.c) of the whole recording screen, and lots of little updates (done in peakmeter.c) of just the peakmeter in one cycle.
Title: Re: Recording Enhancements Pack
Post by: vinylivo on March 15, 2006, 12:48:27 PM
(small) problem..

I found the peakmeter is actually drawn twice, once in peakmeter.c and once again in recording.c..  In peakmeter.c the hight and position for the meter appear to be set in line 1190:

int peak_meter_draw_get_btn(int x, int y, int height)

Now as I see it is not possible to get the different positions/sizes for screens with different fonts using this as there is nothing to identify the screen.

I have been browsing the source, but cannot find anything that would help me here, but I might miss something..

any ideas..?

Hi paulheu I have a solution to your prpblem. I already tried it myself and it works. But we need modifying the 'peak_meter_draw_get_btn() function, it's used by recording.c exclusively so this won't be a problem.

Change in 'peakmeter.h':
Code: [Select]
extern int  peak_meter_draw_get_btn(int x, int y[], int height[]);(pass an array with the different sizes to the function, this can also be written like 'int *y' which is the same in C)

changes in 'peakmeter.c':
Code: [Select]
int peak_meter_draw_get_btn(int x, int y[], int height[])
{
    int button = BUTTON_NONE;
    long next_refresh = current_tick;
    long next_big_refresh = current_tick + HZ / 10;
    int i;
#ifndef SIMULATOR
    bool highperf = !ata_disk_is_active();
#else
    bool highperf = false;
#endif
    bool dopeek = true;

    while (TIME_BEFORE(current_tick, next_big_refresh)) {
        button = button_get(false);
        if (button != BUTTON_NONE) {
            break;
        }
        if (dopeek) {          /* Peek only once per refresh when disk is */
            peak_meter_peek(); /* spinning, but as often as possible */
            dopeek = highperf; /* otherwise. */
            yield();
        } else {
            sleep(0);          /* Sleep until end of current tick. */
        }
        if (TIME_AFTER(current_tick, next_refresh)) {
            FOR_NB_SCREENS(i)
            {
                peak_meter_screen(&screens[i], x, y[i], height[i]);
                screens[i].update_rect(x, y[i], screens[i].width, height[i]);
            }
            next_refresh += HZ / PEAK_METER_FPS;
            dopeek = true;
        }
    }

    return button;
}

As you see we just use the different sizes for calling 'peak_meter_screen'.
The small refresh in 'recording.c' becomes:
Code: [Select]
        /* Wait for a button a while (HZ/10) drawing the peak meter */
        button = peak_meter_draw_get_btn(0, pm_y, pm_h);


And then in 'recording.c' the big refresh is done around line 2020:
Code: [Select]
            FOR_NB_SCREENS(i)
            {
                peak_meter_screen(&screens[i], 0, pm_y[i], pm_h[i]);
                screens[i].update();
            }

Of course we need some initialisation for the pm_y and pm_h arrays:
Code: [Select]
    int font[2];
    int w[2], h[2];
    int pm_y[2], pm_h[2];

.....

    FOR_NB_SCREENS(i)
    {
        screens[i].setfont(FONT_UI);
        screens[i].getstringsize("M", &w[i], &h[i]);
        if (i == SCREEN_MAIN) {
            if (h[i] < ((LCD_HEIGHT - 40) / 8))
                font[i] = FONT_UI;
            else
                font[i] = FONT_SYSFIXED;
        }
        else if (h[i] <= ((64 - 8) / 7))
            font[i] = FONT_UI;
        else
            font[i] = FONT_SYSFIXED;

        screens[i].setfont(font[i]);
        screens[i].getstringsize("M", &w[i], &h[i]);
        screens[i].setmargins(global_settings.invert_cursor ? 0 : w[i], 8);
        if (h[i] > 8) {
            pm_y[i] = 9 + h[i] * 2;
            pm_h[i] = (h[i] - 1) * 2;
        }
        else {
            pm_y[i] = 8 + h[i] * 2;
            pm_h[i] = h[i] * 2;
        }
    }
This includes a check if it fits on the recording screen and selects the user font if it does otherwise it chooses the default. For bigger fonts the peak meter height is made slightly (2 pixels) smaller because it looks better.

Hope this helps!

vinylivo

PS:I'm still working on an updated version of my AGC patch and then you can have the whole. I just need to go on a business trip for the next 2 days...
Title: Re: Recording Enhancements Pack
Post by: paulheu on March 16, 2006, 08:00:45 AM
Cool.. I got your new patch and it works very well.

I have been studying the wps code to see if I can work up some sort of wrs thingie (While Recording Screen).. I do not think it has to be as fancy as WPS, but it would have mutliple fonts (so you can display less important info in a smaller font). Easy peakmeter handling, pm_set[pm_screen].xxx functions like .height, .color_low and .color_high, but that's being _very_ brave for me right now..  ;D

I'm just learning a lot about coding C now that I am getting into this stuff and it's much fun in any case. I guess it's time to get a good book on this.. :)
Title: Heavy Crash at playback with latest Recording Enhancements Pack
Post by: bennis on March 16, 2006, 03:40:57 PM
My player freezed dramatically ( reset button needed to be used) on some newly encoded music files, in wma format. Does Rockbox not support wma?? Can't recall having this problem before though...
Title: Re: Recording Enhancements Pack
Post by: Llorean on March 16, 2006, 04:01:45 PM
Rockbox does not, and has never so far, supported WMA.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 16, 2006, 04:04:39 PM
An inspired bit of coding there Vinylivo.... I like it!  :)

Instead of setting the arrays to a size of '2' though, you could set them to the size of 'NB_SCREENS' so that any number of screens are supported and  instead of hardcoding the  height of the remote as 64, you could change

Code: [Select]
else if (h[i] <= ((64 - 8) / 7))to
Code: [Select]
else if (h[i] <= ((screens[i].height - 8) / 7))....I think that should work... :D

Anyway...good stuff, have you made a patch with my new display code in? I'll put it in my build in post#1 if you have..  :) I think with your screen size testing idea I will only need one build now! ;D

Quote from: bennis
My player freezed dramatically ( reset button needed to be used) on some newly encoded music files, in wma format. Does Rockbox not support wma?? Can't recall having this problem before though...
No, Rockbox doesn't support WMA....are you sure you posted in the right thread?
Title: Re: Recording Enhancements Pack
Post by: vinylivo on March 17, 2006, 02:40:33 AM
An inspired bit of coding there Vinylivo.... I like it!  :)

Instead of setting the arrays to a size of '2' though, you could set them to the size of 'NB_SCREENS' so that any number of screens are supported and  instead of hardcoding the  height of the remote as 64, you could change

Code: [Select]
else if (h[i] <= ((64 - 8) / 7))to
Code: [Select]
else if (h[i] <= ((screens[i].height - 8) / 7))....I think that should work... :D

Ah yes of course, don't know why I didn't think of that! I'll try that when I'm back home...

And by the way I used the remote support patch from the flyspray tracker.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 17, 2006, 09:54:44 AM
And by the way I used the remote support patch from the flyspray tracker.

I'm confused...that's  what paulheu said too.... but if so, how come the first change in your patch is
Code: [Select]
                     peak_meter_draw(0, peak_meter_y, LCD_WIDTH,
-                                    MIN(h, LCD_HEIGHT - peak_meter_y));
+                                    MIN(h, LCD_HEIGHT - peak_meter_y), false);
(from http://www.rockbox.org/bugs/task/4748 (http://www.rockbox.org/bugs/task/4748))

Whereas the equivalent line in mine is
Code: [Select]
-                    peak_meter_draw(0, peak_meter_y, LCD_WIDTH,
-                                    MIN(h, LCD_HEIGHT - peak_meter_y));
+                    peak_meter_screen(gwps->display, 0, peak_meter_y,
+                                    MIN(h, display->height - peak_meter_y));
(from  http://www.rockbox.org/bugs/task/4818 (http://www.rockbox.org/bugs/task/4818))

The line in your patch is from my original (it doesn't use the display gui)....or am i looking in the wrong place or something ???
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 17, 2006, 01:51:26 PM
Well I've merged Vinylivo's and my patch myself and added the variable fonts and made a couple of tiny changes...

Unfortunately, because the histogram takes up so much room, you cant really get a really big font to fit the main screen...only 12 pixels high max! 13 just wont go!  :(

You gan get 13 in if you are in mic mode, but where 's the fun in that eh?   :D
I think the solution would be to move something...hmmmm I'll think about it...
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 17, 2006, 02:43:08 PM
Doh...ignore my last two posts... still working out how flyspray works!  ::)

heh heh....back to the drawing board.....
Title: Re: Recording Enhancements Pack
Post by: kingtone on March 18, 2006, 03:20:10 PM
Hi,

I'm a touring musician who is WAY thankful for the enhancements for the H120 you all have provided to record live shows, etc. Thank you thank you thank you.

I had success loading the basic build (3.14.06) and the recording works fine. However, I just loaded the recording enhancements pak and the 'line in' setting no longer picks up any signal from my Sony ECM mic as it did before. I both tested the mic and even reloaded the old build which works fine. Am I doing something wrong?

As a mac user w/ no program/interface to 'patch' i have to rely on the latest build (on post #1). I'd really like to add the AGC stiff from Flyspray's page - does his build supercede this one or do i have to do a 'patch?'

Thanks!

lucio

www.kingtone.com
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 18, 2006, 05:00:43 PM
Post#1 now updated, AGC included along with changeable fonts and all the other stuff....

Try that out kingtone...maybe that'll work for you, although I never had a problem with the old version myself...
Title: Re: Recording Enhancements Pack
Post by: kingtone on March 18, 2006, 08:45:04 PM
Thanks Mmmm!

Sorry if I'm being a retard...Is the build in your signature updated or the patch?

I loaded the build from your sig and ended up with an older looking affair (w/ out histogram etc) but, I was able to load Flyspray's 3.13.06 build and it works (but does not have the fancy double size meters, etc refered to on page 11).
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 19, 2006, 06:45:28 AM
Hmmm try it now, I've re-uploaded and tested it...this time it is definitely the right version (both patch and build in sig)
The 3.13.06 build on flyspray isnt a build I made so I can't vouch for what may or may not be included in that one!  :)

Post#1, definitely has the right versions now!   :D
Title: Re: Recording Enhancements Pack
Post by: paulheu on March 19, 2006, 12:11:58 PM
I sortof took over the experimental build on mistic river from needleboy..

It uses the latest recording enhancement patch and appears to work well..

http://www.misticriver.net/showthread.php?t=38915
Title: Re: Recording Enhancements Pack
Post by: kingtone on March 19, 2006, 03:20:10 PM
Thanks Mmmm. The problem was far too simple...after checking the file date on the rockbox.iriver file, i reset the browser cache and got the proper link to 3.18 build you posted on #1.  :P

The recording screen looks looks right, but there seems to be a problem with setting a theme. When accessing the 'browse themes' directory it autoloads the first menu item (boxes) and then returns you to the main directory.

paulheu - i tried your latest 3.19 build (rb-exp-03192006_1545) and got a 'checksum error' on reboot.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 19, 2006, 03:47:06 PM
kingtone...I think this is a small bug with the oneclick insert patch... A workaround is to use right to select instead of pressing the joystick. Also if you change the 'click insert options' to something other than 'original behaviour' this problem goes away (but then clicking will add to playlist instead of just selecting!).
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 19, 2006, 03:53:00 PM
I sortof took over the experimental build on mistic river from needleboy..

It uses the latest recording enhancement patch and appears to work well..

http://www.misticriver.net/showthread.php?t=38915
this is for H3xx right? I'll put a link to it in post#1
Title: Re: Recording Enhancements Pack
Post by: paulheu on March 20, 2006, 12:36:42 PM
paulheu - i tried your latest 3.19 build (rb-exp-03192006_1545) and got a 'checksum error' on reboot.

Hmmmm (pun intended.. ;) ) First time I heard about this.. we're a few builds further down the road now.. and I knw of no other people having this issue. Try a fresh install and reset your settings..
Title: Re: Recording Enhancements Pack
Post by: qpwoei on March 20, 2006, 12:50:12 PM
So, am I the only one who gets 'disk full, shutting down' whenever a use a build with AGC??? The two builds with AGC I have tried did show that message (or 'warning, low space in disk') which suggest inability to read available disk correctly. 
AHHHHH!!!! Dam**... I would LOVE the AGC feature :-(
Title: Re: Recording Enhancements Pack
Post by: paulheu on March 20, 2006, 03:15:36 PM
Just to be sure, did you try a real clean install? (including wiping the stored settings..)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 21, 2006, 02:22:52 AM
paulheu - i tried your latest 3.19 build (rb-exp-03192006_1545) and got a 'checksum error' on reboot.
If my build works for you, as it seems it does,then you have a H120 or a H140. Paulheu's build will not work for your player as it is not for the H140/H120 (at least it is in the H3xx forums on mistic river so I assume it isn't). So don't even bother trying to get it to work!  :) ....it won't!
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 21, 2006, 02:25:01 AM
So, am I the only one who gets 'disk full, shutting down' whenever a use a build with AGC??? The two builds with AGC I have tried did show that message (or 'warning, low space in disk') which suggest inability to read available disk correctly. 
AHHHHH!!!! Dam**... I would LOVE the AGC feature :-(
How big is your disk and how full is it? What type of disk do you have?
Title: Re: Recording Enhancements Pack
Post by: qpwoei on March 21, 2006, 03:11:56 AM

How big is your disk and how full is it? What type of disk do you have?

thanx for answering

windoze reports a 20 Gb ToshibaMK2004GAL inside my H120, with 10 Gb free. I have defragmented the volume, but no success...

My steps to test builds are:
 
- first, keep a backup of the working one
- second, overwrite the file 'old rockbox.iriver' at root with that of the new build
- third, erase everything inside ./rockbox
- fourth, refill ./rockbox with folders from the new build
- restart and reset settings

Also I do NOT touch the loader (ihp_120.hex) at root which is perhaps a bit dated (20051227) , might this be a problem?

cheers
Title: Re: Recording Enhancements Pack
Post by: AlexP on March 21, 2006, 03:37:48 AM
Also I do NOT touch the loader (ihp_120.hex) at root which is perhaps a bit dated (20051227) , might this be a problem?

ihp_120.hex is only used when you flash the firmware from within the iRiver firmware.  Having it sat on your disk is doing nothing.

Once you flash the bootloader there it stays unchanging until you reflash with another version.  Version 6 is the latest.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 21, 2006, 09:08:17 AM

How big is your disk and how full is it? What type of disk do you have?

thanx for answering

windoze reports a 20 Gb ToshibaMK2004GAL inside my H120, with 10 Gb free. I have defragmented the volume, but no success...

My steps to test builds are:
 
- first, keep a backup of the working one
- second, overwrite the file 'old rockbox.iriver' at root with that of the new build
- third, erase everything inside ./rockbox
- fourth, refill ./rockbox with folders from the new build
- restart and reset settings

Also I do NOT touch the loader (ihp_120.hex) at root which is perhaps a bit dated (20051227) , might this be a problem?

cheers

So you have the stock battery...hmmm that can't be the problem then.
Bigbambi is right..it is entirely possible that updating your bootloader to V6 may fix it...I'd give that a go first.

Another longshot.. try resetting your settings (deletng the .rockbox folder doesn't reset them).
Title: Re: Recording Enhancements Pack
Post by: qpwoei on March 21, 2006, 11:52:06 AM
tried everything suggested, but it keeps saying the disk is full. Thank you anyway.

I have noticed that Info (within General Settings menu) always reports '0 k free', no matter which build is loaded. But curiously enough, while most 'recording enhaced' builds record OK for hours, those with AGC fail completely.

Oh, I forgot to say I use the European version of rockbox (H120(eu)-v165).

Title: Re: Recording Enhancements Pack
Post by: Llorean on March 21, 2006, 11:55:52 AM
There is no European version of Rockbox. Rockbox is a completely separate firmware, and whatever version of iRiver firmware you have will not affect the functioning of Rockbox.

Have you tried forcing Rockbox to rescan your disk? (Go to check your disk in the debug menu under the info menu, and scroll to where it says how much free you have and click the Navi stick.) Windows can sometimes report free space where there isn't. Or, Rockbox can assume there isn't free space when there is because Windows hasn't properly updated file tables of some sort (I personally don't know much about this aspect, so I don't really get it, but my mind summarized it to 'windows doesn't always handle things right' which to me is a perfectly acceptable cause)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 21, 2006, 12:04:11 PM
But curiously enough, while most 'recording enhaced' builds record OK for hours, those with AGC fail completely.
That is because the AGC patch includes a disk space checker so that you will be warned when disk space gets low...
It stops recording when you run out so that you don't end up with a corrupted file...
If your unit reports the correct remaining space this is great. If not it is a real pain (as you have noticed).
Title: Re: Recording Enhancements Pack
Post by: qpwoei on March 21, 2006, 03:30:07 PM
Have you tried forcing Rockbox to rescan your disk? (Go to check your disk in the debug menu under the info menu, and scroll to where it says how much free you have and click the Navi stick.)

Yeah, it reports 0 Mb free, whereas original iRiver firmware and windows both report 9807 Mb free in the single FAT32 partition. For me that's the usual situation because I regularly avoid filling any disk above 50-70% of total capacity.

Windows can sometimes report free space where there isn't. Or, Rockbox can assume there isn't free space when there is because Windows hasn't properly updated file tables of some sort (I personally don't know much about this aspect, so I don't really get it, but my mind summarized it to 'windows doesn't always handle things right' which to me is a perfectly acceptable cause)

I don't trust windows either, so after scanning the disk for errors with scandisk I resorted to PQmagic.... and it said there existed 'cross-linked files' in the volume but can't correct for the error. Now I face the hard decission of either re-format (and hopefully solve the issue) or stick to a build with no AGC. Anyway, shi* happens!

A lot of thanks for your input, guys
Title: Re: Recording Enhancements Pack
Post by: Llorean on March 21, 2006, 03:55:08 PM
And the continued 0mb free was *after* a rescan (which isn't just browsing to that part of the screen, but clicking the stick, which will then cause it to tell you it's scanning and take several seconds.)

Anyway, it sounds like you've found the cause. I don't know what to say. =/
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on March 21, 2006, 04:20:46 PM
A couple of times now (once each with rockbox @ iriver f/w) my free space has been misreported by several gig.  'tis a real pain in the arse when you can't record because of it.

I couldn't figure it out, so I formatted the disk and all was well.  The problem doesn't seem to arise when I use the delete function within rockbox. *shrug*
Title: Re: Recording Enhancements Pack
Post by: evilnick on March 21, 2006, 05:27:15 PM
Have you tried running the disktidy plugin to make sure there are no files lurking in the recycle bin?
Title: Re: Recording Enhancements Pack
Post by: qpwoei on March 22, 2006, 04:24:30 AM
OK, problem solved!! I did NOT format, yet free space is read correctly (either rockbox rescanned at last - thanx Llorean - or PQmagic somehow fixed it. Dunno, but rockbox declares i can record for 16 hours so I'm happy :)
Did I mention this AGC is wonderful? Well, it IS!

A great THANKS to all of you for helping, your the best!

Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on March 24, 2006, 06:18:34 PM
FANTASTIC!!!!

The R.E.P. build is fantastic! Who do I petition to have it commited?
I don;'t know much about the open source developement process, but I'd like to voice my enthusiasm to the powers that be (or commit as it were).

Man, very very cool.

Thanks so much to all those involve in the R.E.P..

Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 25, 2006, 06:37:46 AM
FANTASTIC!!!!

The R.E.P. build is fantastic! Who do I petition to have it commited?
I don;'t know much about the open source developement process, but I'd like to voice my enthusiasm to the powers that be (or commit as it were).

Man, very very cool.

Thanks so much to all those involve in the R.E.P..
Cheers...There are two of us that currently have work in the R.E.P, Me (remote support) and Vinylivo (AGC).

To be committed each little bit has to be done at a time. I have a separate patch that just implements the remote support that is ready for committing http://www.rockbox.org/tracker/task/4818 (http://www.rockbox.org/tracker/task/4818).

Vinylivo has his AGC patch on the tracker too which incorporates a number of different features (so may not be so committable in its present state...who knows?)
http://www.rockbox.org/tracker/task/4748 (http://www.rockbox.org/tracker/task/4748).

It is just a case of getting on IRC and going on and on about it until someone buckles and says they will have a look at it! (A bit tedious i know :D )

Unfortunately the devs with CVS access that are into recording are few and far between (petur being the only one I know of and he doesn't have a remote, so the chances are small :( )

We just have to be patient, keep nagging and keep those fingers crossed!  :D

PS. Does anybody have a digital camera that they can use to take a pic of the remote recording screen so I can put it in post#1? As you can see, my effort is awful!  :D
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 25, 2006, 08:53:14 AM
WOW....The remote support has just been committed.....Yippeeeeeeeeeeeeee

So now it is just Vinylivo's patch left.....

We've come a long way eh?  ;D

The rest of the day must be spent in the pub methinks.....  :D
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on March 25, 2006, 09:30:29 AM
Congrats...that's awesome news!  It must be a good feeling to see the culmination of all your efforts over the last few months.

Are you going to get bored now? :)
Title: Re: Recording Enhancements Pack
Post by: paulheu on March 25, 2006, 09:53:39 AM
WOW....The remote support has just been committed.....Yippeeeeeeeeeeeeee

So now it is just Vinylivo's patch left.....

Good news.. But now I guess we need a separate AGC patch again?! As the two were sortof intermixed ..
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 25, 2006, 10:19:14 AM
Congrats...that's awesome news!  It must be a good feeling to see the culmination of all your efforts over the last few months.

yes, it's a great feeling, I'm on a super high at the moment.... ;D

Quote
Are you going to get bored now? :)
Heh heh..no, I'm going to retire to a place where there is no electricity so that I'm not tempted to code any more, and get some guitar practice in (learning to code is not good for guitar practice!  :D ).

Quote from: paulheu
Good news.. But now I guess we need a separate AGC patch again?! As the two were sortof intermixed ..
Yep, Vinylivo may want to do that, or maybe you could as you had a bit of success with this sort of thing earlier...  ;)
Title: Re: Recording Enhancements Pack
Post by: paulheu on March 25, 2006, 12:05:56 PM
I've been looking at it.. Bit it seems that what's commited means we also loose big fonts in the recording screen..

It appears that this is just a bit too much for me to fix (right now) and as I want to keep both AGC and the big fonts I guess I'll have to stay away from CVS updates for the time being and stick with my latest build. No big deal as where I am now works for me ..
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 25, 2006, 01:04:19 PM
Ok, I've updated the patch...I had forgotten about the fonts thing!  ;D

Patch in Post#1 should now work with latest CVS... :)

Oh and I won't be needing that photo any more seeing as the patch has been committed now  ;D
Title: Re: Recording Enhancements Pack
Post by: paulheu on March 25, 2006, 05:52:34 PM
Cool.. just did a completely new experimental build (http://www.misticriver.net/showpost.php?p=419147&postcount=13) with the new patch (and some more..) for H3x0
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 27, 2006, 12:02:19 PM
Updated build/patch to latest CVS (to include tagcache)
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on March 27, 2006, 09:27:53 PM
To the developers in this thread: I'm harrassing a mate of mine to have a crack at implementing optical recording.

Do you have any tips to make his life easier?  I've pointed him @ recording.c and the s/pdif analyser. Is there anything else you can think of that may help him out?
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on March 28, 2006, 07:54:23 PM
So let me get this straight...

The WRS (while recording screen) and the remote has been committed to the regular rockbox build, but not the AGC patch (yet).

Also the regular rockbox build has files for all targets, while your build has just the H120 files as well as AGC.

Assuming all of that is correct I would never install the regular build as long as you specialized build is available.

I need to learn to compile this thing before you decide not to provide this awesome little service here.   :o :P

Thanks again for adding so much to an already super cool device.
Title: Re: Recording Enhancements Pack
Post by: petur on March 29, 2006, 04:06:49 AM
what's the state of AGC?
- does it work ok
- on what devices does it run
- does the patch build for all targets

As there will be a feature freeze on april 4, I might try to get it into version 3.0 :)

Peter
Title: Re: Recording Enhancements Pack
Post by: Benway on March 29, 2006, 05:36:13 AM
As there will be a feature freeze on april 4, I might try to get it into version 3.0 :)

Oh yes, that would be awesome!
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 29, 2006, 08:55:50 AM
what's the state of AGC?
- does it work ok
- on what devices does it run
- does the patch build for all targets

As there will be a feature freeze on april 4, I might try to get it into version 3.0 :)

Peter
It seems to work ok on h140, I haven't tried compiling for anything else... Vinylivo, who wrote it, seems to have disappeared for a while and I'm not sure whether he tested it or not, he said he was going to.

I haven't really looked at the code in any detail so I don't really know much about it... The balance indicator seems to have weird lines that appear on it but I'm not really sure what it is supposed to do, so maybe it's supposed to do that! ???

There are really a number of changes in the patch. They are:

i) AGC
ii) Battery meter/warning
iii) Disk space meter/warning
iv) Histogram
v) Fonts

So you might want them separating before a commit. We need to PM vinylivo I think!  :)
Title: Re: Recording Enhancements Pack
Post by: paulheu on March 29, 2006, 09:08:37 AM
what's the state of AGC?
- does it work ok
- on what devices does it run
- does the patch build for all targets

Works well

Runs on H1x0 and H3x0 that I know of.. I could wipe the dust of my archos recorder and see if it'll run ..

Have to try to see if it build for all targets too..
Title: Re: Recording Enhancements Pack
Post by: petur on March 29, 2006, 02:11:25 PM
There are really a number of changes in the patch. They are:

i) AGC
ii) Battery meter/warning
iii) Disk space meter/warning
iv) Histogram
v) Fonts

So you might want them separating before a commit. We need to PM vinylivo I think!  :)
Aargh.. I don't understand why people keep putting multiple changes in one patch... will have a look to extract the AGC
Title: Re: Recording Enhancements Pack
Post by: groovetube66 on March 29, 2006, 03:21:47 PM
I started another thread not realizing their was the vu_meter plugin.  Can this plugin work with the recording enhancements patch to replace the led bar meters.  I really like vu meters as I find it easier to see where the overall level is setting.
Title: Re: Recording Enhancements Pack
Post by: vinylivo on April 03, 2006, 04:54:18 AM
Hi folks, here I'm back again.
Sorry that I was unavailable, but I just moved to a new place, and had some business trips too so there was no time left for programming. :(

The updated patch is on the Tracker:
http://www.rockbox.org/tracker/task/4748

This one only includes the AGC part. The histogram follows in a seperate patch.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 03, 2006, 05:46:39 AM
Aggghhhhh just too late!  :D

Ah well....we'll just have to wait till the freeze is over eh?  :)
Title: Re: Recording Enhancements Pack
Post by: larry_llama on April 03, 2006, 02:26:36 PM
Mmmm, do you have a build for the h100 (h110/h115) or just the h120?

I will have to have a look at doing my own patching soon :-p
Title: Re: Recording Enhancements Pack
Post by: paulheu on April 09, 2006, 05:44:37 PM
Well.. we've lost the (bigger) fonts again.. and there's some other stuff changed. Guess we have some puzzling to do ..;^)
Title: Re: Recording Enhancements Pack
Post by: paulheu on April 11, 2006, 09:16:34 PM
OK.. so I tried filtering out the font bits to regain teh larger fonts, but it don't work as expected (or before).. guess too much changed. Oh well, let's hope we'll see a new patch from Mmmm soon..

In any case I now understand the need to keep each change in it's own patch.;)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 18, 2006, 06:56:53 AM
Ok....I'm back from spain....It's FANTASTIC over there!  :D

Quote from: paulheu
Oh well, let's hope we'll see a new patch from Mmmm soon.
I've updated the patch and build in post no.1.............. So you can get your H3xx build up and going now Paulheu :)
Title: Re: Recording Enhancements Pack
Post by: paulheu on April 18, 2006, 09:59:27 AM
Welcome back man.. Glad you enjoyed yourself..

Could you post a patch with just 'your' stuff in it? so without the AGC and histogram patches which are now in the patchtracker?!
Title: Re: Recording Enhancements Pack
Post by: paulheu on April 18, 2006, 10:12:44 AM
Also, the patch in post #1 is against an older Histogram version, without the color bits..

Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 18, 2006, 01:26:30 PM
Colour bits??  :o

wow...how exciting...shame I live in a black and white h140 world eh?  :D
There isn't much of my stuff left! just the fonts I suppose..is that what you mean?

Are you using cvs update to do your updating? if not you may find this makes things much easier for you! ;)
Title: Re: Recording Enhancements Pack
Post by: paulheu on April 18, 2006, 02:22:00 PM
Yes, yes and yes..;)

From what I know 'your part' of the patch constitutes the fonts and remote peakmeter?! I woul very much like to see these in a separate patch whcih would make it easier to do new builds as updates to AGC and/or histogram appear.. (like the 'color bits'..;) )
Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 18, 2006, 04:15:58 PM
Remote peakmeter has gone to cvs heaven along with all my other bits and bobs! just the fonts left which is an awful unrockboxish bit of coding so wont be seeing any cvs joy ever...so that's it! I'll look into a separate patch for you....

so are you 'cvs up -dP' ing or not? This will tell you where all the conflicts occur and makes it fairly easy to spot how to change them! Really useful!
Title: Re: Recording Enhancements Pack
Post by: paulheu on April 18, 2006, 04:58:29 PM
yes, I use cvs to update.. I tried patching a clean CSV with agc/histogram patches added and then using your patch to basically remove the 'double bits' and be left with the stuff that's yours.. but that does not work very well.. In part because it seems the agc/histogram patch you use is behind the current available patch (it seems)..

So yes, if the fonts is what's left of your original patch the I'd much appreciate a separate patchfile for that to make it easier to get into future builds.

thanks!
Paul
Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 19, 2006, 04:48:03 PM
OK Paul, here's a patch that will only allow changeable recording fonts to current cvs version.

This may not apply cleanly to vinylivo's version though, or it may and could still not work! If this is the case try the following:

Code: [Select]
You must make sure that in recording.c any w's and h's need to be changed to w[i] and h[i]
if they are within a FOR_NB_SCREENS(i) loop. If any of these are outside a loop do the same but change the i to a 0.
and change anything like setfont(SYSFIXED) to setfont(font[i]) if it's in one of the loops.
If a setfont is outside a loop leave it alone!

Hopefully that should make sure all runs smoothly.....  :D
Good luck... ;)

[attachment deleted by admin, too old]
Title: Re: Recording Enhancements Pack
Post by: paulheu on April 20, 2006, 06:45:09 PM
Indeed, the fontspatch does not work with the latest agc_histogram patch, the battery/diskspace/balance graphics disapear and do not return..

Oh well.. big(ger) fonts are nice but I can do without em (for now)..
Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 21, 2006, 06:33:10 AM
Does the batt indicator go even when you are using the default font? It is supposed to disappear when a large font is used, as otherwise you just get a nasty mess (it overlaps).

On vinylivo's original the max font size was 12 which is pretty small and useless so I changed it slightly so that it overwrote the batt/disk/balance info. This way you can have larger fonts like chicago12 without any problems (just a small compromise).

Or is it that they never turn up at all?
Title: Re: Recording Enhancements Pack
Post by: paulheu on April 21, 2006, 10:09:07 AM
It never turns up, if I remove the screenclear around line 1550 it stays, but seems to not be updated with the fontpatch. I use a small enough font with plenty of space left..
Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 21, 2006, 11:11:00 AM
Paul: Find this bit in recording.c
Code: [Select]
            /************** AGC Test Info only *************
            lcd_setfont(FONT_SYSFIXED);
            snprintf(buf, 32, "D:%d U:%d",
                     (agc_droptime+2)/5, (agc_risetime+2)/5);
            lcd_putsxy(1, LCD_HEIGHT - 8, buf);
            snprintf(buf, 32, "B:%d",
                     (agc_baltime+2)/5);
            lcd_putsxy(LCD_WIDTH/2 + 3, LCD_HEIGHT - 8, buf);
            ***********************************************/

            if (hist_bal_y > (8 + 8 * h[SCREEN_MAIN]))
            {
                lcd_setfont(FONT_SYSFIXED);
                if (charger_inserted())
                    lcd_mono_bitmap(bitmap_icons_7x8[Icon_Plug],
                                    2 + 19*(battery_level() > 48),

I reckon it must have something to do with this bit of code...
Especially that           
Code: [Select]
  if (hist_bal_y > (8 + 8 * h[SCREEN_MAIN]))bit.
This is the condition for the drawing of the bat/disk/bal info.

hist_bal_y is the start point for drawing the graphs
the first 8 is the size of the status bar and the second is the number of lines of text that are displayed on the screen h[0] or h[SCREEN_MAIN] (same thing) is the height of the font on the main screen.

So the batt/disk/bal info is only displayed if the text doesn't run into it...

Is yours the same as mine?
If it is have a go at changing that second 8 to a 7
Title: Re: Recording Enhancements Pack
Post by: paulheu on April 21, 2006, 11:52:38 AM
I found that one and it appear to work... Had it set to h initially, but of course since this is always the main LCD h[0] is what it should be..

I'll do a bit of testing tonight and let you know what I come up with..
Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 22, 2006, 05:56:17 AM
So it works now?

I was also thinking that seeing as you have a much bigger screen than I do, you might want to change this line
Code: [Select]
    FOR_NB_SCREENS(i)
    {
        screens[i].setfont(FONT_UI);
        screens[i].getstringsize("M", &w[i], &h[i]);
        if (i == SCREEN_MAIN) {
*****if (h[i] < ((LCD_HEIGHT - 16) / 8))]***********
                font[i] = FONT_UI;
            else
                font[i] = FONT_SYSFIXED;
        }
        else if (h[i] <= ((screens[i].height - 8) / 7))
(the ****** line)
Change that 16 to a 40, then the font will never be allowed to overwrite the batt/bal/disk info.
I only changed it because on the small H1xx screen this meant you couldn't get a decent sized font in before it reset to the system font...I don't think that this would be an issue for the H3xx.  ;)
Title: Re: Recording Enhancements Pack
Post by: paulheu on April 22, 2006, 08:19:11 AM
in the fontsonly patch it is actually set to 40
Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 22, 2006, 08:52:57 AM
in the fontsonly patch it is actually set to 40
Ha ha...really?? well...that saves a bit of time then eh  :D

Quote from: paulheu
I found that one and it appear to work... Had it set to h initially, but of course since this is always the main LCD h[0] is what it should be..

I'll do a bit of testing tonight and let you know what I come up with..

You still haven't said whether it works now or not!  ::)
Didn't you set all h's to h[0] or h{i} like I said? :)
Title: Re: Recording Enhancements Pack
Post by: paulheu on April 22, 2006, 01:19:08 PM
I actually commented the 'int w,h;' lines out to find any missed ones, but get no errors. I did spot some leftover &h and &w var but they do not cause any warnings or errors..

I sortof expected them to, but it all works well sofar.. Should I turn all these &w and &h vars into &w[0] and &h[0] as well then ?
Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 22, 2006, 05:40:01 PM
That's weird...the fonts patch should get rid of the 'int w,h' line, how come yours didn't?...  ???

The leftover &w's and &h's are probably within a #ifdef REC_F3 type precompiler thingy which means that when you compile for the iriver the compiler doesn't even look at this bit of code and so no errors... If you tried to compile for archos or something you would have to change to &w[0] etc or there would be errors galore. One of many reasons why the patch is really a load of crap!  :D

So there is no need to change anything if there are no compiler errors. Glad it's all working now.... ;)
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on April 25, 2006, 10:30:43 AM
Hey, are you guys are watching the optical recording progress going on right now?
It's still very alpha, but it seems to be working already.
Also, did you see my parts auction to benefit ROCKbox? (specifically the recording aspect on H1xx targets) I can't code, but I'm trying to do some good for this awesome project... :-P
Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 26, 2006, 07:30:31 AM
New patch/build in post#1

Paul: your fonts patch will be broken now, are you ok to fix it yourself?

Davide: I'm watching and waiting!  ;)
Title: Re: Recording Enhancements Pack
Post by: paulheu on April 27, 2006, 08:08:15 PM
It appears you're still using a previous version of the AGC patch as I get no color on the H3x0 with your complete patch and I do when I apply Ivo's latest current AGC patch..
Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 28, 2006, 06:30:07 AM
Yeah you're right...I'm afraid that I've been struck by a bit of lazyitis!  :D Seeing as there is no colour on the h140 anyway I couldn't be bothered to update the patch to vinylivo's latest...  ::)

Have you managed to make a patch with the fonts in? if so I'll use it and update that.
Title: Re: Recording Enhancements Pack
Post by: paulheu on April 28, 2006, 03:48:16 PM
No, I've been very busy and will be for a few days..
Title: Re: Recording Enhancements Pack
Post by: rjlhughes on April 29, 2006, 08:12:14 AM
Is there a 'how to' for the REP anywhere?  I can't work out what that graph is above the right hand histogram. And I could do woth some guidance on the best recording levels to set the inputs at....am I right in thinking that 28 dB gain might be best?

It's a wonderful tool though and turns out great sounding files. Thanks.


Bob
Title: Re: Recording Enhancements Pack
Post by: paulheu on April 30, 2006, 08:14:26 AM
I've put the font stuff with the latest AGC/histogram patch.. works fine here..

[attachment deleted by admin, too old]
Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 30, 2006, 12:11:20 PM
I've put the font stuff with the latest AGC/histogram patch.. works fine here..
Good stuff...unfortunately this won't compile for the H140!  :(
It doesn't like your lcd_set_foreground(global_settings.fg_color); not one little bit!

I changed it back to LCD_DEFAULT_FG and then it compiled but it hangs when you try to use the line in! So seeing as I'm still feeling lazy, I think I'll just carry on using my humble little B/W patch!  :D

Quote from: rjlhughes
Is there a 'how to' for the REP anywhere?  I can't work out what that graph is above the right hand histogram. And I could do woth some guidance on the best recording levels to set the inputs at....am I right in thinking that 28 dB gain might be best?

It's a wonderful tool though and turns out great sounding files. Thanks.


Bob
There is no manual for these functions as far as I know (as it isn't part of the official build yet) and I know very little about it as it is Vinylivo's work.

All I can say is, the graph you mention tells you about the balance of the input.

There is no perfect level, it just depends on what you are recording and how loud it is. As a general rule you need the level as high as possible without it clipping.

Have a look at the tracker info on the AGC patch (Link in post#1) for more info.
Title: Re: Recording Enhancements Pack
Post by: paulheu on April 30, 2006, 02:20:14 PM
Good stuff...unfortunately this won't compile for the H140!  :(
It doesn't like your lcd_set_foreground(global_settings.fg_color); not one little bit!

My guess is the fg_color is defined for H300 only..
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on May 12, 2006, 09:44:58 PM
I do not know much about programming, but I was able to patch the latest bleeding edge source (late 20060512) with the AGC patch petur put up on the tracker. I was not (since I don't know what I'm doing) able to apply the histogram patch without errors.

Just an FYI.

I'm thrilled to have AGC and optical! THRILLED!
Title: Re: Recording Enhancements Pack
Post by: petur on May 13, 2006, 03:03:45 PM
I wonder why AGC is usefull when recording digital? Isn't it the ADC/preamp that needs tweaking when clipping occurs?

Unless you mean that with the AGC patch on the latest version, you can do digital recording and analog recording with AGC...
Title: Re: Recording Enhancements Pack
Post by: dwonk on May 13, 2006, 05:05:27 PM
FYI, there is no control of gain by the recording device when receiving digital information from a outboard A/D (the H120 is essentially a bit dump at this point) .  Only the A/D's gain will increase/decrease the gain/signal to the bit dump.
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on May 13, 2006, 08:13:20 PM
I meant AGC for line-in is crucial for my field applications (just an external mic for now) and optical recording I've only been using 'in the studio' to do transfers from old DAT tapes etc.

So even though they don't get used simultaneously, I am still THRILLED to have them both operational. RockRivers are the best!

So what about the Histogram patch? I know it's just eye candy, but it's mad cool.

D :-)
Title: Re: Recording Enhancements Pack
Post by: petur on May 14, 2006, 04:27:18 PM
A short warning that amiconn is writing an audio driver or at least moving the gain setting to a lower level. This will break the AGC patch again.

Just so you won't be surprised when this happens ;)
Title: Re: Recording Enhancements Pack
Post by: petur on May 15, 2006, 05:13:29 PM
AGC patch updated, please test....
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on May 16, 2006, 02:09:06 AM
Patched the bleeding edge CVS and 'make' a normal build no problem.
I'll do some field testing with the line-in using an external stereo mic tomorow.
The patch breaks the simulator. Is this normal?
Looks good so far! Will report back after doing some recording!
Thanks!  ;D

Title: Re: Recording Enhancements Pack
Post by: petur on May 16, 2006, 02:21:48 AM
The patch breaks the simulator. Is this normal?

euh... no... will check tonight. As this wasn't meant to be committed directly I didn't check on anything but h300 (which means also h100)
Title: Re: Recording Enhancements Pack
Post by: renho3k on May 16, 2006, 09:20:08 PM
recorded another show last night with the set up and it worked beautifully. i've recorded a few shows before but they were mostly acoustic where clipping wasn't a major issue but this time it was a nice, loud rock concert. oh blessed is the remote recording feature!! ditching the MD and never looking back!

thanks again for all that made this possible.
Title: Re: Recording Enhancements Pack
Post by: Jan on May 17, 2006, 08:08:07 AM
Would it be possible for the AGC to write some kind of log when which amplification was used? That would be very useful (e.g. when you set the AGC to safety to get no clipping and want the whole audio on one level later when editing)
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on May 17, 2006, 08:32:33 AM
Jan, I've mentioned this feature to vinylivo previously, and he sounded pretty open to it...so...*fingers crossed*
Title: Re: Recording Enhancements Pack
Post by: jplumey on May 17, 2006, 04:06:55 PM
Using a stereo pair of binaural microphones and setting the recording format to mono still records in stereo. Is this by design or would that be considered a bug. I love the pack by the way!

JP
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on May 17, 2006, 05:17:11 PM
JP: The devs haven't gotten around to working on mono recording.  As such the latest builds have removed the option.
Title: Re: Recording Enhancements Pack
Post by: jplumey on May 17, 2006, 10:43:57 PM
Thanks!
Title: Re: Recording Enhancements Pack
Post by: ummagumma on May 19, 2006, 02:45:19 AM


 hey, I just picked up an hp120, installed this pack + rockbox, this is amazing!!!

 thx for putting this together!!!


 I can't wait to test out the recording function
Title: Re: Recording Enhancements Pack
Post by: Mmmm on May 20, 2006, 08:04:54 AM
OK...new patch and build in post#1 as usual...

I've used Petur's updated AGC patch so there is no pretty histogram or balance meter etc.. but I've never actually used them anyway so it's certainly not a problem for me...It does have the changeable fonts in there too and all that patch fixing that's been going on recently in CVS (not to mention optical recording).  :)


Edit: hmmm having a bit of trouble getting the build uploaded..my internet connection is playing silly buggers with me! The patch is ok though...

....ok....should work now  :D
Title: Re: Recording Enhancements Pack
Post by: vanakaru on May 28, 2006, 03:09:45 PM
Hi.
I just got myself a iRiver iHP140 few days ago after reading about the Rockbox project.
So I have working digital recorder inally.
If minidisk ever had an open firmaware.... So far it seems that I am going to sell most of my MD setup.

I have been reading this tread for almost a day and downloading  patches and trying them out. So I have few questions I did not get answered from readings. Maybe I missed something and the info is here, so sorry to ask it again.

I have installed the latest optimised build from pilot000 (misticriver) as a last try, but still my recording settings does not have Frequency nor Independent  Frames option.
Both are what I think I need. I would like to get the max quality(48kz) recording and edit it with pro software.
So, do I suppose to have them?
The other interest is in AGC. Does using AGC and gain in rec. window give good results?
I shall be doing some testing with my mic-preamp setup, but since there is a lots of excitement about AGC I would like your suggestion.

AND THANKS FOR THE GGOD WORK!
Title: Re: Recording Enhancements Pack
Post by: petur on May 28, 2006, 04:28:13 PM
I have installed the latest optimised build from pilot000 (misticriver) as a last try, but still my recording settings does not have Frequency nor Independent  Frames option.
Both are what I think I need. I would like to get the max quality(48kz) recording and edit it with pro software.
So, do I suppose to have them?
Nope. Frequency and stuff are not configurable. As a matter of fact, those settings are not available on the official build anymore so the 'optimized' build you have must be getting old...

The other interest is in AGC. Does using AGC and gain in rec. window give good results?
I mainly use AGC as clipping protection, to make sure gain is lowerd a bit when the signal gets louder. No idea how it works otherwise, I suggest you try it.

Oh, and welcome to rockbox ;)
Title: Re: Recording Enhancements Pack
Post by: vanakaru on May 28, 2006, 05:37:48 PM
One more thing:
from some old treads like "external mic recording?" there is a talk about setting ADC gain in record setting window.
Is this no more possible?
Title: Re: Recording Enhancements Pack
Post by: petur on May 29, 2006, 02:32:42 AM
One more thing:
from some old treads like "external mic recording?" there is a talk about setting ADC gain in record setting window.
analog and digital gain have been combined into one gain setting where rockbox selects a combination that's the best for you. Gives you as much analog gain as possible with the 0.5 dB step of digital gain. (c) Mmmm

ADC gain was a wrong description anyway...
Title: Re: Recording Enhancements Pack
Post by: udo on May 30, 2006, 12:29:32 PM
About the clip protection:
How smooth is the gain reduction?
I.e.: does it draw attention?
Or is it safe to use? Can it be influenced enough? (not afraid to compile my own version if necessary)

Some clip protection if e.g. signal reaches -3dBFS would be nice. Some type of limiter-like stuff?
Title: Re: Recording Enhancements Pack
Post by: Mmmm on May 31, 2006, 03:35:27 AM
About the clip protection:
How smooth is the gain reduction?
I.e.: does it draw attention?
Or is it safe to use? Can it be influenced enough? (not afraid to compile my own version if necessary)

Some clip protection if e.g. signal reaches -3dBFS would be nice. Some type of limiter-like stuff?

There is lots of technical info in THIS THREAD (http://forums.rockbox.org/index.php?topic=2841.0) about AGC and all it's various settings.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on June 02, 2006, 06:12:11 PM
A possible new addition to the REP.

Pressing the record button with this patch will start up a new file continuing seamlessly from the previous one (so you can add track splits in real time). I've moved the pause function to the play key (which I was always pressing when i wanted it to pause anyway! :D )

Try it out, tell me what's wrong with it and all the usual stuff...

Only implemented for irivers at the mo....not sure about the buttons to use on other targets but would be very easy to put in. Any suggestions?

The other targets with recording are the Ondio and Gmini100 I think. It would be ideal if we could have the present recording button as the Record/new file button and another button as pause. But which button on these would be good for pause? Is there a spare button at all on those targets?

Anyway...heres the present patch for the Irivers:
manualrecordingsplit.patch (http://homepage.ntlworld.com/martin.scarratt/Rockbox/manualrecordingsplit.patch)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on June 04, 2006, 01:15:22 PM
Ok, post#1 has an updated patch and build.

I've also added my latest patch (realtime tracksplit) see post#1 for details.

So Mlind, there you go...  :)
Title: Re: Recording Enhancements Pack
Post by: paulheu on June 05, 2006, 02:35:51 AM
Withe the latest patch I get this error:

Invalid operands to binary * in line 1531 which reads:

peak_meter_screen(&screens, 0, pm_y + h*filename_offset, pm_h);
Title: Re: Recording Enhancements Pack
Post by: evilnick on June 05, 2006, 07:58:33 AM
Same here with the compiling error.  ???
Title: Re: Recording Enhancements Pack
Post by: Mmmm on June 05, 2006, 11:38:35 AM
doh.... get rid of the h* I'll change the patch...oops!  :)

I've got so many patches hanging about on various street corners I must have put the wrong one up!

Should be ok now...  :-[
Title: Re: Recording Enhancements Pack
Post by: harpster on June 05, 2006, 12:17:35 PM
Just recorded my band's weekend gig using the REP and the recording was wonderful. Big thanks to Mmmm and Vinylivo (and other Rockboxers) for making this happen.

I could use some advice on settings for future recording of live bands. In my last recording session, I kept gain levels low enough that I don't think the AGC ever kicked in. However, I don't fully understand how AGC really works (I've read the thread on it, but I guess I'm a little slow). I'd like to get people's take on how to set up my H140 best for live recording of rock bands. Where should I initially set gain? Which AGC setting (e.g., Safety, Live, etc.)? What should AGC max gain be set to? What should AGC clip time be set to? Any explanation as to benefits of various settings would also be much appreciated.

Thanks!!!!
Title: Shorcut key to the Recording Screen?
Post by: Wolf on June 08, 2006, 02:44:39 PM
FOA, great package. Thanks for putting it all together!
Quality recording is basically the reason why I bought an iRiver H140 and installed Rockbox soon after opening the package.

One question though. Is it possible to access the recording screen quickly thru a shorcut ? (ie long click on the Record button, which does nothing different from the short click=turn on the backlight)

Thanks, Wolf.
Title: Re: Shorcut key to the Recording Screen?
Post by: whatboutbob on June 08, 2006, 04:48:05 PM
One question though. Is it possible to access the recording screen quickly thru a shorcut ? (ie long click on the Record button, which does nothing different from the short click=turn on the backlight)

Not yet.  There is a feature request for that though.
Title: Re: Recording Enhancements Pack
Post by: paulheu on June 09, 2006, 08:40:16 PM
For those interested, there's a new H3x0 build with the latest recenhpack available here (http://www.misticriver.net/showthread.php?t=38915)
Title: Re: Recording Enhancements Pack
Post by: k1spanish on June 12, 2006, 04:46:39 AM
I just tested Mmmm's build with enhanced recording because I am use my iHP 120 often for live recordings - the new features looked good for me.

BUT: I can't change language to German with this build, menu appears and disappears immediately. My fault or a bug???

Would like to have menus in German...
Title: Re: Recording Enhancements Pack
Post by: Mmmm on June 13, 2006, 08:24:22 AM
I just tested Mmmm's build with enhanced recording because I am use my iHP 120 often for live recordings - the new features looked good for me.

BUT: I can't change language to German with this build, menu appears and disappears immediately. My fault or a bug???

Would like to have menus in German...


I've just changed to german and I had no problems that i could see... How exactly did you do it and what menus are you talking about?
Title: Re: Recording Enhancements Pack
Post by: k1spanish on June 14, 2006, 04:40:56 AM
Hi and thank you!

I just copied your build at the player and opened the menu for language but this menu didn't allow to change language setting but closed immediately.

I will download your build again tonight and try. If it works with you it should work with me too I guess, maybe I messed up something last time. I will post the result tomorrow.
Title: Re: Recording Enhancements Pack
Post by: AGI on June 14, 2006, 07:50:22 AM
k1spanish, to go inside the language menu try moving the joystick to the right instead of pushing it's center (select).

this is how Mmmm's build works for me with menus, I dunno what's the reason for this but pushing select results in showing the menu for 1 second and then rapidly exiting from it.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on June 14, 2006, 03:32:56 PM
k1spanish, to go inside the language menu try moving the joystick to the right instead of pushing it's center (select).

this is how Mmmm's build works for me with menus, I dunno what's the reason for this but pushing select results in showing the menu for 1 second and then rapidly exiting from it.

Ahh yes, AGI, that's the problem....It is a bug in the joyclick insert patch. The bug is that when you have 'Click Insert Options' set to 'original behaviour', a click will select whatever is in the next screen automatically... but as you say, until I fix it, pressing right instead of clicking in is a workaround.

I have the setting on 'Insert' and so never use the click unless i'm adding to the playlist so never encounter this bug!  :)
Which means I'll probably never get around to fixing it! :D
Although I have a very long holiday coming up, (just been made redundant! :( ) so you never know I may have a look at it then!  ;D
Title: Re: Recording Enhancements Pack
Post by: petur on June 14, 2006, 06:49:38 PM
sorry to hear that Martin. Happened to me 3 years ago but it actually gave me a better (new) job, so don't hang the head...

On topic now: In recent days I've noticed a small glitch when changing gain during recording, and committed a tweak that will reduce it from +/- 12 to +/- 5 samples having a slightly wrong volume. Too bad this seems to be an issue with the audio chip as even writing both gain registers in one go causes the glitch.

I've also rearranged the calls so that, when the glitch occurs, it's always a dip, never a peak, because I think peaks are more audible.
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on June 15, 2006, 03:49:38 AM
Mmmm: Bad luck mate.  On the up side, I've got 5 mates who were made redundant over the last 5 years (seems to be the way of the world these days).  4 of them got better jobs and the other one used it as an opportunity to set up his own business and is now raking in the dough and loving the work.

petur: Nice work reducing the gain chance glitch.  I was just putting up with it. :)
Title: Re: Recording Enhancements Pack
Post by: k1spanish on June 15, 2006, 12:23:21 PM
Great support, thank you for advice with the menus, helps to handle it.

Mmmm: I Germany we say "pressing the thumb" helps somebody else with having luck. I am pressing now!
Title: Re: Recording Enhancements Pack
Post by: amoergosum on June 15, 2006, 02:26:18 PM
Hello,
I’m new to the whole Rockbox world.
Where do I download the official “Recording Enhancement
Pack” (link?) and how do I unstall it? I can’t wait to use it
since I’m a musician.
Best,
Ben
Title: Re: Recording Enhancements Pack
Post by: petur on June 15, 2006, 04:52:01 PM
Hello,
I’m new to the whole Rockbox world.
Where do I download the official “Recording Enhancement
Pack” (link?) and how do I unstall it? I can’t wait to use it
since I’m a musician.

Welcome on board Ben!

The recording enhancement pack is not an official build and thus unsupported (but users here can help). It consists of the official build with a number of patches added. Some/most of these patches will get into the official build sooner or later.

You're free to try both the official and this build and see what suits you. The build discussed here is linked to from the signature of Mmmm. (Martin correct me if I'm wrong)
Title: Re: Recording Enhancements Pack
Post by: amoergosum on June 15, 2006, 05:08:17 PM
Hello,
I’m new to the whole Rockbox world.
Where do I download the official “Recording Enhancement
Pack” (link?) and how do I unstall it? I can’t wait to use it
since I’m a musician.

Welcome on board Ben!

The recording enhancement pack is not an official build and thus unsupported (but users here can help). It consists of the official build with a number of patches added. Some/most of these patches will get into the official build sooner or later.

You're free to try both the official and this build and see what suits you. The build discussed here is linked to from the signature of Mmmm. (Martin correct me if I'm wrong)


Hi Petur,
thanks for your reply!
I just downloaded the latest Rockbox build....
Yeeeeah! I love it!
But back to the REP;
So I would have to install Mmmm's build, right
or can I somehow only add the REP now?
What are the differences between his build and the latest
official one (only the REP?) ?
Title: Re: Recording Enhancements Pack
Post by: amoergosum on June 16, 2006, 01:03:19 AM
Hello,
I just installed Mmmms build with the REP.
Incredible! I loooove it...
The only thing not working is seeing the same recording screen
as shown in the 2 pictures of this thread's first post (the ones
with the wave pictures on the bottom).
Can anyone help me out there?
Title: Re: Recording Enhancements Pack
Post by: petur on June 16, 2006, 01:20:22 AM
The only thing not working is seeing the same recording screen
as shown in the 2 pictures of this thread's first post (the ones
with the wave pictures on the bottom).
afaik, one or more patches were dropped because they were no longer compatible with the official build - the creator of the patch or some other interested soul needs to update them. So the screen may have changed a bit, yes.

Title: Re: Recording Enhancements Pack
Post by: amoergosum on June 17, 2006, 01:38:03 AM
Hi,
I just wanted to copy a minidisc to my IHP-140 (line in).
Now if I play the minidisk and connect the two players I
see that the Iriver display shows 2 different gain  numbers (gain right/gain left).
I have to set gain right&gain left to the same levels, right?
I set them both to 19dB.

Update: I started the recording and the weird thing is that
              the gain right/left numbers changed by itself after a while.
              Now gain right is 19.5 and gain left 18.5. Weird...
Title: Re: Recording Enhancements Pack
Post by: petur on June 17, 2006, 03:20:36 AM
You normally set the L/R gain numbers the same unless you have a special reason not to (like L/R input signal not equal)

If you're using the recording enhancement pack, it has AGC functionality. Disable it (in recording screen, go to the menu, last line)

Title: Re: Recording Enhancements Pack
Post by: paulheu on June 18, 2006, 06:59:33 AM
Anyone heard anything from vinylIvo recently? I'd like to see and update to the histogram patch to go with the current AGC build.. I kinda miss the pretty pictures..;)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on June 19, 2006, 03:40:04 AM
Thanks for all the votes of sympathy I appreciate it :) My next job is just going to be great I know ;) :D

You're free to try both the official and this build and see what suits you. The build discussed here is linked to from the signature of Mmmm. (Martin correct me if I'm wrong)

That's right, and the patch is in the first post of this thread along with the out of date screen shots and all that :D
(Sorry for the confusion amoergosum, I suppose I should get them updated eh?)
Title: Re: Recording Enhancements Pack
Post by: amoergosum on June 19, 2006, 04:38:52 AM
Thanks for all the votes of sympathy I appreciate it :) My next job is just going to be great I know ;) :D

You're free to try both the official and this build and see what suits you. The build discussed here is linked to from the signature of Mmmm. (Martin correct me if I'm wrong)

That's right, and the patch is in the first post of this thread along with the out of date screen shots and all that :D
(Sorry for the confusion amoergosum, I suppose I should get them updated eh?)

Hi Mmmm,
no problem...
your work is beyond....thanks so much!!!!!!!!!!!
best,
Ben/amoergosum
Title: minor problem
Post by: lurker on June 19, 2006, 07:47:21 AM
I've been using the REP and absolutely love it. I've found the following problem with SW version 060604-1858 (although this may be a problem in the main code branch as well, no idea).

I have "Show Recording Screen on Startup" set to "yes". When I startup, I'm immediately on the recording screen and everything is fine EXCEPT I can't monitor audio through the headphones. The level meters are responding and it in fact records just fine, I just can't hear a thing. To actually hear the audio, I need to press "Stop" to go to the "Recording Screen|Recording Settings" screen and then if I go back into the "Recording Screen", everything is fine.

This happens with headphones plugged into the remote or plugged directly into the main unit.

Thanks to all for the great work!

Title: Re: minor problem
Post by: Mmmm on June 19, 2006, 08:26:54 AM
I've been using the REP and absolutely love it. I've found the following problem with SW version 060604-1858 (although this may be a problem in the main code branch as well, no idea).

I have "Show Recording Screen on Startup" set to "yes". When I startup, I'm immediately on the recording screen and everything is fine EXCEPT I can't monitor audio through the headphones. The level meters are responding and it in fact records just fine, I just can't hear a thing. To actually hear the audio, I need to press "Stop" to go to the "Recording Screen|Recording Settings" screen and then if I go back into the "Recording Screen", everything is fine.

This happens with headphones plugged into the remote or plugged directly into the main unit.

Thanks to all for the great work!
Hi Lurker...sounds as if that could be a problem with the normal build...would you mind testing it? Cheers... :)
Title: Re: minor problem
Post by: petur on June 19, 2006, 02:29:50 PM
I have "Show Recording Screen on Startup" set to "yes". When I startup, I'm immediately on the recording screen and everything is fine EXCEPT I can't monitor audio through the headphones. The level meters are responding and it in fact records just fine, I just can't hear a thing. To actually hear the audio, I need to press "Stop" to go to the "Recording Screen|Recording Settings" screen and then if I go back into the "Recording Screen", everything is fine.

This happens with headphones plugged into the remote or plugged directly into the main unit.
Just checked this and it works fine on my h340, so the cvs build used with line-in and mic should be ok. Just can't test spdif...
Title: Re: Recording Enhancements Pack
Post by: petur on June 19, 2006, 03:56:11 PM
I just updated the unboost recording patch:
http://www.rockbox.org/tracker/task/5457 (http://www.rockbox.org/tracker/task/5457)

It should be fine now for spdif (boosts if recording from spdif, as before).

If possible, please test ;)

Title: Re: Recording Enhancements Pack
Post by: Mr. Brownstone on June 19, 2006, 04:19:09 PM
Is this compatible with the AGC patch?
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on June 19, 2006, 04:46:43 PM
I just updated the unboost recording patch:
http://www.rockbox.org/tracker/task/5457 (http://www.rockbox.org/tracker/task/5457)

It should be fine now for spdif (boosts if recording from spdif, as before).

If possible, please test ;)

Will test this w/e if no-one else gets to it first.

Petur, did you test the 2GB auto-split since you removed boosting?  Saw you mentioned that there seemed to be a gap in playback, so I'm just making sure that is is just an issue with long wav playback, not the actual recorded files not being seemless...cos it was working ok a couple of months ago (last time i tested).
Title: Re: Recording Enhancements Pack
Post by: petur on June 19, 2006, 05:06:13 PM
Petur, did you test the 2GB auto-split since you removed boosting?  Saw you mentioned that there seemed to be a gap in playback, so I'm just making sure that is is just an issue with long wav playback, not the actual recorded files not being seemless...cos it was working ok a couple of months ago (last time i tested).

Still need to have a look at the wavs on PC, hope to have time this week :/
Title: Re: Recording Enhancements Pack
Post by: Mr. Brownstone on June 19, 2006, 06:17:09 PM
Is this compatible with the AGC patch?
Kind of answered my own question with the --dry-run parameter. ;D

The answer is yes. I record quite regularly, so I'll report back if I have any problems.
Title: Re: Recording Enhancements Pack
Post by: petur on June 20, 2006, 02:18:28 AM
The answer is yes. I record quite regularly, so I'll report back if I have any problems.

Be warned that there's possibly lost samples in the filesplit (until I can investigate this). It should be save if you stay below 2GB and don't use the timesplit feature...
Title: Re: Recording Enhancements Pack
Post by: amoergosum on June 20, 2006, 04:23:38 AM
I just had an idea for the REP...
wouldn't it be nice if there would be the possibility to
press the left record button in order to get to the
recording screen instantly?

And another question:
Would it be possible to integrate AM-radio?
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on June 20, 2006, 05:18:54 AM
I just had an idea for the REP...
wouldn't it be nice if there would be the possibility to
press the left record button in order to get to the
recording screen instantly?

http://www.rockbox.org/tracker/task/5233
Title: Re: minor problem
Post by: Mmmm on June 20, 2006, 06:06:41 AM
I have "Show Recording Screen on Startup" set to "yes". When I startup, I'm immediately on the recording screen and everything is fine EXCEPT I can't monitor audio through the headphones. The level meters are responding and it in fact records just fine, I just can't hear a thing. To actually hear the audio, I need to press "Stop" to go to the "Recording Screen|Recording Settings" screen and then if I go back into the "Recording Screen", everything is fine.

This happens with headphones plugged into the remote or plugged directly into the main unit.
Just checked this and it works fine on my h340, so the cvs build used with line-in and mic should be ok. Just can't test spdif...
Works ok on mine too with the patch applied (but again no spdif test). Lurker...does it work properly with default settings?
Title: Re: Recording Enhancements Pack
Post by: petur on June 20, 2006, 06:23:37 AM
Would it be possible to integrate AM-radio?

No, it's an FM radio chip
Title: Re: Recording Enhancements Pack
Post by: petur on June 20, 2006, 04:31:39 PM
Be warned that there's possibly lost samples in the filesplit (until I can investigate this). It should be save if you stay below 2GB and don't use the timesplit feature...

duh... false alarm, it was foobar acting up on me. I appended the wavs in audacity and it was a perfect match.
Title: Re: minor problem
Post by: lurker on June 21, 2006, 06:55:51 AM
I have "Show Recording Screen on Startup" set to "yes". When I startup, I'm immediately on the recording screen and everything is fine EXCEPT I can't monitor audio through the headphones. The level meters are responding and it in fact records just fine, I just can't hear a thing. To actually hear the audio, I need to press "Stop" to go to the "Recording Screen|Recording Settings" screen and then if I go back into the "Recording Screen", everything is fine.

This happens with headphones plugged into the remote or plugged directly into the main unit.
Just checked this and it works fine on my h340, so the cvs build used with line-in and mic should be ok. Just can't test spdif...
Works ok on mine too with the patch applied (but again no spdif test). Lurker...does it work properly with default settings?

It seems that on my h140, the headphones don't get turned on for monitoring until I go from the "Recording Screen|Recording Settings" menu and select the "Recording Screen" option. That would appear why when it jumps to the "Recording Screen" at startup (without going through the menu), I don't have any audio out of the headphones. If I set "Show Recording Screen on Startup" to "no" and (therefore) enter the "Recording Screen" manually, all is fine.

Now that I know what's going on, it's just mostly annoying. I've been capturing sounds on the spur of the moment (which is why I use the "Show Recording Screen on Startup" set to "yes"). But to hear audio in the headphones, I have to press "Stop" to backup to the menu and press "Play" again to turn on the headphones.

I would guess (that at least on my h140) there's some initialization code for  monitoring that's being skipped unless I manually go through the menu and press "Play". Note that the headphones are "dead", not "quiet", but "dead" (like a D/A or output stage is not turned on). When I go through the menu, the audio immediate jumps on.

Any other tests anyone can suggest?
Title: Re: minor problem
Post by: whatboutbob on June 21, 2006, 07:28:49 AM
Any other tests anyone can suggest?

Seeing as it is working for others, I would suggest that there's something specific about your setup that is breaking it...likely either your build, your settings or your unit (unlikely).

Have you tried resetting your settings to clean the slate then changing only the 'show recording screen on start up'?  Let us know if that is still demonstrating the same problem.  If its not, then change your options one at a time back to what they were pre-reset until you find the gremlin.

Are you running the headphones out of a remote btw, or out of the main unit?
Title: Re: Recording Enhancements Pack
Post by: lurker on June 21, 2006, 09:00:49 PM
Have you tried resetting your settings to clean the slate then changing only the 'show recording screen on start up'?  Let us know if that is still demonstrating the same problem.  If its not, then change your options one at a time back to what they were pre-reset until you find the gremlin.

Are you running the headphones out of a remote btw, or out of the main unit?

I'm running sw 060604-1858

I went into "Manage Settings|Reset Settings" and did a play to reset. However, even after the reset, and powering off and back on, my h140 still enters the recording screen and the mic. gain is still set to what I set it to. So, why did my "Reset Settings" not clear the Recording Screen at Startup and my mic. gain? (I really did try to RTFM, to try and reset settings by holding down a button at startup, but I couldn't find what button to hold and I tried a bunch to no avail... do I need to delete some file to reset settings?)

Regarding the headphones coming from the remote or main unit, I get the same behavior from both.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on June 22, 2006, 03:24:19 AM
When rockbox asks you to press play (when resetting) it means click the joystick in. To reset at startup just press the on button to start and then hold down the record button (it will say "cleared" in the centre of the screen.
Title: Re: Recording Enhancements Pack
Post by: lurker on June 22, 2006, 09:34:31 AM
When rockbox asks you to press play (when resetting) it means click the joystick in. To reset at startup just press the on button to start and then hold down the record button (it will say "cleared" in the centre of the screen.

Ah... worked great, thanks. Note that Page 12 of the latest PDF manual for the iriver shows a picture and both in the picture and text, Play is the button above Stop and the joystick press is Select.

Back to the issue at hand...

After doing a reset, if I change ONLY "Show Recording Screen on Startup" to "yes" then power off and back on, I have the exact same problem (except I'm obviously using the internal mic instead of my external mic).

So, on my h140, reset to default, change "Show Recording Screen on Startup" to "yes". Every subsequent power on requires me to press Stop then Play to exit and re-enter the recording screen before any audio comes from the headphones. Happens both on the remote and main unit.

Is no one else with a h120/h140 seeing this with the REP sw build I'm using? Again, it's build 060604-1858. Is there a newer REP build one I should be running?

I may be able to get access to another h140 to try, if the concensus is that it might be my hardware.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on June 22, 2006, 12:51:12 PM
Note that Page 12 of the latest PDF manual for the iriver shows a picture and both in the picture and text, Play is the button above Stop and the joystick press is Select.
Ooh, That'll have to be changed then! :) Febs!!! Top right is the On/Pause button joyclick is Play/Select.

Quote
Back to the issue at hand...

After doing a reset, if I change ONLY "Show Recording Screen on Startup" to "yes" then power off and back on, I have the exact same problem (except I'm obviously using the internal mic instead of my external mic).

So, on my h140, reset to default, change "Show Recording Screen on Startup" to "yes". Every subsequent power on requires me to press Stop then Play to exit and re-enter the recording screen before any audio comes from the headphones. Happens both on the remote and main unit.

Is no one else with a h120/h140 seeing this with the REP sw build I'm using? Again, it's build 060604-1858. Is there a newer REP build one I should be running?

I may be able to get access to another h140 to try, if the concensus is that it might be my hardware.

Well I'm using exactly the same build as you so that isn't the problem....

I must say I'm a bit stumped....It seems unlikely to me that it is hardware but it seems to be pointing that way... hmmmm I'll keep thinking about it.

Ps. this thread now has more postings than any other on the whole forum!! wow! :o
Title: Re: Recording Enhancements Pack
Post by: lurker on June 22, 2006, 02:19:50 PM
Well I'm using exactly the same build as you so that isn't the problem....

I must say I'm a bit stumped....It seems unlikely to me that it is hardware but it seems to be pointing that way... hmmmm I'll keep thinking about it.

Ok, I was able to try a virgin h140 just off ebay. Loaded the bootloader and loaded REP rockbox build from my hard drive and it worked?!? Then, I looked at the version and saw it was an OLD REP version, 060506-1452. This version was from May and didn't include digital input (which I don't care about anyway). However, the important thing to note is that it worked fine (i.e. I immediately got audio from the headphones on powerup without having to press Stop/Play to exit/re-enter the recording screen).

So, I then downloaded 060604-1858 from Mmmm's sig, and when I boot it up, I get exactly the same broken behavior described earlier in this thread.

So, now I'm curious what changed between the builds to cause this? Because these builds were built at different times from different patched sources, is it true that diff-ing the source from the two builds is near impossible to see what's going on? If not, I'm game if someone can point me to the correct places in the souce tree & patches. Alternatively, if anyone has the two source trees for these builds, I'd love an email of them (PM me if you're willing to send them).

Mmmm, do you have an h120/h140 or have your tests which worked been on another iriver model?
Title: Re: Recording Enhancements Pack
Post by: petur on June 22, 2006, 05:32:21 PM
I know this is the REP thread, but could you *please* test with the latest CVS build as well? Just to figure out if this is related to a patch included in the REP

thanks
Title: Re: Recording Enhancements Pack
Post by: lurker on June 22, 2006, 07:36:57 PM
petur: good point.

I loaded CVS-060622 (todays bleeding edge), reset settings, set "Show Recording Screen on Startup" to "yes". After powerdown and restart, recording screen is enterred but no audio from headphones. I must press Stop and Play to enable audio from headphones.

<edited post>

Ok, I've configured the dev environment and have downloaded the latest CVS code, built it, and I have the problem. I will try and play with it this weekend since (I think) I understand what gets called when and it doesn't look like there's that much that could go wrong. Will report back if/when I have any new information.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on June 23, 2006, 08:26:06 AM
Some of you will be pleased to hear that I've finally fixed the bug in my build (not in the REP) with the joyclick patch (where when clicking, it did a double select in menus)...

I have also added Rincewind's patch for customising the record button (to the REP and my build).

And of course my build is up to date with current CVS now too (with a date stamp just for Dunno ;)).
See post#1 as usual for all updated stuff  :)

EDIT: just a few afterthoughts... ;)
Title: Re: Recording Enhancements Pack
Post by: lurker on June 23, 2006, 12:57:17 PM
ok, I tracked down my no audio if "Show Recording Screen on Startup" set to "yes" problem. Turns out that it appears the HW seems to need a kick that it's not getting before jumping to the recording screen. At least this is true for the current CVS version on two units I have access to. Anyway, the patch was trivial and is attached (it's a one-liner). I've submitted it for inclusion in CVS.

Mmmmm, any possibility of getting it included in your REP build?

If not, anyway for me to get a zip of your REP patches and I'll apply it to the current CVS, now that I can build  ;D

[attachment deleted by admin, too old]
Title: Re: Recording Enhancements Pack
Post by: Mmmm on June 23, 2006, 02:11:29 PM
ok, I tracked down my no audio if "Show Recording Screen on Startup" set to "yes" problem. Turns out that it appears the HW seems to need a kick that it's not getting before jumping to the recording screen. At least this is true for the current CVS version on two units I have access to. Anyway, the patch was trivial and is attached (it's a one-liner). I've submitted it for inclusion in CVS.

ooh, well done...It's a bit weird that you have this problem on two units and  (if everyone's silence is anything to go by) nobody else has this problem at all isn't it? ???.

Quote
Mmmmm, any possibility of getting it included in your REP build?

If not, anyway for me to get a zip of your REP patches and I'll apply it to the current CVS, now that I can build  ;D

You can find the REP patch in post#1 of this thread... :)
Title: Re: Recording Enhancements Pack
Post by: petur on June 23, 2006, 04:01:10 PM
ok, I tracked down my no audio if "Show Recording Screen on Startup" set to "yes" problem. Turns out that it appears the HW seems to need a kick that it's not getting before jumping to the recording screen. At least this is true for the current CVS version on two units I have access to. Anyway, the patch was trivial and is attached (it's a one-liner). I've submitted it for inclusion in CVS.

The 'fix' looks not like a fix. I bet that if you'd replace that code with a sleep(), it would act the same.

Still, I don't understand the problem in the first place. And if the sleep fixes it, something seems to be started too soon?
Title: Re: Recording Enhancements Pack
Post by: lurker on June 23, 2006, 04:37:18 PM
petur: you're right. Since this is clearly not REP related anymore, I've taken my response over to my patch comments in Flyspray. Please take a look when you get a chance, I'm hoping you have additional insight into the problem. Thanks to all for your patience on this.
Title: Re: Recording Enhancements Pack
Post by: paulheu on June 25, 2006, 10:37:39 AM
Anyone heard anything from vinylIvo recently? I'd like to see and update to the histogram patch to go with the current AGC build.. I kinda miss the pretty pictures..;)
Bump.. anyone?!
Title: Re: Recording Enhancements Pack
Post by: rickeyjt on June 25, 2006, 10:22:59 PM
File dates are the build date e.g., 060623 = 6/23/2006 2:35 AM.

Maybe someone could write in a way to see the build date on the recording screen and allow you to change it there, along with the time.  Use the joystick to go down to a date line and set the date/time for your recording.

 
Title: Re: Recording Enhancements Pack
Post by: jaybeee on June 26, 2006, 02:34:19 AM
Another feature request for the Recording Enhancements Pack:
I think a great enhancement to the 'recording' (or 'sleep timer'?) functionality would be to allow recording with a timer.  Say I want to record a radio broadcast at night, I have to leave the player running all night which on my 20gb model normally fills it up (depending on when it is started & stopped).  Whilst that isn't much of a biggy really, to allow the recording to be stopped (cleanly of course) when the sleep timer has finsihed counting down, would be just magic   ;D

Is it possible?
Title: Re: Recording Enhancements Pack
Post by: Llorean on June 26, 2006, 02:42:09 AM
Or perhaps a filesize and time-limit cap (with an option to split or stop recording when the cap is reached).
Title: Re: Recording Enhancements Pack
Post by: jaybeee on June 26, 2006, 02:53:19 AM
Or perhaps a filesize and time-limit cap (with an option to split or stop recording when the cap is reached).
Yep, the time-limit cap would be useful. Just a different way to a achieve the same thing; like it  ;)
Title: Re: Recording Enhancements Pack
Post by: Llorean on June 26, 2006, 02:57:52 AM
I think a time limit AND a file size cap would be useful.
Say you're making recordings in MP3 (once that's supported) or just don't know how long a 700mb WAV is off the top of your head, and want to make files that split at CD length (not audio-CD, data-CD) for archiving. Easy with a autosplit at filesize option. :)
Title: Re: Recording Enhancements Pack
Post by: jaybeee on June 26, 2006, 03:09:41 AM
I think a time limit AND a file size cap would be useful.
Say you're making recordings in MP3 (once that's supported) or just don't know how long a 700mb WAV is off the top of your head, and want to make files that split at CD length (not audio-CD, data-CD) for archiving. Easy with a autosplit at filesize option. :)
Having that as an option I can see being useful.  For me I'd probably not use the size split, but as you say, and I agree, it would be a handy option for people.  Nice thinking Llorean
Title: Re: Recording Enhancements Pack
Post by: Llorean on June 26, 2006, 03:12:13 AM
It's most useful with VBR formats like any of the lossless compressed ones where you can't predict filesize by playback time.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on June 26, 2006, 08:59:22 AM
Anyone heard anything from vinylIvo recently? I'd like to see and update to the histogram patch to go with the current AGC build.. I kinda miss the pretty pictures..;)
Bump.. anyone?!

Well, I've merged his histogram patch with batt/balance meters into the REP So pretty pictures are with us once more :D

Unfortunately the screen real estate is getting a bit thin on the ground and using larger fonts is getting to be impossible on the H1xx (you can just about fit in a font with height of 10 now)....you lucky H3xx owners you with your big screen...... ;)

Patch/build/new screenshots in post#1
Title: Re: Recording Enhancements Pack
Post by: Mmmm on June 27, 2006, 06:12:49 AM
Or perhaps a filesize and time-limit cap (with an option to split or stop recording when the cap is reached).

So Jaybee and Llorean, I have made a patch which I have attached and it is also on the tracker. Not in the REP yet but it will be.... So Jaybee no more filling your player with rubbish all night! :)

These are the filesize split points I have used...any obvious ones I have missed? (2GB is max file size anyway so it automatically splits there).
off,5MB,10MB,15MB,30MB,60MB,75MB,90MB,100MB,200MB,400MB,650MB,700MB,
1GB,1.5GB,1.75GB

http://www.rockbox.org/tracker/task/5605 (http://www.rockbox.org/tracker/task/5605)

[attachment deleted by admin, too old]
Title: Re: Recording Enhancements Pack
Post by: paulheu on June 27, 2006, 07:48:48 AM
There's a problem when  using black backgrounds as the font color is always black..

Replacing lcd_set_foreground(LCD_DEFAULT_FG) with lcd_set_foreground(global_settings.fg_color) works for me.. (in recording.c)
Title: Re: Recording Enhancements Pack
Post by: jaybeee on June 27, 2006, 09:13:42 AM
Or perhaps a filesize and time-limit cap (with an option to split or stop recording when the cap is reached).

So Jaybee and Llorean, I have made a patch which I have attached and it is also on the tracker. Not in the REP yet but it will be.... So Jaybee no more filling your player with rubbish all night! :)

These are the filesize split points I have used...any obvious ones I have missed? (2GB is max file size anyway so it automatically splits there).
off,5MB,10MB,15MB,30MB,60MB,75MB,90MB,100MB,200MB,400MB,650MB,700MB,
1GB,1.5GB,1.75GB

http://www.rockbox.org/tracker/task/5605 (http://www.rockbox.org/tracker/task/5605)
great stuff Mmmm  ;D

Couple of things:
(1) do you think the alternative option to specify a time to stop recording could be achieved? Without vbr recording (i.e. just wav) this option would be relevant and useful.
(2) With your current code, how would I ask my player to stop after say 2.5gb? (that would be approx 2 1/2 hrs with 44.1khz using normal line in). I know that a file will split after 2gb, so 2.5gb couldn't be achieved, BUT then it looks as if it can only ask for the max 2gb to be recorded then stop the player - or am I missing something?

thanks
Title: Re: Recording Enhancements Pack
Post by: Mmmm on June 27, 2006, 09:36:03 AM
Couple of things:
(1) do you think the alternative option to specify a time to stop recording could be achieved? Without vbr recording (i.e. just wav) this option would be relevant and useful.

Do you mean the time as in 2.15pm type of thing? you can't do this on the H120 as is doesnt have a clock! My pach allows you to tell it to stop recording after a set amount of time.

Quote
(2) With your current code, how would I ask my player to stop after say 2.5gb? (that would be approx 2 1/2 hrs with 44.1khz using normal line in). I know that a file will split after 2gb, so 2.5gb couldn't be achieved, BUT then it looks as if it can only ask for the max 2gb to be recorded then stop the player - or am I missing something?

thanks
You want more? how far do you want to go? ;)
I thought 2GB is about 3 hrs 25 mins of wav recording (if 10mb = 1 min) - isn't that right? Also the way I have done it it will only split at 2GB so the max for stopping at the mo is only 1.75 GB... I could change that relatively easily though...I would need to have a 'no split' option in 'split measure' though or people would be very annoyed if they had forgotten they had it set to stop and it stopped after 2GB (even with both time and size set to off) eh? :D
Title: Re: Recording Enhancements Pack
Post by: Llorean on June 27, 2006, 09:48:58 AM
I think he meant "Record 1 hour of audio" type of thing. Not a specific time to cut off, but rather a duration limit as an alternative choice to a filesize limit. While the two directly correlate in CBR formats (which is all we support right now) with VBR ones, duration and filesize aren't so closely linked.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on June 27, 2006, 09:53:02 AM
I think he meant "Record 1 hour of audio" type of thing. Not a specific time to cut off, but rather a duration limit as an alternative choice to a filesize limit. While the two directly correlate in CBR formats (which is all we support right now) with VBR ones, duration and filesize aren't so closely linked.
Unless I'm really misunderstanding, my patch already does this...In fact the cvs version allows you to specify a time for a split too..my patch adds a stop option and a filesize option (adds not replaces) which you can use in any combination.  ???
Title: Re: Recording Enhancements Pack
Post by: Llorean on June 27, 2006, 10:00:04 AM
I was just putting forth my input as to what I think he was trying to ask.

But isn't the current time split option only capable of splitting after a certain period of time, not halting recording?
Title: Re: Recording Enhancements Pack
Post by: Mmmm on June 27, 2006, 10:06:03 AM
 :D Yep...and my patch adds the ability to stop the recording....
so you can have:

stop recording after 1 hour
Or
start a new file after 2 hours
Or
stop recording after 650MB
Or
start a new file after 700MB
etc etc...



Sorry...it's probably that I wasn't really being clear about what it does...I'm like that when I get excited about having written a bit of code! :D
Title: Re: Recording Enhancements Pack
Post by: Llorean on June 27, 2006, 10:17:08 AM
Alright, so with your patch it meets all the requests. :)
Yeah, it wasn't clear that yours added the option to stop for time, instead of just splitting for time. Sounds great.
Title: Re: Recording Enhancements Pack
Post by: jaybeee on June 27, 2006, 12:13:21 PM
 :D

It seems you two figured out what I was trying to say without me having to explain, te he

And yes, it's basically as Llorean said. Cos your first post about the patch didn't mention time splits.  All I was trying to get at was: if I want to record something that is 4 hours long, I know at the moment that will create one 2gb file being about 3hrs 22mins long, and then a second file being 38mins long; so I was just trying to see if asking the player to record me 4hrs then stop was possible.  Seems it is  :-*  ;D

--

I like the option about startng a new file after a certain time too.

--

I guess with the feature freeze still on, this isn't gonna get commited anytime soon. Trouble is, I've never added a patch into the package before, so might not be able to test it.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on June 27, 2006, 01:00:39 PM
Don't worry jaybee....eventually (probably tomorrow) I'll put it in the REP and you can download a patched build from my sig if you want...I'll post here once I've done it :)

Quote
I like the option about startng a new file after a certain time too.
You can do this already without the patch! it's called timesplit!!!  ::)
Title: Re: Recording Enhancements Pack
Post by: jaybeee on June 27, 2006, 01:43:54 PM
Quote
I like the option about startng a new file after a certain time too.
You can do this already without the patch! it's called timesplit!!!  ::)
:-[ lol
yes i did know that. What an idiot lol
thanks in advance for the patched build  ;D
Title: Re: Recording Enhancements Pack
Post by: Mmmm on June 27, 2006, 03:20:28 PM
Quote
I like the option about startng a new file after a certain time too.
You can do this already without the patch! it's called timesplit!!!  ::)
:-[ lol
yes i did know that. What an idiot lol
thanks in advance for the patched build  ;D

 :D lol....

I've put it in now so you can use the build in my sig (if you have an H120/H140) or the patch is in post#1 as per usual...:)
Tell me if there is anything you would like improved...and I'll think about it ;)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on June 27, 2006, 03:34:08 PM
There's a problem when  using black backgrounds as the font color is always black..

Replacing lcd_set_foreground(LCD_DEFAULT_FG) with lcd_set_foreground(global_settings.fg_color) works for me.. (in recording.c)

hmmm I remember you saying this before, and I seem to remember that this breaks the h1xx build (as it doesn't have a colour screen) so maybe a bit of preprocessing magic is needed eh?

something like:

    lcd_set_foreground(
#ifdef HAVE_LCD_COLOR
    global_settings.fg_color);
#else
    LCD_DEFAULT_FG);
#endif

or something?
Title: Re: Recording Enhancements Pack
Post by: paulheu on June 27, 2006, 04:25:27 PM
That should work I guess..
Title: Re: Recording Enhancements Pack
Post by: NorTheBear on June 28, 2006, 08:11:47 AM
Hello,

I am just wondering if it is possible to enhance the split functionality with a configurable option to do file splits on-the-fly by pressing a key while recording and listening to the source at the same time.

This would be a time saver for all those persons (like me) who merely want to split a recorded live show into single songs while listening to the show. I hate it when it comes to sit in front of a computer scanning a 1 or 2 GB audio file and to manually set the "cut points".

Thank you for considering and keep up the great work.

Best, Norbert.
Title: Re: Recording Enhancements Pack
Post by: Llorean on June 28, 2006, 08:14:34 AM
I thought there was already a button to trigger a manual split. Wasn't there?
Title: Re: Recording Enhancements Pack
Post by: Mmmm on June 28, 2006, 09:02:57 AM
This is already in the REP....see post#1 in this thread
Title: Re: Recording Enhancements Pack
Post by: jaybeee on June 29, 2006, 03:59:51 PM
@Mmmm: I installed your rockbox build today and tried out the REP for the first time.  The screen looks cool and so are the other setting options.  Great work fella.

One problem though: when I started to record it displayed a message saying 'low disk space'.  I didn't understand why cos there was 12gb free (I've got a H120 [20gb]).  So I thought I'd just carry on, but after 11mins it turned itself off.
The settings used were to use time split of 2hrs with source being line-in.

I installed the latest offical Rockbox daily build and recorded my tape no problems just now.

So I guess it must be something in your code that has interrogated my disk space, thought there was not much left (must've though it was really low to only allow ~11mins), and stopped recording when it reached it's apparent critical level.

---

One other thing: when on digital source, the scroll bar that you move up & down to the various options; well there's a gap (where the gain is normally placed for line-in) and when scrolling down the scroll bar disappears and to then reappears once it's past those 'imaginary' gain lines.
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on June 29, 2006, 05:36:50 PM
jaybeee: Rescan your disk. Off the top of my head its in debug > disk info > free space, click your joystick.

This problem usually occurs when you delete files via windows explorer.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on June 30, 2006, 03:24:20 AM
@Mmmm: I installed your rockbox build today and tried out the REP for the first time.  The screen looks cool and so are the other setting options.  Great work fella.

One problem though: when I started to record it displayed a message saying 'low disk space'.  I didn't understand why cos there was 12gb free (I've got a H120 [20gb]).  So I thought I'd just carry on, but after 11mins it turned itself off.
The settings used were to use time split of 2hrs with source being line-in.

I installed the latest offical Rockbox daily build and recorded my tape no problems just now.

So I guess it must be something in your code that has interrogated my disk space, thought there was not much left (must've though it was really low to only allow ~11mins), and stopped recording when it reached it's apparent critical level.

Yeah, what whatboutbob said except its in  info > rockbox info and you have to press the on button.

It's something to do with windows and reporting filesize and it telling the player what the filesize is and getting it wrong or so I've been told. It only happens with the REP because it includes a safety feature courtesy of Vinylivo, that checks the remaining diskspace so that it doesn't just record right off the end and cause probs.
---
Quote
One other thing: when on digital source, the scroll bar that you move up & down to the various options; well there's a gap (where the gain is normally placed for line-in) and when scrolling down the scroll bar disappears and to then reappears once it's past those 'imaginary' gain lines.
Ahh, well spotted! I hadn't noticed that, thanks! I'll fix it sometime...something to do with the AGC patch I think...
Title: Re: Recording Enhancements Pack
Post by: jaybeee on June 30, 2006, 06:02:27 AM
Yeah, what whatboutbob said except its in  info > rockbox info and you have to press the on button.
So it is.  A 'hidden' feature! cos that info page gives no indication that a scan disk can be performed.  All sorted now. I'm gonna be recording some stuff tonight, so I'll test out the REP later  ;)
Title: Re: Recording Enhancements Pack
Post by: Febs on June 30, 2006, 08:07:36 AM
Maybe it would be a good idea either to scan the disk space automatically when recording is started, or at least to duplicate the scan option on the recording settings screen so that it is easy to update.
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on June 30, 2006, 07:50:14 PM
Maybe it would be a good idea either to scan the disk space automatically when recording is started, or at least to duplicate the scan option on the recording settings screen so that it is easy to update.

...or auto-scan when entering the recording screen (it can take a while to scan).  Quite a few people (myself included) have been caught out by this now.
Title: Re: Recording Enhancements Pack
Post by: Llorean on July 01, 2006, 01:39:52 AM
I think auto-scanning when entering the recording screen would be somewhat irritating, especially if your disk space *is* correct, and you wanted to make a quick recording of something.

If it's going to auto-scan, that should be optional, but I think there should be at least a "Verify Free Space" or something in the recording menus.
Title: Re: Recording Enhancements Pack
Post by: jaybeee on July 01, 2006, 03:01:44 AM
^^ yep agree. Make it an option in the menu. An option to run every time you enter the recording screen or not. And an option to simply run it when required.
Title: Re: Recording Enhancements Pack
Post by: petur on July 01, 2006, 05:58:34 AM
quick remark: the 'unboosted recording' changes have been committed, so for analog recording (mic and line-in) the cpu runs at a much lower speed. spdif should still run at full speed. The cpu is boosted while writing to disk.

the remarks I have:
- I did not actually test with spdif as I don't have an h1x0, but it should function as before (but test it nonetheless)
- I have not tested the impact of this change when you use other fancy recording stuff like the graphics and stuff. It is tested only with AGC active.

As posted before, this change got me 12h continuous recording from line-in on my h340...
Title: Re: Recording Enhancements Pack
Post by: petur on July 03, 2006, 02:35:15 AM
sorry to break patches again ;)

I committed part of the changes jvo made for AGC, namely the better sample -> dB calculation for (amongst others) the peakmeter
Title: Re: Recording Enhancements Pack
Post by: Rincewind on July 03, 2006, 04:30:24 PM
Mmmm, the next time you update your build, you should put the newest version of my rec button patch in, it fixes a very nasty freezing bug that was in the last version.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on July 04, 2006, 03:27:57 AM
Cheers Rincewind..I'll do that and I'll tiptoe around the minefield of conflicts Petur has created too :D ;)
Title: Re: Recording Enhancements Pack
Post by: petur on July 04, 2006, 05:06:38 AM
:p

Actually, it shouldn't give many conflicts....
Title: clipping light is always on...
Post by: davehouse on July 04, 2006, 03:27:28 PM
Hiya,

Firstly, nice one to everyone involved in rockbox and its enhancements, especially the recording enhancements pack. I bought my H120 specifically for recording and have been very impressed with the capabilities that rockbox brings and the support available!

So, on to my query, and apologies if it's been covered before in the depths of this forum!

Basically, I have the clipping light enabled (useful feature) but it seems to stay on permanently when in the recording screen. This only started happening after I'd changed themes, so I swapped back to the previous one, but the light remained on while recording. I've tried recording with every input source and they're all doing it, and rest assured none of them are actually peaking!

Any ideas whats going on?! I'm assuming its a setting somewhere... Its gonna drain my battery at this rate apart from anything else!
Title: Re: Recording Enhancements Pack
Post by: Mmmm on July 04, 2006, 03:53:28 PM
Do you mean it's on as soon as you go into the screen or it clips and then stays on forever? are there two little black boxes to the far right of the peakmeter or just a vertical line?
Title: Re: Recording Enhancements Pack
Post by: davehouse on July 04, 2006, 04:11:32 PM
it clips then stays on forever. There's the black boxes to indicate its clipped. I've just noticed that the black boxes dissapear after a minute or so, after which the light goes out. So its staying on for the duration of the time the peak is indicated on screen, right? Is this how the softwares designed? If so, is there a way of altering the length that the peak is indicated for?

Cheers
Title: Re: Recording Enhancements Pack
Post by: Mmmm on July 04, 2006, 04:13:22 PM
it clips then stays on forever. There's the black boxes to indicate its clipped. I've just noticed that the black boxes dissapear after a minute or so, after which the light goes out. So its staying on for the duration of the time the peak is indicated on screen, right? Is this how the softwares designed? If so, is there a way of altering the length that the peak is indicated for?

Cheers
You've got it! there is a setting...it's here:
mode->general settings->display>peakmeter->peak hold time
Title: Re: Recording Enhancements Pack
Post by: davehouse on July 04, 2006, 04:16:43 PM
 :) excellent! Thanks a lot. And good work on the development pack. I'm loving how customizable my little toy is!!
Title: Re: Recording Enhancements Pack
Post by: Mmmm on July 05, 2006, 05:39:45 AM
Synced with latest CVS and Rincewind's update is included...

No conflicts at all Petur!!! What you put in must have exactly fitted the patch! :D
Title: Re: Recording Enhancements Pack
Post by: amoergosum on July 05, 2006, 06:08:07 AM
Synced with latest CVS and Rincewind's update is included...

No conflicts at all Petur!!! What you put in must have exactly fitted the patch! :D

Mmmmh---
how did you manage to add this second player on myspace.com?
Can you give me instructions on how to do that?
best,
Ben
Title: Re: Recording Enhancements Pack
Post by: Mmmm on July 05, 2006, 07:34:09 AM
I've fixed the fonts patch as it stopped working properly (not enough brackets in an if statement ::) )

I've also improved the fonts patch so now it takes into account the mode you are recording in (so maxfont size for spdif > maxfont size for internal mic > maxfont size for line in) and when you change mode your font may change if it fits in that particular mode.
Also the histogram patch now takes this into account too (with the showing (or not) of the batt/bal/disk display)

And I've fixed the display problem reported by Jaybee (thanks) when in digital mode... now everything is running smoothly again

Great.....  ;D

Post#1 for patch and build....  ;)

amoergosum: bit of an inappropriate place to post that don't you think? 
Try THIS (http://www.scenenetworks.com/MYsPLAYERmyspaceinternethtmlmusicplayerradio-08312006.html?PHPSESSID=51e01850e571c9379e7433a84c6bf465) out....Not how I did it, but probably the easiest way!
PS. why havent you done a friend request eh? ;)
Title: Re: Recording Enhancements Pack
Post by: petur on July 05, 2006, 08:49:22 AM
now everything is running smoothly again
Does that mean that AGC + histogram has enough cpu power in unboosted operation (line-in / mic)? I guess you tested it ;)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on July 05, 2006, 09:29:25 AM
now everything is running smoothly again
Does that mean that AGC + histogram has enough cpu power in unboosted operation (line-in / mic)? I guess you tested it ;)

Well...it appears to be ok....but I dont really know what sort of thing to look for..
dropouts or something else?
Sound is ok on a quick 1min recording....my record button patch works fine which means the buffer is ok and it can write a new file at the same time as recording (it's still seamless).... What else might go wrong?
Title: Re: Recording Enhancements Pack
Post by: petur on July 05, 2006, 12:56:58 PM
yes, dropouts or the recording stopping completely due to buffer overruns.

Maybe I should add some kind of performance counter like the audio thread has
Title: Re: Recording Enhancements Pack
Post by: Mmmm on July 05, 2006, 04:42:06 PM
yes, dropouts or the recording stopping completely due to buffer overruns.

Ok..I suppose I should test it over a longer period eh?

Maybe I should add some kind of performance counter like the audio thread has
Sounds like a good idea!

I have slightly adjusted the new patch so that you poor H3xx owners without the lovely spdif connection can also use it...:)

Damn them and their large 'customisable font' friendly screen...... ;)
Title: Re: Recording Enhancements Pack
Post by: paulheu on July 07, 2006, 07:10:55 PM
the H3x0 experimental build (see post#1) has been update using the latest RecEnh patch..

so there..
Title: Re: Recording Enhancements Pack
Post by: Techy_Bloke on July 12, 2006, 08:42:47 AM
why is it that nowhere to be found is the ability to change from MP3 or WAV and the selectable Bitrate that u want to record at ??
Title: Re: Recording Enhancements Pack
Post by: Febs on July 12, 2006, 09:12:22 AM
Because Rockbox on irivers currently only supports .wav recording, so there is no bitrate to select.
Title: Re: Recording Enhancements Pack
Post by: kuuan on July 18, 2006, 06:31:59 AM
as for now,  ;D,...GMT 11:40 on 18/07/2006...
which Rockbox + Recording enhancement pack best to install?
( nothing installed yet, the H120 due to arrive tomorrow or the day after and can't get no sleep any more... )
Title: Re: Recording Enhancements Pack
Post by: Mmmm on July 18, 2006, 07:07:50 AM
which Rockbox + Recording enhancement pack best to install?
Out of what?

CVS rockbox and the patch in post#1... I think... Unless I misunderstand your question
Title: Re: Recording Enhancements Pack
Post by: kuuan on July 18, 2006, 10:04:05 PM
oops, since it is ever evolving I thought later updated versions were to be downloaded from later posts...

thank you Mmmm
Title: Re: Recording Enhancements Pack
Post by: Techy_Bloke on July 19, 2006, 01:29:37 AM
Because Rockbox on irivers currently only supports .wav recording, so there is no bitrate to select.

so would this be right...

(http://img90.imageshack.us/img90/7913/iriverrecordar6.jpg)

i thought there was something wrong with my software install...

i can only pretty much record in full .wav quality... and it wont turn off and it wont stop after a certain amout of time / data ??  also the side record button doesnt access anything i have to goto record through the menu...
Title: Re: Recording Enhancements Pack
Post by: pupil on July 19, 2006, 04:50:28 AM
Oooooooh, feature freeze now lifted, so everyone get pestering the devs (specifically petur) to commit the REP patches to Rockbox! Would be awesome to get the AGC, Histogram and Track Split patches commited :)

And SID support is commited now too, yay! (not related to REP, but hey, SID's rule!)
Title: Re: Recording Enhancements Pack
Post by: yngwi on July 19, 2006, 05:31:31 AM
SID's rule!

Aye!
Title: Re: Recording Enhancements Pack
Post by: Mmmm on July 19, 2006, 05:41:30 AM
Oooooooh, feature freeze now lifted, so everyone get pestering the devs (specifically petur) to commit the REP patches to Rockbox!
HAHA..no more need to pester...I've got CVS access.....So lets see what can be committed eh? :D
Quote
And SID support is commited now too, yay! (not related to REP, but hey, SID's rule!)
What is SID?
Title: Re: Recording Enhancements Pack
Post by: yngwi on July 19, 2006, 06:05:55 AM
The "SID-Chip" is the sound Chip of the C64 computer, and SID or *.sid specifies sound files for that chip.
that means, with rockbox, you can now listen to your favourite C64 Tunes!

If interested, check out the High Voltage Sid Collection at http://www.hvsc.c64.org/

Title: Re: Recording Enhancements Pack
Post by: pupil on July 19, 2006, 06:37:51 AM
Oooooooh, feature freeze now lifted, so everyone get pestering the devs (specifically petur) to commit the REP patches to Rockbox!
HAHA..no more need to pester...I've got CVS access.....So lets see what can be committed eh? :D
Quote
And SID support is commited now too, yay! (not related to REP, but hey, SID's rule!)
What is SID?


GO Mmmm GO!  ;D
Title: Re: Recording Enhancements Pack
Post by: Mmmm on July 19, 2006, 06:56:55 AM
The "SID-Chip" is the sound Chip of the C64 computer, and SID or *.sid specifies sound files for that chip.
that means, with rockbox, you can now listen to your favourite C64 Tunes!

If interested, check out the High Voltage Sid Collection at http://www.hvsc.c64.org/
OH WOW! ....it brings it all back..of course, SID... But hang on.... for it's time it was great but apart from sentimental reasons would I really want to listen to C64 tunes again???
Title: Re: Recording Enhancements Pack
Post by: yngwi on July 19, 2006, 07:24:59 AM
The "SID-Chip" is the sound Chip of the C64 computer, and SID or *.sid specifies sound files for that chip.
that means, with rockbox, you can now listen to your favourite C64 Tunes!

If interested, check out the High Voltage Sid Collection at http://www.hvsc.c64.org/
OH WOW! ....it brings it all back..of course, SID... But hang on.... for it's time it was great but apart from sentimental reasons would I really want to listen to C64 tunes again???

In my opinion:
.) sentimental reasons alone would be more than sufficient to waste ~60MB of Disk space
.) some of the Tunes are pretty good
.) C64, man!
Title: Re: Recording Enhancements Pack
Post by: Mmmm on July 19, 2006, 07:28:13 AM
 LOL :D
Title: Re: Recording Enhancements Pack
Post by: yngwi on July 19, 2006, 07:37:31 AM
LOL :D

yeah, i admit it, thats a pretty nerdy mc nerd attitude! ;-)
Title: Re: Recording Enhancements Pack
Post by: pupil on July 19, 2006, 07:52:36 AM
Nah seriously, Rob Hubbard, one of the greatest composer's EVER! IT's like listening to YMO records, who cares how oldskool electronica they sound, their tunes are amazing.


anyways... REP, yeah :)
Title: Re: Recording Enhancements Pack
Post by: Techy_Bloke on July 19, 2006, 11:36:39 AM
say i want to record in mp3 for 7hrs... (i would use rockbox but uncompressed wav my i river disk space is full...)

i boot up in  the i river software... it says that the recording will stop after 195mb MP3 or longer than 5hrs...

will it split my tracks ?? and keep recording or do i have to run back n restart it?
Title: Re: Recording Enhancements Pack
Post by: petur on July 19, 2006, 12:20:26 PM
Why do you think Rockbox exists? Because the original firmware is crap!

Seriously, the iriver recording code will stop mp3 recording after some time. Depends on bitrate.

Be patient, maybe mp3 encoding will come to Rockbox ;)
Title: Re: Recording Enhancements Pack
Post by: Llorean on July 19, 2006, 12:48:52 PM
I believe there's a way to make lossy recordings in the tracker somewhere. I think searching for Recording Codecs will do it, I'm not sure though.
Title: Re: Recording Enhancements Pack
Post by: adam917 on July 19, 2006, 04:47:05 PM
I believe there's a way to make lossy recordings in the tracker somewhere. I think searching for Recording Codecs will do it, I'm not sure though.
Ogg Vorbis would be a good open source lossy option for Rockbox. Speex is another lossy open source format made for speech. Why not incorporate direct recording to these formats someday?
Title: Re: Recording Enhancements Pack
Post by: petur on July 19, 2006, 05:50:49 PM
Ogg Vorbis would be a good open source lossy option for Rockbox. Speex is another lossy open source format made for speech. Why not incorporate direct recording to these formats someday?

sure, just get us the time and manpower....
Title: Re: Recording Enhancements Pack
Post by: petur on July 19, 2006, 05:58:05 PM
Martin, regarding the AGC: I looked into it and it would be nice to have it for all targets. However, the way it's done now would create another ifdef hell (linuxstb is going to add ipod recording), so I'm going to wait with AGC until recording code is a bit more universal.

Title: Re: Recording Enhancements Pack
Post by: Llorean on July 20, 2006, 01:07:59 AM
Just to bring this topic back up, any of the programming types here feel like having a crack at getting this old patch working: http://www.rockbox.org/tracker/task/2939

Seems to qualify as a "recording enhancement" and all.
Title: Re: Recording Enhancements Pack
Post by: petur on July 20, 2006, 03:00:30 AM
Yes, we should, as there's always somebody asking for it...

Also mono and maybe other bitrates should be implemented in a WAV encoder and loaded just like an mp3 encoder.

We will also need buffer management in order to boost if the encoder can't process quick enough.
(analog recording runs unboosted nowadays)
Title: Re: Recording Enhancements Pack
Post by: Llorean on July 20, 2006, 03:43:35 AM
Actually, I believe one of the later patches for the encoding codecs mentions something about unboosting when it's not necessary. Depending on how it does it, you may just need to reverse the behaviour.

I just wanted to make sure that patch wasn't forgotten, as I often see people asking about the feature, and not knowing the patch even exists. In all the experimental, etc, builds, I don't think I ever saw it included, even when it was up to date. ;)
Title: Re: Recording Enhancements Pack
Post by: petur on July 20, 2006, 04:01:24 AM
Well I'm not very interested as I still have HD space left and would only care about a lossless encoder. Before Rockbox worked on my h340, I always hated the fact that it would only record mp3 and not some better quality.

But I agree it should get included for others who have use for it (recording lectures, ...)

We also need to do the whole rtc alarm stuff so recording can be programmed. But that probably won't be for the h1x0 series as they don't have an rtc (iirc)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on July 20, 2006, 05:03:38 AM
We also need to do the whole rtc alarm stuff so recording can be programmed. But that probably won't be for the h1x0 series as they don't have an rtc (iirc)
No clock on the h1xx but instead of being able to set the time at which it starts recording, how about a countdown timer? So you could set it to start recording in 3 hours time or something. Of course this would only work if the unit was on for those three hours.
Title: Re: Recording Enhancements Pack
Post by: jaybeee on July 20, 2006, 05:50:40 AM
No clock on the h1xx but instead of being able to set the time at which it starts recording, how about a countdown timer? So you could set it to start recording in 3 hours time or something. Of course this would only work if the unit was on for those three hours.
That sounds great. And what would be brilliant would be to have the DAP 'wake' itself up and start recording. That would need a clock which we don't have, BUT I guess there could be a frig that may work something like:
- when the DAP detects that power via the charger has been enabled (use a timer plug to allow electricity to run through the charger at a specificed time), which can be allowed to happen via a setting (default is off)
- the countdown timer could start (or indeed recording could start straight away via a setting)
- then recording could start
- and if the time limit / file size limit has also been enabled, then maybe the DAP could come on at 2am, start recording straight away, and stop after 2hrs.

What d'ya reckon? I have just blurted that out, but food for thought maybe :P
Title: Re: Recording Enhancements Pack
Post by: Mmmm on July 20, 2006, 09:36:41 AM
Martin, regarding the AGC: I looked into it and it would be nice to have it for all targets. However, the way it's done now would create another ifdef hell (linuxstb is going to add ipod recording), so I'm going to wait with AGC until recording code is a bit more universal.

Ahh ok then...In that case I'm going to commit the (newly optimised and CVS ready) record split button patch (after I've compiled it 20 times :D) which will break the AGC patch a bit I think...but that's life I suppose eh? ;)

- when the DAP detects that power via the charger has been enabled (use a timer plug to allow electricity to run through the charger at a specificed time), which can be allowed to happen via a setting (default is off)

What d'ya reckon? I have just blurted that out, but food for thought maybe :P

Hmmm I don't know... maybe... but this would definitely have to be done in the bootloader and that's risky stuff!
Title: Re: Recording Enhancements Pack
Post by: Llorean on July 20, 2006, 11:20:17 AM
I'm not 100% sure the H100 can wake on power, can it?

Wouldn't the optimal solution be to turn off any un-necessary hardware, and slow the CPU down to the minimum speed during whatever countdown?

So you could set it to like, 18 hours, and during that time, until maybe 10 seconds before recording, it's in absolute lowest power mode, then it wakes, wakes all hardware, and prepares to record, then goes.

petur: There is a lossless wavpack codec in that patch I mentioned. ;)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on July 20, 2006, 12:06:40 PM
I'm not 100% sure the H100 can wake on power, can it?

Wouldn't the optimal solution be to turn off any un-necessary hardware, and slow the CPU down to the minimum speed during whatever countdown?

So you could set it to like, 18 hours, and during that time, until maybe 10 seconds before recording, it's in absolute lowest power mode, then it wakes, wakes all hardware, and prepares to record, then goes.

By 'then goes' do you mean then the battery runs out? :D
Title: Re: Recording Enhancements Pack
Post by: Llorean on July 20, 2006, 12:19:54 PM
If you turn off all unnecessary hardware and idle the core at 11 mhz you can probably get a good amount of time.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on July 20, 2006, 05:47:37 PM
Real-time track splitter with filename view is now in CVS... :o
Title: Re: Recording Enhancements Pack
Post by: harpster on July 20, 2006, 11:44:57 PM
I'm a bit confused now as to which Rockbox to download for ideal recording. I've got Mmmm's build from the first post of this topic which I downloaded a few weeks ago. I've been pleased with it. Has that been updated lately? Or, now that some of it is being commited to the CVS, should I download the latest CVS build? Or should I leave well-enough alone and use what I've got?
Title: Re: Recording Enhancements Pack
Post by: Mmmm on July 21, 2006, 04:21:32 AM
CVS doesn't contain everything in the REP yet and I haven't updated my build either so you're probably better off sticking with what you've got until I update, unless there is a new feature added to CVS that you want more than what's in the REP.
Title: Re: Recording Enhancements Pack
Post by: Rincewind on July 21, 2006, 07:28:55 AM
Mmmm, if you consider commiting my record button configuration patch, please wait, I want to clean it up a little bit first.
Unfortunately I don't have much time now, takes possibly 2 weeks until I get round to do it.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on July 21, 2006, 07:50:19 AM
Mmmm, if you consider commiting my record button configuration patch, please wait, I want to clean it up a little bit first.
Unfortunately I don't have much time now, takes possibly 2 weeks until I get round to do it.
Don't worry... it needs cleaning up a bit before it is committed ;)

I'm not sure on the general opinion (in dev world) about the use of the record button yet so I think it may take a bit of discussion there first anyway! :)
Title: Re: Recording Enhancements Pack
Post by: Llorean on July 21, 2006, 12:47:43 PM
I think the general idea is that buttons shouldn't be configurable.
Definitely *all* buttons shouldn't be, because then you can accidentally remove the ability to configure them by changing them too far. At the very least many need to be hard-coded for specific screens.

And in my opinion having one button configurable (especially one with a suggested purpose such as Record) leads to the idea that all of them could be.

I kinda think short-record should go to the recording screen, and long-record, well, we need to come up with something.

Note: These are my personal opinions, and the only part that has come from others is that "We should not allow all buttons to be configurable"
Title: Re: Recording Enhancements Pack
Post by: Rincewind on July 23, 2006, 07:20:48 AM
And in my opinion having one button configurable (especially one with a suggested purpose such as Record) leads to the idea that all of them could be.

I kinda think short-record should go to the recording screen, and long-record, well, we need to come up with something.

Note: These are my personal opinions, and the only part that has come from others is that "We should not allow all buttons to be configurable"

short press of rec to go to recording screen isn't good imho, because if press it accidentally your playback stops etc.

I disagree with you that every button should be hardcoded. Of course almost all buttons have to be fixed so that rockbox can operate, but on units that have extra buttons, why not make them optional to use?
The opinions of how the rec button should be used differ so wildly that I think that everybody is happy if he can choose how he wants to use it.

I don't want to be able to change every button in rockbox on the fly, but it is nice to have a short cut that you can customize.

On your argument "if we do this, users want to have that", that applies to every feature that is added to rockbox.

I make a discussion thread with a poll, so that we can disuss the REP here again.
Title: Re: Recording Enhancements Pack
Post by: Shindig on July 23, 2006, 11:47:11 AM
Is there a way to modify the vu meter's width? It'd be nice if dB numbers were added too, from -20 to +3, for example. 

Edit: The iriver firmware has a feature that let's one do voice activated recordings. Also known as VOX, is there a way this feature could be implemented into this patch. I'd be more than happy to contribute in any way I can.



Title: Re: Recording Enhancements Pack
Post by: Techy_Bloke on July 23, 2006, 11:57:07 AM
that would be handy...

also is there a DB meter as a plugin usuing the internal mic ?? - how accurate is it if ther is such a thing ?
Title: Re: Recording Enhancements Pack
Post by: paulheu on July 24, 2006, 06:18:29 AM
I guess there will be a new patch shortly due to the recent additions to CVS?
Title: Re: Recording Enhancements Pack
Post by: Mmmm on July 24, 2006, 02:09:36 PM
I guess there will be a new patch shortly due to the recent additions to CVS?
I must admit that I am in the process of completely destroying the REP by committing it all... ahhh haah haaa haah haaa....

umm yeah.... now that I think I have committed all the REP I'm going to commit, I might make a new patch. Or I might start looking at AGC while Petur's away :D
Title: Re: Recording Enhancements Pack
Post by: paulheu on July 28, 2006, 11:47:18 AM
I guess there will be a new patch shortly due to the recent additions to CVS?
Any news here?  ;)
Title: Re: Recording Enhancements Pack
Post by: pupil on July 30, 2006, 06:03:30 AM
I guess there will be a new patch shortly due to the recent additions to CVS?
I must admit that I am in the process of completely destroying the REP by committing it all... ahhh haah haaa haah haaa....

umm yeah.... now that I think I have committed all the REP I'm going to commit, I might make a new patch. Or I might start looking at AGC while Petur's away :D

Have you managed to commit all of the REP components to CVS yet Mmmm? I'm holding off from using the current CVS untill things like AGC/Histogram etc are commited, but am really looking forward to get to try out the other new CVS features since I haven't updated since April.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on July 30, 2006, 07:14:46 AM
Have you managed to commit all of the REP components to CVS yet Mmmm? I'm holding off from using the current CVS untill things like AGC/Histogram etc are commited, but am really looking forward to get to try out the other new CVS features since I haven't updated since April.
I've done everything except fonts, AGC and histogram I'm afraid...Petur said the AGC isn't useable on all targets and so needs some looking into... Maybe i'll look into it..... I sort of keep getting side tracked!
Title: Re: Recording Enhancements Pack
Post by: ALJ on July 30, 2006, 10:38:15 AM
I can only affirm that the AGC is something that is sought after, and would be highly appreciated if it'd be included anywhichway and how !?!?
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on July 30, 2006, 04:39:36 PM
I have to re-iterate and agree with ALJ... AGC is a fantastic feature that I consider invaluable.
But it should be a Rockbox feature and not just a "RockRiver" feature.

I for one am willing to wait (or use your REP build from 20060705) until the code is portable to mutiple targets (people with iAudio units will be interested for sure)

To anyone who needs AGC right now you can just use Mmmm's R.E.P. build from here
http://homepage.ntlworld.com/martin.scarratt/Rockbox/rockbox.zip
or Pilot000's build from here
http://homepage.sunrise.ch/mysunrise/remartinelli/rockboxH120.zip

Title: Re: Recording Enhancements Pack
Post by: Techy_Bloke on July 30, 2006, 09:24:06 PM
G'day,

through the weekend i did some line in recording...

for a 3hrs 22min 9sec uncompressed wave file it is 1.99gb 

and then it gets auto split and starts 002...

quality is ausome just make sure u set your input levels properly.... bit before 0db...

Battery was on 15hrs - nearly full  - recorded non stop  for  7hrs 57 and 44secs and then had 1hr of battery left on it...  and died during playback

Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 03, 2006, 05:13:28 AM
I have finally got around to doing it (and it was no small job - I did a really good job of breaking it! :D)

Now post#1 has all the updated files/builds.
Title: Re: Recording Enhancements Pack
Post by: paulheu on August 03, 2006, 09:45:24 AM
Thanks! I started doing it myself, but as you said it was quite broken ;^)

I have a new experimental build up for iRiver H3x0. check here (http://www.misticriver.net/showthread.php?t=38915&page=5) for more info..
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on August 03, 2006, 10:05:05 AM
Hello Mmmm,

I was wondering if you could also upload a zip of the source of your REP builds for H120 targets.
That way I could include the 300remotekeys patch and the disktidy patch.
I have very little coding experience but would like to attempt to maintain a build that is essentially your REP build plus these two useful patches.

Out of curiosity, what is stopping AGC and Disktidy from being commited to CVS?

Davide-NYC
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 03, 2006, 01:18:39 PM
Hello Mmmm,

I was wondering if you could also upload a zip of the source of your REP builds for H120 targets.
That way I could include the 300remotekeys patch and the disktidy patch.

The patch for the REP is in post#1, that is all you need! :)

Quote
Out of curiosity, what is stopping AGC and Disktidy from being commited to CVS?
AGC needs to be made more friendly to other targets and I have no idea what disk tidy is! :D
Title: Re: Recording Enhancements Pack
Post by: Scimmia on August 03, 2006, 01:52:44 PM
I have no idea what disk tidy is! :D

Disktidy is a plugin that gets rid of the crap that operating systems put on your drive when you connect it as a UMS drive.

http://www.rockbox.org/tracker/task/2596
Title: Re: Recording Enhancements Pack
Post by: petur on August 03, 2006, 04:34:44 PM
Mmmm, can you compare the agc patch (in the tracker) with the state of your code? I've made it compatible with CVS again but am unsure if we followed the same way.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 04, 2006, 05:55:55 AM
Mmmm, can you compare the agc patch (in the tracker) with the state of your code? I've made it compatible with CVS again but am unsure if we followed the same way.

 I think that the only thing I changed is how the AGC status is displayed (so that it is always directly below the gain setting) using the int line variable which is either 5 6 or 7 depending on the input (dig/mic/line as you have different no.s of lines displayed)). I also fixed the display for digital when pressing down as you got a load of blank stages before you reached the AGC status before. Apart from that I'm pretty sure it is the same as the original (apart from a few tweaks to make it work with the fonts and histogram patches).
I'll have a look at yours later :)
Title: Re: Recording Enhancements Pack
Post by: petur on August 04, 2006, 07:38:04 AM
I'll have a look at yours later :)

Fine. I'm looking at making it compatible with all targets that can record. Just checking stuff and fixing some hard coded assumptions into the correct variables...
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 04, 2006, 11:24:48 AM
Ok, I've had a look and digital mode doesn't work properly on yours (which I suppose is to be expected since you have an H3xx, so you're forgiven ;))

So I could add in the changes I made to get this working properly if you like, have you got a more up to date patch with any recent changes to the 'hard coded assumptions'?
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 04, 2006, 12:08:30 PM
OK Petur, If you are still monkeying around with that AGC patch the following will fix the Digital in recording screen (just in case you don't want to think about it ;))
Hope it makes sense to you! :D

around 510 have this as the cursor position definitions
Code: [Select]
#ifdef HAVE_AGC
    if (global_settings.rec_source == SOURCE_MIC)
    {
        if(cursor == 2)
            cursor = 4;
        else if(cursor == 3)
            cursor = 1;
    }
#ifdef HAVE_SPDIF_IN
    else if (global_settings.rec_source == SOURCE_SPDIF)
    {
        if(cursor == 1)
            cursor = 4;
        else if(cursor == 3)
            cursor = 0;
    }
#endif
    max_cursor = 5;
#else
    switch(global_settings.rec_source)
    {
    case SOURCE_MIC:
        max_cursor = 1;
        break;
    case SOURCE_LINE:
        max_cursor = 3;
        break;
    default:
        max_cursor = 0;
        break;
    }
#endif /* HAVE_AGC */


around line 1430 put this in to define placement of the AGC info
Code: [Select]
        if (global_settings.rec_source == SOURCE_LINE)
            line = 5;
        else if (global_settings.rec_source == SOURCE_MIC)
            line = 4;
#ifdef HAVE_SPDIF_IN
        else if (global_settings.rec_source == SOURCE_SPDIF)
            line = 3;
#endif

get rid of this around 1470
Code: [Select]
line = (global_settings.rec_source == SOURCE_MIC)? 4 : 5;

around line 1560 replace this:
Code: [Select]
#ifdef HAVE_AGC
            line = (global_settings.rec_source == SOURCE_MIC)? 5 : 6;
#else
            line = (global_settings.rec_source == SOURCE_MIC)? 4 : 5;
#endif
             for(i = 0; i < screen_update; i++)
                screens[i].puts(0, filename_offset[i] + PM_HEIGHT + line, buf);

With this:
Code: [Select]
            for(i = 0; i < screen_update; i++)
#ifdef HAVE_AGC
                screens[i].puts(0, filename_offset[i] + PM_HEIGHT + line + 1, buf);
#else
                screens[i].puts(0, filename_offset[i] + PM_HEIGHT + line, buf);
#endif

I also think that the remote display needs looking into as it goes off the bottom of the screen at times.... Something like the last line on the remote always changes into the next line (a bit like the agc info part).
Title: Re: Recording Enhancements Pack
Post by: Techy_Bloke on August 05, 2006, 06:04:06 PM
is there anyway of making just the recording screen text heaps massive instead of having it really small so its all easier to read

and also a bigger and labeled DB meter

and prehaps scrolling input waveform ??
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 06, 2006, 07:27:32 AM
is there anyway of making just the recording screen text heaps massive instead of having it really small so its all easier to read

and also a bigger and labeled DB meter

and prehaps scrolling input waveform ??

ummm..yeah..use the REP.... ???
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 06, 2006, 08:07:45 AM
Oh, Petur, one thing I forgot..The pointer cursor.

at about line 1540 replace this:
Code: [Select]
#ifdef HAVE_AGC
                    case 4:
                    case 5:
                        screen_put_cursorxy(&screens[0], 0, line, true);
#ifdef HAVE_REMOTE_LCD
                        screen_put_cursorxy(&screens[1], 0, line, true);
#endif
                        break;
#endif /* HAVE_AGC */
(which seems to me to be a bit of a weird thing to have anyway)

With this:
Code: [Select]
#ifdef HAVE_AGC
                    case 4:
                    case 5:
                        for(i = 0; i < screen_update; i++)
                            screen_put_cursorxy(&screens[i], 0, filename_offset[i] +
                                                    PM_HEIGHT + line, true);
                        break;
#endif /* HAVE_AGC */

Of course, all of this is in recording.c! :)
Title: Re: Recording Enhancements Pack
Post by: k1spanish on August 07, 2006, 02:58:42 AM
No technical matter here, just to say

                                  THANK YOU !!

for the fantastic REP! I taped 4 Rock-Shows last weeks with AGC (live). The Pack run absolutely stable, no problems and brilliant results. I used two 2$-mic-capsules with selfmade casing, works better than all prof mic's I tested.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 07, 2006, 06:27:54 AM
Glad it's working for you K1spanish

I've updated the build and i've added some minor AGC improvements:

When using digital in, the AGC option won't display (as it does nothing anyway) this means you can have even larger fonts when using dig in...Hoorah!

I've fixed the remote display when you are using line in. Previously you couldnt see the AGC settings, now you can scroll down to them on the remote (and any other small screened devices).

All in post#1
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on August 07, 2006, 10:06:28 PM
Hey Mmmm,

I think your latest REP patch is busted.
I DLed a fresh CVS and your latest patch and got this:
Code: [Select]
$ patch --binary -p0 < recordingenhancementspack.20060807.patch
patching file apps/rec_button.c
patching file apps/rec_button.h
patching file apps/SOURCES
patching file apps/settings.c
patching file apps/settings.h
Hunk #1 succeeded at 289 (offset 10 lines).
Hunk #2 succeeded at 380 (offset 10 lines).
patching file apps/settings_menu.c
patching file apps/sound_menu.c
patching file apps/tree.c
Hunk #1 succeeded at 81 (offset 1 line).
Hunk #2 succeeded at 754 (offset 1 line).
patching file apps/tree.h
patching file apps/gui/gwps.c
patching file apps/gui/gwps.h
patching file apps/lang/deutsch.lang
Hunk #1 succeeded at 9044 with fuzz 1 (offset 658 lines).
patching file apps/lang/english.lang
Hunk #3 FAILED at 9147.
1 out of 3 hunks FAILED -- saving rejects to file apps/lang/english.lang.rej
patching file apps/recorder/peakmeter.c
patching file apps/recorder/peakmeter.h
patching file apps/recorder/recording.c
Hunk #27 FAILED at 1832.
Hunk #28 succeeded at 2183 (offset 1 line).
1 out of 28 hunks FAILED -- saving rejects to file apps/recorder/recording.c.rej

patching file apps/recorder/recording.h

I think your source might be out of date? I dunno much I just thought I'd report it.
Title: Re: Recording Enhancements Pack
Post by: Chill on August 08, 2006, 02:34:21 AM
I remember a while back that someone suggested AGC should keep a log of the gain adjustments that it makes in real time, so that after the event a uniform gain level could be applied to an entire recording.  That way, the user need not worry about setting the initial gain too high - the final gain setting would ensure that even the loudest passages would not clip.

Did anything ever come of this suggestion?  Is there a suitable tool that could take a WAV file and apply different gain settings to different sections of it?
Title: Re: Recording Enhancements Pack
Post by: lenny on August 08, 2006, 03:27:51 AM
that's a great idea chill. and since there's probably not a program like that, someone could concievably write it as a plugin for post-recording processing. sounds like a good idea to me anyway.
Title: Re: Recording Enhancements Pack
Post by: petur on August 08, 2006, 03:54:39 AM
Hey Mmmm,

I think your latest REP patch is busted.
Most probably caused by the recent commit by Lamed.
Nothing hard to fix...
Title: Re: Recording Enhancements Pack
Post by: paulheu on August 08, 2006, 08:13:12 AM
it's two simple fixes really..
Title: Re: Recording Enhancements Pack
Post by: petur on August 08, 2006, 06:22:44 PM
Mmmm: new AGC patch on the tracker.

Let me know if I missed something.
I think it's getting close to ready for commit.

Took over your screen handling changes,
I'm still looking for a better solution.
Title: Re: Recording Enhancements Pack
Post by: BayTaper on August 08, 2006, 09:59:43 PM
Should I put this in the AGC thread? Anyway...

First of all, thanks guys for all of your hard work. I'm a taper who uses a couple of different recorders, but I'm in the process right now of transitioning one of my recorders from a JB3 to an H120. I'll be just going analog line in for most of my use (not digital, use something else for that). Anyway, I've got Rockbox plus REP installed and working fine it seems no problem, and while I am not a fan of AGC in general for the kinds of things I tape (music), I think the "Safety" AGC mode is a stealther's dream, and it's so easy to turn it off if you don't even want that. So, a big thanks goes out to all of the developers that have turned the H120 into a much greater thing than it was out of the box.

Now to my main question... I'm trying to understand how the gain works on the H120 with RB. From what I've read, I think it just uses the analog gain to take a big step up and then the decimator to shave some off db digitally so it increments in steps of .5 db and in a way that uses as much analog gain as it can while only using digital gain to lower the level back for .5 steps. So, from what I've seen when the gain goes negative it is simply a digital scaling down of the signal. Do I have that right?

If so, then when you're clipping, and you reduce the gain into "negative"  territory in the UI, you'll still have distorted audio with flat waveforms at a reduced db level. I totally understand that there's nothing the H120 can do about this situation because it doesn't have true analog "pads" or anything like that. But, from the AGC's "Safety" mode, I'm thinking a slightly better algorithm might be to "safety it down to 0 gain and then stop". Now maybe I've got this wrong, but my thinking from a recordist's perspective is once I'm clipping, I'm pretty screwed, and all lowering the gain down past zero into the negative gain territory is just bringing my noise floor up at that point. My thinking goes that, hey you're clipping, that data is lost forever, so it doesn't really matter to lower the gain digitally, it's not doing me any good past zero is it? Now I can see where as long as you aren't clipping, you could use negative gain to simply lower the signal in the recorded file, but why would you want to do that if you weren't already clipping cause aren't all you're doing is raising the noise floor? One idea I had was to make this an option, where you can put a floor on the gain as an option. I'd set mine to floor = zero (zero gain that is, not db).

Well, let me say that I'm not asking anyone to develop anything here, and I am grateful for what's already been developed, and I love RB and the REP as is for sure. I was just thinking about all of this negative gain thing while foolin' around with my H120, and I wanted to try to better understand how the gain staging was working because as a taper, I just want to know those kinds of things.  :P

Anyway, thanks again for your code guys!



Title: Re: Recording Enhancements Pack
Post by: petur on August 09, 2006, 02:50:40 AM
Now to my main question... I'm trying to understand how the gain works on the H120 with RB. From what I've read, I think it just uses the analog gain to take a big step up and then the decimator to shave some off db digitally so it increments in steps of .5 db and in a way that uses as much analog gain as it can while only using digital gain to lower the level back for .5 steps. So, from what I've seen when the gain goes negative it is simply a digital scaling down of the signal. Do I have that right?

correct up to the point of the digital scaling down. We don't know for sure what the decimator does and works on.

If so, then when you're clipping, and you reduce the gain into "negative"  territory in the UI, you'll still have distorted audio with flat waveforms at a reduced db level. I totally understand that there's nothing the H120 can do about this situation because it doesn't have true analog "pads" or anything like that. But, from the AGC's "Safety" mode, I'm thinking a slightly better algorithm might be to "safety it down to 0 gain and then stop". Now maybe I've got this wrong, but my thinking from a recordist's perspective is once I'm clipping, I'm pretty screwed, and all lowering the gain down past zero into the negative gain territory is just bringing my noise floor up at that point. My thinking goes that, hey you're clipping, that data is lost forever, so it doesn't really matter to lower the gain digitally, it's not doing me any good past zero is it? Now I can see where as long as you aren't clipping, you could use negative gain to simply lower the signal in the recorded file, but why would you want to do that if you weren't already clipping cause aren't all you're doing is raising the noise floor? One idea I had was to make this an option, where you can put a floor on the gain as an option. I'd set mine to floor = zero (zero gain that is, not db).

Good question.... I still need to do some tests on this. I once had a recording where the AGC turned the gain down negative (not much) and I didn't see clipping I think. So what the decimator does exactly is still a bit of a mistery. It does come right after the ADC and operates on the full ADC output (which has more accuracy than the data the chip sends to the cpu)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 09, 2006, 06:26:29 AM
Mmmm: new AGC patch on the tracker.

Let me know if I missed something.
I think it's getting close to ready for commit.

Took over your screen handling changes,
I'm still looking for a better solution.

Great...
What is it you're not happy with?...I'm away from my dev environment for a while so I won't be able to do any testing/improving for a week or so... but I'll be near a computer until tomorrow at least, so I could offer some suggestions (or excuses for how i did it :P).
Title: Re: Recording Enhancements Pack
Post by: BayTaper on August 09, 2006, 10:16:07 AM
Now to my main question... I'm trying to understand how the gain works on the H120 with RB. From what I've read, I think it just uses the analog gain to take a big step up and then the decimator to shave some off db digitally so it increments in steps of .5 db and in a way that uses as much analog gain as it can while only using digital gain to lower the level back for .5 steps. So, from what I've seen when the gain goes negative it is simply a digital scaling down of the signal. Do I have that right?

correct up to the point of the digital scaling down. We don't know for sure what the decimator does and works on.

If so, then when you're clipping, and you reduce the gain into "negative"  territory in the UI, you'll still have distorted audio with flat waveforms at a reduced db level. I totally understand that there's nothing the H120 can do about this situation because it doesn't have true analog "pads" or anything like that. But, from the AGC's "Safety" mode, I'm thinking a slightly better algorithm might be to "safety it down to 0 gain and then stop". Now maybe I've got this wrong, but my thinking from a recordist's perspective is once I'm clipping, I'm pretty screwed, and all lowering the gain down past zero into the negative gain territory is just bringing my noise floor up at that point. My thinking goes that, hey you're clipping, that data is lost forever, so it doesn't really matter to lower the gain digitally, it's not doing me any good past zero is it? Now I can see where as long as you aren't clipping, you could use negative gain to simply lower the signal in the recorded file, but why would you want to do that if you weren't already clipping cause aren't all you're doing is raising the noise floor? One idea I had was to make this an option, where you can put a floor on the gain as an option. I'd set mine to floor = zero (zero gain that is, not db).

Good question.... I still need to do some tests on this. I once had a recording where the AGC turned the gain down negative (not much) and I didn't see clipping I think. So what the decimator does exactly is still a bit of a mistery. It does come right after the ADC and operates on the full ADC output (which has more accuracy than the data the chip sends to the cpu)

Thanks for the response. I guess I forgot to mention that I DID TEST this already. As far as I can tell negative gain just digitally lowers the signal strength. I ran a hot signal into the H120, it was clipping at 0 db with 0 gain. The AGC safety mode then moved the gain into negative territory (or I'm sure I could have just done that manually myself), and I then inspected the waveform in SF. The top of the wave was below 0 db, but it was chopped-off flat just like if it had clipped at 0 db. To me that spells only one thing, that negative gain is a digital scaling down of the signal and nothing more. Thus, I don't think there is really any advantage to using it (negative gain that is, I understand why its kind of nice to use the decimator to achieve smaller .5 increments, that makes sense to me, but whenever possible it's probably better to stick with pure analog gain, which I think I read was in 3 db increments starting at zero, right?). The wavform is just as screwed as it would be up at 0 db, and I think by lowering it from that point the signal to noise ratio suffers, not to mention that any digital scaling at all at 16-bit creates quantization noise from the rounding that must occur to do it. Anyway, just wanted to add more flavor to my post above considering I did actually test this yesterday. THANKS!
Title: Re: Recording Enhancements Pack
Post by: Wolf on August 09, 2006, 10:21:11 AM
Very interesting BayTaper. I also bougth my H140 mainly for recording live gigs and this information helps to get hi quality recordings.

Do you by any chance has any screenshots documenting your analysis?
Thx, Wolf.
Title: Re: Recording Enhancements Pack
Post by: BayTaper on August 09, 2006, 10:40:21 AM
Very interesting BayTaper. I also bougth my H140 mainly for recording live gigs and this information helps to get hi quality recordings.

Do you by any chance has any screenshots documenting your analysis?
Thx, Wolf.

Note the flat tops that are not occuring at 0 db. All the neg gain did was scale it down but left the clipping there (which is honestly exactly what I expected it to do). So, for me, once I confirm that, my thinking is that I'd never use the "negative" side of the gain structure because I'm only making things worse than they already are. And if I wasn't actually clipping, then I don't think I would ever want to lower the gain on-the-fly, when I can just do that in post with (arguably) a better algorithm than the H120 is using.

[attachment deleted by admin, too old]
Title: Re: Recording Enhancements Pack
Post by: Wolf on August 09, 2006, 11:28:11 AM
Thx again BayTaper. The image suggest that the gain reduction is applied after the ADC adquired the (already clipped) signal. I didn't expect that.
Will probably make some tests on my own with test signals and see what I can get.

Thx. Wolf.
Title: Re: Recording Enhancements Pack
Post by: petur on August 09, 2006, 04:01:38 PM
I just did a small test:

- disabled gain
- set gain to 0
- increase input signal until the peakmeters reach 0 dB and then give it a bit more
- decrease recording gain until peakmeters are below 0 dB

after step4 the waveform looked like this (scale in dB, gain set at -5 dB)

(http://users.telenet.be/petur/noclip.jpg)
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on August 09, 2006, 05:46:22 PM
I think the difference was that BayTaper's input signal was strong enough to clip when the unit was set at 0db 'volume' and 0db 'gain'.
Petur, was your input signal strong enough?
I am willing to do some testing as well.
Let me know what you want done exactly.

Title: Re: Recording Enhancements Pack
Post by: BayTaper on August 09, 2006, 06:59:06 PM
Yeah, let there be no doubt, I was sending a signal that was clipping the hell out of the iRiver with the sole purpose to try to understand WTH negative gain was going to do with it. It pretty much did exactly what I was expecting it to, it lowered the gain of the clipped signal. Now, it seems like Petur did the exact same thing as me, so I'm a bit perplexed why his waveforms look so nice and round. :) But, not sure if Petur was really clipping hard enough to really tell, and in my waveform pic above, you can see I "zoomed" way into the waveform (down to the individual sample, you can see the "dots") to take a closer look.
Title: Re: Recording Enhancements Pack
Post by: petur on August 10, 2006, 01:27:09 AM
yes it was clipping when gain was set at 0 dB, but not much, only a few dB.

This was the signal when gain was set at 0 dB (just before gain was set negative)

(http://users.telenet.be/petur/clip.jpg)

My test only clipped a little bit, but this was about the hottest signal I managed to produce.

Title: Re: Recording Enhancements Pack
Post by: BayTaper on August 10, 2006, 10:35:42 AM
That's pretty interesting though. It's almost like it can pad it a little before it runs out of headroom. Strange. More tests might unlock some more clues...
Title: Re: Recording Enhancements Pack
Post by: Llorean on August 10, 2006, 10:39:16 AM
One thing you could do is make a recording of something that clips at 0 gain, then make another recording of the same thing at negative something, then at negative something further, and see if all three clip, and if they do, at the same point.

This should tell you if lowering into the negatives can or cannot prevent clipping (if it's at a different point in each one, then you may just need to lower it further in the negatives than it seems like, maybe a bug of some sort in the peakmeter / clip detection output).
Title: Re: Recording Enhancements Pack
Post by: mlind on August 11, 2006, 05:58:42 PM
Hi guys
I never tried the AGC patch, but anxiously awaits it beeing committed.

For all I know, it's a fact that there's NO WAY to by any digital means save a signal from clipping if it's clipping BEFORE the analog->digital conversion (ADC).... 

Could there be some built in steady digital gain raise AFTER the digital gain change?
What's the resolution before the dig. gain ch.? 16 bit? 20?
Is there a reduction stage from 20 bit to 16?
(As far as I know the H1x0 has a possibility to work with 20 bit sound in some stage.)

Maybe I should go to sleep...
Title: Re: Recording Enhancements Pack
Post by: BayTaper on August 11, 2006, 06:18:31 PM
For all I know, it's a fact that there's NO WAY to by any digital means save a signal from clipping if it's clipping BEFORE the analog->digital conversion (ADC).... 

My thoughts exactly, which is why I'm thinking negative gain makes no sense under any conditions, I just can't think of any reason why you'd use it?
Title: Re: Recording Enhancements Pack
Post by: Techy_Bloke on August 12, 2006, 11:26:46 PM
is there anyway of making just the recording screen text heaps massive instead of having it really small so its all easier to read

and also a bigger and labeled DB meter

and prehaps scrolling input waveform ??

ummm..yeah..use the REP.... ???

what is REP and where can i find it??

i know that u can use the oscilliator to veiw waveform but not whislt recording ??

how can i make the recording screen txt bigger without effecting my theme text size ?

also how do i install Automatic Gain Control
Title: Re: Recording Enhancements Pack
Post by: LurkAzusa on August 13, 2006, 12:04:53 AM
See the first post on page one of this topic.  If you have an H1XX, use the build there.  For the H3XX use KOSH's experimental build on www.misticriver.net
Title: Re: Recording Enhancements Pack
Post by: paulheu on August 13, 2006, 05:38:03 AM
The iRiver H3x0 experimental build has just been updated (http://www.misticriver.net/showpost.php?p=485177&postcount=88) with the latest patches (including latest RecEnhPatch)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 13, 2006, 12:48:56 PM
is there anyway of making just the recording screen text heaps massive instead of having it really small so its all easier to read

and also a bigger and labeled DB meter

and prehaps scrolling input waveform ??

ummm..yeah..use the REP.... ???

what is REP and where can i find it??

i know that u can use the oscilliator to veiw waveform but not whislt recording ??

how can i make the recording screen txt bigger without effecting my theme text size ?

also how do i install Automatic Gain Control
REP stands for Recording Enhancements Pack which is (supposedly) what this thread is all about.
As LurkAzusa says, all details are in post#1 (http://forums.rockbox.org/index.php?topic=2513.msg17218#msg17218).

Unfortunately there is not much room left on the screen for use of a bigger font (if you are using an H1xx). The REP will use whichever font you have set as long as it will fit on the screen (10 pixels high is the largest for H1xx I'm afraid) Otherwise it will use the system font (8 pixels high), which is what you see without the REP. I find CourB08 a good font, but then It depends on your theme.

On the recording screen there is a Histogram view which scrolls, telling you what the input levels are and AGC is also part of the REP. So I think that is everything you asked about except the labelled peakmeter values but I think you can work them out for yourself without labels eh?  :)
Title: Re: Recording Enhancements Pack
Post by: BayTaper on August 13, 2006, 02:04:36 PM
Alright, I know that the development is done for free by some of you guys, so I always hesitate to offer up feature requests because I am truly grateful and humbled by what you've already done. That said, you know what would be insanely cool from at least a "wow" factor perspective? A real-time graphic frequency/spectrum analyzer. Maybe 8-10 frequency slots from bass to treble all with peak indicators and peak holding. It'd probably have to use the screen on the bottem where the already-cool historical level and balance plotting is happening, but something like this would just look slick -- in fact, I'm not sure I've ever seen a portable recorder show something like that. Not sure, but the historical plot might be more useful and I'm betting this would grind some serious CPU cycles, but thought it was worth mentioning...
Title: Re: Recording Enhancements Pack
Post by: petur on August 16, 2006, 06:40:21 PM
note: AGC has been committed to CVS  :D
Title: Re: Recording Enhancements Pack
Post by: BayTaper on August 16, 2006, 06:51:34 PM
Congrats!
Title: Re: Recording Enhancements Pack
Post by: petur on August 17, 2006, 06:27:40 AM
Mmmm, I have closed http://www.rockbox.org/tracker/task/4748 (http://www.rockbox.org/tracker/task/4748), I count on you to add the rest of the REP that is commitworthy... Don't know if the histogram should get committed.

I'll be having less time to work on rockbox for about a month :/
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 17, 2006, 07:21:42 AM
Mmmm, I have closed http://www.rockbox.org/tracker/task/4748 (http://www.rockbox.org/tracker/task/4748), I count on you to add the rest of the REP that is commitworthy... Don't know if the histogram should get committed.

I'll be having less time to work on rockbox for about a month :/

Wow...you've finally got around to committing the AGC...Fantasic :D
That has pretty much killed the REP off I think, apart from the histogram (I wouldn't submit the rest). What are you unsure of about the histogram? Is it because it really has no use other than just eye candy, or the way it is coded?

I'll have a look at that some time (although I'm still nowhere near my Dev-Environment  :'( - ahh well, there's more to life than coding eh? :D).
Title: Re: Recording Enhancements Pack
Post by: petur on August 17, 2006, 10:10:30 AM
What are you unsure of about the histogram? Is it because it really has no use other than just eye candy, or the way it is coded?

The first... I see not much use for it, so maybe somebody can convince me? ;)
Title: Re: Recording Enhancements Pack
Post by: paulheu on August 17, 2006, 10:23:01 AM
Mmmm, I do hope you're releasing a (final) patch with whatever is left..
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 17, 2006, 11:55:06 AM
What are you unsure of about the histogram? Is it because it really has no use other than just eye candy, or the way it is coded?

The first... I see not much use for it, so maybe somebody can convince me? ;)

I agree..not a lot of point really, but it looks gorgeous! ;)
I suppose you can tell if you had a clip recently as you have a history of input levels.
erm.... You can get an exact balance using the balance-ometer.
But I must say, I have never used this while recording and can't see myself ever needing to.
......But it looks fantastic.

Has anyone actually used this feature?

Mmmm, I do hope you're releasing a (final) patch with whatever is left..
Yes, I probably will when I get around to it ;)
Title: Re: Recording Enhancements Pack
Post by: petur on August 17, 2006, 01:27:29 PM
I agree..not a lot of point really, but it looks gorgeous! ;)
I suppose you can tell if you had a clip recently as you have a history of input levels.
erm.... You can get an exact balance using the balance-ometer.
But I must say, I have never used this while recording and can't see myself ever needing to.
......But it looks fantastic.

Has anyone actually used this feature?

No I haven't... maybe I should and get impressed ;)
But no time here now :/
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on August 17, 2006, 01:40:29 PM
CONGRATS on the Commit!!!  ;D  :D  :)

My opinion: The histogram is purely eye candy.
But the battery, disk and balance meters are very useful.
They don't need to be graphically represented.
A single line of formatted text would be just fine.
But graphics are nice...  ;)
Title: Re: Recording Enhancements Pack
Post by: Rincewind on August 17, 2006, 01:43:28 PM
Mmmm, I do hope you're releasing a (final) patch with whatever is left..

One thing that is left, my record button patch, needs a major rework now that the whole button handling is changed completely. I try to update it in the next time.
Title: Re: Recording Enhancements Pack
Post by: redwood on August 19, 2006, 10:54:42 AM
Personally I find the histogram/balance unnecessary, and when using a larger font it ends up overwriting it anyway. Is there a way to either defeat the histogram/balance meter or set smaller fonts in the WRS only?

thanks for all the great work

jp
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 19, 2006, 11:38:17 AM
Personally I find the histogram/balance unnecessary, and when using a larger font it ends up overwriting it anyway. Is there a way to either defeat the histogram/balance meter or set smaller fonts in the WRS only?

thanks for all the great work

jp
It overwrites it? really?? It's supposed to change to the default font in that case....Damn!...

Which font do you use?
Title: Re: Recording Enhancements Pack
Post by: paulheu on August 22, 2006, 07:54:56 AM
Mmmm, I do hope you're releasing a (final) patch with whatever is left..
Yes, I probably will when I get around to it ;)
[/quote]

From what I figure all that is left now is the fonts and histogram patch. The recording button patch has to be rewritten anyway. Maybe you could post an updated histogram patch to the patch tracker and add the fonts stuff as a separate patch. That would more or less keep everything nice and tidy and maybe have the fonts patch also committed shortly..
Title: Re: Recording Enhancements Pack
Post by: paulheu on August 22, 2006, 10:07:19 AM
OK.. so I actually managed to sync the (older) histogram patch against CVS..

check the tracker (http://www.rockbox.org/tracker/task/5021)


I don't know if anything changed between the previous patch on the tracker and the one used in the REP, but if not it appears this is one less part of REP to update :)

Now for the fonts patch..
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 22, 2006, 11:14:30 AM
OK.. so I actually managed to sync the (older) histogram patch against CVS..

check the tracker (http://www.rockbox.org/tracker/task/5021)


I don't know if anything changed between the previous patch on the tracker and the one used in the REP, but if not it appears this is one less part of REP to update :)

Now for the fonts patch..
Good work...I think you'll find the fonts a little more tricky though :)
But you can't beat a good challenge eh? ;)
Title: Re: Recording Enhancements Pack
Post by: paulheu on August 22, 2006, 11:19:49 AM
The synced Histogram patch and the Peakmeter Margins and Height patch do not sit well together right now..
Title: Re: Recording Enhancements Pack
Post by: old45 on August 22, 2006, 07:58:47 PM
Are any of the features of the recording enhancement pack included in the daily builds or are they confined to the CVS files?
Title: Re: Recording Enhancements Pack
Post by: Llorean on August 22, 2006, 08:01:00 PM
Daily builds are JUST CVS builds that are made once per day and backed up.
Title: Re: Recording Enhancements Pack
Post by: Jillorious on August 22, 2006, 08:40:16 PM
Daily builds are JUST CVS builds that are made once per day and backed up.
Then why does the manual say that the daily builds are more prone to bugs than the CVS builds?
Title: Re: Recording Enhancements Pack
Post by: Llorean on August 22, 2006, 08:43:13 PM
Imagine this scenario:

Bob the coder introduces an accidental major bug. He fixes it 10 minutes later.

If the users are downloading CVS builds, there is a 10 minute period during which they can end up with this major bug. If that build lands on the crossover where the daily is made, any users downloading daily builds will be stuck with this bug. It won't be gone from the daily for 24 hours, even though it was fixed 10 minutes later.

In most cases, if a bug is fairly obvious, it gets fixed fairly quickly. Unfortunately users of daily builds with obvious bugs won't get the fixes unless they update to a CVS build. Therefor it's better that all users only use CVS builds, so that as of the time of downloading, they're getting the most recent bug fixes, instead of problems that were fixed as much as 23 hours prior.
Title: Re: Recording Enhancements Pack
Post by: Chill on August 23, 2006, 08:27:58 AM
So do we really need daily builds at all then?
Title: Re: Recording Enhancements Pack
Post by: Llorean on August 23, 2006, 08:52:49 AM
Yes, primarily for archival purposes as far as I know. The daily builds are kept for a month, so that should some major, hard to fix bug creep in, users can use a slightly older daily until it's fixed.
Title: Re: Recording Enhancements Pack
Post by: Rincewind on August 23, 2006, 03:45:30 PM
when I started using rockbox (about the same time last year) it was said, that the daily builds are more stable than the bleeding edge, because devs would take care not to submit major stuff right before a day break. I don't know if this really was (and is) the case.

The point is, if you watch the cvs log like a hawk, then it is better to download a bleeding edge and download another one if an important fix is out a few minutes later. But if you just want to download a build and go on holidays it would be better to take a daily build.
Title: Re: Recording Enhancements Pack
Post by: Llorean on August 23, 2006, 07:53:43 PM
If you want to take a build on holiday, you shouldn't pick a build you haven't tested yet. A week before the holiday you should stop updating unless you're sure a build is solid.

These days, many devs aren't even certain when the daily builds are made, so while yes some major changes may wait until after the daily build, that doesn't do anything for "unintended consequences" or developers who don't know when it'll happen.
Title: Re: Recording Enhancements Pack
Post by: redwood on August 25, 2006, 06:45:15 AM


Personally I find the histogram/balance unnecessary, and when using a larger font it ends up overwriting it anyway. Is there a way to either defeat the histogram/balance meter or set smaller fonts in the WRS only?

thanks for all the great work

jp

It overwrites it? really?? It's supposed to change to the default font in that case....Damn!...

Which font do you use?


I'm using nimbus-12

jp
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 25, 2006, 12:32:00 PM
Hmmm just tested it and when I use nimbus-12 I get the system font in the recording screen!
But you get nimbus 12 in the recording screen overwriting the histogram? Weird ???

I'm going to put a new patch/build up soon so when I do try that... I'll tell you when :)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 25, 2006, 01:16:45 PM
Aha... I think I may have found the problem Redwood...
I'll put a new build up soon...which will hopefully fix it  ;D
Title: Re: Recording Enhancements Pack
Post by: redwood on August 25, 2006, 01:30:55 PM
Cool! What was it? (I won't pretend to understand but am starting to study some C++ so maybe i could learn something) ;)

jp
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 26, 2006, 06:35:29 AM
All it was was that the font check was done outside the main recording screen loop which meant that if you go into the screen with a certain font (say nimbus12) and you have a mic or digital source then everything will be fine, but if you then change to line source the font wouldnt be rechecked and so you would get an overlap of the histogram. I have simply moved the font check into the loop and made it so that it is only checked when  last_source !=source (ie only when the source has changed), simple!

well, I hope that was your problem anyway...it was the only way I could reproduce it! :)

I should be able to post the new code today sometime.

PS. Rockbox is coded in C, not C++  :)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 26, 2006, 10:19:44 AM
Ok then..here we go.. A new version at last

Unfortunately we have lost rincewinds record button patch as I was too lazy to update it and I think that he will do that sometime anyway... I'll add it when he does.

I have put in a patch that displays the samplerate and channels (mono/stereo) in the statusbar when in the recording screen.
This means that you can now see this info on any screen (main and remote) all the time.

It also means that we have more space on the main screen so bigger fonts are possible...although not that much bigger unfortunately...one extra line doesnt go far I'm afraid!

Input method                      Previous max fontsize          New max fontsize
Line In                                              10                        Â     11   ->No change really
Mic In                                                11                            12    ->some extra fonts become possible
Digital In                                           14                             17    ->WOW!

I did a bit of tweaking for the fonts patch too:
i) to get rid of the bug redwood noticed (now the font will change as soon as you change the input method)
ii) take into account the lack of AGC info for digital in (the reason for the large increase in max fontsize for digital in)

Post#1 for patches etc....
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 26, 2006, 12:19:57 PM
hmmm It appears to be riddled with bugs..I wouldnt touch it for now! :D
Title: Re: Recording Enhancements Pack
Post by: Rincewind on August 26, 2006, 02:48:34 PM
I've got something for you, Mmmm!

I finally had time to update my Record Button Config patch.
Works with current cvs again and uses the new button action system. Code is a lot cleaner, too.

http://www.rockbox.org/tracker/task/5555#comment9737
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 26, 2006, 05:47:18 PM

I've got something for you, Mmmm!

I finally had time to update my Record Button Config patch.
Works with current cvs again and uses the new button action system. Code is a lot cleaner, too.

http://www.rockbox.org/tracker/task/5555#comment9737


Good stuff rincewind..I'll put that in sometime..

By the way, I've got rid of all the bugs so the patch and build in post#1 are good now...
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on August 26, 2006, 08:08:59 PM
Nice work Mmmm!

Larger fonts just tempted me into updating for the first time in ages (I've been enjoying not testing). :)

Am I missing something, or is there currently no way to turn histogram off?

Does two taps up on the joystick just increase/decrease the vertical size of the histogram? (note that with size 16 fonts this causes the larger histogram o overlap the volume bar)

Are there any size 17 fonts to choose from?  Which font do y'all use?

edit: Ooh...I just had a crazy idea.  I'm sure the developers'll hate me for this one (and I don't think it'll be very friendly with non-iriver targets).  What do y'all think about having different configs mapped to different boot buttons?

For examples: You'd press record button to boot up 'recording' settings.  This would boot straight to recording screen with user-defined "recording" settings (for me that means big fonts, specific peakmeter & backlight settings.  If I wanted my usual playback settings I'd jsut press play to boot.

The reason I suggest this is because its a little irritating constantly having to change config settings when switching between recording and playback mode (yeah, I know, boohoo). ;)  This would be a one button solution!
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 27, 2006, 06:30:24 AM
Yeah...I decided not to bother with dealing with the Zoom on the histogram and the fonts, and yes, all it does is increase the vertical measure.

You haven't missed anything, you can't turn it off!

Unfortunately it is impossible to use other keys as boot keys as the play button is special - on its own little circuit I think. That is also why it is impossible to have button combinations with any key other than the play button.

A better solution to your problem would be to have a seperate font defined for the recording screen eh? ;)
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on August 27, 2006, 07:15:41 AM

Yeah...I decided not to bother with dealing with the Zoom on the histogram and the fonts, and yes, all it does is increase the vertical measure.

You haven't missed anything, you can't turn it off!

Unfortunately it is impossible to use other keys as boot keys as the play button is special - on its own little circuit I think. That is also why it is impossible to have button combinations with any key other than the play button.

A better solution to your problem would be to have a seperate font defined for the recording screen eh? ;)


I don't know if I'd class it as 'better' but a separate definable recording screen font would be good...so I'll take what I can get. :P

Gah...I'll just stop being lazy and create a different config file (once I can remember how...).
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 27, 2006, 08:44:09 AM

Gah...I'll just stop being lazy and create a different config file (once I can remember how...).


If you only want to change the font then paste this into a text file (replacing the font with whichever you want of course) and save it with a .cfg extension.
Code: [Select]
font: /.rockbox/fonts/courB08.fnt

Easy peasy!  :P
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on August 27, 2006, 09:16:19 AM
Thanks, but I'm not just changing fonts...I'm also after different peakmeter, power-down and backlight settings. I'll figure it out. :)

I'm really liking these larger fonts and peakmeter...thanks again.

Title: Re: Recording Enhancements Pack
Post by: BayTaper on August 27, 2006, 12:07:54 PM

Thanks, but I'm not just changing fonts...I'm also after different peakmeter, power-down and backlight settings. I'll figure it out. :)

I'm really liking these larger fonts and peakmeter...thanks again.




Is it possible to make the peakmeter taller, like each bar is "wider" on the vertical size? I saw a patch that seemed to imply it would do that. If I use the daily build now, that has all the recording and AGC in it now, right? Everything except the histogram? So, does that mean I could use the patch to widen my meters?
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 27, 2006, 12:56:25 PM

Is it possible to make the peakmeter taller, like each bar is "wider" on the vertical size? I saw a patch that seemed to imply it would do that. If I use the daily build now, that has all the recording and AGC in it now, right? Everything except the histogram? So, does that mean I could use the patch to widen my meters?

Using the REP your peakmeter will be the same height as the font you use (or 2x the height depending on which player you have)
So yes...this patch will enable you to increase the peakmeter size by using a bigger font.

If that isn't enough for you or you don't want to change the font size look in apps/recorder/recording.c and near(ish) the top you will see PM_HEIGHT defined. This has two values 1 or 2. change it to whatever number you want (the number you use is the multiple of the current font height your peakmeter will appear).
Title: Re: Recording Enhancements Pack
Post by: BayTaper on August 27, 2006, 01:21:38 PM


Is it possible to make the peakmeter taller, like each bar is "wider" on the vertical size? I saw a patch that seemed to imply it would do that. If I use the daily build now, that has all the recording and AGC in it now, right? Everything except the histogram? So, does that mean I could use the patch to widen my meters?

Using the REP your peakmeter will be the same height as the font you use (or 2x the height depending on which player you have)
So yes...this patch will enable you to increase the peakmeter size by using a bigger font.

If that isn't enough for you or you don't want to change the font size look in apps/recorder/recording.c and near(ish) the top you will see PM_HEIGHT defined. This has two values 1 or 2. change it to whatever number you want (the number you use is the multiple of the current font height your peakmeter will appear).


I'm too much of a newb coder to deal really, but I'm intrigued about the possibility. I actually like all the info on the screen I have right now, but I see there is some room on the screen to make the meters wider, which would be cool. It'd be awesome if it were on option in the settings screen. You could pick 1 or 2 or something, but maybe I'll try to learn how to change that number myself. Thanks!
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 27, 2006, 02:16:38 PM
Hmmm this is the line that needs changing, it is line 91
Code: [Select]
#define PM_HEIGHT ((LCD_HEIGHT >= 72) ? 2 : 1)
All you need to do is replace this line with this

Code: [Select]
#define PM_HEIGHT 3
and that will give you a 3*fontsize peakmeter
Title: Re: Recording Enhancements Pack
Post by: ZincAlloy on August 27, 2006, 03:04:10 PM

Yeah...I decided not to bother with dealing with the Zoom on the histogram and the fonts, and yes, all it does is increase the vertical measure.

You haven't missed anything, you can't turn it off!

Unfortunately it is impossible to use other keys as boot keys as the play button is special - on its own little circuit I think. That is also why it is impossible to have button combinations with any key other than the play button.

A better solution to your problem would be to have a seperate font defined for the recording screen eh? ;)


I still think it's a good idea that may be worth thinking about.
Why not button combinations with the play button?
Title: Re: Recording Enhancements Pack
Post by: paulheu on August 27, 2006, 03:04:33 PM
New build (http://forums.rockbox.org/index.php?topic=6038.0) of my experimental build for H3x0 with new Record enhancement pack and Record button patch included
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 27, 2006, 05:53:52 PM
Well...whatboutbob You're oing to love this...I haven't done a build yet but the patch in post#1 now contains the ability to switch the histogram off..so you know what that means folks....yep, even bigger fonts!! :D

Source           with histogram             without histogram
Line                             11                           13
Mic                              12                            15
Dig                              17                             20


HA HA... Superfonts.............
Of course this is all with the H1xx....with the H3xx the world is your oyster...I dont even want to think about it.... :'(

PS. I haven't tested it yet so it probably won't work... ;) I've got to get to bed.... :)

ps. Oh yeah... it might be useful to know that the histogram off key is 'hold mode'
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 28, 2006, 05:59:39 AM
New build with long press mode to turn off histogram. post#1
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on August 28, 2006, 10:17:10 AM

Well...whatboutbob You're oing to love this...I haven't done a build yet but the patch in post#1 now contains the ability to switch the histogram off..so you know what that means folks....yep, even bigger fonts!! :D


Sweet lord...I can't wait to see the digi peak-meters.  I've got gigs over the next 3 nights tho so I dare not update just yet...but I'm so tempted. :)

As always, thanks Mmmm.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 28, 2006, 10:22:34 AM


Well...whatboutbob You're oing to love this...I haven't done a build yet but the patch in post#1 now contains the ability to switch the histogram off..so you know what that means folks....yep, even bigger fonts!!


Sweet lord...I can't wait to see the digi peak-meters.  I've got gigs over the next 3 nights tho so I dare not update just yet...but I'm so tempted.

As always, thanks Mmmm.

No probs mate! ;D

I'm very tempted to put in bay taper's option...should be quite easy... a separate option for peak meter size...wouldnt that be nice? :D

and a histogram on/off default option (at the moment it will always start up on).... ooohh...I think my head's going to explode.... :D
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 28, 2006, 06:08:33 PM
OH WOW!!

The patch now contains the above enhancements and it is really quite amazing.
You can now set the peakmeter to be up to 8x font height ha ha...:D

It's great..thanks baytaper for that idea...

Also in the histogram menu, you can set a default for the histogram on/off. You can still toggle the histogram on and off by holding mode too but when you start the recording screen it will always start with your default setting.

Have fun....I am!

Ps. its only the patch for now...I'll put the build up tomorrow with rincewinds patch back in it... Goodnight...;)
Title: Re: Recording Enhancements Pack
Post by: simon142857 on August 29, 2006, 01:30:20 AM
Mmmm, Petur, and all you devs a biiiiiig thanks for all this amazing work on the REP!
WOW!
I'm wondering if the next build will include the Mp3 recording capacity I noticed mentioned in the Recording Forum? I would use that when I'm recording long lectures and might run out of room on my H120 recording in Wav.

Thanks again to you!
Title: Re: Recording Enhancements Pack
Post by: norbusan on August 29, 2006, 03:45:32 AM
And again, the recent changes in CVS have messed up the REP. Unforunately the rejects are too big to be fixed by me.

Can you take a look, thanks a lot.

Ciao
Norbert
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 29, 2006, 05:33:27 AM
Alright then...The Patch ONLY is updated in post#1.

Rincewind's button config patch is back.

The only prob now is that the new encoder options have given us an extra line on the display again meaning max font sizes would suffer, so I have got rid of this line and I'm looking at squeezing it into the statusbar like the samplerate. So for now you'll have to fly blind as to which filetype you are encoding into..... Not for long though hopefully ;)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 29, 2006, 10:49:38 AM
Right then...I've finished.......

Took me longer than I thought it would..

Now the peakmeters are calculated better and automatically resize if they won't fit on the screen, each screen will resize seperately so you can have a different sized peakmeter on the remote to the main screen.

Also I have squeezed the bitrate and filetype info into the status bar replacing the redundant volume info (as the volume info is also on the options part of the screen) I'm afraid that mp3 files are displayed as an M with the bitrate next to it..I just couldnt fit Mp3 into the bar.

Any change of font/source/peakmeter size/histogram on/off will recalculate the font sizes so you will always have the right font.....

Phew... can I have a break now? :D

Patch/build in post#1 as always.... :)
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on August 29, 2006, 11:16:52 AM
No break for you!

Oh ok...you can get 8 4 hours sleep if you like... :)

Nice work. Can't wait to test.
Title: Re: Recording Enhancements Pack
Post by: Wolf on August 29, 2006, 12:55:29 PM
Wow, a lot of features added in the past few days for the recording crowd. Impressive response from the developers to include them all in REP.

Thanks a lot to everyone who work so hard to get this hi quality pack out!
Wolf.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 29, 2006, 03:13:00 PM
Seeing as there has been quite a big change in the way it looks, I have put some new screenshots in post#1 just so you can see how ridiculously big those peakmeters can get without installing anything! :D

Amazing eh?
Title: Re: Recording Enhancements Pack
Post by: norbusan on August 29, 2006, 05:54:05 PM

Took me longer than I thought it would..


Great, thanks a lot. I have (re)included the REP into my build http://www.misticriver.net/showthread.php?t=42675

Best wishes

Norbert
Title: Re: Recording Enhancements Pack
Post by: whatboutbob on August 29, 2006, 06:09:55 PM

Amazing eh?


Hehehe...I never thought I'd say this...but I don't think I need peakmeters that big...but its sure nice to have the option. :)
Title: Re: Recording Enhancements Pack
Post by: nigelsh on August 29, 2006, 09:39:30 PM

Seeing as there has been quite a big change in the way it looks, I have put some new screenshots in post#1 just so you can see how ridiculously big those peakmeters can get without installing anything! :D

Amazing eh?


I don't see any screenshots in post #1!

Could someone explain what the three items are that display at the bottom of the recording screen (iriver h120). There's something that looks a bit like a battery which has 23m written in it, then comes a rectangle with 14h in it and then another rectangle that looks like it might be some kind of a gauge. Is this stuff documented somewhere?
Thanks
Title: Re: Recording Enhancements Pack
Post by: nigelsh on August 29, 2006, 10:18:53 PM

Right then...I've finished.......

Patch/build in post#1 as always.... :)


I downloaded your h120 build. Initial boot was fine and I set some of the settings that I wanted, I set the option to show the recording screen on boot. Now I have to consistently use reset because I'm getting a hang before it hits the recording screen. The screen hangs with the rockbox logo on it and the rectangle in the middle of the screen indicating "Recording...". Build indicated as 060829-1630. This is the first time I've ever needed to use reset!

Perhaps this is not the fault of your build, just downloaded and installed from CVS 060830-0137 and it hangs too - never even got past the boot logo! Reverted to a build from May which is not hanging. Installed all the builds the same way - deleted the .rockbox directory and unzipped the build to the root of my h120 - overwriting the rockbox.iriver file in the process.

By the way many thanks to all who have contributed to the REP - made my h120 so much more usable for recording!

Nigel
Title: Re: Recording Enhancements Pack
Post by: kleusl on August 30, 2006, 09:31:20 AM
Mmmm,

thank you for this great work!

Kleusl
Title: Re: Recording Enhancements Pack
Post by: BayTaper on August 30, 2006, 10:38:35 AM
Am I just an idiot? I tried to upgrade to your new build by simply dragging the rockbox file and folder onto the HD. I thought that's all I needed to do, but I've never upgraded before. Anyway, the rockbox bootloader loads up, but then I can't get into rockbox. If I select it, it acts like it's going to go into rockboxs, but then ends up back at the boot screen. WTF? What did I do wrong? Then I tried to move back the files I had before that worked, and I'm stuck with the same problem? What did I do wrong? Should I just start over?

I was thinking about reformatting anyway, is that process easy? Do I just reformat the drive, and start the installation from scratch? Will that work?

Any help is much appreciated. Shit! I'm going to a huge music fest in one day, I knew I shouldn't have messed with my stable install -- doh!
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on August 30, 2006, 12:09:40 PM
Baytaper:

Before anything else try rebooting and hold down the REC button *just after* the unit powers up.
This will clear all of the settings and might solve your problem. If not...

What I usually do is take the rockbox.iriver file and put it inside the .rockbox folder.
Then I rename the .rockbox folder to old.rockbox.

Then I unzip the new rockbox-full.zip to the root of the player. (Mine is R:\)
That way if I don't like anything i can just roll back to the previous build.

You might want to delete the .rockbox folder and the rockbox.iriver file and un-zip fresh.
Why not just use a daily build from just before the encoding options where put in for the mean time?

Davide.
Title: Re: Recording Enhancements Pack
Post by: BayTaper on August 30, 2006, 12:24:58 PM
Alright, I'm going to try to fix it tonight, but I essentially did what you are saying, I just took the backup to my own hard disk. I copied my current build's rockbox.iriver and the rockbox folder to my desktop, then I deleted them from the H120, then I copied over the new files, and I have this strange behavior. So then, I just copied back the build files that were working from my desktop, but I still have the same problem? Isn't that basically the same approach you are taking (which I like BTW)? I'll try resetting the settings, but what's weird is why wouldn't my old version work? I don't need to update the bootloader/firmware do I?
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 31, 2006, 03:01:12 AM
Quote
f I select it, it acts like it's going to go into rockboxs, but then ends up back at the boot screen

What does this mean? How do you select it? which boot screen and what does back at the boot screen mean?

Bootloader 6 is the latest but I think it should work fine with 5 I'd reflash if it's below 5, but otherwise this isnt your problem.

If you had 'startup on recording screen' enabled then this is currently out of action and results in a hang on the loading rockbox screen (thanks to  nigelsh for spotting that one) - resetting the settings will get you in but you can't use this feature at the moment. I'm looking into it - but no promises ;)

Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 31, 2006, 03:08:30 AM


I don't see any screenshots in post #1!

really? weird...They are definitely there at the bottom of the post.

Quote

Could someone explain what the three items are that display at the bottom of the recording screen (iriver h120). There's something that looks a bit like a battery which has 23m written in it,

That's the remaining battery time

Quote

 then comes a rectangle with 14h in it

that's the amount of diskspace left. Thinking about it I'm not sure if this works with the new codecs...something to look at...

Quote

and then another rectangle that looks like it might be some kind of a gauge.

Thats the Balance meter.

Quote

 Is this stuff documented somewhere?

Nope, Although it could be on the histogram flyspray page - link in post#1
Title: Re: Recording Enhancements Pack
Post by: BayTaper on August 31, 2006, 10:02:05 AM
Sorry, I don't have my "terms" down right. I managed to figure out that I had to press the A-B button from the first menu after boot. Funny thing is, I used to be able to press on the rockbox file to move forward, but not anymore, who cares though, as long as I know how it works. HOWEVER, man 'o man did I have issues with the REC on Startup. I finally fixed it all, but here's the post I made at TS in the hopes of sparing others the hassle. I learned a few things about recovering that's for sure...


"Oh man, I thought I was screwed for a while, but I learned a few things and tips from you guys made a BIG difference. For strarters, I was able to get to the normal rockbox menus by pressing A-B. Doh! So I wasn't as screwed as I thought I was this morning. But then, after getting the new REP installed and working, and after setting all of my settings, I was goofing around recording, and the thing seized up, frozen solid, like mmmatt it sounded like, but I didn't have the luxury of being able to unplug the damn thing. I so couldn't figure it out, nothing would unfreeze it, not plugging in electricity, plugging in the USB cable, holding various buttons, nothing. Then, I figured out there is a tiny reset button on the bottom (think paperclip hole), but even though that made a clicking noise, the unit was still hung. I thought I was going to have to wait until the battery died. But then I read somewhere that people were having a really, really hard time getting their reset buttons to work, they said you needed to use something even smaller than a paperclip, and you need to hit the reset direct on or it wouldn't work. So, I used the backside of a threaded needle, the eye part not the pointy part, and lo and behold, I could get it to turn off. But, I'd turn it back on and then freeze. Hit reset, pluged it into the computer, worked no problem again. Unplugged the USB, frozen again. Booted into iRiver no problem though, so I reformatted, reloaded the files, turned it on, frozen again. Then I reset the firmware again, reformatted, loaded the files, and FREEZE. FUCK! Sound familiar though? Exactly what was happening to mmmatt, but I had to use the reset to get it to turn off (very important to know, this should be added to the FAQ). So finally, doh! I did what mmmatt said (and took it one step further with flashing the firm again). I (1) re-flashed the firmware (probably not necessary), booted into iRiver mode, reformatted the drive, turned it off, connected to computer, loaded an OLDER version from 7/31/06 daily build, safely unplugged, and FINALLY, it worked. Then, dragged back on the latest version, and everything has been working sense. I also get the same sinking feeling mmmatt got, which was that it was RECORD on startup that screwed me over. It always hung with the startup screen showing, and the words "Recording" overlaid on the screen, the "Recording" text box looking just like it does when you go into the recording screen from the menus. For now, on my trip, I'm not going to use that boot to recording screen or any of the recording shortcuts cause I don't trust it. Also, I learned that you can save a CONFIG file from the Manage Menu, that saves all of your settings to a file and can easily be reloaded after upgrades if your settings get reset. So, I went back, customized all of my settings, and saved a config file (manage > save config > press play to save... I think). Finally, I'll have to say, the ability to tweak the font a little bigger (you still can't use the taller fonts, but you can get a slightly bigger one that is bolded, I found something that starts with an "n" I think was the largest/boldest I could get to work in the recording screen -- if you pick a font too big, the recording screen will go back to the default size, so you have to experiment to find a bigger font that will actually show on the recording scren. Finally, the new REP has a setting for the size of the peak meters -- just SO F'ING COOL. Worth installing REP for that feature alone, LOL! The meters on this thing are so awesome!!! Anyway, thanks so much for the tips here. I thought I'd write this all down for everyone because it might help someone someday. But at a minimum, I think we need to add some content to the iRiver FAQ about the reset button, what it is, where it is, and that it behaves weird (paper clip fits in and feel like it presses a button, but that doesn't work, something thinner in just the right spot, doesn't even feel like a button was pushed, so be careful not to push too hard with something sharp, that does reset it. The second thing we should add to the FAQ is the process for resurrecting an iRiver that's badly hung/frozen: the whole reflash, reformat via irvier, reload rockbox files with an old build, then boot, then reload newer software routine. It's more of a desperate act, but now there have been two of us that have been saved by that routine.

THANKS! (phew, what a rant... Hope that helps someone someday...)"

Title: Re: Recording Enhancements Pack
Post by: Rincewind on August 31, 2006, 12:57:18 PM
an easier way would have been to start rockbox and hold the Record Button    IMMEDIATELY after the bootloader. This sets rockbox to default settings.

reflashing and reformatting doesn't help much, because there is only the bootloader in the flash (bootloader is never changed by a running rockbox, if it works once it works every time), and the settings are stored in a hidden sector of the disc that can possibly stay even after formatting.

You succeded, because you switched back to a version that used different settings than the current one, so it cleared automatically at boot.

But that's only my guess, I can be wrong.
Title: Re: Recording Enhancements Pack
Post by: BayTaper on August 31, 2006, 01:16:11 PM
Seems reasonable enough to me. I was trying to figure out how it could possibly stay screwed even after flashing and reformatting. I didn't realize that the settings could survive those two steps. Thanks for the tips!
Title: Re: Recording Enhancements Pack
Post by: Mmmm on August 31, 2006, 02:51:24 PM
Baytaper: Glad you got it working in the end.. You should practise the 'holding record just after pressing the on button' trick. It'll get you out of many a sticky situation..

About the recording on startup...I have finally (after two days of following trails of code around and keeping that record button pressed) worked out what the problem is and all CVS builds should work now.

I've done a new build for the REP and so all should be well again..Hoorah \o/ post#1... ;)
Title: Re: Recording Enhancements Pack
Post by: nigelsh on August 31, 2006, 10:13:58 PM
About the recording on startup...I have finally (after two days of following trails of code around and keeping that record button pressed) worked out what the problem is and all CVS builds should work now.

I've done a new build for the REP and so all should be well again..Hoorah \o/ post#1... ;)

Great work. Thanks. Your latest build appears to be working OK now.

Any chance of adding the recording source to the recording window? Most of the time I record via Line-In but occasionally I record from FM. It would be nice to have a reminder of what source I'm using on the recording screen (I just know that I'm going to end up recording some FM when I think I'm recording a live show - showing the source on the recording window won't stop that happening but it might make it a little less likely!)

By the way, I've looked at post #1 in Firefox and in IE - there are no pictures - unless I'm logged in! When I complained about the lack of pictures earlier I was not logged in - now that I am I see the pictures!

Thanks
Nigel
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on August 31, 2006, 11:48:31 PM
While not recording the STOP icon in the statusbar is a musical note instead of a solid square. That tells you if the source = FM Radio. But nothing will tell you while you're actually recording. But maybe that's enough?
Title: Re: Recording Enhancements Pack
Post by: Mmmm on September 01, 2006, 04:05:34 AM
Great work. Thanks. Your latest build appears to be working OK now.
Ahh good stuff, thanks for testing it...
Quote
Any chance of adding the recording source to the recording window?
Yes, I've been thinking that now with so many sources it's getting difficult knowing which one you are in without going into the recording menu... But the question is, where does it go! And now we get a crossover with this thread http://forums.rockbox.org/index.php?topic=5882.0

Title: Re: Recording Enhancements Pack
Post by: Mmmm on September 01, 2006, 04:48:37 AM
I just broke the patch with a commit so there is a new one in post#1. No new build needed though as the commit didn't affect the functionality of the REP.
Title: Re: Recording Enhancements Pack
Post by: redwood on September 01, 2006, 08:58:00 AM
To everyone involved in the REP - thanks so much, with all the recent improvements this is what the H120 should always have been

Mmmm - thanks again for fixing that font overwriting the histogram probrlm - works like a charm.

jp
Title: Re: Recording Enhancements Pack
Post by: Mmmm on September 01, 2006, 09:47:47 AM

To everyone involved in the REP - thanks so much, with all the recent improvements this is what the H120 should always have been

Mmmm - thanks again for fixing that font overwriting the histogram probrlm - works like a charm.

jp

Great, I'm glad it's working now...any more problems just post :D
Title: Re: Recording Enhancements Pack
Post by: norbusan on September 01, 2006, 02:53:06 PM
Hi all!
Hmm, it still doesn't compile here. Just 5min ago (ie 21:50 CEST) I did a fresh cvs checkout and redownloaded the REP, applied it (no error/warnings), configured it for H300/Normal build and I get:
In file included from bookmark.c:38:
recorder/icons.h:28:25: rockboxlogo.h: No such file or directory
recorder/icons.h:30:32: remote_rockboxlogo.h: No such file or directory
make[1]: *** [/data/src/iriver/rockbox/bla/build/apps/bookmark.o] Error 1
make: *** [all] Error 2

Any ideas ...

Ciao
Norbert
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on September 01, 2006, 06:07:53 PM
Lots and lots of changes lately! Me likey...  :)

I believe you current patch breaks the Simulator.
I am not absolutley certain since I have one other (very very simple) patch installed.
But I'm pretty sure.
Title: Re: Recording Enhancements Pack
Post by: paulheu on September 01, 2006, 07:45:13 PM
New h3x0 build available here (http://forums.rockbox.org/index.php?topic=6038.msg48483#msg48483)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on September 02, 2006, 03:39:00 AM
I'm going to be doing more work on the statusbar patch for a few days and then I'll commit it... which will break the REP again so I'm not going to touch it until then... (although if it's a simple one I might put a new patch up, we'll see... :)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on September 02, 2006, 03:48:20 AM
It was very simple...I forgot to put Rincewind's extra files in the patch  ::) That'll teach me for being in a rush eh? Try it now...
Title: Re: Recording Enhancements Pack
Post by: Mmmm on September 02, 2006, 12:41:26 PM
New patch as I just committed the statusbar patch

It hasn't even come up on the homepage yet! It doesn't get much faster than that! :D
Title: Re: Recording Enhancements Pack
Post by: Mmmm on September 13, 2006, 05:40:03 AM
A new addition to the REP. A countdown timer so you can set recording to start at some time in the future (particularly useful for radio recording)

see this thread for more info
Countdown timer thread (http://forums.rockbox.org/index.php?topic=6297.0)

Post#1 as always....
Title: Re: Recording Enhancements Pack
Post by: IpaqMan on September 13, 2006, 10:37:00 AM
Your current H120/140 build appears to be an Aug 31 build.
Title: Re: Recording Enhancements Pack
Post by: thermiGR on September 13, 2006, 01:19:27 PM

Your current H120/140 build appears to be an Aug 31 build.



Thanks to Mmmm. Now everything is perfect!!!!!! Mono and stereo .wav, .WV and .mp3 recording with very good mp3 codecs. Thanks, thanks, thanks .....
Title: Re: Recording Enhancements Pack
Post by: Mmmm on September 13, 2006, 01:38:18 PM

Your current H120/140 build appears to be an Aug 31 build.

Really..oops, soory about that...I've redone it (and now it has the div by zero fix so it shouldnt crash anymore \o/)...


Thanks to Mmmm. Now everything is perfect!!!!!! Mono and stereo .wav, .WV and .mp3 recording with very good mp3 codecs. Thanks, thanks, thanks .....

Well, although I'd love to take the credit for everything, I must just point out that none of that was me! :(

It was that JSMikes bloke....
I just do the tiny insignificant things...If I didn't pipe up here now and then noone would even know I exist! :D
Title: Re: Recording Enhancements Pack
Post by: vanakaru on September 20, 2006, 03:37:24 PM
Thanks for all this great work.
I do not follow every change in development, but just check in time to time.
When I first started the latest recording pack I had the same font on recording screen than the rest of the menues. Next time I started it was back to default fonts and I am not finding the way to change it.
Does it got finally added, so we can have a large font on recording or I saw ghost.
This is a feature I have been waiting, because in many recording situations I just do not see the small font on screen and can not put everything down to get my glasses.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on September 21, 2006, 02:43:02 AM

Thanks for all this great work.
I do not follow every change in development, but just check in time to time.
When I first started the latest recording pack I had the same font on recording screen than the rest of the menues. Next time I started it was back to default fonts and I am not finding the way to change it.
Does it got finally added, so we can have a large font on recording or I saw ghost.
This is a feature I have been waiting, because in many recording situations I just do not see the small font on screen and can not put everything down to get my glasses.


The font changes depending on what you are doing (bear with me, there is a good reason ;)). You can fit a larger font on the screen if you are using mic in than you can if you are using line in because of the number of lines used for the gain settings, so whichever font you usually use is more likely to be used in the recording screen if you are using mic in. Also if you turn the histogram off (long press mode) you can fit larger fonts in (you can have this off by default by changing the setting in the menu). Oh yes and the smaller you set your peak meters the larger the font you can use.

So what I am saying is that the recording screen checks the size of your user font to see if it will fit on the screen. If it does then it uses your user font, If it doesn't, it uses the default font.

This feature is only in the REP and not the CVS version of rockbox, mainly because it is a bit of a hack. The proper way to do it would be to have either a completely customisable recording screen (like the WPS) where you can make your own screen to fit the font that you use, or have a separate font setting for the recording screen so that you could choose the font that you want to fit your usual setup. Both being rather tricky to implement! :)
Title: Re: Recording Enhancements Pack
Post by: vanakaru on September 21, 2006, 07:26:16 AM
Great, it works. Using xtal-14 and histogram off I have custom fonts in recording window.
All this work you have done makes h140 an excellent portable recorder. I was missing the original external mic line in power first, but after going to better mic with small preamp I get much better S/N ratio and sound quality owerall.
Thanks guys!!
Title: Re: Recording Enhancements Pack
Post by: petur on September 21, 2006, 09:35:58 AM

I was missing the original external mic line in power first, but after going to better mic with small preamp I get much better S/N ratio and sound quality owerall.

???
There's nothing missing regarding this in Rockbox.

The line-in connector always supplies mic power - it can't be switched off

Rockbox offers you the full analog and decimator gain range the hardware offers, iriver only offers two smaller and overlapping ranges. You're getting more, not less.

edit: read your post about frying the mic power of your player - that explains it all then...
Title: Re: Recording Enhancements Pack
Post by: mborus on September 25, 2006, 03:50:24 AM

Hi,

I finally installed the REP to get the larger font size and
it worked great over the weekend.

I've got one problem, though:

I often pause and restart the recording. On the weekend I copied a batch of 100 vinyl singles. Here I paused whenever I changed the singles and adjusted the gain for each.

My biggest fear is that I leave the Iriver in REC-PAUSE mode instead of recording. This has happened a few times in the past. On the Archos units, the flashing red LED shows the pause - on the Iriver, there isn't anything that catches my attention fast. I after restarting, I need to look at the display for a second to catch the time changing.

Am I the only one with this problem?



Title: Re: Recording Enhancements Pack
Post by: Mmmm on September 25, 2006, 04:40:28 AM
There is a pause icon in the statusbar!
Title: Re: Recording Enhancements Pack
Post by: mborus on September 25, 2006, 05:04:55 AM
Quote
There is a pause icon in the statusbar!


Alas this icon is so small that I can't make out the difference
between recording and paused when glancing at the display
without picking up the H120. In a normal recording situation
where the H120 is on a table one arm length away from me the
icon doesn't help much.








Title: Re: Recording Enhancements Pack
Post by: petur on September 25, 2006, 06:22:55 AM
/me presents the option to have the background color changed depending on the state :) Would this be a great idea? At least I would be using this as I often find myself in the same situation
Title: Re: Recording Enhancements Pack
Post by: Mmmm on September 25, 2006, 06:23:53 AM

/me presents the option to have the background color changed depending on the state :) Would this be a great idea? At least I would be using this as I often find myself in the same situation

It would be a great idea if you had a nice flashy colour screen yes! :D
Title: Re: Recording Enhancements Pack
Post by: Llorean on September 25, 2006, 06:25:56 AM
Yeah, that only solves the problem for two of the at least five recording-capable targets I can think of off the top of my head. Clearly not the best solution. ;)

Could you perhaps make something on the screen itself blink, like say the peakmeter flashing between displayed and not? That being moderately large and easy to notice, if it were blinking would be a clear sign of it being paused. Or really, anything blinking in and out.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on September 25, 2006, 06:28:19 AM
Not the peakmeter as you need to use that while the recording is paused... A tricky one that.
Title: Re: Recording Enhancements Pack
Post by: petur on September 25, 2006, 06:49:17 AM
inverted colors?

and sorry for insulting you poor B&W display users :p
Title: Re: Recording Enhancements Pack
Post by: mborus on September 25, 2006, 07:04:31 AM
Quote
inverted colors?

and sorry for insulting you poor B&W display users :p


Inverting the LCD in recording pause mode (but not stop mode) would
solve the problem for me. This is easy to spot and doesn't
cover any of the other screen information.

Of course this should be optional for either screen and/or remote
and could be deactivated by default.

Title: Re: Recording Enhancements Pack
Post by: petur on September 25, 2006, 07:10:56 AM

Of course this should be optional for either screen and/or remote
and could be deactivated by default.

of course ;)
Title: Re: Recording Enhancements Pack
Post by: Rincewind on September 25, 2006, 10:02:12 AM
Isn't there enough room somewhere on the screen (I'm not talking about remotes or archos here) to have a HUGE Pause icon flashing?
Title: Re: Recording Enhancements Pack
Post by: petur on September 25, 2006, 10:07:29 AM
I fear most REP users would say 'no' ;)
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on September 25, 2006, 11:43:07 AM
Quote
Inverting the LCD in recording pause mode (but not stop mode)


Better yet, only invert during recording. (?) you cant leave the screen anyway while you're actually recording so why not?

I think inverting the LCD during recording is a very good idea.

Title: Re: Recording Enhancements Pack
Post by: Mmmm on September 25, 2006, 02:45:22 PM

I fear most REP users would say 'no' ;)

Yeah... look at the screenshots in post#1 no more real estate I'm afraid...!

The thought of a totally inverted screen gives me a headache... couldn't we just invert one thing? like the top two lines or something? Or maybe that wouldn't be obvious enough..I don't know...

I don't think inverting during recording would be useful would it? I suppose then it would be easy to tell that it is recording...how would you know it was paused and not stopped?
Title: Re: Recording Enhancements Pack
Post by: petur on September 25, 2006, 03:51:17 PM
on color targets we could write a huge stop/pause/rec symbol into the backdrop buffer :) in soft colors of course to keep text readable.
Title: Re: Recording Enhancements Pack
Post by: Llorean on September 25, 2006, 03:52:32 PM
Maybe just a "backlight on pause" option that allows the user to set the backlight to stay on while recording is paused?
Title: Re: Recording Enhancements Pack
Post by: Rincewind on September 25, 2006, 04:07:52 PM
maybe the time could be flashing in pause? There is some screen estate in the line of the time (on the right). Maybe something could be put there.
I'm not in favor of the invert screen thing. A new user could think he has done something very wrong if he sees it the first time.
Title: Re: Recording Enhancements Pack
Post by: mborus on September 26, 2006, 02:08:20 AM
Quote
maybe the time could be flashing in pause?


I prefer the inverted LCD, but this is not a bad idea.
Many digital stopwatched flash in pause mode, so this
is quite intuative.

Quote

I'm not in favor of the invert screen thing. A new user could think he has done something very wrong if he sees it the first time.


True, but as a option that is turned off by default a new user would not see this.
Also, the inverted screen would go away as soon as the recording is restarted or
stopped completely. So even if it confuses a new user, he/she should understand it
soon.
Title: Re: Recording Enhancements Pack
Post by: petur on September 26, 2006, 02:15:52 AM

Also, the inverted screen would go away as soon as the recording is restarted or
stopped completely. So even if it confuses a new user, he/she should understand it
soon.


err... I'd rather have an indication that makes a difference between recording and not recording, not between pause and stop/rec.
Title: Re: Recording Enhancements Pack
Post by: Rincewind on September 26, 2006, 07:28:34 AM
it should be something that doesn't need a configurable option. More options in the settings menu = less likely to ever get commited.
Title: Re: Recording Enhancements Pack
Post by: pabouk on September 26, 2006, 08:40:15 AM
I am against inverting the whole screen. It would be hard to read and it is not so easily visible as something flashing.

I vote for one flashing (alternating inverted and normal text) line or part of a line - possibly the time.
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on September 26, 2006, 10:57:48 AM
I got an idea (what's new?)

A two line high, right justified icon, across from the "Time" and "Size" lines.

Square (stop) Double Vertical Bar (pause) and Circle (record).

I would also implement a blinking (invert/normal) time line during pause.
as well as a full screen invert during record.

Check the png's! (remember the inverted line in the pause screenshot should 'blink')

Edit: After looking at them I'd put a two pixel space between the screen edge and the end of the blinking (paused) time line, instead of only a single pixel. It just needs a little 'breathing room'.

[attachment deleted by admin, too old]
Title: Re: Recording Enhancements Pack
Post by: Mmmm on September 26, 2006, 03:36:46 PM
Well...that looks pretty good (apart from the middle screenshot, that is horrible! :D) but the other ideas I reckon should do the trick... I'm looking forward to seeing your patch ;)
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on September 26, 2006, 03:48:36 PM

I'm looking forward to seeing your patch ;)


If everyone is willing to be (possibly infinitely) patient I'll take the challenge.  ;D
Title: Re: Recording Enhancements Pack
Post by: mborus on September 27, 2006, 02:05:54 AM
Quote
If everyone is willing to be (possibly infinitely) patient I'll take the challenge.  Grin


Look good. I'm happy to wait for this...
Title: Re: Recording Enhancements Pack
Post by: IpaqMan on September 27, 2006, 08:49:08 PM
I understand that most recording users stay with uncompressed recording, but some of us are using the H1xx for recording classes and 64K mp3s are sufficient.  With that in mind, the disk space warning seems to be based upon uncompressed recording and the recording screen minutes left on disk seems to be based upon uncompressed recording, too.  

IMHO, the disk space warning and the minutes left display should account for the actual recording quality.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on September 28, 2006, 02:37:31 AM

I understand that most recording users stay with uncompressed recording, but some of us are using the H1xx for recording classes and 64K mp3s are sufficient.  With that in mind, the disk space warning seems to be based upon uncompressed recording and the recording screen minutes left on disk seems to be based upon uncompressed recording, too.  

IMHO, the disk space warning and the minutes left display should account for the actual recording quality.


Good point, I hadn't thought of that!
Title: Re: Recording Enhancements Pack
Post by: Llorean on September 28, 2006, 05:47:07 AM
I was curious: Does encoding happen during prerecord? Or does it not start until recording is active? I mean, I can't think of a time I'd need a 10 minute pre-record unless I just forgot to press record for some reason, but it was simply a thought I had. (Also, better battery life while not recording if encoding is able to be postponed until recording starts.)
Title: Re: Recording Enhancements Pack
Post by: petur on September 28, 2006, 07:30:52 AM

I was curious: Does encoding happen during prerecord? Or does it not start until recording is active? I mean, I can't think of a time I'd need a 10 minute pre-record unless I just forgot to press record for some reason, but it was simply a thought I had. (Also, better battery life while not recording if encoding is able to be postponed until recording starts.)

Yes, the way it is currently implemented, the codec is init and runs as soon as pre-recording starts, and any chunk the DMA handler releases is picked up by the encoder.

The pre-recording logic was also moved to act on encoded chunks.

To solve the spdif samplerate issue and to save battery life, it would be better to handle the pre-recording in the WAV buffer, not the encoder buffer.
Title: Re: Recording Enhancements Pack
Post by: larry_llama on October 18, 2006, 03:23:49 PM
Has anyone tested: does the battery last longer using wav (more disk access/less processing) or wavpack (less disk access/more processing)? Just curious!

PS thanks again to everyone who has coded (and tested (and made suggestions)) toward making this recording package a reality!
Title: Re: Recording Enhancements Pack
Post by: fraide on October 20, 2006, 05:42:29 AM


I understand that most recording users stay with uncompressed recording, but some of us are using the H1xx for recording classes and 64K mp3s are sufficient.  With that in mind, the disk space warning seems to be based upon uncompressed recording and the recording screen minutes left on disk seems to be based upon uncompressed recording, too.  


IMHO, the disk space warning and the minutes left display should account for the actual recording quality.


Good point, I hadn't thought of that!


hye,

I find 'recording Enhancements Pack' very useful.
But it isn't by default in the Rockbox daily build and i haven't the competencies to encoding my own build.
Before the news 'rockbox daily build improvement' i used your build but it had not been updated since the 13 september 2006 : http://homepage.ntlworld.com/martin.scarratt/Rockbox/rockbox.zip

Please, Could you update it ? I think I'm not the only person who will be happy.
Thanks by advance,
Fraide
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on October 20, 2006, 09:31:01 AM
I's suggest waiting for MikeS's big recording update to be committed and tested, then patch the REP.
Title: Re: Recording Enhancements Pack
Post by: jhMikeS on October 20, 2006, 01:54:05 PM
Hey Davide...to speed things up, wanna check the switching and sample rates on my chicken-out version of the patch? It basically works like it did before when you could switch and 11kHz might even go. If it works alright, up it goes.  ;D
Title: Re: Recording Enhancements Pack
Post by: Bedlore on October 21, 2006, 06:57:36 PM
Hi Guys

Awesome work on the REP and rockbox generally.  I looked at using this sometime ago but back then there was no mp3 recording support.  Even though I'm a complete newbie I found the install pretty friendly and well documented.  But one thing I haven't found so clear is how to follow changes in REP and download the latest.  

I own a H140 and I used the version of REP supplied by Martin Scarratt.  But it would be great if there was a change log or something.  For example there is a pretty serious bug fix here: http://forums.rockbox.org/index.php?topic=6718.0  Is that in the latest REP pack and if not how do I manually apply it?

Many Thanks.
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on October 21, 2006, 10:23:37 PM
AGC in in the CVS, thus whenever Martin (Mmmm) syncs the REP with CVS any CVS bug fixes will be included.
Title: Re: Recording Enhancements Pack
Post by: Arni on October 22, 2006, 02:41:53 AM

For example there is a pretty serious bug fix here: http://forums.rockbox.org/index.php?topic=6718.0  Is that in the latest REP pack and if not how do I manually apply it?

Many Thanks.

i am using the REP of Mmmm and could NOT find this bug when using agc-safety-clip.
my post in the AGC-thread thread does not refer to the REP!
using the REP i set the levels way too low and after 10 hours they didn´t boost at all.
so for ME there is no "bug" in Mmmm´s REP although it should be there aswell.
strange ;).
i will definitely use the REP of Mmmm with AGC-safety clip(maximum gain set at +24dB..I will start the recording with +24dB and AGC will decrease the levels as needed!) for recording the next 3 concerts due in a few weeks!
Title: Re: Recording Enhancements Pack
Post by: petur on October 22, 2006, 02:56:23 AM
afair, this bug was only triggered with low signals and substantial differences between left and right. The bug was in the balance correcting code, which didn't take the AGC mode into account.

I think Mmmm's build is from 13 september, so the bug should be in that build. But the circumstances that trigger it are rare enough to not bother too much. I've used AGC a lot and only encountered it once.
Title: Re: Recording Enhancements Pack
Post by: mlind on October 23, 2006, 06:23:38 AM

The bug was in the balance correcting code...


Hey hey hey!
Ballance correcting?!?
When, how and why?
Title: Re: Recording Enhancements Pack
Post by: Mmmm on October 23, 2006, 06:44:31 AM
Hi folks....

I will get around to updating this but unfortunately I had to reformat my drive and so it won't be as easy as usual as I've lost my nice cvs updatable version... It'll probably give me a bad headache so I've been putting it off....

I probably will wait until Mike has got his bit sorted (I think this is a great excuse to put it off a bit longer, Thanks Davide for the idea ;)).

Oh, and completely off topic, I finally got another job...wooohooooo... So now I can be as busy as you Petur! ;)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on November 14, 2006, 12:29:52 PM
Well I've finally updated it..... Only the patch for now, I'll do my build tomorrow probably.

I've removed the countdown timer as I now have a better version and I'll probably commit it soon...

and just think of all those new goodies in cvs you can play with now too!
Title: Re: Recording Enhancements Pack
Post by: Mmmm on November 14, 2006, 03:58:37 PM
Found some time to get it done tonight..... The updated patch and build is in post#1.... :o
Title: Re: Recording Enhancements Pack
Post by: Bedlore on November 14, 2006, 08:45:44 PM
Thanks for the update.  I've updated my iHP-140 but think I found a bug, I updated to version 061114-2046 but now I seem unable to record an mp3 in mono.  Can some else confirm if this is a new bug please.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on November 15, 2006, 04:20:01 AM
It seems to work for me... What is the problem exactly?
Title: Re: Recording Enhancements Pack
Post by: Mmmm on November 15, 2006, 06:15:42 AM
Small update, now the font sizing etc takes the trigger into account if you have it switched on - if the trigger wont fit, it moves up to the second line and shrinks a bit.
Title: Recording channels
Post by: Bedlore on November 15, 2006, 06:36:42 AM
Perhaps I have forgotten how to set it, but I thought that previously you could into Recording Settings / Channels and select mono recordings.  I definately did this somewhere and I thought Channels was the logical place.  Am I wrong?

Thanks Martin
Title: Re: Recording Enhancements Pack
Post by: Mmmm on November 15, 2006, 07:17:30 AM
Yes, that's right, what happens when you do that?
Title: Re: Recording Enhancements Pack
Post by: petur on November 15, 2006, 07:25:11 AM
confirmed with latest CVS build: if format is set to mp3, the channels option only lists stereo.
I suggest you create a bugreport in the tracker if there isn't already one...
Title: Re: Recording Enhancements Pack
Post by: Mmmm on November 15, 2006, 08:06:26 AM
confirmed with latest CVS build: if format is set to mp3, the channels option only lists stereo.
I suggest you create a bugreport in the tracker if there isn't already one...
Ahh.. the build I'm using must be a smidgin too old, it being from yesterday and all.  ::)
Title: Re: Recording Enhancements Pack
Post by: petur on November 15, 2006, 03:59:43 PM
This seems to be by design:

320kbps stereo is in fact 2x160kbps streams, one for each channel. So it is not possible to go higher than 160kbps in mono.

So: to record mp3 mono, just stay on or below 160kbps....

Title: Re: Recording Enhancements Pack
Post by: Mmmm on November 15, 2006, 04:18:46 PM
Aha, that explains a lot..I was trying it with 128kbps
Title: Re: Recording Enhancements Pack
Post by: simon142857 on November 15, 2006, 07:16:59 PM
Another big Thank You to Mmmm, Petur, and others for this brilliant REP!
I've been making some field recordings with my H120, and was trying to split a file on the Iriver while away from my computer. I noticed that the plugin "splitedit" doesn't work for us Iriverians. Is there anyone involved getting this plugin on board?
Title: Re: Recording Enhancements Pack
Post by: Jeules on November 17, 2006, 02:27:33 AM
I just installed the latest build from post #1, on my iHP-140.  This is my first time with the pack.  When I goto the recording screen I get:

I05:Divx0
at 31025788

???
Title: Re: Recording Enhancements Pack
Post by: Mmmm on November 17, 2006, 04:28:18 AM
I just installed the latest build from post #1, on my iHP-140.  This is my first time with the pack.  When I goto the recording screen I get:

I05:Divx0
at 31025788

???
I've just tried it myself with no problems. Try resetting your settings.
Title: Re: Recording Enhancements Pack
Post by: davitchus on November 17, 2006, 06:26:44 AM
Hello
I would like to ask, what's the state of developement of Recording Enhancements Pack for IaudioX5L?
I'm newbie in using rockbox and my friend has a iriver H340 and would like to know
if it's possible to have all features he has, especially AGC and histogram.
Thank you, David
Title: Re: Recording Enhancements Pack
Post by: Mmmm on November 17, 2006, 09:04:37 AM
The X5 and the I-Rivers are Identical for recording (and the REP).
Title: Re: Recording Enhancements Pack
Post by: petur on November 17, 2006, 10:07:51 AM
Let me add following warning to that statement: You can build the REP for X5, not use the pre-build binaries, which only run on iriver h1x0 and h3x0 respectively.

So you'll have to download the patch and apply it to your local tree and build yourself.
Title: Re: Recording Enhancements Pack
Post by: Jeules on November 17, 2006, 12:14:25 PM

I've just tried it myself with no problems. Try resetting your settings.


I reset the settings and reinstalled your newest build and still get the error on the recording screen.  Is there any way it could be because my 140 has been upgraded with one of those 60 gig drives?
Title: Re: Recording Enhancements Pack
Post by: Mmmm on November 20, 2006, 07:23:14 AM
Let me add following warning to that statement: You can build the REP for X5, not use the pre-build binaries, which only run on iriver h1x0 and h3x0 respectively.

So you'll have to download the patch and apply it to your local tree and build yourself.
Ha ha... Good point...

I've just tried it myself with no problems. Try resetting your settings.

I reset the settings and reinstalled your newest build and still get the error on the recording screen.  Is there any way it could be because my 140 has been upgraded with one of those 60 gig drives?
I wouldn't think so. Do you get the same error with an un-patched build?
Title: Re: Recording Enhancements Pack
Post by: Mmmm on November 22, 2006, 04:52:01 AM
Build updated and tiny tweak to patch to get rid of a conflict.
Title: Re: Recording Enhancements Pack
Post by: amoergosum on December 07, 2006, 08:45:21 AM
Is there a REP manual actually?
For example I have no idea what the section "trigger"
is for.
/Ben
Title: Re: Recording Enhancements Pack
Post by: Mmmm on December 07, 2006, 01:34:50 PM
I have committed the trigger patch so it's in the main build so not really part of the REP, there is no manual for the REP apart from what's in post#1 and the links there.
There is a lot of info on the trigger though, have a look at this thread: Trigger Thread (http://forums.rockbox.org/index.php?topic=7004.0)
Title: Re: Recording Enhancements Pack
Post by: IpaqMan on December 23, 2006, 04:32:05 PM
Just a comment to those who may not have seen it.  There is a hardware mod and Rockbox patch for the H120/H140 that gives it a real-time clock!  I did the mod and now my recordings are named after the date and time.  That makes it so much easier to differentiate my recordings.

For the patch, I CVSed the December 16 build and added both the RTC.patch and the Recordingenhancementspack.patch.  The build ran successfully and works fine thus far on my H120.

For more information, see the Rockbox Hardware forum and look for the RTC thread.

Title: Re: Recording Enhancements Pack
Post by: redwood on December 30, 2006, 06:51:50 PM
I thought I saw something about this once but could not find it after a search. If this is a known issue then sorry.

Might've found a small bug with the REP, or maybe it's just rincewind's button patch. I am using a CVS build from 12/23 patched with the REP patch from Mmmm's sig so it was all rolled into that patch...have confirmed this with Kosh's most recent build as well.

Basically what happens is if you use the button config (long press of rec button goes to recording) to get to the recording screen and then press A-B to get to the recording settings, the "Source" menu item is missing.

However if you get to the recording screen from the menu item "Recording" and then select the menu item "Recording Settings" the "Source" menu item is there. Then it will stay there even if you go to the recording screen and then back to recording settings. But once you back out of recording entirely, the bug will manifest itself again.

curious......

update - I found that if you are in the recording screen under the above conditions and press stop and then select the "Recording Settings" menu item (instead of pressing the A-B button to enter the Recording Settings menu directly) the bug does not exhibit itself - it only appears when you first enter the recording screen and press A-B.

Title: Re: Recording Enhancements Pack
Post by: kleusl on January 01, 2007, 08:52:17 AM
@ Mmmmh
Your version is great and my absolute favourit. There were since 22.11. some changes in the original-build. Is it possible that you publish an update?
Do you know, where I find good manuals about patching files?
Thanks

Kleusl
Title: Re: Recording Enhancements Pack
Post by: Mmmm on January 01, 2007, 10:46:37 AM
Ok, patch and build updated....
Have a look in the "Getting Started and Compiling (http://forums.rockbox.org/index.php?board=33.0)" forum to get to grips with patching etc..there are lots of links and people getting stuck with it there.
Title: Re: Recording Enhancements Pack
Post by: kleusl on January 01, 2007, 01:51:15 PM
@Mmmm

Thank you!
Kleusl
Title: Re: Recording Enhancements Pack
Post by: Raptor on January 01, 2007, 11:34:27 PM
Mmmm,

Thanks for updating your REP build.  Could you update the Record Button Configuration patch when you have extra time?  I noticed that when I enter the recording screen using the Button Config option, the Source menu disappears.  I pointed this out to Rincewind and he has updated the patch.  Refer to the patches tracker for it:

http://www.rockbox.org/tracker/task/5555#comment11905

Thanks again!
Title: Re: Recording Enhancements Pack
Post by: Mmmm on January 02, 2007, 06:22:00 PM
Ok, updated build as it looks like something important happened in cvs to do with audio on Hxxx

Also Rincewinds button patch fixed.

And some more features: The countdown timer is back and as an extra bonus there is a repeat timer too.. See post#1 and the various links there for details.
Title: Re: Recording Enhancements Pack
Post by: paulheu on January 08, 2007, 06:14:22 PM
updated my H3x0 build. You can find it here (http://forums.rockbox.org/index.php?topic=6038.msg46550#msg46550).
Title: Re: Recording Enhancements Pack
Post by: renho3k on January 11, 2007, 02:57:53 AM
i'm looking into upgrading my h120 to an iaudio x5. i know the rockbox works in getting the iaudio  to record, but i was wondering if the recording enhancement pack works in getting recording via the remote on the iaudio x5 as well.
Title: Re: Recording Enhancements Pack
Post by: b0br on January 11, 2007, 03:50:50 AM

i'm looking into upgrading my h120 to an iaudio x5. i know the rockbox works in getting the iaudio  to record, but i was wondering if the recording enhancement pack works in getting recording via the remote on the iaudio x5 as well.


Well, don't do it!
My friend has recently bought x5 for recording purposes and he's strongly disapointed.
The line-in is so quiet, that he can't record anything without preamp. So he bought one from http://www.visivoxtechnologies.com but still he has problems with recording loud sounds (the result is distorted, but that's the issue of that preamp setup)
So if you have any chance, stick with your old good h120..
Title: Re: Recording Enhancements Pack
Post by: renho3k on January 12, 2007, 12:08:31 PM
well, that was hope-shattering news! darn. i was thinking the iaudio filled in the rest of the shortcomings of the h120. i guess i'll sit tight a bit longer before upgrading then.
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on January 20, 2007, 03:36:02 PM
I have been using the Mmmm build for my iRiver, since I got it. Mmmm, thanks for the work and the recent update.
Title: Re: Recording Enhancements Pack
Post by: qpwoei on January 21, 2007, 05:46:41 AM
Guys, you always amaze me. I update RB twice a year only and... well, each time is like I'm using a brand new machine...for free  ;)
You are great, thanks a bunch for the effort, you make an excellent job.

cheers
Title: Re: Recording Enhancements Pack
Post by: norbusan on January 27, 2007, 06:10:18 PM
Hi all!
Any chance to update this to the new settings.c code?

Thanks a lot and all the best

Norbert (norbusan build)
Title: Re: Recording Enhancements Pack
Post by: paulheu on January 27, 2007, 06:22:55 PM
I believe I got the sync right.. here's my diff patch (http://www.audiostuff.info/rockbox/patch/recordenhpack070128.patch)
Title: Re: Recording Enhancements Pack
Post by: norbusan on January 27, 2007, 06:46:55 PM
Hi Paul!

Thanks a lot. BTW: Did you update some of the other patches, too? I have asked on the tracker for some of them in the meantime.

Thanks again for the great work

Norbert
Title: Re: Recording Enhancements Pack
Post by: paulheu on January 27, 2007, 07:07:59 PM
I have updated all patches I use which had changes to settings.c..
Title: Re: Recording Enhancements Pack
Post by: norbusan on January 27, 2007, 07:12:40 PM
But you probably don't have split out versions of these patches? Well, I will take a look at your and try to update the single patches.

Thanks and bye

Norbert
Title: Re: Recording Enhancements Pack
Post by: Rincewind on January 28, 2007, 10:11:52 AM
I'm going to wait with the update of my record button config patch until the menu rework is complete. Otherwise I would have to update everything again in a week or two.
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on January 28, 2007, 08:26:06 PM
I find that I use the balance indicator a lot to determine how centered my recordings are. I don't use the histogram at all. I'm wondering if the balance indicator is configurable or if it can be made configurable. I would like it to spead across the whole bottom of the screen, like the histogram does. I like that I can eliminate the histogram by holding the bottom right button for a couple of seconds.
Title: Re: Recording Enhancements Pack
Post by: paulheu on January 29, 2007, 05:39:25 AM
Even better, you can set the histogram to not show at all..
Title: Re: Recording Enhancements Pack
Post by: Bedlore on February 02, 2007, 06:49:14 PM
Can someone tell me if the RTCModH1x0 patch ( http://www.rockbox.org/twiki/bin/view/Main/RTCModH1x0 ) is compatible or even better, included in REP? Is there any chance of getting this permanently included in REP, that would be excellent if possible since REP and the iH1xx series RTC mod goes hand in hand.

I've never used a patch before so am not sure how to go about it.  Any advice would be appreciated.   Thanks  ;D
Title: Re: Recording Enhancements Pack
Post by: redwood on February 03, 2007, 04:25:45 AM
Hey

I was doing a build off today's svn and got a couple of hunk failures when patching the REP:

 patching file apps/user_action.c
patching file apps/user_action.h
patching file apps/SOURCES
Hunk #1 succeeded at 18 with fuzz 1.
patching file apps/action.h
patching file apps/settings.c
Hunk #1 succeeded at 724 with fuzz 2 (offset 19 lines).
Hunk #2 succeeded at 1123 (offset -1027 lines).
patching file apps/settings.h
Hunk #1 succeeded at 325 (offset 139 lines).
Hunk #2 succeeded at 420 (offset 133 lines).
Hunk #3 FAILED at 692.
Hunk #4 FAILED at 718.
2 out of 4 hunks FAILED -- saving rejects to file apps/settings.h.rej
patching file apps/settings_menu.c
Hunk #1 succeeded at 2206 (offset 20 lines).
Hunk #2 succeeded at 2296 (offset 20 lines).
patching file apps/sound_menu.c
patching file apps/tree.c
Hunk #3 succeeded at 783 (offset 2 lines).
patching file apps/gui/gwps.c
patching file apps/gui/statusbar.c
patching file apps/gui/statusbar.h
patching file apps/keymaps/keymap-h1x0_h3x0.c
patching file apps/keymaps/keymap-x5.c
patching file apps/lang/english.lang
Hunk #1 succeeded at 2716 (offset 3 lines).
Hunk #2 succeeded at 8598 (offset 3 lines).
Hunk #3 succeeded at 9902 (offset 3 lines).
Hunk #4 succeeded at 9955 (offset 3 lines).
Hunk #5 succeeded at 10271 (offset 3 lines).
patching file apps/recorder/icons.c
patching file apps/recorder/icons.h
patching file apps/recorder/peakmeter.c
patching file apps/recorder/peakmeter.h
patching file apps/recorder/recording.c
patching file apps/recorder/recording.h

Is this a problem with settings.h or the REP? I'm a novice at compiling so any assistance is appreciated.

jp


Title: Re: Recording Enhancements Pack
Post by: Rincewind on February 03, 2007, 05:45:53 AM
Which Patch did you use?
If you used the original REP from the first post in this thread, then it failed because the REP is out of date at the moment (that's because there was a large change about settings in SVN recently).
paulheu made an update of the REP, see a few posts above me.

If you used paulheu's patch then either this patch is out of date now, too, or something else was wrong. You can have a look at settings.h.rej and try to understand what failed.
Title: Re: Recording Enhancements Pack
Post by: redwood on February 03, 2007, 11:44:17 AM

Which Patch did you use?
If you used the original REP from the first post in this thread, then it failed because the REP is out of date at the moment (that's because there was a large change about settings in SVN recently).
paulheu made an update of the REP, see a few posts above me.


Yes I used the original patch my mmmm, thanks for the info. I see that Paul's patch is a diff patch and I'm a little unclear how to proceed with it, do I just patch the whole SVN build it the same way as the other patch, or do I patch the REP patch itself?


 You can have a look at settings.h.rej and try to understand what failed.


I did take a look at it and I didn't quite understand what the problem was - I'm still learning this stuff.

thanks!
Title: Re: Recording Enhancements Pack
Post by: paulheu on February 03, 2007, 06:06:29 PM
A diff or patch is (sortof) the same thing ..

A diff is the DIFFerence between the original and the patched code..
Title: Re: Recording Enhancements Pack
Post by: Bedlore on February 04, 2007, 06:22:16 AM
Howdy, I'd like to request that the REP releases recieve support for roolku's RTC mod for the H1xx please.  It really does go hand in hand with getting the most out of recording with Rockbox and I believe more and more H2xx owners will be doing this.
Roolku rolled one release as a once off here:
http://forums.rockbox.org/index.php?topic=7605.msg66916#msg66916

I'd like to hear others opinion on this.

Thanks
Bedlore
Title: Re: Recording Enhancements Pack
Post by: Rincewind on February 04, 2007, 08:37:53 AM
well, the code for the RTC really only makes sense if you have made the hardware-mod.
And I don't think that most users of the REP want to mod their player just to use the REP...
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on February 04, 2007, 10:32:07 AM
I just did the RTC mod and was unable to patch the REP version myself. I would like to see the RTC patch incorporated into the regular REP build.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 05, 2007, 04:06:58 AM
I havn't looked at the RTC patch because I'm not going anywhere near the innards of my player if I can help it, but the question is really whether it breaks un-modded players, if so It's definitely not going to get included. If not, I'll think about it!  :)
Title: Re: Recording Enhancements Pack
Post by: Bedlore on February 05, 2007, 05:06:57 AM
I encourage you install this mod, I didn't take any precautions really. I didn't earth my soldering iron, didn't disconnect the battery, accidentally soldered together the pins of an existing IC yet it survied and the mod works brilliantly.  

I accept that if it breaks un-modded units then it definitely must not be included, but I would be keen to help you decide if that is or isn't the case.

Thanks for considering it, in my opinion this mod is very significant and contributes what was a major lack to the H1xx units when it comes to recording.

Let me know how I can help :)
Title: Re: Recording Enhancements Pack
Post by: Llorean on February 05, 2007, 06:16:15 AM
Are any of the patches in this build still actively being developed toward inclusion? I've left this build alone for quite some time because it was a focus of several core developers, but by this point I haven't seen many recording enhancements move from this build to CVS, and it's reaching a point where I'm considering moving this thread to the unsupported builds forum before someone starts calling "hypocrisy" on me.

I'd really like to also know if any of the patches in this build are flat out likely to never be included in CVS.
Title: Re: Recording Enhancements Pack
Post by: roolku on February 05, 2007, 08:04:30 AM

but the question is really whether it breaks un-modded players, if so It's definitely not going to get included. If not, I'll think about it!  :)


Depends what you mean by "break". It will work, but timestamps and filenames will be set to invalid times rather than use the workarounds for RTC-less players. So I wouldn't recommend using it for players without the mod.

I guess that means two REP builds, one with RTC patch, one without.
Title: Re: Recording Enhancements Pack
Post by: LinusN on February 05, 2007, 08:24:37 AM

I guess that means two REP builds, one with RTC patch, one without.


Perhaps we should consider autodetecting the presence of an RTC...
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on February 05, 2007, 08:57:54 AM


I guess that means two REP builds, one with RTC patch, one without.


Perhaps we should consider autodetecting the presence of an RTC...



Great idea!

Since I did the mod, now I'm worried my build will become obsolete, because I think the patching is MUCH harder to do than soldering in the chip.
Title: Re: Recording Enhancements Pack
Post by: Rincewind on February 05, 2007, 10:19:25 AM

Are any of the patches in this build still actively being developed toward inclusion? I've left this build alone for quite some time because it was a focus of several core developers, but by this point I haven't seen many recording enhancements move from this build to CVS, and it's reaching a point where I'm considering moving this thread to the unsupported builds forum before someone starts calling "hypocrisy" on me.

I'd really like to also know if any of the patches in this build are flat out likely to never be included in CVS.


Well, I would like to see an inclusion of my record button patch and there seems to be at least a consensus that someting should be done about the record button, but not what exactly. If I come around to code the special options for file browser (insert stuff mostly) then I would consider the patch ready for inclusion, and I am willing to change the functionality of the patch if that helps inclusion.
To sum it up: my patch is still actively under development, I'm just waiting for the menu recoding to finish until I work on it again.
Title: Re: Recording Enhancements Pack
Post by: redwood on February 05, 2007, 09:14:42 PM
I think Rincewind's patch is a must, it should definitely be included when he's ready to update it with the new menu settings.

thanks
Title: Re: Recording Enhancements Pack
Post by: Rincewind on February 06, 2007, 09:07:35 AM

Since I did the mod, now I'm worried my build will become obsolete, because I think the patching is MUCH harder to do than soldering in the chip.


Well, it is the other way round for me ;D
I don't want to give my 10€ soldering iron a chance to brick my player.

And if you get the patching right once, then it doesn't get any harder to keep it up to date, and making your own builds is just typing 3 commands and getting a coffee inbetween then.
Title: Re: Recording Enhancements Pack
Post by: roolku on February 06, 2007, 10:51:22 AM


I guess that means two REP builds, one with RTC patch, one without.


Perhaps we should consider autodetecting the presence of an RTC...



I have added a preliminary version of the rtc patch with autodetection to flyspray http://www.rockbox.org/tracker/task/6419 . Let me know what you think.

There is a test build with the REP included here: http://roolku.pwp.blueyonder.co.uk/rockbox_rep_rtc_r12213.zip . I would appreciate some feedback.

EDIT: fixed link
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on February 06, 2007, 02:31:40 PM
http://roolku.pwp.blueyon...ockbox_rep_rtc_r12186.zip

I used this version after I did the hardware portion of the RTC mod. So far it is working fine.

Title: Re: Recording Enhancements Pack
Post by: roolku on February 06, 2007, 02:51:53 PM


I have added a preliminary version of the rtc patch with autodetection to flyspray http://www.rockbox.org/tracker/task/6419 . Let me know what you think.

There is a test build with the REP included here: http://roolku.pwp.blueyonder.co.uk/rockbox_rep_rtc_r12186.zip . I would appreciate some feedback.


Sorry I got the link to the compiled version wrong. The version with MOD auto detection is:  http://roolku.pwp.blueyonder.co.uk/rockbox_rep_rtc_r12213.zip
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on February 06, 2007, 08:20:30 PM
That's awesome roolku! Auto-detect, that should help get it added into a regular build.

As far as the RTC mod goes, soldering was the easy part. Getting the code patched into the REP was the difficult part. I know I will fall behind in getting the new builds of the REP because of the hassle of having to patch the code each time, if it isn't added into the regular build.
Title: Re: Recording Enhancements Pack
Post by: norbusan on February 07, 2007, 06:36:50 AM
Rediff for current svn

[attachment deleted by admin, too old]
Title: Re: Recording Enhancements Pack
Post by: paulheu on February 08, 2007, 06:11:54 PM
REP is (seriously) broken against current SVN changes.. Maybe if I have some time I'll look into it this weekend..
Title: Re: Recording Enhancements Pack
Post by: Bedlore on February 09, 2007, 06:06:02 AM
Hi roolku
Just tested your version with MOD auto detection on my modded unit and it worked very well!

Cheers  :D
Brendan
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 09, 2007, 07:06:27 AM
I would do an update for the REP, but I get the feeling that Mr Gordon is going to commit his menu overhaul any time now and it'll be seriously broken again, so I may just wait until then...

Llorean, as far as what is commitable in the REP at the moment, There is only one patch, which is the countdown timer - it has been reported that it is slightly innaccurate so I'm looking into that at the moment. Also it is so big that it breaks the archos builds and I'm scared of Amiconn! ;)

I'm not sure about Rincewind's patch, I'll leave that for someone else to decide on.....
Title: Re: Recording Enhancements Pack
Post by: petur on February 09, 2007, 08:19:04 AM
afaik, quick-launch key(s) have been debated quite a bit and never really gotten green light...
Title: Re: Recording Enhancements Pack
Post by: Llorean on February 09, 2007, 09:31:17 AM
How many patches are in the REP now?

It sounds like it's getting close to needing to be an unsupported build, if it contains patches that aren't trying to meet the requirements of SVN inclusion any more.
Title: Re: Recording Enhancements Pack
Post by: paulheu on February 09, 2007, 10:11:31 AM

I would do an update for the REP, but I get the feeling that Mr Gordon is going to commit his menu overhaul any time now and it'll be seriously broken again, so I may just wait until then...


He did and it is..;)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 09, 2007, 02:07:36 PM
I would do an update for the REP, but I get the feeling that Mr Gordon is going to commit his menu overhaul any time now and it'll be seriously broken again, so I may just wait until then...

He did and it is..;)

Nah..that was just a small one - there's more to come...I mean he's going to REALLY muck it up with the main menu rework (unless I missed something that is)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 09, 2007, 02:08:19 PM
How many patches are in the REP now?

It sounds like it's getting close to needing to be an unsupported build, if it contains patches that aren't trying to meet the requirements of SVN inclusion any more.

There are quite a few but only one that I am working for svn inclusion.
Title: Re: Recording Enhancements Pack
Post by: paulheu on February 10, 2007, 10:35:00 AM
synced REP to current SVN revision

[attachment deleted by admin, too old]
Title: Re: Recording Enhancements Pack
Post by: norbusan on February 10, 2007, 11:13:06 AM
Hi Paul!
Thanks a lot, but it seems to have problems with compiling. Current svn plus only you rpatch gives me (for H300):
recorder/icons.h:28:25: rockboxlogo.h: No such file or directory
recorder/icons.h:30:32: remote_rockboxlogo.h: No such file or directory
no idea where this is coming from?

Best wishes

Norbert
Title: Re: Recording Enhancements Pack
Post by: paulheu on February 10, 2007, 11:57:45 AM
get the attachment again and try that one.. works for me..
Title: Re: Recording Enhancements Pack
Post by: norbusan on February 10, 2007, 03:03:48 PM
Thanks, the newly downloaded one works fine!

Norbert
Title: Re: Recording Enhancements Pack
Post by: paulheu on February 11, 2007, 12:30:41 PM
Another REP sync (changed settings_list.c)

[attachment deleted by admin, too old]
Title: Re: Recording Enhancements Pack
Post by: rickeyjt on February 13, 2007, 12:46:21 PM
Can Mmmm recompile REP with the latest h120 build please?  I have one of these OutletMP3 units which required a firmware update to boot Rockbox.  I am missing the recording screen level peak graph I used to have at the bottom of my old h120 using REP.  Or is that feature gone now?  I did load the contents of a zip file from mmmms site that includes the new countdown timer but not sure if that is the complete REP compile.
Title: Re: Recording Enhancements Pack
Post by: amoergosum on February 14, 2007, 06:01:52 AM
I was wondering....would it be possible to create a patch which
makes it possible to go directly into recording mode?
What I mean is that when the player is switched off and you turn it on,
it would automatically start to record.
That would be very helpful.
/Ben
Title: Re: Recording Enhancements Pack
Post by: bascule on February 14, 2007, 07:54:19 AM
There is a setting that starts up straight into the recording screen. Then I think it's only a matter of pressing one button?

This topic refers:

http://forums.rockbox.org/index.php?topic=8793.msg68096#msg68096
Title: Re: Recording Enhancements Pack
Post by: amoergosum on February 14, 2007, 11:29:49 AM

There is a setting that starts up straight into the recording screen. Then I think it's only a matter of pressing one button?

This topic refers:

http://forums.rockbox.org/index.php?topic=8793.msg68096#msg68096



yes...but it would be great if you had the choice of having to
press that button or not...
Title: Re: Recording Enhancements Pack
Post by: amoergosum on February 14, 2007, 11:30:40 AM
Hi,
I’ve noticed that there’s a lot more hiss with RB when recording somebody who's speaking  for  example. There’s less hiss with the Iriver firmware.
How’s that possible?
Ben
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on February 14, 2007, 11:40:53 AM
It's not.

This is probably a function of AGC. Turn it off or play with the settings.

 :)
Title: Re: Recording Enhancements Pack
Post by: amoergosum on February 15, 2007, 04:29:11 AM

It's not.

This is probably a function of AGC. Turn it off or play with the settings.

 :)


no....it doesn't have anything to do with that...
I always turn off AGC.
/Ben
Title: Re: Recording Enhancements Pack
Post by: Llorean on February 15, 2007, 04:44:49 AM
What format are you recording in?
Title: Re: Recording Enhancements Pack
Post by: petur on February 15, 2007, 05:06:02 AM
and which gain levels. Anything above +15dB will give audible hiss. Get an external pre-amp if you need more amplification
Title: Re: Recording Enhancements Pack
Post by: amoergosum on February 15, 2007, 06:31:56 AM
I just recorded two test files.
Both were recorded with maximum gain in order to hear the difference.
One with the Iriver firmware, the other with RB.
When I listen to the two files they seem to be equal in volume.
What I noticed was that there’s much (!) more hiss with the RB version.
How’s that possible?
Title: Re: Recording Enhancements Pack
Post by: petur on February 15, 2007, 07:21:37 AM
you have no idea what gain settings the original firmware uses so you can't compare them.
Using max gain will give you A LOT of hiss. As the whole gain and ADC thing is done by a hardware chip, I don't see how noise levels can be different...

As stated, keep gain well below +15dB (in rockbox) and you'll be fine.

This is a table somebody once made, don't know how accurate it is:

orig fw setting     rockbox
                          adc     decrementer
line in ~             -6    +   0  (???)
ext mic 0            18   +   0
ext mic 5 ~         24   +  0
ext mic 20 ~       24   +  24

Title: Re: Recording Enhancements Pack
Post by: petur on February 17, 2007, 05:04:26 AM
Mmmm: I think it's worth rebuilding your REP as jhMikeS committed some important recording changes which should guarantee more stability (ie no missing samples).
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 17, 2007, 10:30:09 AM
I'm just waiting until JDGordon moves the recording settings menu really! or I'll just have to go and do it all again in a week or so! :)
Title: Re: Recording Enhancements Pack
Post by: Rincewind on February 17, 2007, 12:07:37 PM
just a note for Mmmm: it is very likely that I make a new record button patch at the end of next week.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 17, 2007, 01:26:22 PM
Well, after saying all that I went ahead and did it anyway seeing as I had a bit of spare time. So post#1 has the new patch and my new build. (So, Rincewind, when you're updating, you may want a look in here for the new settings and menu code for your patch).  

 (I haven't updated the extra patches that are usually in my build so for now there is no left to wps and click insert and whatever else is usually in there. So my build is purely REP at the moment).
Title: Re: Recording Enhancements Pack
Post by: Peter200lx on February 25, 2007, 05:56:11 PM
I was just wondering how much longer until this is updated? Has the new menu progressed far enough yet for a new version of the REP?
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 26, 2007, 12:24:35 PM
I was just wondering how much longer until this is updated? Has the new menu progressed far enough yet for a new version of the REP?
??What do you mean?? look at the post above yours, I updated it on 17th Feb!

(Whenever I do an update I modify post#1 so that the modified date of post#1 should be the version date)

(and I've just updated it again today..... :) )
Title: Re: Recording Enhancements Pack
Post by: x1jmp on February 27, 2007, 08:32:08 AM
There's missing an adjustment in apps/gui/statusbar.c on which breaks compiling on RTC targets

Code: [Select]

---  apps/gui/statusbar.c      2007-02-27 14:27:24.412249030 +0100
+++ apps/gui/statusbar.c        2007-02-27 14:23:54.851257558 +0100
@@ -155,7 +155,7 @@
 static void gui_statusbar_timer(struct screen * display, int dy, int hr, int mn, int sc);
 #endif
 #ifdef CONFIG_RTC
-static void gui_statusbar_time(struct screen * display, int hour, int minute);
+static void gui_statusbar_time(struct screen * display, int hour, int minute, bool timer_display);
 #endif
 #endif
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 27, 2007, 08:35:34 AM
There's missing an adjustment in apps/gui/statusbar.c on which breaks compiling on RTC targets

Code: [Select]
---  apps/gui/statusbar.c      2007-02-27 14:27:24.412249030 +0100
+++ apps/gui/statusbar.c        2007-02-27 14:23:54.851257558 +0100
@@ -155,7 +155,7 @@
 static void gui_statusbar_timer(struct screen * display, int dy, int hr, int mn, int sc);
 #endif
 #ifdef CONFIG_RTC
-static void gui_statusbar_time(struct screen * display, int hour, int minute);
+static void gui_statusbar_time(struct screen * display, int hour, int minute, bool timer_display);
 #endif
 #endif
Oops, I'll fix that tonight...I only tested compiling for H140 which doesn't have rtc so I missed that one.

EDIT: Ok, it's fixed now.....
Title: Re: Recording Enhancements Pack
Post by: Wolf on February 27, 2007, 03:53:51 PM
Martin,
Somehow I'm still getting your REP release from the 17th from your signature...
Thx for keeping this wonderfull add-on updated, Wolf.
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on February 27, 2007, 04:28:50 PM
So, the REP build now incorporates the RTC patch?
Title: Re: Recording Enhancements Pack
Post by: Febs on February 28, 2007, 09:25:14 AM
I believe that the RTC patch was committed to SVN today, so it is now part of the official builds.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on February 28, 2007, 03:57:41 PM
Martin,
Somehow I'm still getting your REP release from the 17th from your signature...
Thx for keeping this wonderfull add-on updated, Wolf.
Hmm, sorry about that.... Should be th latest build now (still only the REP), and I've updated the patch to work with the RTC mod.
Title: Re: Recording Enhancements Pack
Post by: Wolf on February 28, 2007, 04:12:41 PM
Working now, thx! Wolf
Title: Re: Recording Enhancements Pack
Post by: jplumey on March 08, 2007, 11:51:16 AM
Weird interference from the hard drive when recording.

When I hit the record button the hard drive spins up for about 5 seconds and in the audio of the recording I hear some loud interference that comes from the hard drive. When the hard drive spins down, the interference goes away and the recording sounds great. I am using the latest build of the REP (which is amazing, btw).

Any thoughts?
Title: Re: Recording Enhancements Pack
Post by: jplumey on March 08, 2007, 12:01:07 PM
Never mind.. I did another search and found out that it's the just the internal mic. Thanks.
Title: Re: Recording Enhancements Pack
Post by: Wolf on March 24, 2007, 03:03:44 PM
Trying to compile with the REP for the first time (SVN went ok, wooohooo!) I noticed that the current REP patch fails on apps/sound_menu.c (which is now located at apps/menus/sound_menu.c).

Even simple changing the file new location didn't work. Is this simple to solve or consequence of the menus improvements?

Thx, Wolf.

--------------------------
|Index: apps/sound_menu.c
|===================================================================
|--- apps/sound_menu.c  (revision 12521)
|+++ apps/sound_menu.c  (working copy)
--------------------------
File to patch: apps/menus/sound_menu.c
patching file apps/menus/sound_menu.c
Hunk #1 FAILED at 41.
Hunk #2 succeeded at 80 with fuzz 2 (offset -3 lines).
Hunk #3 FAILED at 355.
Hunk #4 FAILED at 520.
Hunk #5 FAILED at 571.
Hunk #6 FAILED at 729.
Hunk #7 FAILED at 879.
Hunk #8 FAILED at 1062.
Hunk #9 FAILED at 1074.
8 out of 9 hunks FAILED -- saving rejects to file apps/menus/sound_menu.c.rej
Title: Re: Recording Enhancements Pack
Post by: redwood on March 24, 2007, 03:48:40 PM

Trying to compile with the REP for the first time (SVN went ok, wooohooo!) I noticed that the current REP patch fails on apps/sound_menu.c (which is now located at apps/menus/sound_menu.c).

Even simple changing the file new location didn't work. Is this simple to solve or consequence of the menus improvements?


Wolf - I'd say it's due to the menu changes, yes.

Mmmm - do you know if the menu changes that would affect the REP have been finished? Looks that way to me but I am not an authority on code matters. Any idea when you might update?

thanks

jp
Title: Re: Recording Enhancements Pack
Post by: Rincewind on March 24, 2007, 05:13:22 PM
It seems to me that there are no more great changes to come for the recording menus and settings. Whoever updates the REP, I made a new Rec Button Config patch, it works again and now has insert options in file browser. FS #5555
Title: Re: Recording Enhancements Pack
Post by: Mmmm on March 25, 2007, 11:25:25 AM
Yeah, no more big changes now..... The changes are pretty big so not an easy fix(for a non coder anyway) I'm afraid. I've fixed up the countdown timer (which should be the hardest part) but haven't started on the rest of the REP yet. But I will... Just need a little spare time ;)
I'll attempt Rincewinds new patch too while I'm at it...
Title: Re: Recording Enhancements Pack
Post by: BayTaper on March 31, 2007, 01:15:09 PM
I know you guys probably hate the one-off feature requests, so apologies in advance, but I thought I'd mention something related to AGC functionality. My comment specifically relates to safety AGC, but I think it is probably relevant for all AGC modes. What would be great is a way to "link" or "unlink" the left/right channels so the AGC works on both channels together.

Here's an example of why this would be helpful. You're stealthing in safety agc mode. You get a screamer to your right who causes the right channel to clip harder than the left (or the left doesn't clip at all), the agc comes in to help things out going forward but ends up lower the right channel more than the left. Now the rest of the show gets recorded at significantly different levels between the two channels. If you could link the channels, the screamer on the right would cause safety agc to lower both channels (left/right) the same amount such that the left won't clip at that same loudness scream, but both levels of both channels are still set the same going foward.

Does that make sense? That's just one example, you could easily make other examples not related to a screamer or clapper that just come from the music, but where you'd want the levels to stay linked across L/R channels. It's kind of the same reason why the level adjustments first work on both channels at the same time, and then you have to press down again if you want to adjust levels independently for each channel (this is how setting levels already works, and it kind of exemplifies the same reasons why you might want AGC mode to operate in a similar way. I could see it being an option under the AGC menu -- to link channels or not.

Anyway, just a thought, and thanks again for the development efforts, rockbox is an invaluable tool no doubt...
Title: Re: Recording Enhancements Pack
Post by: mlind on March 31, 2007, 03:21:13 PM
????
Do you really mean that now the AGC really does change the gain independently for left and right?
When would you actually want that?
Title: Re: Recording Enhancements Pack
Post by: petur on March 31, 2007, 04:03:31 PM
yes it does that if there is a severe unbalance between L and R... didn't know this was also active in safety mode... must check
Title: Re: Recording Enhancements Pack
Post by: nigelsh on April 01, 2007, 01:40:16 PM
I second the request to 'lock' L&R when in safety mode.
Title: Re: Recording Enhancements Pack
Post by: petur on April 01, 2007, 02:48:12 PM
Well I just checked the code and balance is explicitly not done in AGC_SAFETY mode...(apps/recorder/recording.c line 299)

So I tried myself and there's no way I can make AGC_SAFETY change the balance: clipping on one channel while the other is silent and gain goes down on both.

BayTaper: sure you were using AGC_SAFETY?
Title: Re: Recording Enhancements Pack
Post by: nigelsh on April 01, 2007, 10:15:32 PM
I'm sure that I was using AGC safety when one channel was lowered without the other one being - but perhaps this has been fixed since I last download a REP? I'm using the REP dated 060913. Sorry, I realise that I should use the latest ROCKbox before suggesting a bug or an enhancement (I'll try not to let it happen again!)
Title: Re: Recording Enhancements Pack
Post by: petur on April 02, 2007, 12:24:55 AM
 ;)
Title: Re: Recording Enhancements Pack
Post by: wolfattack on April 04, 2007, 11:23:31 AM
I just installed Mmmm's build with the REP, and was wondering if the values of the peak meter change from the meter without the REP.

I run my meter on linear scale, and on my previous build without the REP, the middle dot was -12db and the very last dot before peaking was -3db. When i switch my meter to Linear on this build with the REP, should it be the same, or have the values shifted?

Thanks, i am going to a show in a few days and i don't want to screw up since i messed with the meter.

PS, i love the fat meters in this REP!!!
Title: Re: Recording Enhancements Pack
Post by: petur on April 04, 2007, 12:58:09 PM
the scale of the peak meters is configurable (both max and min)
Title: Re: Recording Enhancements Pack
Post by: wolfattack on April 04, 2007, 06:41:58 PM
Peutur, I was not saying for logarithmic scale, i am saying linear scale. On Logrithmic you can chose the max and min. but on linear it is just percentage. On my previous build without the REP, i had been told that under the linear scale, the 50% mark corresponds to -12db, i am trying to figure out if it should be the same for the peak meter with this build and the REP.
Title: Re: Recording Enhancements Pack
Post by: petur on April 05, 2007, 01:29:31 AM
just checked, and when using linear scale, you can still set min/max, of course those settings are also linear...
Title: Re: Recording Enhancements Pack
Post by: BayTaper on April 05, 2007, 11:04:44 AM

Well I just checked the code and balance is explicitly not done in AGC_SAFETY mode...(apps/recorder/recording.c line 299)

So I tried myself and there's no way I can make AGC_SAFETY change the balance: clipping on one channel while the other is silent and gain goes down on both.

BayTaper: sure you were using AGC_SAFETY?


I'm 100% sure cause it happens to me all the time, but I'm also using an older REP build -- I tend not to upgrade ever as long as things are stable. Sounds like maybe I should upgrade now though, eh? Thanks for checking, sounds like my bad for not keeping up with releases?
Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 13, 2007, 06:16:24 PM
At last... New patch, new build  :o... see post#1
Title: Re: Recording Enhancements Pack
Post by: redwood on April 13, 2007, 10:25:16 PM
Thanks a lot, Mmmm....One thing though - I can't get button config to work on 2 different H3xx boxes - is your button config working?

jp
Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 14, 2007, 04:55:30 AM
Hmm...ahh yes, sorry about that..... Should be ok now :)

Note to Rincewind:
lines 23 and 122 of user_action.c should read #ifdef HAVE_RECORDING instead of #ifdef RECORDING ! ;)
Title: Re: Recording Enhancements Pack
Post by: Rincewind on April 14, 2007, 07:39:59 AM
Thanks.
I didn't test every option this time obviously  ::), I use playlistviewer and themes usually.

It seems to me that my patch is slowly being forgotten, since nobody is complaining for weeks...
Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 14, 2007, 07:46:42 AM
Ha ha...
It's possible that most of the people using your patch for the recording screen use it through the REP, and so have only just noticed it, as I have only just updated your patch within the REP.
I'll be using it now for the insert function instead of the joyclick patch, so you've gained 1 user! :)
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on April 14, 2007, 04:34:59 PM
warning:0000001
warning:0000002

I got this on both my Mmmm Rockboxed iHP-120 and iHP-140, last week, while recording Toslink in. The warning came up in the time display on the recording screen...

Can someone tell me what this warning means?
Title: Re: Recording Enhancements Pack
Post by: petur on April 15, 2007, 02:36:17 PM

warning:0000001
warning:0000002

I got this on both my Mmmm Rockboxed iHP-120 and iHP-140, last week, while recording Toslink in. The warning came up in the time display on the recording screen...

Can someone tell me what this warning means?

jhMikeS can... I'll have a look at the code too. Can you please see that this also occurs with the 'official' build? Patched builds (I guess you're using REP) are not supported.
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on April 15, 2007, 02:40:42 PM
I am running a test now, in a more controlled enviroment...  with Mmmm's build... If it happens again, I'll test with the regular build.
Title: Re: Recording Enhancements Pack
Post by: petur on April 15, 2007, 03:21:14 PM
in any case, those warnings indicate some serious problems (buffer overflows in PCM and ENCODER)

Do try with the latest SVN build, not Mmmm's
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on April 15, 2007, 03:39:49 PM
 :-\ that can't be good ... The clip light came on a few times, but other than that, everthing seemed OK. I also have done the RTC mod and patch, if that info is important.
Title: Re: Recording Enhancements Pack
Post by: petur on April 15, 2007, 03:48:08 PM
how's your player? Disk nearly full, disk fragmented?
Title: Re: Recording Enhancements Pack
Post by: jhMikeS on April 15, 2007, 04:02:17 PM
The warnings as defined in pcm_record.h:

/* pcm (dma) buffer has overflowed */
#define PCMREC_W_PCM_BUFFER_OVF         0x00000001
/* encoder output buffer has overflowed */
#define PCMREC_W_ENC_BUFFER_OVF         0x00000002

As petur said and I second, please test with SVN.

PCM Buffer overflows should be nearly impossible in the newer SVN builds (post reliability fix) if not actually so even if the encoded data can't be written. I've never seen the PCM buffer fuller than 1 second with any codec at any data rate and you've got 11 seconds worth. Encoder not so much if your disk is on the slow side for some reason in which case not much can help.

More info on warnings: If both of these occurred during the same session, you would be looking at Warning: 0x00000003 since the bits OR together as problems occur.
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on April 15, 2007, 04:10:39 PM
No, I always record on a clean drive. Plenty of room on the HD.

One thing I noticed is that my ANSR light was off on my V3 when I got home. It was on when I started recording the night this warning came up. I also had my other pre-amp, a DMIC-20, synced to the V3 via coax cable, and the recorders got off sync somewhere in the last hour of the recording.

So, for testing, I just switched the ANSR off, on the V3, to see if that warning pops up again.

Unfortunately, I don't have much more time to test today.
I'll report back if I can make the warning come up again.
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on April 15, 2007, 04:18:51 PM

The warnings as defined in pcm_record.h:

/* pcm (dma) buffer has overflowed */
#define PCMREC_W_PCM_BUFFER_OVF         0x00000001
/* encoder output buffer has overflowed */
#define PCMREC_W_ENC_BUFFER_OVF         0x00000002

As petur said and I second, please test with SVN.

PCM Buffer overflows should be nearly impossible in the newer SVN builds (post reliability fix) if not actually so even if the encoded data can't be written. I've never seen the PCM buffer fuller than 1 second with any codec at any data rate and you've got 11 seconds worth. Encoder not so much if your disk is on the slow side for some reason in which case not much can help.

More info on warnings: If both of these occurred during the same session, you would be looking at Warning: 0x00000003 since the bits OR together as problems occur.



Thank you for the info on what the warning means. I'll have to test the SVN at another time.
Title: Re: Recording Enhancements Pack
Post by: petur on April 16, 2007, 01:58:37 AM
/me gets slightly worried when he also sees http://taperssection.com/index.php/topic,83004.0.html... Probably also using REP though...
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on April 16, 2007, 07:20:42 AM
Well, I tested the the REP yesterday, recording for 8 hours, and no problems. Hopefully it was a fluke...
Title: Re: Recording Enhancements Pack
Post by: jhMikeS on April 16, 2007, 12:02:00 PM

/me gets slightly worried when he also sees http://taperssection.com/index.php/topic,83004.0.html... Probably also using REP though...



Frankly, I ought to have a quick look at that REP and see if there's any big nono's there.
Title: Re: Recording Enhancements Pack
Post by: jhMikeS on April 16, 2007, 12:33:52 PM
Come to think of it, who knows what optical might throw at it. If the CPU reports an error, it will drop stuff and who knows if something could deceive it into thinking it has finished a chunk of data too soon. Before the update I burdened flushes by just wasting so many CPU cycles they'd take over a minute to complete and I still didn't have problems so conditions on the recording side should have to be just atrocious to have any. The old problem was just the encoder being starved too much by boosting the flushing thread but they both boost now. As of now, I'm thinking the scheduler change to use priority_yield in the ATA driver could do something since we're balancing two threads to not starve one another of CPU. The codecs could use it as well to make sure they have equal footing. I've performed no evaluation of the behavior of recording since changing the ATA driver.

With optical the CPU should always be boosted as well (WAV /AIFF is practically like having nothing running at all so should never not be able to keep pace esp. boosted) and if something new in SVN messed with that, glitches will occur if it goes back to boosting dynamically as well.
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on April 16, 2007, 06:58:13 PM
I was recording optical in on both iRiver recorders.

Mics> Grace V3 (optical)> iHP-120

SBD> modified DMIC-20 (optical)> iHP-140

It was loud, so maybe the recorders were feeling the thumping bass? They both reported errors. But, I was at the SBD position, and the I've recorded successfully, with those recorders, at much louder shows.

I had both the pre-amps sync to the V3 clock, which makes it easier to align the separte recorders for mixing. In editing, I noticed that about a third of the way through the show, the pre-amps lost sync, with the audience recording on the V3 running increasingly behind the SBD recording. I figured it was from dropped samples  ???

If it happens again, I will report back.
Title: Re: Recording Enhancements Pack
Post by: jhMikeS on April 17, 2007, 06:25:27 PM
Your problems point to encoder starvation since the only possible way the PCM buffer could overflow is if something is keeping the encoder thread from running enough....period.

Some counterintuitive points:
You could get an encoder buffer overflow and not a PCM overflow because the codec is starved and then dumps a huge payload on the output all of a sudden when flushing is starting because it starts encoding data rapidly when the PCM buffer is _nearly_ full. The starvation can disappear as flushing waits in the ATA driver and starts yielding alot.

To maintain stability the PCM buffer must be maintained nearly empty all the times then when the codec gets a lot of run cycles it only dumps a small quantity into the output when the flushing is able to do nothing more than wait for a disk spinup.

I will, right now, give a check on the thread stuff. The pcmrec and codec threads really have to be peers and the ATA change may have affected that.
Title: Re: Recording Enhancements Pack
Post by: jhMikeS on April 17, 2007, 06:49:50 PM
Sorry to go on and on here  ::)

There are some more possibilities with S/PDIF recording:
1) An series of errors not being read as an errors when the boxes lost sync advanced the queue very rapidly leading to PCM buffer overflow - this will cause mega glitches or a jump in time and symptoms very much that same as starved encoder.

2) Your unsynced clocks have slightly different samplerates - No glitches or errors, just drift over time when both files are played back using the PC soundcard clock.

BTW: My checks show the threads to still be peers in SVN.
Title: Re: Recording Enhancements Pack
Post by: jhMikeS on April 17, 2007, 07:10:55 PM
Well, looking at things in the pcm driver reveals that the S/PDIF code may in fact miss certain error conditions. I really only moved the S/PDIF driver implementation around in RB to the HAL and never changed it so this could be the answer and why digital recording seems to be where continued bug reports are coming from...notably overflows.

If an S/PDIF error is detected on the receiver, in SVN, the PCM chunk should be dropped and the queue not advanced...but if it's not detected...well...there ya go. A simple check to see if the transfer actually completed and filled the chunk might be all that's needed.
Title: Re: Recording Enhancements Pack
Post by: jhMikeS on April 17, 2007, 07:27:02 PM
More and more....: Hehe...seems someone set the wrong bits in the driver.
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on April 17, 2007, 07:55:26 PM
Did I expose a bug?  ???
I hope it's fixable, as I love my REP Rockboxed iRiver.
Title: Re: Recording Enhancements Pack
Post by: jhMikeS on April 17, 2007, 08:09:21 PM
Yes, I think so. I can't say for sure yet if it is _the_ bug though. The driver one is fixable by checking the correct flags though and I'll commit the changes as soon as I run some tests.
Title: Re: Recording Enhancements Pack
Post by: jhMikeS on April 17, 2007, 09:11:22 PM
Well, I committed the bugfix anyway and checked it by pulling the optical cable about half way out where it just made a lot of crunching noise. Recording properly rejected that invalid data and progress just held steady with no warnings. Best I could do to check that.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 18, 2007, 03:26:55 PM
So after all that it's nothing to do with the REP at all.... cor I don't know  ::)

:D

I suppose Id better update to get that fix in....

Edit: update in post#1
Title: Re: Recording Enhancements Pack
Post by: jhMikeS on April 19, 2007, 09:35:42 AM
Never mind about it. Allergies, cold medicine and programming don't mix.  ::) My bit counting was off that day and I couldn't tell bit 22 from bit 20 so after all that it's still in the air and nothing actually changed. Regardless, the few reports of problems these days seem to come from digital sources so after all that...

BTW, what should your REP have to do with the pcm driver and DMA1?
Title: Re: Recording Enhancements Pack
Post by: NorTheBear on April 19, 2007, 12:49:18 PM
Hello everybody,

I have to confess that the Recording Enhancements Pack seduced me some time ago to move constantly from iRiver firmware to Rockbox. The feature set of the recording section is really amazing, though most crucial for me was when I was able to control the gain while recording on my beloved H320.

Well, there is one little thing that might be so minor an improvement that nobody else might ever have thought about it but hell, I was think of it whenever I missed a nice recording because of me pressing the wrong key and realising only when it's already too late. I am sure some of you know what I mean.

Thus I am daring to bring in the idea of colorized peak meters as another record indicator which is visually easy to spot (in addition to the other helpful indicators like file size increasing and the small icons on the top of tehe screen (for me too small):

Colorized peak meters, e.g.
black = no recording at the moment  ||||||||||||
red = recording is running at the moment  |||||||||||||||||
yellow = recoding is on hold (i.e. recording is interrupted)  |||||||

I would have coded and patched it myself if only were able to do it ...

See manipulated dump screens and see what I am talking about.

Thank you for your kind consideration.

Enjoy your life and your favorite music, NortheBear


[attachment deleted by admin for age]
Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 19, 2007, 03:15:00 PM
BTW, what should your REP have to do with the pcm driver and DMA1?

I seriously doubt that the REP would have anything to do with it as it is mostly to do with display rather than the real nitty gritty stuff. The only potential problem is that all that histogram info may be too much for the unboosted CPU but I'm pretty sure it is ok.....

Colorized peak meters, e.g.
black = no recording at the moment  ||||||||||||
red = recording is running at the moment  |||||||||||||||||
yellow = recoding is on hold (i.e. recording is interrupted)  |||||||

I would have coded and patched it myself if only were able to do it ...
Ahh, Very nice....Unfortunately I have a lowly H140 which has no colour, so for me this wouldn't bring any joy...
You could always learn to code and patch it.... :)
Title: Re: Recording Enhancements Pack
Post by: jhMikeS on April 20, 2007, 12:57:05 PM
Quote
I seriously doubt that the REP would have anything to do with it as it is mostly to do with display rather than the real nitty gritty stuff. The only potential problem is that all that histogram info may be too much for the unboosted CPU but I'm pretty sure it is ok.....


As I've mentioned, the CPU is always boosted during digital recording or should be and since the only reports seem to be coming from S/PDIF users, there could be a problem in the boost being turned off perhaps? I didn't spot any boost fiddling in the patch but I could have missed it. Nonetheless I'll keep pushing myself to find an answer to any lingering issues and probably test recording with the debugging screen I made up with and without patch to see if it changes the behavior.
Title: Re: Recording Enhancements Pack
Post by: redwood on April 21, 2007, 09:44:07 AM

Hello everybody,

*snip*
Colorized peak meters, e.g.
black = no recording at the moment  ||||||||||||
red = recording is running at the moment  |||||||||||||||||
yellow = recoding is on hold (i.e. recording is interrupted)  |||||||



If it were to happen, colorization of the peak meters should be tied in with background and foreground colors because some people don't use the defaults. I for example use a black backgound with blue text, which would  render the no recording mode invisble to me.

Personally I think there are better ways to indicate recording status other than meter color or the small indicators in the status bar, but this has been discussed before.

jp
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on April 21, 2007, 10:50:29 AM
I got the:

warning: 000000001

again last night.
I was recording optical in from a Grace v3.

Maybe my hard drive is going bad? My other recorder, iHP-140, was fine. No problems.
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on April 21, 2007, 12:44:35 PM
Could a bad (cracked) optical cable be causing this? Or, is it hard disc or software related? It's frustrating, because I tested for eight hours + last weekend with no problems...  ???

Is there a version of the REP that is approved, so I can start using that, to see if that's the problem?
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on April 21, 2007, 01:45:44 PM


Hello everybody,

*snip*
Colorized peak meters, e.g.
black = no recording at the moment  ||||||||||||
red = recording is running at the moment  |||||||||||||||||
yellow = recoding is on hold (i.e. recording is interrupted)  |||||||



Personally I think there are better ways to indicate recording status other than meter color or the small indicators in the status bar, but this has been discussed before.

jp


I feel this is a good time to resurrect the BIG STATUS ICON idea.

Also adding a line to the REP that states which input is currently being used would be huge.


[attachment deleted by admin for age]
Title: Re: Recording Enhancements Pack
Post by: jhMikeS on April 21, 2007, 03:59:05 PM

Could a bad (cracked) optical cable be causing this? Or, is it hard disc or software related? It's frustrating, because I tested for eight hours + last weekend with no problems...  ???

Is there a version of the REP that is approved, so I can start using that, to see if that's the problem?


It could I imagine though I'd hope the CPU would properly detect the errors and not flood out the buffers if that's what really happened. I think pulling the connector half way out would give similar problems to that but if the equipment you're using did something bad when trying to keep sync or if the coldfire CPU doesn't report all errors correctly, I'm not sure rockbox can do anything about it.

Despite my idiocy the other day, :) I did notice not every flag is being checked (for real, they're not) and that could possibly be it though I'll have to do some reading and make sure the other flags are at all relevant to detecting stream errors.

So this is either outside the software pervue or else there's some creepy little obscure bug hiding out in the REP or in SVN that messes with digital in. Due to the fact there was a PCM buffer overflow when it really should not even be possible,  that's what my gut tells me.

So, I'll just shut my trap now and I'll check my recording debug screen soon. I'd love to have that in SVN so the buffers can be watched but the recording screen isn't modular enough to keep functioning correctly while showing it. That's something I plan to change in the near future.
Title: Re: Recording Enhancements Pack
Post by: petur on April 23, 2007, 02:45:15 AM
Looking at http://taperssection.com/index.php/topic,83004.0.html it seems something is funky with the REP build.... maybe the gui stuff is overloading the cpu during some peak moments?

Warning 00000001 is being mentioned in above link
Title: Re: Recording Enhancements Pack
Post by: jhMikeS on April 23, 2007, 02:46:43 PM
If something is funky with the REP build which it seems to be, esp. for digital in users, I'd suggest mmmm take a look and make sure:

1) No threads are being boosted in priority (via thread_set_priority) as this will require the codec and pcmrec threads to also be priority boosted. This was _the big_ stability issue where the boosted pcmrec thread starved the codec. Boosting the codec thread at the same time keeps it stable since the codec cannot over the long term output data exceeding the data rate from the ADC. The empty state makes the codec yield a lot to other threads.

2) CPU frequency scaling is set to boosted at all times when running S/PDIF. Make sure no cpu_boost(false) call is made unpaired with cpu_boost(true). I wasn't part of developing the digital support itself but was told switching frequencies when recording S/PDIF is very bad and glitchy and it must not be put in a state where is goes back to actively frequency scaling.

3) That all code yields very frequently and never starves the codecs of cycles. I've mentioned elsewhere that, in SVN, running the WAV/AIFF codecs while observing the buffers - even with the CPU frequency unboosted - never showed PCM buffer usage over zero bytes. It's almost as good a situation with MP3 and WavPack. The codecs are very fast if allowed to run enough. See to it large numbers of graphics operations have yields in between each one. Putting up a quick display for debugging to watch the PCM buffer is easy...test at the highest possible samplerate, stereo WavPack and it should pass that worst case without fault.

If I think of any more points to check, I'll post.
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on April 23, 2007, 04:30:59 PM

Looking at http://taperssection.com/index.php/topic,83004.0.html it seems something is funky with the REP build.... maybe the gui stuff is overloading the cpu during some peak moments?

Warning 00000001 is being mentioned in above link


Yeah, that's actually me again... I'm back to the regular build for now.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 24, 2007, 03:06:26 AM

If something is funky with the REP build which it seems to be, esp. for digital in users, I'd suggest mmmm take a look and make sure:

1) No threads are being boosted in priority (via thread_set_priority).

2) CPU frequency scaling is set to boosted at all times when running S/PDIF.

3) That all code yields very frequently and never starves the codecs of cycles.

If I think of any more points to check, I'll post.


I suspect that no. (3) will be the one if any. I don't think that there is any extra boosting/unboosting at all in the patch so 1 and 2 are not possible (I'll check though, there may be the odd case that I havent noticed).

There is a very large amount of extra graphics code and no extra yields so I'd put my money on it being that.

It is weird that this has suddenly surfaced and there were no reports of it a couple of weeks ago - maybe it's something I did in the last update....Don't know what it could be though... Or maybe it's because people have started using more recent builds since I did the update...Arggghhhh too many possibilities.... :D
Title: Re: Recording Enhancements Pack
Post by: jhMikeS on April 24, 2007, 05:11:54 PM
Nothing has really changed in the builds since the update that stopped problems in the SVN code that petur was reporting. The scheduler change afterward should have no effect either since priority_yield gives a thread no advantage over others that are the highest priority running - hence they stay peers anyway.

If (3) is the reason, just verify by monitoring the PCM buffer fullness on the recording screen or wherever. Not much to it really but to watch the read and write positions. If you can ever see anything more than a flicker of > 0 used when running WAV or AIFF, CPU boost or not, there's a problem. For MP3 and WavPack, the same applies when CPU boost is in effect as these can fill to 1 second which kicks the CPU boost in but they'll empty it out really fast.

Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 28, 2007, 06:27:02 AM
Hmmm Mike, just realized that to test this I am going to have to have an optical input signal.. but I have nothing that can give me one.....
Just to check, If I can find an input , on your recording utility the uppermost bar (pcm) is the one that I should be looking at right?

If I cant find any optical input its going to have to be down to people to test some things out for me... any volunteers? :)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 28, 2007, 10:25:31 AM
Ok, a slightly modified version of the REP in my sig (some yields() included)... Needs lots of testing from as many people as possible to find out if I've fixed it or not...

This build includes JSMikes recording debug screen which is activated by toggling the remote lcd on and off while you are recording (Vol - key on remote, press stop to exit the debug screen). I think that on this screen you should see the top bar staying on 0. if it changes there could be a problem... This screen is a bit new to me so cant be certain.
You can obviously still record as normal....

If any errors or dropped samples come up with this build then post here and I'll try something else...
Title: Re: Recording Enhancements Pack
Post by: petur on April 28, 2007, 05:51:12 PM
I've just looked at the REP patch for the first time and I'm wondering:

1) where does the changed dB conversion come from. I once committed changes to that (from Vinylivo), and I wonder it this reverts to the old values or is a new fix that results in more accuracy?

2) I'm thinking of moving the peakmeters below the last line and add a simple if(LCD_HEIGHT > xxx) to double the peakmeter height. That will also leave a nice upper-right corner for a REC/PAUSE symbol.

More recscreen layout changes should wait until after the viewport stuff, and it should go towards a WRS :)
Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 29, 2007, 05:43:20 AM
I've just looked at the REP patch for the first time and I'm wondering:

1) where does the changed dB conversion come from. I once committed changes to that (from Vinylivo), and I wonder it this reverts to the old values or is a new fix that results in more accuracy?
I dont know.... The histogram etc patch came from Vinylivo and I haven't really looked carefully at it (apart from a couple of cosmetic changes).  The changes for the DB values are as they were in his latest version which was quite a while ago.. Maybe they are an update to his update... It'd be odd if he reverted the change, can't think how that would've happened.

Quote
2) I'm thinking of moving the peakmeters below the last line and add a simple if(LCD_HEIGHT > xxx) to double the peakmeter height. That will also leave a nice upper-right corner for a REC/PAUSE symbol.
Double the peakmeter height? you mean to 4x font height? if(LCD_HEIGHT > xxx) already exists in the present svn code. (the recorder only gets a single height peakmeter).
Personally, I like the present placing of the peakmeter. It breaks the screen up a little...makes it look more interesting.
Quote
More recscreen layout changes should wait until after the viewport stuff, and it should go towards a WRS
Ahhh yes...WRS.... that would pretty much make the REP completely redundant...That's what we want! :D
Title: Re: Recording Enhancements Pack
Post by: bugg100 on April 30, 2007, 05:29:12 AM
Hey Petur & Mmmm,

I'm the person with a h320 that has also gotten the  same errors as Chuck.  

I've gotten the errors in different recording sessions.  My drive is 80% filled and I am using Paulheu's most recent build (mid Feb.) with REP.  Analog of course.......  I am not sure if any optical issues apply to these errors.....

I will pay closer attention to this thread and not at tapperssection.com, so the people ACTUALLY addressing my problems (rockbox & REP devs) have less steps out of there way.

Thanks are in order, as always, for rockbox development.

Joe
Title: Re: Recording Enhancements Pack
Post by: petur on April 30, 2007, 06:32:41 AM

I've gotten the errors in different recording sessions.  My drive is 80% filled and I am using Paulheu's most recent build (mid Feb.) with REP.  Analog of course.......  I am not sure if any optical issues apply to these errors.....


H3x0 has no optical, as you know ;)


I will pay closer attention to this thread and not at tapperssection.com, so the people ACTUALLY addressing my problems (rockbox & REP devs) have less steps out of there way.


I try to monitor here and at taperssection, but for support issues this forum is the best place.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 30, 2007, 07:08:29 AM

I've gotten the errors in different recording sessions.  My drive is 80% filled and I am using Paulheu's most recent build (mid Feb.) with REP.  Analog of course.......  I am not sure if any optical issues apply to these errors.....


Interesting...so it seems it is not optical only which means that I should be able to test a bit myself..... and Feb I think was before I did the last major update...(could be wrong though, time is just flying by at the moment...).

I'll do you an H3xx build later with those yields in it for you to test with...:)
Title: Re: Recording Enhancements Pack
Post by: jhMikeS on April 30, 2007, 08:50:04 AM

Ok, a slightly modified version of the REP in my sig (some yields() included)... Needs lots of testing from as many people as possible to find out if I've fixed it or not...

This build includes JSMikes recording debug screen which is activated by toggling the remote lcd on and off while you are recording (Vol - key on remote, press stop to exit the debug screen). I think that on this screen you should see the top bar staying on 0. if it changes there could be a problem... This screen is a bit new to me so cant be certain.
You can obviously still record as normal....

If any errors or dropped samples come up with this build then post here and I'll try something else...


Yes, the top bar should pretty much stay at zero for WAV and AIFF. But one thing is using the interface to test while in the screen, say by replacing the recording screen text lines with the bars or numbers which would give more accurate results since all the screen functionality would be running too. I suppose a button could toggle what's displayed on those lines.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on April 30, 2007, 02:36:32 PM
An H3xx build HERE (http://homepage.ntlworld.com/martin.scarratt/Rockbox/rockboxH3xx.zip)

JsMikes: ahh yes...without the histogram drawing there will probably be no problems anyway eh? :D
Ill just butcher the first 2 lines out of the display and plonk then on the recording screen - for testing... should fit somewhere...:-/
Title: most recent Paulheu build...
Post by: bugg100 on April 30, 2007, 03:58:45 PM
Pualheu's build most recently:

In sync with SVN at 5 Feb 18:29GMT
I am downloading the h320 build now and will test this evening.  Thanks
Title: Re: Recording Enhancements Pack
Post by: Mmmm on May 01, 2007, 12:36:54 PM
I've been doing some testing with the PCM buffer display and with svn there is a slight 'twitch' every 5 seconds or so to 8000 and then fairly quickly back to 0....
With the REP installed this happens every 0.5 seconds or so....

I have been experimenting with yields in various places and I now have it so that there isn't even the suggestion of a twitch at all, and that's with REP installed! So better than SVN it seems!

Only testing will tell if this fixes the problem, so any testers out there please give the build in my sig a go (H120/140)... I'll do an H3xx build later (got to rush off to dinner now!) :)

EDIT: H3xx build HERE (http://homepage.ntlworld.com/martin.scarratt/Rockbox/rockboxH3xx.zip)
Title: Re: Recording Enhancements Pack
Post by: jhMikeS on May 08, 2007, 01:07:08 PM
Well, peturs lastest bringing of something to my attention has shown that some atomicity issues in the scheduler must be fixed and fast. The cliplight may very well increase the likelyhood of a thread to get orphaned or not scheduled properly due to posts from IRQ handlers -- increased backlight activity and all that. The problem will be worse on targets with fading in combination with cliplight. It caused thread orphaning not just in recording but playback and other places. It's not likely, but a large number of copies of rockbox running will make it a situation someone is sure to encounter regularly. A change I made earlier made it less likely but hardly impossible...time for a thorough scheduler scan and bugfix.

The report petur pointed me to is a dead ringer for such an occurrence. The timing changes from this patch are probably relevant to the race condition.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on May 11, 2007, 04:05:06 PM
I've updated the patch in post#1 to latest SVN and put in the yields that improve the buffer usage. So hopefully that and JSMikes updates mean the problems that have been seen recently are no more....
Title: Re: Recording Enhancements Pack
Post by: jhMikeS on May 11, 2007, 07:00:35 PM
I should have the proper code guarding in the scheduler/queues in SVN today or tomorrow. I think it'll be a red line on the delta table but it's a decent solution with more detailed panicf as well. Really, I want to take my core lock patch and commit it sans locking but I fear it still might bork the PP5020 targets since all the IRQ fiddling seem to be what keeps them running. Without the locking mechanism in place it will basically be a rework to keep IRQs completely away from the scheduler which is really the _right_ thing imo.
Title: Re: Recording Enhancements Pack
Post by: DeepBlueEditor on May 23, 2007, 03:04:52 PM
I have asked this in another forum but didn't get a good answer.  Here's the question.

I am looking to record some short films and am looking at using my H320 to record field audio.  Is there a "pretty" and more useful recording interface?  Something with much larger text and metering that anyone has come up with?  I was pointed to this branch of the forums by a few others who thought you guys would know best.

The recording in 44.2KHz audio isn't the best answer for video (it's 48KHz) but it will do with conversion so that's all cool and since it's hard coded, it'll do.  As I am getting older, the tiny little meters built in to the current build RockBox are just too tiny to be usable for a real audio operator under stressful situations on a film shoot.

Anyone have an easy to install option?  I would do the programming for it myself if I had the time but I simply don't.  IF anyone has ideas or even better, screen shots of various record screens, that would help a lot.  Otherwise I'll breakdown and buy an H4 or the new H2 for these projects and keep the H320 as a media player.  I love it for that.

Thanks folks,

Sean McHenry
Sean@DeepBlueEdit.com
http://www.DeepBlueEdit.com
Title: Re: Recording Enhancements Pack
Post by: petur on May 24, 2007, 02:31:48 AM

I am looking to record some short films and am looking at using my H320 to record field audio.  Is there a "pretty" and more useful recording interface?  Something with much larger text and metering that anyone has come up with?  I was pointed to this branch of the forums by a few others who thought you guys would know best.

The REP (the thread you're posting in now) has such a feature but you'd probably have to disable some other visual stuff to make room. Others should be able to help you on that (I'm not a REP user)


The recording in 44.2KHz audio isn't the best answer for video (it's 48KHz) but it will do with conversion so that's all cool and since it's hard coded, it'll do.  As I am getting older, the tiny little meters built in to the current build RockBox are just too tiny to be usable for a real audio operator under stressful situations on a film shoot.

I think the h3x0 (and h1x0) series can't handle 48kHz. You could try to get an h1x0 and use its optical input. IMHO I don't think the quality difference between 44/48kHz is significant.
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on May 24, 2007, 10:22:43 AM
I just noticed the static user-selected recording directory patch over here (http://www.rockbox.org/tracker/task/7201)...

Will this be included in the REP? If someone would provide me with a patched build I'll test it and report back here.
Title: Re: Recording Enhancements Pack
Post by: Darktrain on May 25, 2007, 07:47:38 PM
As a newbie with a 120, what steps should i take and what should i install from the beginning, i am a little confused about all these downloads, patches, enhancements, is there one download that covers it all? everyone says get the REP but not sure where to begin. i am going to be using the 120 to record live shows?

Thanks
Title: Re: Recording Enhancements Pack
Post by: redwood on May 25, 2007, 09:11:33 PM
Darktrain -

go here:

http://forums.rockbox.org/index.php?topic=2513.0

Download the build in Mmmm's signature. You can follow the standard install instructions:

http://www.rockbox.org/twiki/bin/view/Main/ManualRockboxInstall#iriver_jukeboxes

Good luck - enjoy.

jp
Title: Re: Recording Enhancements Pack
Post by: petur on May 27, 2007, 11:03:26 AM

I just noticed the static user-selected recording directory patch over here (http://www.rockbox.org/tracker/task/7201)...

Will this be included in the REP? If someone would provide me with a patched build I'll test it and report back here.

As you can see on that tracker-task, there's still a bit of discussion going on about what we want it to do. I'm quite sure it's supposed to be included in the svn version.
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on June 02, 2007, 11:54:12 AM
I've run Mmmm's 05-11 build a bunch of times, so far, with no problems. I'm trying the 05-13 build today on an iHP-120 and an iHP-140.
Title: Re: Recording Enhancements Pack
Post by: davehouse on June 03, 2007, 01:04:40 PM
how can i tell what version of the H120 Rockbox firmware Im running, and whether Mmmms latest build is a newer version? I downloaded Mmmms build with the REP ages ago and recon its probably time for an upgrade. But I dont wanna do that if I dont need to!
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on June 03, 2007, 08:03:58 PM
No problems running the lastest Mmmm build on iHP-120 and iHP-140 last night.  :)
Title: Re: Recording Enhancements Pack
Post by: wolfattack on June 05, 2007, 05:59:19 PM
Hey Mmmm,

A few months ago, i installed your build with the REP on my H120, and it works great, but today, i just bought a refurbished H115, and i was wondering if i will be able to just install this same build on it.

From what i understand there are some few minor differences in the ram (smaller buffer) but besides that, not much difference, should it be okay?

If not, what will i need to change in your build to make it so it works the same as my H120. I would like them to have the same build and what not so when i am recording with both at shows, i can get my levels to match and stuff like that.

thanks a bunch!

Josh
Title: Re: Recording Enhancements Pack
Post by: paulheu on June 12, 2007, 04:27:03 PM
Is the version of the rec-button-config used in the pack the most recent one? right now the REP does not compile with the latest SVN. It breaks on an error when compiling the additional rec-button-patch files

EDIT: was a simple fix really.. so never mind..
Title: Re: Recording Enhancements Pack
Post by: fed on June 16, 2007, 03:13:11 AM
Has anyone made a build with this patch for the Sansa e200?
Title: Re: Recording Enhancements Pack
Post by: pixelma on June 16, 2007, 03:43:04 AM
While the Sansa can record, its recording capabilities are not nearly as powerful as those of the H1x0/H3x0s that this patch was made for (far away would be the better word). I don't know all the details but I even doubt you could get it to run at all or would have much fun with it.
Title: Re: Recording Enhancements Pack
Post by: jhMikeS on June 16, 2007, 06:09:59 AM
I do intend to see how far things can be pushed in order to make it at least acceptable but even the original firmware only outputs effectively 24kHz. The files are 48khz but each sample value shows up twice and that's just how the hardware operates. Even getting true 32khz - ideal for fm recording - will require checking out overclocking the audio codec to 64khz so I make no promises that it will work well or even at all.  ;D
Title: Re: Recording Enhancements Pack
Post by: Rincewind on June 16, 2007, 07:42:58 AM

Hey Mmmm,

A few months ago, i installed your build with the REP on my H120, and it works great, but today, i just bought a refurbished H115, and i was wondering if i will be able to just install this same build on it.

From what i understand there are some few minor differences in the ram (smaller buffer) but besides that, not much difference, should it be okay?

If not, what will i need to change in your build to make it so it works the same as my H120. I would like them to have the same build and what not so when i am recording with both at shows, i can get my levels to match and stuff like that.

thanks a bunch!

Josh


If you want to use Mmmm's compiled build, then it won't work, because the binary is made specifically for H120/140
You can downoad the source, apply the REP patch and compile a build for yourself. This should work without any changes to the code of the REP.
Then you can make a second folder and make you own builds for the H115 and H120 from the same source. You can find more info in the wiki under SimpleGuideToCompiling.
Title: Re: Recording Enhancements Pack
Post by: fed on June 16, 2007, 10:12:14 AM
Actually, the Sansa e200 records quite well.  I use it mainly for recording.  

I need to change the button assignment for stopping the recording from the power button to the select button.  Do you know how I could do that?
Title: Re: Recording Enhancements Pack
Post by: fed on June 16, 2007, 11:03:41 AM
Does anyone happen to know if prerecoding writes to disk or only to RAM.  What I am really interested in is if constantly prerecording will wear out the flash drive faster.
Title: Re: Recording Enhancements Pack
Post by: petur on June 16, 2007, 11:38:15 AM
prerecording just constantly wraps around data in the recording buffer in RAM. So no Flash involved.
Title: Re: Recording Enhancements Pack
Post by: fed on June 16, 2007, 04:48:51 PM
Thanks for the information.

I have successfully reassigned the select button.  

Now I would like to make the rec button start a recording from any menu.  I cannot figure out how to do this.  Can anyone help?

Thanks.
Title: Re: Recording Enhancements Pack
Post by: jhMikeS on June 17, 2007, 12:49:55 AM
fed,

I think that's a bit off topic here and also isn't really that trivial to do. Personally I think having assignable shortcut keys would be good thing though. There's a UI forum around here somewhere.
Title: Re: Recording Enhancements Pack
Post by: Rincewind on June 17, 2007, 08:09:25 AM

Now I would like to make the rec button start a recording from any menu.  I cannot figure out how to do this.  Can anyone help?


You could try to get my Rec button patch working on the Sansa (Flyspray #5555). With this you can start a recording from WPS and file browser (among other things). The only thing that you need add is the keymap for the sansa and a few #defines.

If I find time I'll do it myself, but that's not happening very soon :(
Title: Re: Recording Enhancements Pack
Post by: fed on June 17, 2007, 09:14:29 AM
I've tried to adapt your patch no sansa.

I substituted BUTTON_POWER for BUTTON_ON and BUTTON_OFF
I remeved the line
{ ACTION_WPS_ID3SCREEN,     BUTTON_POWER|BUTTON_MODE,          BUTTON_NONE },
because I don't know the equivalent of BUTTON_MODE for sansa.

I inserted the your ketmap to where I thought it should go in keymap200

I applied the patch.

But it does not work.

I'm sorry, but I can't figure out which #defines to add.

Could you let me know which to add?

Thanks!
Title: Re: Recording Enhancements Pack
Post by: fed on June 17, 2007, 01:43:59 PM
I am sorry to keep bothering, but I have been racking my brain for a week now
trying to do something that I think is probably easy to do.

I would like to make a button do something.  I can make the changes in the
keymap.  I want to run GO_TO_RECSCREEN.  I don't know how to link these two
things.  I think I have to set up something in action.c, but I am not sure
what.

In the end, I want to go to the recording screen when I press the rec button
on the sansa.

Can you please help me?
Title: Re: Recording Enhancements Pack
Post by: Rincewind on June 18, 2007, 10:05:09 AM
@fed: you have to add the action to the button handlers, too. Every screen has it's own button handler, which is a big 'switch case' statement, e.g. in tree.c for the file browser, gwps.c for wps. I don't know exactly where the buttons in the menus are handled (look in every file that has 'menu' in the name and you should find it).
Title: Re: Recording Enhancements Pack
Post by: fed on June 18, 2007, 11:19:38 AM
Thanks.  That helps a lot!

Do you know which menu is for the main menu.  I tried main_menu.c, but it seems to be for something else.
Title: Re: Recording Enhancements Pack
Post by: Peter200lx on June 18, 2007, 12:16:45 PM
The Current REP patch has some problems when applying it. I was wondering if it was a simple changing of some lines to get it working, and if it was if someone could post a changed REP.patch. My programing skills are in the infant stage, so I'm not at all sure what to do myself. If someone could post an update, I'd greatly appreciate it. If needed, I can post a copy of the errors that I'm getting.
Title: Re: Recording Enhancements Pack
Post by: fed on June 19, 2007, 10:37:44 AM
I was wondering where I could find the function recording_start_automatic
Title: Re: Recording Enhancements Pack
Post by: GodEater on June 19, 2007, 10:49:26 AM
Really - look at finding out how to use grep....
Title: Re: Recording Enhancements Pack
Post by: fed on June 19, 2007, 10:50:11 AM
Thanks.  I found it.

Is there a way to recurse the folders?  I tried -r, but it didn't work.
Title: Re: Recording Enhancements Pack
Post by: GodEater on June 19, 2007, 11:39:51 AM
I think you have to use -R (case sensitive)
Title: Re: Recording Enhancements Pack
Post by: Llorean on June 19, 2007, 02:52:39 PM
Code: [Select]
grep -i "stuff to look for" -R * is what I tend to use. I actually think -r also works, or claims to, if I recall.
Title: Re: Recording Enhancements Pack
Post by: Rincewind on June 19, 2007, 03:06:39 PM
This is the grep command my Emacs uses for recursive grepping (M-x rgrep):

Quote
find . \( -path \*/CVS -o -path \*/.svn -o -path \*/\{arch\} -o -path \*/.hg -o -path \*/_darcs -o -path \*/.git -o -path \*/.bzr \) -prune -o  -type f \( -name \*.\[ch\] \) -print0 | xargs -0 -e grep -i -nH -e "the search string"


this command has the advantage that it doesn't find the files inside the .svn directories and it is limited to *.[ch] files. It displays the line numbers, too.
Title: Re: Recording Enhancements Pack
Post by: GodEater on June 19, 2007, 03:27:23 PM
...and the award for best "Sledgehammer to crack a nut approach" goes to .... ;)
Title: Re: Recording Enhancements Pack
Post by: Rincewind on June 19, 2007, 03:35:37 PM

...and the award for best "Sledgehammer to crack a nut approach" goes to .... ;)


well, the only thing I really type is the search string, everything else is handled automatically. With this I can click on a result and the file is opened at the right place for me.

It took my quite some time with the man page for 'grep' and 'find' to analyze how it works  ;D
Title: Re: Recording Enhancements Pack
Post by: fed on June 19, 2007, 07:49:54 PM
Thanks!  

This is going to help me a lot!

I actually prefer the really long one.  It gives better results.
Title: Re: Recording Enhancements Pack
Post by: fed on June 19, 2007, 08:32:43 PM
Now I'm trying to put something (text or graphics) on the recording screen while the unit is recording (to make it obvious to me), and to take it away when it is not recording.  Any idea how I would tackle this?
Title: Re: Recording Enhancements Pack
Post by: cpchan on June 22, 2007, 04:39:17 AM

Has anyone made a build with this patch for the Sansa e200?


I just did:

http://www.anythingbutipod.com/forum/showthread.php?t=12583

@Mmmm: I have resynced this patch with SVN and added a simple ifdef to make it compile for the e200 target (no line in). Also, I have added the e200 target to Rincewind's code  for a customisable record button. Do you want me to send it to you?

Charles
Title: Re: Recording Enhancements Pack
Post by: fed on June 22, 2007, 09:18:23 AM
Thanks for doing that!

I tried your most recent build, and I don't see the menu for setting the buttons.  Some of the other menus (in recording settings) seem to be a bit off as well.  Is the patch in your most recent build?
Title: Re: Recording Enhancements Pack
Post by: cpchan on June 22, 2007, 09:28:44 AM

I tried your most recent build, and I don't see the menu for setting the buttons.


I updated patch 5555. I am now in the process of doing the same for the "Recording Enhancement Pack". It will be available shortly after some testing.

Quote
Some of the other menus (in recording settings) seem to be a bit off as well.  Is the patch in your most recent build?


Can you see if it is still "off" after you try the next release?

Charles

Title: Re: Recording Enhancements Pack
Post by: fed on June 22, 2007, 09:55:57 AM
Thanks, looking forward to it.

I'd like to ask you a question, if you don't mind.  I posted it

http://forums.rockbox.org/index.php?topic=11179.0

I think I'm not supposed to double post questions, so could you please check out the link?  It is about writing to the rec screen to make the recording status larger on the screen.
Title: Re: Recording Enhancements Pack
Post by: cpchan on June 22, 2007, 12:39:53 PM

Thanks, looking forward to it.


OK it is done. Everything is working fine for me. Please test:

http://www.anythingbutipod.com/forum/showthread.php?t=12583

Charles
Title: Re: Recording Enhancements Pack
Post by: fed on June 22, 2007, 04:37:11 PM
I only changed the rockbox.mi4, so I don't know if that is the problem.  I tried your build, and it doesn't look quite right.  In

http://www.rockbox.org/tracker/task/5555#comment8661

it states "A Menu entry is added under General Settings -> System => Button Config"

but I cannot find Button Config.
Title: Re: Recording Enhancements Pack
Post by: cpchan on June 22, 2007, 04:49:03 PM

it states "A Menu entry is added under General Settings -> System => Button Config"

but I cannot find Button Config.


Strange, I am starring at it right now. It is right between "Car Adepter Mode" and "Wheel Light Timeout." Are you sure you have the latest version? Try installing both zip files and see.

Charles


[attachment deleted by admin for age]
Title: Re: Recording Enhancements Pack
Post by: fed on June 22, 2007, 07:11:21 PM
Nope.  I don't.  I have 'Encoder Settings' at that location.  The sub-menu is 'No Setting' and 'Same As Source'.  From there, both sub-sub-menus are Bitrate, Trityp, and Stop.  I can't make sense of it.

Do you think I need to replace all the files, or is just replacing rockbox.mi4 enough?

How'd you get the screenshot?
Title: Re: Recording Enhancements Pack
Post by: fed on June 22, 2007, 07:45:37 PM
Sorry.  I installed all the files, and it now seems to work.  
Title: Re: Recording Enhancements Pack
Post by: AlexP on June 22, 2007, 07:56:56 PM

How'd you get the screenshot?


Although this is off topic for this thread, look for screen dump in the manual.
Title: Re: Recording Enhancements Pack
Post by: fed on June 22, 2007, 08:24:06 PM
I like the patch, but it is missing two button actions that I find useful:

The rec button on the main menu to go to the rec screen.

The select button in the rec screen to stop the recording.  But if you press the select button again, you don't exit the rec screen.  

Here is my patch.

[attachment deleted by admin for age]
Title: Re: Recording Enhancements Pack
Post by: fed on June 22, 2007, 09:43:06 PM
How do you get the letters on the rec screen to print using the larger font?
Title: Re: Recording Enhancements Pack
Post by: cpchan on June 23, 2007, 04:01:33 AM

How do you get the letters on the rec screen to print using the larger font?


No idea, I have only started to look at the code.

Charles
Title: Re: Recording Enhancements Pack
Post by: Rincewind on June 23, 2007, 08:26:07 AM

How do you get the letters on the rec screen to print using the larger font?


This is not possible at the moment, because there are only two fonts that rockbox uses, the (small) system font and the user font.
Maybe you can put a huge bmp image on the screen instead.

about the Rec button: If I find the time I have look if I can use your patch in my rec button config patch.
Title: Re: Recording Enhancements Pack
Post by: fed on June 23, 2007, 09:34:35 AM
So how do I use the user font on the rec screen?

I like the idea of a bmp on the rec screen.  I don't know how to do that either.  Would you be able to point me in the right direction?
Title: Re: Recording Enhancements Pack
Post by: cpchan on June 23, 2007, 12:53:02 PM

The rec button on the main menu to go to the rec screen.


I did one for my builds today. Here you go.

Charles


[attachment deleted by admin for age]
Title: Re: Recording Enhancements Pack
Post by: fed on June 23, 2007, 03:10:43 PM
Do you know I can print to the rec screen or put a bmp on the rec screen?
Title: Re: Recording Enhancements Pack
Post by: fed on June 23, 2007, 05:25:55 PM
Here is the patch I made to use the rec button for getting to the rec screen no matter where you are, except the FM menu.  I can't figure that one out.  Also, I made the font bigger in the rec screen, so you can see 'pre recording', etc more clearly.

Sorry about the '****' and all that, but that's how I keep track of my changes.

I still need to print on the rec srceen, or place a bmp there when the recording is ongoing.

[attachment deleted by admin for age]
Title: Re: Recording Enhancements Pack
Post by: taylordb on July 06, 2007, 10:08:00 AM
I apologize if this has been asked before...

Does Mmmm's build for H120/H140 in the 1st post include the "Patch:  Recording Enhancement Pack (all targets) (latest version)"  or do I need to install the patch separately.

Thanks in advance for you help.
Title: Re: Recording Enhancements Pack
Post by: mschneider on July 06, 2007, 12:14:58 PM
fed: you dont have to modify the patch to make the userfont print on the rec screen. Just patch multifont and specify the font you want in your .cfg (that's what i do anyway).
Title: Re: Recording Enhancements Pack
Post by: Darktrain on July 13, 2007, 11:29:05 AM
A little confused about REP for the H3XX, where do I get it? I know the H1XX is in a certain person's post, is it the same for the H3XX? Any help will be appreciated.
Title: Re: Recording Enhancements Pack
Post by: petur on July 13, 2007, 11:59:04 AM

A little confused about REP for the H3XX, where do I get it? I know the H1XX is in a certain person's post, is it the same for the H3XX? Any help will be appreciated.

Heya taperssection fellow, welcome to the rockbox forum :)

Read the first post of this thread, it contains a link to a h3x0 build as well.
(H1x0 and H3x0 are not compatible!)
Title: Re: Recording Enhancements Pack
Post by: cpchan on July 13, 2007, 12:25:47 PM
Hello Mmmm:

I have a build for the e200 target with a fully functional Recording Enhancements Pack (including Rincewind's patch for a customisable record button). If you would like to link it from the first post, here is the link:

http://www.anythingbutipod.com/forum/showthread.php?t=12583

Thanks.

Charles
Title: Re: Recording Enhancements Pack
Post by: chrisjs169 on July 14, 2007, 10:28:48 PM
Tried the patch before and liked it...if only I could get apps/gui/statusbar.c to work so it'd build =/
Title: Re: Recording Enhancements Pack
Post by: paulheu on July 15, 2007, 05:54:55 AM
Here's an updated patch that compiles against the current svn. I removed the talk_unit bits from settings.c as I do not know what changed there, but they did break compiling..

so if anyone can fix that it'll be complete again.. :)

[attachment deleted by admin for age]
Title: Re: Recording Enhancements Pack
Post by: cpchan on July 15, 2007, 06:18:51 AM

Here's an updated patch that compiles against the current svn. I removed the talk_unit bits from settings.c as I do not know what changed there, but they did break compiling..

so if anyone can fix that it'll be complete again.. :)


I used a different solution. I simply added the talk_unit function back in. Everything compiles and work fine.

Charles
Title: Re: Recording Enhancements Pack
Post by: paulheu on July 15, 2007, 04:36:23 PM
guess that's also a solution.. maybe better.. so here's the diff with tak_unit back in..

[attachment deleted by admin for age]
Title: Re: Recording Enhancements Pack
Post by: paulheu on July 22, 2007, 03:36:50 AM
another SVN sync..

I also have source and build for iRiver H3x0 available at http://www.audiostuff.info/rockbox

[attachment deleted by admin for age]
Title: Re: Recording Enhancements Pack
Post by: paulheu on July 31, 2007, 02:49:52 PM
I would like to know whether it would be possible to just get the 'specific' REP parts (that would IMO be the fonts stuff) on to flyspray.. It would be nice to see this patch committed already!
Title: Re: Recording Enhancements Pack
Post by: Peter200lx on August 01, 2007, 11:11:49 PM
Useing the latest SVN sync patch, (Thanks paulheu!) I tried building with the latest SVN and got this error:

Code: [Select]
CC gui/option_select.c
gui/option_select.c: In function `selection_to_val':
gui/option_select.c:237: internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.
See for instructions.
make[1]: *** [/home/Peter/rock/build/apps/gui/option_select.o] Error 1
make: *** [build] Error 2


Would it be possible for someone to bring the REP patch up to date? I'd be quite grateful. If not no problem, I don't need it now if it's too much trouble. Thanks for the patch in the first place! It's been a great tool!

PS. I can give more error details if asked, my build is with the RTC (Real Time Clock) option in building enabled.
Title: Re: Recording Enhancements Pack
Post by: Heriver on August 02, 2007, 05:48:11 AM
Hello Peter200lx

I have make a build last weekend it give's me some hunk's

=====================================
SVN 29-july-2007
--
Patching file tree.c
Hunk #2 succeeded at 631 (offset -5 lines).
patching file lang/englisch.lang
--
=====================================
But it did wel!
Later i did the SVN update and i have no problems.

====================================
SVN UPDATE 01-august-2007

Target: h120
Target id: 9
Target define: -DIRIVER_H120
Memory: 32
CPU: coldfire
Manufacturer: iriver
Version: r14107M-070801
Binary: rockbox.iriver
Binary size: 367644
Actual size: 367636
gcc: m68k-elf-gcc (GCC) 3.4.5
ld: GNU ld version 2.16
Host gcc: gcc (GCC) 3.4.4 (cygming special, gdc 0.12, using dmd 0.125)
Host system: CYGWIN_NT-5.1
==================================================

I have also compile the build wit RTC on and REP patch executed!
For my h120 only the REP (because it has not -yet- the RTC-mod,
the h140 has the RTC-mod (see posting in the RTC-thread).

Also you can refer my message at;
http://forums.rockbox.org/index.php?topic=11882.msg89853#msg89853

Title: Re: Recording Enhancements Pack
Post by: paulheu on August 02, 2007, 12:26:51 PM
Now that the record button is supported in svn I guess that spells the end for the rec-button-config patch, IMO at least as far as it being part of REP is concerned.

We truly need to get the fonts stuff (and histogram) into svn, so a split of the patch and addition to Flyspray would IMO be a good idea by now..
Title: Re: Recording Enhancements Pack
Post by: Rincewind on August 02, 2007, 03:23:50 PM
well, the rec button patch still offers a button that starts the recording immediatly.
but I guess that my patch is not necessary for most users of the REP anymore.

I plan to continue updates to my patch, though.
Title: Re: Recording Enhancements Pack
Post by: paulheu on August 02, 2007, 07:40:40 PM
True, your patch offer more functionality. And I can see ppl using it, but I think that with the current svn in mind it should be removed from the REP..
Title: Re: Recording Enhancements Pack
Post by: Llorean on August 02, 2007, 10:28:38 PM
Just a reminder, "ppl" isn't an English word, and we ask that you try to make sure all posts are as machine-translatable as possible.
Title: Re: Recording Enhancements Pack
Post by: Diamond D on August 06, 2007, 10:00:24 PM
1st time poster, been using Rockbox on my h120 for a year now and love it!

I downloaded "mmmm"s build from his signature, my first update in at least 6 months. I love the new menu setup and graphics, but I have encountered one problem. When I go into Settings>General>Display>Peak Meter and click on "Peak Release" the unit freezes up every time, I have to reset it.

Does anyone else see this problem? Any fix, or specific recent builds with the REP that people are using?

Thanks to mmmm and everyone at Rockbox for their amazing work!
Title: Re: Recording Enhancements Pack
Post by: petur on August 07, 2007, 05:29:09 AM
The REP isn't really supported....

Is there any feature of the REP you really need?
Because the official RockBox version will record just as fine.
Title: Re: Recording Enhancements Pack
Post by: Arni on August 08, 2007, 05:58:40 AM
With the REP from July 23rd 2007 of Mmmm´s signature, there´s a bug..... when selecting "Peak release" in the menue=>rockbox freezes and needs a hard reset.
I use an iHP-120.

settings/general settings/display/peak meter/peak release

As far as I can remember this bug was also in the current build from 2 weeks ago when I used my iHP-100.
Title: Re: Recording Enhancements Pack
Post by: petur on August 24, 2007, 06:48:39 PM

With the REP from July 23rd 2007 of Mmmm´s signature, there´s a bug..... when selecting "Peak release" in the menue=>rockbox freezes and needs a hard reset.
I use an iHP-120.

settings/general settings/display/peak meter/peak release

As far as I can remember this bug was also in the current build from 2 weeks ago when I used my iHP-100.


I fixed this bug in SVN on 17/8, REP builds always stay behind when it comes to bugfixes...
Title: Re: Recording Enhancements Pack
Post by: petur on August 24, 2007, 06:51:24 PM
I have coded up a first version of a clip counter.
It shows the number of times the clipping indicator went on (in front of the peakmeter, they become a bit shorter)
Must be enabled in the peak meter settings.
The counter is reset on recording start, so it stays there (and unfortunately also keeps counting) when recording is stopped.

http://www.rockbox.org/tracker/task/2976

edit: committed :)
Title: Re: Recording Enhancements Pack
Post by: Diamond D on August 26, 2007, 05:16:50 PM

The REP isn't really supported....

Is there any feature of the REP you really need?
Because the official RockBox version will record just as fine.


While none of the features are truly necessary for me, I found that the histogram feature and being able to enlarge the peak meter were very useful in the field.

I did download the most recent build today (without those features) and was happy to see that the 'peak meter release' bug is gone, thanks for that!
Title: Re: Recording Enhancements Pack
Post by: petur on August 27, 2007, 02:26:22 AM
I'll have a look at getting the peakmeters enlarged. I was think about doubling the size on targets that can handle it - would that be enough?
Title: Re: Recording Enhancements Pack
Post by: Heriver on August 27, 2007, 11:35:40 AM

The REP isn't really supported....

Is there any feature of the REP you really need?
Because the official RockBox version will record just as fine.


The Uncommitted section in REP i NEED is this,
iv-a Count downtimer, see below:

iv) New Menu option "Timer options" contains all timer settings (including split timers)
  a) Countdown timer. Set in the settings menu. Max countdown time is 1 week.

From now on the REP patch is useless,
major errors in lang.c lang.h with the current SVN build r14469 (august 26)
Title: Re: Recording Enhancements Pack
Post by: petur on August 28, 2007, 04:22:03 AM

From now on the REP patch is useless,
major errors in lang.c lang.h with the current SVN build r14469 (august 26)

If it is only the lang file that fails it is nothing....
I fear my clipcounter also somehow broke the big peakmeters
Title: Re: Recording Enhancements Pack
Post by: Heriver on August 28, 2007, 11:06:58 AM

Quote

If it is only the lang file that fails it is nothing....


Petur, i've read between the lines, patience or worse... long term, good luck!

This Topic has already 58 pages and Readings over 71439 times (for now),
Mmmm's REP is now (sadly, far) behind the SVN.
Once a hit and now...Mmmm's thanks that you ever make the REP comes to alive!
Title: Re: Recording Enhancements Pack
Post by: darksaboteur on September 11, 2007, 02:32:12 AM
Hey Guys,
I synced the REP. It is tested on an iRiver H340. Sorry for the short message but the forums are up and down like a yoyo and I'm sick of typing! I created a flyspray page for the REP
http://www.rockbox.org/tracker/task/7753

Get the patch from http://rockbox.biniaris.net/Files/Darky/patches/rep-14667.patch

Enjoy,
Darky
Title: Re: Recording Enhancements Pack
Post by: GodEater on September 11, 2007, 02:53:20 AM
Patches go in the tracker - not on the forums. Please could you move it there.

Many apologies darksaboteur - Llorean has explained to me that REP *should* be posted here. Apparently I've got it all wrong :(
Title: Re: Recording Enhancements Pack
Post by: petur on September 11, 2007, 04:57:50 AM
I closed the tracker item... keep the REP here for the time being...
Title: Re: Recording Enhancements Pack
Post by: Heriver on September 11, 2007, 05:10:11 PM

I synced the REP. It is tested on an iRiver H340.

Hello darksaboteur

I've downloaded the files and patched (without any warnings) with RTC enabled for H120,
build under VMWare-Rockbox (much faster as Cygwin) and the basic functions works fine!
Thanks.
Title: Re: Recording Enhancements Pack
Post by: paulheu on September 12, 2007, 01:53:06 AM

I closed the tracker item... keep the REP here for the time being...


While I agree in principle I feel the chance of the REP getting split and into SVN to be bigger if there's a flyspray entry for it.. More people who might be able to help should come  across it there..

But if it's a rule it's a rule I guess..
Title: Re: Recording Enhancements Pack
Post by: Llorean on September 12, 2007, 02:04:22 AM
Why don't you split it THEN put those split ones in the tracker, instead of trying to do it in the wrong order?
Title: Re: Recording Enhancements Pack
Post by: duncank on October 29, 2007, 07:26:59 AM

Hi there,

Daft newby question:

I've got an iHP140 (which I bought on ebay having got fed up trying to make any external recordings with my iAudio X5L - no plug-in mic power apparently, and even after buying a cheap mic pre-amp on ebay it still doesn't work).

I've downloaded Rockbox version R14632-070907, which is superb (thanks to everyone that coded it!).

I now want to add the Recording Enhancements Pack patch to my download.

When I click on the link to the patch at the beginning of this thread, it just opens a new window with the code in.

So, my daft newby question is "What do I do with that"? Save it? As what? Do I have to overwrite files in my existing download? Would it be easier just to download everything again from Mmmm's signature?

Cheers

Duncan
Title: Re: Recording Enhancements Pack
Post by: AlexP on October 29, 2007, 08:22:42 AM
You save it as a file, then use it to patch the rockbox source code.  Following that you compile the source code into a build which you then put on your player.

Have a look at http://www.rockbox.org/twiki/bin/view/Main/WebHome?topic=SimpleGuideToCompiling

Edit:  I don't know when the REP was last updated.  If it is a while it is likely it will no longer apply cleanly without needing editing.  If you use one of Mmm's builds bear in mind I think they are quite old and you will miss out on new features + bug fixes (although the H1x0 builds are quite stable).

If you run any build other than the official build you download from the current builds page then be aware that they are unsupported here.
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on October 29, 2007, 10:41:01 AM
I'm also not entirely sure any of the features that are exclusive to the REP are absolutely necessary for recording. Most of the essential features have already been accepted into the main Rockbox code.

It looks cool though.
Title: Re: Recording Enhancements Pack
Post by: duncank on October 29, 2007, 12:41:53 PM
Hi,
Thanks for the replies. I've been recording using the download I have without the REP, but I read a review praising the improved clarity of the screen and was keen to try it.

I think the easiest thing is if I download Mmm's signature version - see if I notice any of whatever's missing and decide which I prefer..

Cheers,

Duncan
Title: Re: Recording Enhancements Pack
Post by: amoergosum on November 20, 2007, 06:43:59 AM
Does anyone know what happened to "Mmmm" ?
He hasn't been here for a long time.
Title: Re: Recording Enhancements Pack
Post by: simon142857 on November 20, 2007, 09:33:09 PM

I'll have a look at getting the peakmeters enlarged. I was think about doubling the size on targets that can handle it - would that be enough?

Yes Petur I'm wondering about the While Recording Screen; I have an extremely difficult time with the small font, and would like to be able to change it to a bigger font. It seems like I remember this being a part of the REP?
Title: Re: Recording Enhancements Pack
Post by: petur on November 21, 2007, 03:23:14 AM


I'll have a look at getting the peakmeters enlarged. I was think about doubling the size on targets that can handle it - would that be enough?

Yes Petur I'm wondering about the While Recording Screen; I have an extremely difficult time with the small font, and would like to be able to change it to a bigger font. It seems like I remember this being a part of the REP?


yes, and since you're writing this in the REP forum thread, I assume you know where to get it or the patches that enable it ;)

As for whatever I wrote up there, I have run out of spare time atm, I already asked some for xmas ;)
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on January 27, 2008, 06:56:26 PM

Does anyone know what happened to "Mmmm" ?
He hasn't been here for a long time.



What did happen to Mmmm?
Title: Re: Recording Enhancements Pack
Post by: Bedlore on February 18, 2008, 05:21:02 AM
I think since my last firmware upgrade recordings have been going into the root directory, is this a known bug? I searched through the settings but doesn't appear to be anywhere to set the recording directory.

And yes.  where in the world is Mmmmmm, looks like a new compiled firmware supplier is needed! :(
Title: Re: Recording Enhancements Pack
Post by: AlexP on February 18, 2008, 06:56:34 AM

I think since my last firmware upgrade recordings have been going into the root directory, is this a known bug?


It isn't a bug at all.  Set the recording directory by selecting the folder you want, opening the context menu (hold navi I seem to remember on H1/3x0, then select Set Recording Directory or some such.

If you haven't set the directory it will default to root.
Title: Re: Recording Enhancements Pack
Post by: Bedlore on February 18, 2008, 07:04:22 AM
Nope, searched everywhere.  I would expect to find this setting under Recording Settings but I've looked everywhere else as well.  Perhaps I am going blind?  I'm using a H140 with rockbox r14742M-070918.

Title: Re: Recording Enhancements Pack
Post by: GodEater on February 18, 2008, 07:18:56 AM
Well I'm running a build from this morning, and the option appears exactly where BigBambi says it does.
Title: Re: Recording Enhancements Pack
Post by: Bedlore on February 18, 2008, 07:25:57 AM
Hmm, definitely not there, perhaps it was an old bug now fixed.
Is anyone doing pre-compiled version for REP H/1xx at the moment?
Title: Re: Recording Enhancements Pack
Post by: petur on February 18, 2008, 07:34:40 AM
I recently fixed a bug where this settings wasn't saved so you might be experiencing that (too).

Mmmm is the creator of this REP and I haven't seen him around for months...
Title: Re: Recording Enhancements Pack
Post by: AlexP on February 18, 2008, 10:49:29 AM
You are using the context menu right?

If you want to use /recordings for instance, go to the filetree, highlight the recordings directory, hold NAVI until the context menu pops up, then select Set Recording Directory
Title: Re: Recording Enhancements Pack
Post by: Bedlore on February 18, 2008, 06:10:47 PM
 :-[ Oops, it appears I was just stupid.  I was entering the menu by holding the NAVI but not context sensitive in a directory.  Sorry about that.  :)
Title: Re: Recording Enhancements Pack
Post by: b0br on February 19, 2008, 01:43:19 AM
Please, is there anybody, who could compile current build with REP for H300??
I would really apreciate that, because I need histogram and don't have chance to compile it myself..
Thanks!
Title: Re: Recording Enhancements Pack
Post by: brotherwind on February 19, 2008, 01:47:57 AM

Please, is there anybody, who could compile current build with REP for H300??
I would really apreciate that, because I need histogram and don't have chance to compile it myself..
Thanks!


Yes, please. Did a recording recently without the histogramm and missed it badly!  

Thanks!
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on March 24, 2008, 06:31:34 PM
I'm in a similair situation...

I love the balance meter in the REP. I rely on it when I record with microphones. Now, I want to replace one of my iRiver iHP-120 hard drives with a compact flash card. The latest Rockbox builds have support for the compact flash card mod that I need. To further complicate, I did the Real Time Clock mod on both of my iRivers, so I need that patch to make the mod active.
 
Peter200lx  has, in the past, been kind enough to compile the latest REP with the RTC mod patch for me, but he needs a .patch file for the REP that is synced with the latest SVN for the iHP-120.

Can anyone help? Please?
 

 
 
Title: Re: Recording Enhancements Pack
Post by: Meow on June 16, 2008, 06:01:23 PM
I've updated the patch in post#1 to latest SVN and put in the yields that improve the buffer usage. So hopefully that and JSMikes updates mean the problems that have been seen recently are no more....
Is there anyone updating the REP with the latest main release? I see Mmmm has last done this more than a year ago.

Also, if you're reading:
It looks like the version from your signature ignores 20 Gigabytes of my iHP140's harddrive and records as if it is a iHP120. Is this a setting somewhere?
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on June 16, 2008, 07:08:25 PM
There are a bunch of us that would like that.
Title: Re: Recording Enhancements Pack
Post by: redwood on June 16, 2008, 07:09:44 PM
hear hear!
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on June 16, 2008, 07:25:24 PM
hear hear!

I'd be very happy with just the balance meter patched into a daily build.
Title: Re: Recording Enhancements Pack
Post by: peteswensson on June 16, 2008, 07:48:23 PM
I am so reliant on the REP that I continue to use a Rockbox version from last September (an unsupported build called "Darky's Build"), rather than update it.  This is because I have very weak eyes, and have lots of trouble reading the default font on my iriver H300 player/recorders.  (What I value most about the REP is that it lets me use Nimbus 12 and double-width peak meters.)  I have 3 H300-series recorders, and one of them I will keep in the old version just to maintain access to the REP.  The other two I am converting to CF, which requires use of a current build.

So consider this another word encouraging adding the REP into the current build!

And thanks for all the great work that so many have done on the Rockbox product!
Title: Re: Recording Enhancements Pack
Post by: Llorean on June 28, 2008, 10:16:44 AM
Hi guys.

So, this is a very popular patch. But as many of you have noticed, it's quite out of date. Unfortunately, there's not really anyone on this side with time to work out getting it back into sync. But there is some interest in trying to get more of it committed again.

So, here's the situation: While devs may have time to commit parts of this patch, they don't have times to drag it back up to working spec first so that they can review it and make the decision. So if you'd like a better chance of having some, or all, of this stuff in the official build, resyncing the patch and making sure it works and builds on all recording targets without breaking builds anywhere else would go a very long way toward beginning to see this happen.
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on June 28, 2008, 10:25:26 AM
Hi guys.

So, this is a very popular patch. But as many of you have noticed, it's quite out of date. Unfortunately, there's not really anyone on this side with time to work out getting it back into sync. But there is some interest in trying to get more of it committed again.

So, here's the situation: While devs may have time to commit parts of this patch, they don't have times to drag it back up to working spec first so that they can review it and make the decision. So if you'd like a better chance of having some, or all, of this stuff in the official build, resyncing the patch and making sure it works and builds on all recording targets without breaking builds anywhere else would go a very long way toward beginning to see this happen.

Will someone please, take up our cause?
Title: Re: Recording Enhancements Pack
Post by: petur on July 01, 2008, 02:59:03 AM
After conversion to viewports I might have a look and getting the REP committed. No time line available due to limited resources
Title: Re: Recording Enhancements Pack
Post by: Cheese_Us on July 05, 2008, 01:26:54 PM
After conversion to viewports I might have a look and getting the REP committed. No time line available due to limited resources

Although I understand that you don't give any "guarantee" here I'd just like to say thanks, as I'm also a Rockbox users who would like to see the REP implemented.
Title: Re: Recording Enhancements Pack
Post by: Mmmm on July 13, 2008, 02:10:55 PM
Hello... I'm back! well, briefly anyway. I'm afraid that I just have no time for any Rockboxing anymore as my new job gradually sucked all my spare time up and then me and my wife had a baby and that was the end of that. Our son takes up a LOT of time!

Anyway, just thought I'd drop a note to say what happened, to those of you who asked.
I'm still using the REP build in my signature and haven't had any problems on my H140, but I have no idea what amazing new features there are and what I'm missing out on and I have no time to find out either.

I hope someone takes up the maintenance of the REP, but it's been so long simce it was updated, it could initially be a lot of work.

Good Luck,
Martin
Title: Re: Recording Enhancements Pack
Post by: LurkAzusa on July 13, 2008, 03:54:26 PM
I'm selfishly sorry you don't have the time to work on Rockbox, but happy your real life is going so well.  I just want to say thank you so much for your contribution to getting recording to the incredible state it is in.  I've captured so many wonderful concerts over the last few years.
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on July 13, 2008, 05:30:08 PM
Yeah, thank you very much Mmmm! Glad to hear you are doing well.
Title: Re: Recording Enhancements Pack
Post by: Davide-NYC on July 13, 2008, 09:22:35 PM
Cheers to Mmmm!
Title: Re: Recording Enhancements Pack
Post by: petur on July 14, 2008, 02:30:15 AM
yeah, /me knows what the arrival of a newborn does to your spare-time
Title: Re: Recording Enhancements Pack
Post by: isanggon on July 23, 2008, 03:48:17 PM
I almost successfully re-synced REP patch. The histogram printed wrong position but, it correctly works.;D However, my lack of understanding "recording.c" file, I cound not completed this patch. :'( I attach patch files here. Is any one can complete this, please help. I think there remains small, but big step.
When apply these patch, rec_button patch first. rec_button was done by kugel, but you should fix for hxxx series. you can easily fix keymap file, compare with attached keymap file.
Title: Re: Recording Enhancements Pack
Post by: Llorean on July 23, 2008, 04:25:36 PM
Why didn't you update the tasks on the tracker? Patches do not belong attached to the forums.
Title: Re: Recording Enhancements Pack
Post by: isanggon on July 23, 2008, 08:57:21 PM
I didn't saparetely worked REP patch. So I uploaded here. I didn't know patches should not belongs to here. I'll upload to tracker. Thanks for notifying me :)

-----------

Now I solved histogram positon problem. This problem was related with statusbar issue.
Remaining works is two.

1. remove last blank line upper of histogram
2. filename printing issue : when goes in recording, filename is missing.

I uploaded patch here.
http://www.rockbox.org/tracker/task/5021
Title: Re: Recording Enhancements Pack
Post by: petur on July 24, 2008, 02:56:52 AM
Great work

However, I'm reworking the recording screen massively so I am breaking all your work. Sorry.

My code is on the tracker as well, but do not use it as a basis for your modifications as I am still working on it.
Title: Re: Recording Enhancements Pack
Post by: isanggon on July 24, 2008, 03:43:33 AM

So sad.. but fine. ;D
Title: Re: Recording Enhancements Pack
Post by: Peter200lx on September 28, 2008, 11:10:23 PM
Is there any chance now that there has been an official 3.0 release that this could be updated to work with that? I'd love to have my device on a stable build!
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on September 29, 2008, 07:23:36 AM
That would be great!
Title: Re: Recording Enhancements Pack
Post by: Chronon on September 29, 2008, 03:38:12 PM
Well, 3.0 is kind of a snapshot build.  Any new functionality must be added to the current SVN trunk.  I'm not saying that no one will work on this, I just wanted to point out that you can't really add features to 3.0.
Title: Re: Recording Enhancements Pack
Post by: bascule on September 30, 2008, 09:47:31 AM
No, but if someone forked the REP code and worked on producing a 3.0-based custom REP build, that would effectively be the same thing and then the forked REP wouldn't have to be kept in sync with the trunk.
Title: Re: Recording Enhancements Pack
Post by: Chronon on September 30, 2008, 12:50:40 PM
Good point.  I guess it depends on whether the aim is to produce an unsupported build that has these features, or to try to get features introduced into the trunk.
Title: Re: Recording Enhancements Pack
Post by: petur on September 30, 2008, 03:01:05 PM
the aim should be to get parts of the REP in the normal builds, I hate forking ;)

I just don't seem to find the time to do it....
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on September 30, 2008, 03:24:02 PM
I like the balance meter in the REP. I know that some like the histogram. If someone could add those two features to the SVN it would make some of us recordists very happy.  ;D
Title: Re: Recording Enhancements Pack
Post by: davehouse on October 02, 2008, 09:39:47 PM
I tried my hand at compiling the REP with the latest build... and got very, very baffled very, very quickly! Respect to the folks whose efforts I've downloaded in the past. Can't wait for someone cleverer than me (and with more time than me!) to compile and upload the REP with a more up to date build than July 07.

So what are we missing features-wise by sticking to old builds for the sake of the REP, then? I love the REP, incidentally, its made my H120 my fave toy, but can't help wondering if I'm losing out in other respects!
Title: Re: Recording Enhancements Pack
Post by: jpedder on November 28, 2008, 06:13:52 AM
is there someone working on compiling the record histogramm or the complete enhancementpack for rockbox 3.0?


or is it pointless to wait for it, and better reinstall 2.x...

i would do it myself, but i´dont know anything about it. and i guess, a handful of hints won´t be enough for a total noob to get it, right?
Title: Re: Recording Enhancements Pack
Post by: isanggon on November 28, 2008, 08:35:25 AM
http://isanggon.mireene.com/

I compiled REP with 18163. Maybe this is latest build that compiled with REP. I uploaded source code patch, also. It's not 3.0 but have not big different with current svn.

Title: Re: Recording Enhancements Pack
Post by: AlexP on November 28, 2008, 05:28:55 PM
is there someone working on compiling the record histogramm or the complete enhancementpack for rockbox 3.0?

Petur is working on it I believe, but he has a real life to take into account too

or is it pointless to wait for it, and better reinstall 2.x...

Rockbox 2.x was for Archos devices only, for which the REP does not apply.

i would do it myself, but i´dont know anything about it. and i guess, a handful of hints won´t be enough for a total noob to get it, right?

Yes, the REP is pretty complicated.
Title: Re: Recording Enhancements Pack
Post by: petur on November 29, 2008, 01:25:34 PM
erm.. yeah, I'm 'working' on it, in fact I'm fairly close but missing some time atm. I'll do my best ;)
Title: Re: Recording Enhancements Pack
Post by: jpedder on November 30, 2008, 06:54:06 AM
great... i´m looking forward to... godspeed!

a monumental thanks in advance...
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on November 30, 2008, 07:13:21 PM
http://isanggon.mireene.com/

I compiled REP with 18163. Maybe this is latest build that compiled with REP. I uploaded source code patch, also. It's not 3.0 but have not big different with current svn.



isanggon:

Thank you so much! This is excellent! I can't thank you enough.
With your build, I can use the REP balance meter and it enables the Real Time Clock mod I installed too!

Does this build also support compact flash cards? I can't get my iHP-120 to boot from a compact flash card.

Thanks again,
Chuck


Edit: This build does support the CF card modification.
Title: Re: Recording Enhancements Pack
Post by: davehouse on January 12, 2009, 07:12:04 PM
That link doesn't seem to be working, can anyone re-upload elsewhere? cheers
Title: Re: Recording Enhancements Pack
Post by: isanggon on January 14, 2009, 06:16:21 AM
Paste that address to explorer manually. Then, you can access it :)
Title: Re: Recording Enhancements Pack
Post by: davehouse on January 16, 2009, 09:49:02 PM
Nice one, thanks for that!!
Title: Re: Recording Enhancements Pack
Post by: Diamond D on February 26, 2009, 12:58:33 AM
http://isanggon.mireene.com/

I compiled REP with 18163. Maybe this is latest build that compiled with REP. I uploaded source code patch, also. It's not 3.0 but have not big different with current svn.



Thank you for this! I had a great build with the REP a while back, long story short I updated it but I didn't like as much and couldn't find my old file so I was stuck. Finally I found one I like (yours)! Worked great at a show tonight. The Balance Meter really is a huge help in my opinion.
Title: Re: Recording Enhancements Pack
Post by: nofish on February 27, 2009, 04:42:25 AM
http://isanggon.mireene.com/

I compiled REP with 18163. Maybe this is latest build that compiled with REP. I uploaded source code patch, also. It's not 3.0 but have not big different with current svn.



Haven't been here for a long time and almost gave up about the REP.
Thanks a lot!!!
Title: Re: Recording Enhancements Pack
Post by: Spoonman on March 15, 2009, 03:30:09 PM
hey guys, i´m going to build a line-in cable for my ipod nano next week (still waiting for the doc connector) and then maybe, if rec quality is ok for me, use it to record dj-sets at partys. so i whould like to know if this REP could make sense for me also or the nano has maybe to weak cpu for all that?
i really like the idea to have cliplight and easy split function...

or did i maybe get this all wrong, and the main functions of the REP are all already included in recent builds?
Title: Re: Recording Enhancements Pack
Post by: petur on March 16, 2009, 03:16:06 AM
hey guys, i´m going to build a line-in cable for my ipod nano next week (still waiting for the doc connector) and then maybe, if rec quality is ok for me, use it to record dj-sets at partys. so i whould like to know if this REP could make sense for me also or the nano has maybe to weak cpu for all that?
i really like the idea to have cliplight and easy split function...

or did i maybe get this all wrong, and the main functions of the REP are all already included in recent builds?

most stuff of the REP is already in the regular build, including cliplight and split options. Only the histogram/balance meter are not in (I'm trying to resume work on them). The custom button and extra timers will probably never make it.
Title: Re: Recording Enhancements Pack
Post by: Spoonman on March 16, 2009, 07:00:58 AM
ok, so i can live without that atm despite they are interesting enhancements too, and hope they make it into the builds ;-) thanx for info....

and also thanx for all your hard work....

[edit]
can anybody tell me how to split tracks? according to nano user-manual it should be by pressing long play, but this does not seem to work for me! if i press play for 2 secs or so the player is shutting down...
[/edit]
Title: Re: Recording Enhancements Pack
Post by: nigelsh on April 08, 2009, 08:51:42 AM
The custom button and extra timers will probably never make it.

Is there any technical reason why the extra timers will never make it? I really like the countdown timer and as a result I'm now running a really old version of Rockbox. I might try and get the countdown timer working on 3.2 (for an H120) but I don't want to waste my time if there is some reason why this is no longer possible to do with the way that Rockbox is currently written/structured.
Title: Re: Recording Enhancements Pack
Post by: petur on April 09, 2009, 02:07:52 AM
the custom timers are actually a bit of a hack since it uses the main loop of the recording code to count the time, so it is not accurate and accuracy changes as code gets changed. I'd rather have a clean solution. The idea may be good but the implementation is not.
Title: Re: Recording Enhancements Pack
Post by: Spoonman on May 20, 2009, 03:09:38 PM
hi again.
first i am sorry to bug u guys again with something banal like this, but i am not able to do it by myself, so i need to ask someone else and i do it here since the origin of the problem seems to be the rep...

now to the problem itselve:

i soldered a line in cable for my ipod nano for recording dj sets on partys, wich works verry well with one exception: it is not realy possible to split tracks since the mapping of buttons is not really usable.
according to the manual track split works by a long press of play/pause button while recording, which effectively stops the recording because a long press is also a stop.

in my opinion it just should be mapped to a long press on select button for all ipod targets and the problem is gone. i already filed a bug report in flyspray here: http://www.rockbox.org/tracker/task/10207?project=1&type=2&order=dateopened&sort=desc but it seems like the interest for this issue is not very big at all, so i decided to post it here again.
Title: Re: Recording Enhancements Pack
Post by: Bedlore on June 01, 2009, 12:27:59 AM
Anyone who is following this thread have a recent REP build for H140 they are willing to share?  Mine is from r14742M which is getting on a bit.

Thanks
Title: Re: Recording Enhancements Pack
Post by: Llorean on June 01, 2009, 01:14:51 AM
Which feature of REP is preventing you from updating to an SVN build instead?
Title: Re: Recording Enhancements Pack
Post by: Bedlore on June 01, 2009, 01:26:29 AM
I don't fully understand, are you saying that the normal Rockbox svn incorporates REP's features?
Title: Re: Recording Enhancements Pack
Post by: Llorean on June 01, 2009, 01:46:32 AM
Not all of them, which is why I was asking which one was holding you back. You're using a one and a half year old version of Rockbox, I'd hoped you at least knew what feature(s) you considered indispensable.
Title: Re: Recording Enhancements Pack
Post by: Bedlore on June 01, 2009, 01:57:43 AM
Sure, I understand now.  I'd have to think about the answer for awhile before giving a complete answer but off the top of my head I'd say the recording start up screen, support for time stamping with the RTC mod, input metering and AGC would be high on the list.
Title: Re: Recording Enhancements Pack
Post by: Llorean on June 01, 2009, 01:59:14 AM
Care to guess how many of those are in the official build? (Though, for the RTC mod, you have to change one define before compiling since the player doesn't normally have an RTC, so RTC H100 series will pretty much always need a custom build)
Title: Re: Recording Enhancements Pack
Post by: Bedlore on June 01, 2009, 02:13:40 AM
I'm guessing all of them, could explain the general inactivity of the REP thread now.  Looks like I need to get my head around compiling and also hunt down a good second hand H300 unit too :)
Title: Re: Recording Enhancements Pack
Post by: Chronon on June 01, 2009, 12:33:56 PM
Check petur's comment at the bottom of the previous page.
Title: Re: Recording Enhancements Pack
Post by: TaperChuck on February 26, 2014, 06:02:44 PM
I haven't been here in a very long time....

So, I'm still using the REP for the centering meter, because I use my iHP-120 strictly for recording concerts. That meter is great for making sure you are recording a centered image. Is there a way to incorporate that into the latest builds? I'd love to update to the latest build, but that feature is something I really value.