Rockbox Technical Forums

Rockbox Development => Feature Ideas => Topic started by: yelped on August 26, 2009, 05:06:03 PM

Title: Arranger and Composer Tags
Post by: yelped on August 26, 2009, 05:06:03 PM
Under Track Info or Properties can someone add Arranger and Composer Tags (or whatever tags are available), please? And if there are not filled in, it just disappears,  that way you don't just see an empty box. The only way to see who composed a song right now is to go to Database>Composers>"Name of Composer", which is very time-consuming.

I would appreciate it.

Thanks.

Edit: Actually, you can use the context menu, and use "open with...", and select "Viewer", and at the beginning of the file you'll see the tags, however getting this done is obviously preferred.
Title: Re: Arranger and Composer Tags
Post by: yelped on August 29, 2009, 10:47:37 PM
Bump?
Title: Re: Arranger and Composer Tags
Post by: yapper on August 30, 2009, 12:08:38 AM
Please do not 'bump'. You should read the sticky for the Feature Ideas thread, particularly "there is no guarantee they will be acted upon".
Title: Re: Arranger and Composer Tags
Post by: yelped on August 30, 2009, 01:30:12 PM
Sorry, I just wanted to get a response like "no" or "yes".
Title: Re: Arranger and Composer Tags
Post by: saratoga on August 30, 2009, 01:37:15 PM
The only way you can get a yes answer is if someone is already working on it.  The only way to get a no answer is if your idea if impossible or not allowed for some reason.  Both of these are unlikely, so you're getting the third option "maybe if someone ever decides to add it".
Title: Re: Arranger and Composer Tags
Post by: yelped on August 30, 2009, 08:23:25 PM
OK. Sorry again. :D
Title: Re: Arranger and Composer Tags
Post by: AlexP on August 31, 2009, 06:41:12 AM
I can't imagine that there would be any opposition to this, it just needs someone to do the work, as saratoga says.
Title: Re: Arranger and Composer Tags
Post by: yelped on September 01, 2009, 04:17:50 PM
Are you willing to do the work? ;)
Thanks a lot.
Title: Re: Arranger and Composer Tags
Post by: AlexP on September 01, 2009, 04:43:01 PM
No, are you?  That is the only sure way to make something happen.
Title: Re: Arranger and Composer Tags
Post by: bakseetdrivr on September 01, 2009, 08:18:24 PM
AlexP=awesome :P
Title: Re: Arranger and Composer Tags
Post by: yelped on September 01, 2009, 09:22:32 PM
OK, OK, I get the hint. :) However, one little snag, I can't code. :( So, I'll wait for somebody who can code and wants this feature. :D
Title: Re: Arranger and Composer Tags
Post by: yelped on May 23, 2010, 03:27:01 PM
Just an update: This feature is now infinitely more useful with the hotkey now settable in the WPS Screen for "Track Info".
Title: Re: Arranger and Composer Tags
Post by: csavery on May 24, 2010, 11:33:16 AM
I've just added patch FS#11313 (http://www.rockbox.org/tracker/task/11313) to provide composer on the track info screen.

It shows at the bottom but if you scroll up it's visible easily. I would have added it after "Artist" but that involved changing all the other tags so I just kept it simple.

Composer is a standard ID3 tag and present in the lower level ID3 code in Rockbox. Arranger is not currently there and I'm not sure what ID3 tag it would match up with. I checked on Wikipedia and arranger wasn't listed as a standard tag. So I could make a patch for it but it would be more complex since it needs lower level code and I'd need to know what ID3 tag it should connect to.
Title: Re: Arranger and Composer Tags
Post by: yelped on May 24, 2010, 11:49:22 AM
Thanks a lot! The most useful is the composer tag anyways. Great work!  Update: thanks to jd gordon for accepting the patch in r26409, and even more thanks to Chris Savery for making the patch and modifying it to be accepted and working optimally.