Rockbox Technical Forums

Rockbox Development => Feature Ideas => Topic started by: Serenity on July 25, 2008, 11:48:57 PM

Title: Include the option for a default custom "nocover.bmp" for missing album art.
Post by: Serenity on July 25, 2008, 11:48:57 PM
I realize this is really really low on the list of priorities, but I was wondering if it would be possible to include a 7th "priority" for Rockbox's album cover search.  Just to make Rockbox fish into a specific folder (like /.rockbox/albumart) for a specific filename (like nocover.bmp) and display that instead of shifting the text or revealing part of the wallpaper.

Useless, I know, but fun.  I use a specific graphic that makes me smile whenever a local demo or something equally unadorned shows up, but I have to save that same image as "cover.bmp" in every folder.  It would be nice to just have Rockbox grab it from the single location each time it can't find a proper cover.

I couldn't figure out how to do this with wps tags--if it's possible through conditionals and I missed the tags, then just tell me I'm dumb.  But I really did look before posting!!  :-[
Title: Re: Include the option for a default custom "nocover.bmp" for missing album art.
Post by: ZincAlloy on July 26, 2008, 04:05:14 AM
completely useless. just make the image part of your wps backdrop.
Title: Re: Include the option for a default custom "nocover.bmp" for missing album art.
Post by: karashata on July 26, 2008, 10:11:19 AM
The themes that shift the text over when art isn't present were written that way because that's what the theme authors wanted them to do.  That being said, if you wanted to stop that from happening so you could add the no-cover image to the WPS background and not have it overdrawn by text, you could edit the WPS file to remove the conditionals (%?C<> most likely, and fix the viewport definitions appropriately) that change the layout when no art is found.
Title: Re: Include the option for a default custom "nocover.bmp" for missing album art.
Post by: karashata on July 26, 2008, 10:25:35 AM
I didn't quite catch that until after I had made the post...  I need to stop skimming things so quickly...
Title: Re: Include the option for a default custom "nocover.bmp" for missing album art.
Post by: Serenity on July 26, 2008, 10:48:23 AM
I'll see if I can use conditionals to display the preloaded image when none is found.

Right now I'm using Ben Zavala's Fullscreen (no text shifting), and while I really like the background that displays under the album art, I'd rather use a dumb little photo that actually states "No Cover" (it doesn't take much to make me laugh).  A graphic like that won't work as a background, though.

Thanks everyone for taking seriously my dumb little idea.
Title: Re: Include the option for a default custom "nocover.bmp" for missing album art.
Post by: soap on July 26, 2008, 12:06:39 PM
You can always place your own generic cover.bmp image in the root of your music collection to accomplish this.
Title: Re: Include the option for a default custom "nocover.bmp" for missing album art.
Post by: yapper on July 26, 2008, 04:15:27 PM
Soap's solution is documented here: http://www.rockbox.org/twiki/bin/view/Main/AlbumArt#Where_To_Put_The_Images

An advantage of this over including the 'no artwork found' image into the WPS background is that you only have to add one file, rather than modify the background of every WPS you use.

EDIT: I can't get this to work with my folder structure, which is a Music folder in the root, then Artist folders, with Album folders below that. I have to put the 'dummy' cover.bmp file in the Artist folder to get it to work (case 6 in the examples in the Wiki link I refer to above).

It appears there would need to be a case 7 : ../../cover.bmp for it to work in my case.
Title: Re: Include the option for a default custom "nocover.bmp" for missing album art.
Post by: soap on July 26, 2008, 09:53:08 PM
Yes, I guess I did assume one's file structure was only one layer deep.
(Such as mine has been ever since iPod scrollwheel acceleration came into being.)
Title: Re: Include the option for a default custom "nocover.bmp" for missing album art.
Post by: yapper on July 26, 2008, 09:57:11 PM
I had a look at the source but couldn't find where the album art paths are checked. If anyone can point me at the file I'd have a look at how hard it would be to either check another layer up, or maybe adding something like looking in .rockbox for a default cover.bmp.
Title: Re: Include the option for a default custom "nocover.bmp" for missing album art.
Post by: robin0800 on July 27, 2008, 06:07:37 AM
You can do it as a conditional %?<C| Album art True| Album art false>

Use album art true for album art Picture and album art false For no album art picture
Title: Re: Include the option for a default custom "nocover.bmp" for missing album art.
Post by: karashata on July 28, 2008, 10:18:45 AM
You can do it as a conditional %?<C| Album art True| Album art false>

That should be written as %?C<If Art|If No Art>, what you wrote would break the WPS and force to the old default.