Rockbox Technical Forums

Rockbox Development => Feature Ideas => Topic started by: MajiKool Dragonâ„¢ on July 01, 2008, 07:41:45 PM

Title: Rotate feature should be added to JPEG viewer.
Post by: MajiKool Dragonâ„¢ on July 01, 2008, 07:41:45 PM
i'd like to see the ability to rotate images very much.

so i can rotate images to more efficiently fit the screen.
Title: Re: Rotate feature should be added to JPEG viewer.
Post by: MajiKool Dragonâ„¢ on October 08, 2008, 09:55:44 PM
i would like to bring this topic back to life because, i've talked to several of my rockbox user friends, and they all agree this feature is much needed.



i might actually try to code this one my self! yay ;D  (though i'd rather someone who actually knows how to do it to do it)
just tell me what exactly i need to do... and hopefully at some point i might actually figure out how to do it.
Title: Re: Rotate feature should be added to JPEG viewer.
Post by: saratoga on October 08, 2008, 10:06:31 PM
just tell me what exactly i need to do... and hopefully at some point i might actually figure out how to do it.

Take the output of the JPEG decoder and flip the rows and columns as needed to rotate the image.  Not much else to it.
Title: Re: Rotate feature should be added to JPEG viewer.
Post by: MajiKool Dragonâ„¢ on October 08, 2008, 10:10:26 PM
ahhh.... and how do i do that ???


also i'm not quite sure what you meant but i would like to be able to rotate the image within the viewer on the go
Title: Re: Rotate feature should be added to JPEG viewer.
Post by: Chronon on October 08, 2008, 11:16:36 PM
Basically, you want to transpose (http://en.wikipedia.org/wiki/Transpose) the data.  I don't know C very well, so I don't know the most efficient way of doing this, but that's the game here.  Take the first row and turn it into the first column, etc.
Title: Re: Rotate feature should be added to JPEG viewer.
Post by: saratoga on October 08, 2008, 11:27:29 PM
ahhh.... and how do i do that ???


also i'm not quite sure what you meant but i would like to be able to rotate the image within the viewer on the go

I'm guessing this is probably not something you're going to be able to do yourself then.
Title: Re: Rotate feature should be added to JPEG viewer.
Post by: robin0800 on October 09, 2008, 11:29:13 AM
Don't expect it helps, but there is a rotate display menu item for the Sansa C250, not sure if this is hardware or software. The OF doesn't have this.
Title: Re: Rotate feature should be added to JPEG viewer.
Post by: MajiKool Dragonâ„¢ on October 09, 2008, 02:28:38 PM
Don't expect it helps, but there is a rotate display menu item for the Sansa C250, not sure if this is hardware or software. The OF doesn't have this.

no... doesn't really help...

that only flips it upside down.


ahhh.... and how do i do that ???


also i'm not quite sure what you meant but i would like to be able to rotate the image within the viewer on the go

I'm guessing this is probably not something you're going to be able to do yourself then.

ya.... i might try. but ya... ;D
Title: Rotate feature added to JPEG viewer. FS#9497
Post by: gratt on October 17, 2008, 01:33:42 AM
I added a rotate option to the jpeg viewer FS#9497
It is tested on sansa e200 and should work on colout targets.
More work is required for Zoom and moving around pictures.

Credit to Rene Peinthor and Adam Gashlin with additions by me
for the rotate function from sansa_video.patch FS# 6675

GRaTT
Title: Re: Rotate feature should be added to JPEG viewer.
Post by: MajiKool Dragonâ„¢ on October 18, 2008, 01:00:53 PM
awesome...
good work

thanks!  ;D ;)


edit:
hope this gets accepted into official build