Rockbox Technical Forums

Rockbox Development => Starting Development and Compiling => Topic started by: mschneider on February 23, 2008, 08:31:05 PM

Title: what are we looking for in pictureflow
Post by: mschneider on February 23, 2008, 08:31:05 PM
Just so that I can get an Idead, what kind of direction are we hoping to send pictureflow in? I know database integration is one, but to what extent? because pictureflow only sorts one tag are we only looking for that or for multiple tags? I would just like to know because I want to work on this the right way.
Title: Re: what are we looking for in pictureflow
Post by: NicolasP on February 24, 2008, 01:13:42 PM
Honestly, I think you can define the direction it takes. The person who started it (j0tt) isn't around much currently, and I (who helped him and committed his work) mostly spend the time I have for Rockbox on the playback code. Apart from the two of us, there hasn't been much developer interest in this plugin, so you're welcome to submit any patch you want!
Title: Re: what are we looking for in pictureflow
Post by: mschneider on February 24, 2008, 06:42:43 PM
Well I did, that is the reason I posted this, the patch was rejected.
Title: Re: what are we looking for in pictureflow
Post by: saratoga on February 24, 2008, 07:10:04 PM

Well I did, that is the reason I posted this, the patch was rejected.


Looking at the rejection comment, it seems it was rejected because there isn't much sense in adding it to a context menu.   You're free to take the plugin in whatever direction you want, but arbitrary changes to the rest of rockbox are likely to be rejected until you can justify them.
Title: Re: what are we looking for in pictureflow
Post by: Llorean on February 24, 2008, 07:11:53 PM
The context menu is really for options relating to the specifically highlighted file. If Pictureflow is to be integrated, it should probably be  by some generic way for the Database to use Plugins as filters. Pass a list to the plugin, and accept a list back from them, or something. An abstraction that's expandable, if at all possible.

But touching the "core" of Rockbox is dangerous, relative to just expanding the functionality within the plugin.