Rockbox Technical Forums

Support and General Use => Theming and Appearance Customization => Topic started by: PHK Brasil on May 09, 2007, 04:41:53 PM

Title: New changes affected WPS themes?
Post by: PHK Brasil on May 09, 2007, 04:41:53 PM
♪
I noticed that now, the way the volume dB scale acts with the WPS theme is different than before.

Now, the maximum volume bitmap is showed from 0dB ~ +6dB. While before, it was showed just at +6dB.

I'm not shure, but I think that the relation with the battery bmps also changed. Anyone could say? I hope not, but if is true, it needs some fix in the battery bmps code on some WPS themes.:(
♪
Title: Re: New changes affected WPS themes?
Post by: NicolasP on May 10, 2007, 02:49:41 PM
This isn't a bug, it's a choice. It needs to be discussed because not everyone feels the need for a specific "full" enum case.
Title: Re: New changes affected WPS themes?
Post by: Llorean on May 10, 2007, 03:50:57 PM
In my personal opinion, there needs to be one image for 0dB, and one for anything over 0dB. Then divide up the area below 0dB as you see fit, down to "Mute" which again needs its own image.

On graphical volume displays a user should be able to see when they're going to be clipping.
Title: Re: New changes affected WPS themes?
Post by: PHK Brasil on May 10, 2007, 04:04:54 PM
♪
I really think the old way was better to work. They had more flexibility. I made themes that display a specific bmp just at +6dB, and now they don't have the same effect anymore.

Also, the old way allows to work exactly like the new way, too. Simply repeating the same bitmap on the WPS code, will display the same last image from xdB ~ +6dB. So, why change?  

I vote for the old way.

PS: The battery relation also changed too. :(  
♪

[EDIT]

In my personal opinion, there needs to be one image for 0dB, and one for anything over 0dB. Then divide up the area below 0dB as you see fit, down to "Mute" which again needs its own image.

On graphical volume displays a user should be able to see when they're going to be clipping.


To get a point of bitmap change exactly at 0dB, needs to have an specific WPS Volume section. It will depends of the amount of the Volume bitmaps the theme was created.

On the new builds the 0dB got this point, and must have 10 bmps for the Volume. If you have 9 bmps for the Volume, the point becames to -1dB.
Title: Re: New changes affected WPS themes?
Post by: Llorean on May 10, 2007, 07:35:34 PM
Yes, and in my opinion the current way needs to be improved to the way I suggest.

0dB is a very important volume level, as anything over it can clip. So there needs to be an image specifically for 0dB, and probably at least one image for above it, as a warning that you may experience clipping.

0dB is also line level, important for those players that do not have a separate line output, or that do but do not lock to line level (h100)
Title: Re: New changes affected WPS themes?
Post by: PHK Brasil on May 11, 2007, 12:29:56 AM
♪
OK, I had an idea. And I think the current way must be keeped the way it is. Definitively, please. ;)

Is more easy to improve accuracy to the themes in their codes itself. So, I will can display a specific bitmap wherever I want.

I will just recode my WPS the following way:


VOLUME code will be divided in 65 degrees (-58dB ~ +6dB = 65 "degrees")

BATTERY code will be divided in 101 degrees (0% ~ 100% = 101 "degrees")


Of course, I'm not saying that I'll make one bitmap for each degree. I'll just keep the same bitmaps, repeating them on the codes. And wherever I want to change the bitmap, I can.

For example, in Volume code:

%?pv<%xda|%xda|%xda|%xda|%xda|%xda|%xdb|%xdb|%xdb|%xdb|%xdb|%xdb|%xdc|%xdc| %xdc|%xdc|%xdc|%xdc|%xdd|%xdd|%xdd|%xdd|%xdd|%xdd|%xde|%xde|%xde|%xde|%xde| %xde|%xdf|%xdf|%xdf|%xdf|%xdf|%xdf|%xdf|%xdg|%xdg|%xdg|%xdg|%xdg|%xdg|%xdg| %xdh|%xdh|%xdh|%xdh|%xdh|%xdh|%xdh|%xdi|%xdi|%xdi|%xdi|%xdi|%xdi|%xdi|%xdZ| %xdj|%xdj|%xdj|%xdj|%xdj|%xdY>

(edit by NicolasP: I allowed myself to add a few spaces to make that line wrap)

%xdZ is exactly the 0dB position.

%xdY is exactly the +6dB position.


Just one important question for the developers:

The way I wrote the code will increase battery comsumption? I know that the bitmap will not change at every dB, but the code will send a command at each dB step, repeating the same bitmap.
 
So ? ? ? ?


 
Title: Re: New changes affected WPS themes?
Post by: NicolasP on May 13, 2007, 10:27:57 AM
I think Llorean's idea could be quite simple to implement. I'll try to have a go at it.

EDIT: OK it's done: FS#7164 (http://www.rockbox.org/tracker/task/7164).



Just one important question for the developers:

The way I wrote the code will increase battery comsumption? I know that the bitmap will not change at every dB, but the code will send a command at each dB step, repeating the same bitmap.
 
So ? ? ? ?

Writing it that way shouldn't cause any more noticeable battery consumption, but it could cause problems with the maximum number of tokens in a complex WPS.
Title: Re: New changes affected WPS themes?
Post by: NicolasP on May 14, 2007, 11:36:08 AM
I committed the patch implementing Llorean's request. Please tell me how you like it ! :)