Rockbox Technical Forums

Support and General Use => Theming and Appearance Customization => Topic started by: ASNO on July 02, 2008, 11:05:49 PM

Title: 320x240 (ipod video) fixed some broken themes
Post by: ASNO on July 02, 2008, 11:05:49 PM
let me know if youre interested

(http://www.rockbox.org/twiki/pub/Main/WpsIpod5g/Crossbones.png)

(http://www.rockbox.org/twiki/pub/Main/WpsIpod5g/dosblue_play.png)

(http://www.rockbox.org/twiki/pub/Main/WpsIpod5g/ipod5g.png)

more tomorrow...
Title: Re: 320x240 (ipod video) fixed some broken themes
Post by: JdGordon on July 03, 2008, 03:45:34 AM
the wiki is free for all to edit... why not just upload your fixed versions?
Title: Re: 320x240 (ipod video) fixed some broken themes
Post by: yceberko on July 03, 2008, 01:03:38 PM
thanks your greatly appreciated!!!
I use mainly phk1 and oher phk's it would be ex helpful if you could fix those
Title: Re: 320x240 (ipod video) fixed some broken themes
Post by: Slim on July 03, 2008, 02:32:45 PM
Can someone tell me what the pb values in the OLD format represent? For example here:

 %pb|11|2|318|

.. what do the numbers mean? I'd rather work out the new values from the old than by trial and error :D

Cheers
Slim
Title: Re: 320x240 (ipod video) fixed some broken themes
Post by: ASNO on July 03, 2008, 05:05:45 PM
Quote
Can someone tell me what the pb values in the OLD format represent?

the old seems to be "|height|x|width|y|" but i'm not 100% sure. i tweak it form there if its not right.

Quote
the wiki is free for all to edit... why not just upload your fixed versions?

if someone wants to give me write privileges...
Title: Re: 320x240 (ipod video) fixed some broken themes
Post by: jswetzen on July 03, 2008, 05:13:12 PM
The old format was:
%pb|height|left-position|right-position|y-position(optional)|

and the new one is:
%pb|filename.bmp|x|y|width|height|

which means that:
x = left-position
y = y-position
width = right-position - left-position
height = height

Unfortunately in your case there is no y-position so you will have to experiment on that one.
Title: Re: 320x240 (ipod video) fixed some broken themes
Post by: pixelma on July 03, 2008, 06:05:22 PM
Unfortunately in your case there is no y-position so you will have to experiment on that one.

The y-position was given by the line the %pb tag was on, if you didn't specify a number. This is still the case in the new format but you can not just skip it as you did before but have to use a - instead (at least I know that it works with a plain progressbar that doesn't use a bitmap but should work there too). Also look out for the %P tag which listed the filename of the progressbar bitmap before (between the | ) and which is now merged into the one %pb tag.
Title: Re: 320x240 (ipod video) fixed some broken themes
Post by: Slim on July 03, 2008, 06:20:26 PM
Thanks for the help, everyone - tres useful :D
Title: Re: 320x240 (ipod video) fixed some broken themes
Post by: Chronon on July 03, 2008, 07:10:18 PM
if someone wants to give me write privileges...

If you haven't gotten it yet you can either post your WikiName here or come into the IRC channel and ask there.
Title: Re: 320x240 (ipod video) fixed some broken themes
Post by: ASNO on July 03, 2008, 08:30:11 PM
Quote
If you haven't gotten it yet you can either post your WikiName here or come into the IRC channel and ask there.

KarlMarx

here are some more i fixed:

(http://www.rockbox.org/twiki/pub/Main/WpsIpod5g/insane.png)

(http://www.rockbox.org/twiki/pub/Main/WpsIpod5g/car_v1.png)

(http://i13.photobucket.com/albums/a297/Weenesman1352/CleanDarkcopy.png)

Quote
I use mainly phk1 and oher phk's it would be ex helpful if you could fix those

i tried.... they were too complex
Title: Re: 320x240 (ipod video) fixed some broken themes
Post by: soap on July 04, 2008, 10:55:45 AM
I deleted the post which offered a modified version of a PHK wps, as it (said WPS) is copyright All Rights Reserved (this means no shared modifications).

This may not be the ideal intended by PHK, but it is the law.  He has no license expressly mentioned in his themes. 

This is a perfect example of why all WPS authors need to be explicit about the license they release their works under.

Feel free to discuss how to fix any specific WPS, but no more sharing of WPS files you do not have rights to.
Title: Re: 320x240 (ipod video) fixed some broken themes
Post by: BdN3504 on July 05, 2008, 04:10:07 AM
how to fix any specific WPS

phk1 (http://www.rockbox.org/twiki/pub/Main/WpsIpod5g/phk1.zip):
you need to delete the %P line in and replace it with this: %pb|pb.bmp|2|113|316|13|. but you will need to replace the line which contained the old %pb with a free line, too or the wps looks weird.
Just replace the old %pb line with this one %pb|pb.bmp|2|113|316|13| and delete the %P line.
Also, with phk's themes it's best to put the %X and %pb on the very end of the code, because he doesn't use Viewports. phk uses a now outdated font, so you may want to change that in the .cfg file to "nimbus-14.fnt"

phk2 (http://www.rockbox.org/twiki/pub/Main/WpsIpod5g/phk2.zip):
same as phk1.

phkamp (http://www.rockbox.org/twiki/pub/Main/WpsIpod5g/phkAMP.zip):
pretty much the same as phk1 except for %pb|pb.bmp|13|172|294|10|

i will now only post the needed %pb tags because the same procedure applies to every wps:

phkguitar (http://www.rockbox.org/twiki/pub/Main/WpsIpod5g/phkGUITAR.zip):
%pb|pb.bmp|92|59|162|6|

phkosc (http://www.rockbox.org/twiki/pub/Main/WpsIpod5g/phkOSC.zip):
%pb|pb.bmp|7|55|308|25|
Additionally, there is a typo in the %xl tags. change batplug.bmp to battplug.bmp

phkosctah (http://www.rockbox.org/twiki/pub/Main/WpsIpod5g/phkOSC.zip):
%pb|pb.bmp|7|55|308|25|
Additionally, there is a typo in the %xl tags. change batplug.bmp to battplug.bmp

phkTape_standard (http://www.rockbox.org/twiki/pub/Main/WpsIpod5g/phkTAPE_standard.zip)
phktapea_std, phktapeb_std phktapec_std:
%pb|pb.bmp|97|63|71|25|
On this one, you also might want to edit the pb.bmp yourself, because the original is too long. if you use the tag i've provided, it shall work anyway but it's nicer to have smaller files and cleaner programming, if you create files that you actually use 100% and just 75% or so. the original pb.bmp is (114x25)px you need a bmp which has the following dimensions: (71x25)px.


phktv (http://www.rockbox.org/twiki/pub/Main/WpsIpod5g/phkTV.zip):
%pb|pb.bmp|23|209|232|13|
Similar to tape: The pb.bmp provided is 320px in width, you only need 232px width.

phkVH (http://www.rockbox.org/twiki/pub/Main/WpsIpod5g/phkVH.zip):
%pb|pb.bmp|2|210|316|13|
If you can use photoshop a little, open the pb.bmp and free transform it so it's 13px high, instead of 12px.

that's all folks, you should now all be able to fix phks complicated themes yourself. good luck!
Title: Re: 320x240 (ipod video) fixed some broken themes
Post by: pixelma on July 05, 2008, 04:33:36 AM
...
you need to delete the %P line in and replace it with this: %pb|pb.bmp|2|113|316|13|. but you will need to replace the line which contained the old %pb with a free line, too or the wps looks weird.

Why not replace the old %pb line with the new %pb line? Then you only need to delete the %P tag line and you are done.
Title: Re: 320x240 (ipod video) fixed some broken themes
Post by: BdN3504 on July 05, 2008, 04:48:20 AM
errrrm, yes you could also go the less complicated way...  :D
thanks
Title: Re: 320x240 (ipod video) fixed some broken themes
Post by: soap on July 05, 2008, 08:41:24 AM
Thank you BdN3504. 
I wasn't trying to be a jerk, but Rockbox needs to honour copyright. 
Title: Re: 320x240 (ipod video) fixed some broken themes
Post by: wzzrd on July 06, 2008, 05:45:12 AM
will these theme appear on the centralized theme page? I would really appreciate that.
Title: Re: 320x240 (ipod video) fixed some broken themes
Post by: AlexP on July 07, 2008, 03:23:15 AM
will these theme appear on the centralized theme page? I would really appreciate that.

Please re-read the thread.  They legally cannot, unless the original author gives permission - i.e. releases them under a licence that allows modification.
Title: Re: 320x240 (ipod video) fixed some broken themes
Post by: paatos on February 26, 2009, 03:49:33 PM
What I need to do DOSBlue and CleanDark wps make still displaying?
Title: Re: 320x240 (ipod video) fixed some broken themes
Post by: Chronon on February 26, 2009, 04:04:21 PM
Are you asking for what needs to be changed in those themes to get them working?
Title: Re: 320x240 (ipod video) fixed some broken themes
Post by: Thecoolgman on March 15, 2009, 09:46:01 PM
Hey could someone fix this theme? http://pijulius.blogspot.com/2006/05/jblackglass-rockbox-themes-ipod-video.html I'm too busy trying to learn to compile to learn to fix themes.
Title: Re: 320x240 (ipod video) fixed some broken themes
Post by: soap on March 15, 2009, 10:14:06 PM
Those themes use graphics lifted straight out of Windows Media Player, and therefore are subject to copyright restrictions.
Title: Re: 320x240 (ipod video) fixed some broken themes
Post by: Thecoolgman on March 15, 2009, 11:14:01 PM
Ahh Okay. Guess I'll have to learn to do it my self  :(