Rockbox Technical Forums

Third Party => Unsupported Builds => Topic started by: whiskers75 on December 31, 2012, 10:19:27 AM

Title: Sansa Clip+: whiskers75/rockbox
Post by: whiskers75 on December 31, 2012, 10:19:27 AM
whiskers75/rockbox       (https://api.travis-ci.org/whiskers75/rockbox.png?branch=master)
Fork of Rockbox main repo, with a few additions for the clip+ and feature requests from around the forum.
Link: https://github.com/whiskers75/rockbox (https://github.com/whiskers75/rockbox)   
Build Status: https://travis-ci.org/whiskers75/rockbox (https://travis-ci.org/whiskers75/rockbox)

I take NO liability for anything that happens using these builds.

Releases


Current major changes:
[/font]

Day/Night cycle status:    (https://api.travis-ci.org/whiskers75/rockbox.png?branch=day/night)
Work in progress! Check back later. :)
(from thread http://forums.rockbox.org/index.php/topic,42314.0.html)
Title: Re: Sansa Clip+: whiskers75/rockbox
Post by: bluebrother on January 01, 2013, 10:39:21 AM
Quote from: whiskers75 on December 31, 2012, 10:19:27 AM
(Apologies for the litter of Travis commits, Travis is being very uncooperative) >:(

I don't know about this Travis thing, but having more descriptive commit messages than simply "Travis" would be really helpful for people to understand what you did. You could also squash those commits before pushing to github ...
Title: Re: Sansa Clip+: whiskers75/rockbox
Post by: whiskers75 on January 01, 2013, 12:27:32 PM
Github needs a way to squash a ton of commits into one.
Title: Re: Sansa Clip+: whiskers75/rockbox
Post by: [Saint] on January 01, 2013, 07:00:29 PM
Quote from: whiskers75 on January 01, 2013, 12:27:32 PM
Github needs a way to squash a ton of commits into one.

No, it doesn't.

That isn't GitHub's job. GitHub hosts what you put there, nothing more. If you want to squash several commits, do it before you push.


[Saint]
Title: Re: Sansa Clip+: whiskers75/rockbox
Post by: [Saint] on January 01, 2013, 07:13:21 PM
Another reply for a seperate issue...

I notice you doing some "weird sh*t (TM)" in your repo. Which is fine, it's your repo...it doesn't need to make any sense I guess.

One example, is your commit: "Boomshine total score doesnt work on a clip+"

The "fix" for this, is apparently, to disable total scores for *every* target...which seems a little odd to me since checking if the player is a "Clip" type is trivial (If it fails on Clip+, it'll fail on the others too {resolution, I'm guessing}). I'm also not entirely sure that disabling it altogether is the best option, it's your score...without this, playing the game doesn't seem particularly fun. The simpler option would be to simply alternate the level/total points on players where we know we can't display all this info at once.

There's more, but, it's your repo. I'm not going to say you should do X, Y or Z without knowing whether or not your care about breaking other targets for the sake of one or not.


[Saint]
Title: Re: Sansa Clip+: whiskers75/rockbox
Post by: whiskers75 on January 02, 2013, 04:00:23 AM
Quote from: [Saint] on January 01, 2013, 07:13:21 PM
Another reply for a seperate issue...

I notice you doing some "weird sh*t (TM)" in your repo. Which is fine, it's your repo...it doesn't need to make any sense I guess.

One example, is your commit: "Boomshine total score doesnt work on a clip+"

The "fix" for this, is apparently, to disable total scores for *every* target...which seems a little odd to me since checking if the player is a "Clip" type is trivial (If it fails on Clip+, it'll fail on the others too {resolution, I'm guessing}). I'm also not entirely sure that disabling it altogether is the best option, it's your score...without this, playing the game doesn't seem particularly fun. The simpler option would be to simply alternate the level/total points on players where we know we can't display all this info at once.

There's more, but, it's your repo. I'm not going to say you should do X, Y or Z without knowing whether or not your care about breaking other targets for the sake of one or not.


[Saint]

I'll fix that. (This is a clip+ build, but it's a good idea to keep it compatible with the others)