Rockbox Technical Forums
Support and General Use => Audio Playback, Database and Playlists => Topic started by: forever3 on May 04, 2008, 03:24:31 PM
-
I hope that's the right place for message :)
I've noticed that, "Bass" and "Treble" settings under "Sound Settings" menu, don't work for last 5-6 releases... Equalizer works fine but whatever you adjust "Bass" and "Treble" doesn't differ.. I've replaced an older builds "rockbox.mi4" file with the newes one and those settings worked.. I think there is something forgotten in newer releases.;D
(sorry for my poor English :-\)
Thanks
-
Could you try some older builds to determine exactly in which build it stops working? That would help us determine what caused it.
-
I've found the build which problem starts..
http://www.rockbox.org/dl.cgi?bin=mrobe100
on that page,
2008-04-28 dated build (Rev.17273) Everything is ok.
2008-04-29 dated build (Rev.17288) doesn't work...
I checked changelogs now and at (Rev.17288)s changelog;
r17274:
* introduce AUDIOHW_CAPS to define which audio codec can do what kind of operations in hw, e.g. setting bass
* added documentation why and when we need the software based prescaler
* implement audiohw_set_bass and audiohw_set_treble for mas35xx
* clean up sound_set_bass and sound_set_treble
* simplify some #ifdef logic
* fix special handling of WM8751 - looking for tester :)
writes.. Is this an improvement?
-
But he also mentions a reversion of that patch in r17286. I assume you still experience the problem in r17286 and later?
-
Yes, from r17286 to latest one that released today (r17381), it doesn't work..
r17286: undo some changes of my last patch... should fix wm8751 based targets
-
I have a similar problem:
http://forums.rockbox.org/index.php?topic=16719.0
Bass & Treble work, but they seem to get reset to 0 after a power cycle.
-
Could you add the following patch to the current release and the last working one? And tell me the resulting values?
Index: firmware/drivers/audio/wm8751.c
===================================================================
--- firmware/drivers/audio/wm8751.c (Revision 17425)
+++ firmware/drivers/audio/wm8751.c (Arbeitskopie)
@@ -30,6 +30,9 @@
#include "audiohw.h"
#include "system.h"
+#define LOGF_ENABLE
+#include "logf.h"
+
const struct sound_settings_info audiohw_settings[] = {
[SOUND_VOLUME] = {"dB", 0, 1, -74, 6, -25},
#ifdef USE_ADAPTIVE_BASS
@@ -186,6 +189,7 @@
void audiohw_set_bass(int value)
{
+ logf("b: %d", value);
wmcodec_write(BASSCTRL, BASSCTRL_BITS |
#ifdef USE_ADAPTIVE_BASS
@@ -197,6 +201,7 @@
void audiohw_set_treble(int value)
{
+ logf("t: %d", value);
wmcodec_write(TREBCTRL, TREBCTRL_BITS |
TREBCTRL_TREB(tone_tenthdb2hw(value)));
}
-
It's fixed now, thanks ChristianGmeiner...