Rockbox Technical Forums

Support and General Use => Hardware => Topic started by: MichaelScofield on July 13, 2010, 08:06:22 PM

Title: Brightness of Clip + is very low
Post by: MichaelScofield on July 13, 2010, 08:06:22 PM
Hello,

how to increase the brightness level of my Clip + ?
My old clip is so much brighter w/o changing anything.
Using the newest Rockbox and firmware version.

Thx  for help in advance.

greez
Title: Re: Brightness of Clip + is very low
Post by: saanaito on July 13, 2010, 08:51:25 PM
http://download.rockbox.org/daily/manual/rockbox-sansaclipplus/rockbox-buildch8.html#x11-1370008.4

It would appear that you cannot adjust the brightness on a Clip+ in Rockbox -- at least, not yet.

However, if/when the option becomes available, you can go to Settings, then General Settings, then Display, and finally Brightness.
Title: Re: Brightness of Clip + is very low
Post by: funman on July 14, 2010, 02:41:53 AM
You can change the contrast in this menu though, perhaps that helps
Title: Re: Brightness of Clip + is very low
Post by: torne on July 14, 2010, 04:39:09 AM
OLEDs (like the Clip's display) don't have a brightness, they only have a contrast setting. The contrast does more or less what you would expect brightness to do on an LCD :)
Title: Re: Brightness of Clip + is very low
Post by: bertrik on July 14, 2010, 06:09:01 AM
We could of course change the setting into a brightness setting if that's more clear/expected to users.

In that case we would also get a fade in/out effect when turning the display on or off, however the "brightness"/contrast doesn't go all the way down on the clip (the lowest level is still quite bright).
Title: Re: Brightness of Clip + is very low
Post by: torne on July 14, 2010, 07:56:11 AM
It might make sense to call it brightness, yes. The datasheets I've seen for OLEDs refer to it as contrast, but it really just is how strongly the individual OLED elements are driven...
Title: Re: Brightness of Clip + is very low
Post by: funman on July 14, 2010, 08:51:54 AM
The register we change is documented as "contrast" in the SSD1303 datasheet

(why was the topic locked? I unlocked it)
Title: Re: Brightness of Clip + is very low
Post by: MichaelScofield on July 14, 2010, 09:27:02 AM
Thx for unlocking.
I already saw the "contrast" entry in the settings, but it just does nothing.
On my Clip (non +) it's getting much brighter when upping the value.
I really love Rockbox and would be sad to use the default firmware because of this issue  :/
Title: Re: Brightness of Clip + is very low
Post by: torne on July 14, 2010, 09:46:25 AM
Is it noticeably brighter in the original firmware? That would suggest we're initialising the display differently... or do you just mean it's brighter with a different model of Clip?
Title: Re: Brightness of Clip + is very low
Post by: MichaelScofield on July 14, 2010, 10:00:13 AM
It is much brighter with the default firmware.
Here are 2 pics :

(http://www.abload.de/thumb/20100714_003202y.jpg) (http://www.abload.de/image.php?img=20100714_003202y.jpg)
(http://www.abload.de/thumb/20100714_004t1du.jpg) (http://www.abload.de/image.php?img=20100714_004t1du.jpg)

Hope you can see the difference on the photos.
Title: Re: Brightness of Clip + is very low
Post by: funman on July 14, 2010, 10:54:09 AM
I already saw the "contrast" entry in the settings, but it just does nothing.

This is the problem then, contrast works as intended on my Clip+ (change the brightness).

The Clip+ has 2 different LCD controllers, perhaps the 2nd controller works differently for the contrast.

Do you have a build environment setup to test patches?

EDIT: there is indeed a difference, in spacing of contrast steps.

Try setting MAX_CONTRAST_SETTING to 250 in firmware/export/config/sansaclipplus.h (You will end with 220 possible settings for contrast, just check that the maximum value works correctly)
Title: Re: Brightness of Clip + is very low
Post by: MichaelScofield on July 14, 2010, 11:33:43 AM
I don't really have a clue where to find the config file you mentioned.
Should I find it when plugging the Clip to my PC ?
Title: Re: Brightness of Clip + is very low
Post by: saratoga on July 14, 2010, 11:42:51 AM
I don't really have a clue where to find the config file you mentioned.
Should I find it when plugging the Clip to my PC ?

No, its in the rockbox source code.  And the answer to "Do you have a build environment setup to test patches?" would apparently be "No".
Title: Re: Brightness of Clip + is very low
Post by: MichaelScofield on July 14, 2010, 12:34:54 PM
Okay didn't really know that, sorry

//edit : better ? :p
Title: Re: Brightness of Clip + is very low
Post by: Chronon on July 14, 2010, 12:52:03 PM
Please remember to use complete words on these forums.

Thank you.  :)
Title: Re: Brightness of Clip + is very low
Post by: funman on July 14, 2010, 04:58:25 PM
If you can come on IRC, i'll try to send you a patched build
Title: Re: Brightness of Clip + is very low
Post by: MichaelScofield on July 19, 2010, 06:49:35 PM
Would be cool if you could upload or send me the file cause it seems we are not going to meet in IRC.
Big Thanks in advance.
Title: Re: Brightness of Clip + is very low
Post by: funman on July 19, 2010, 08:14:30 PM
Someone ("punt2") came on irc already and he's looking at this
Title: Re: Brightness of Clip + is very low
Post by: MichaelScofield on August 14, 2010, 07:28:52 PM
Unfortunately I still haven't got the fixed files.
Would be grateful if someone could upload it somewhere.
Title: Re: Brightness of Clip + is very low
Post by: saratoga on August 14, 2010, 07:31:30 PM
Unfortunately I still haven't got the fixed files.
Would be grateful if someone could upload it somewhere.

This didn't fix it for you?

"r27522: Sansa clip+: fix display brightness for players with newer OLED controller type (and reorganise the variant detection a bit in the process) "
Title: Re: Brightness of Clip + is very low
Post by: MichaelScofield on August 14, 2010, 07:42:39 PM
Just installed the new version.
Working fine now.
Thx ;)