Rockbox Technical Forums

Support and General Use => User Interface and Voice => Topic started by: Mikerman on May 28, 2007, 01:49:08 AM

Title: List scan accelleration new feature--superb!
Post by: Mikerman on May 28, 2007, 01:49:08 AM
As one who has hoped for the list scan accelleration feature for a long time, congratulations on and many thanks for this!

And not only was the feature added, but in Rolls Royce fashion:  with a user-configurable start time, and user-configurable speed options.

Now I can get thru my 9000+ file list in seconds rather than minutes, making the database/track option a user reality.

From first impressions, a very nice feature--many thanks!   ;D
Title: Re: List scan accelleration new feature--superb!
Post by: Buschel on May 28, 2007, 04:16:32 AM
I would also love to use this feature. But on iPOD it does not seem to work...
Title: Re: List scan accelleration new feature--superb!
Post by: DefineByte on May 28, 2007, 05:08:01 AM
I think the code for iPods was removed in March as it didn't work properly. I haven't seen anything since then.
Title: Re: List scan accelleration new feature--superb!
Post by: Vortex on May 28, 2007, 06:23:14 AM
Hi everyone,

I tried the new scroll acceleration feature on my Sansa but I downgraded again to a version before this patch because I had several problems:

1. Sometimes the scrolling is somehow "jumpy". It jumps a few entries back and forth while scrolling, even before the acceleration triggers. This also happened when I set the action delay to "Off".

2. The acceleration patch breaks the "Show ID3 Info" screen. In this screen, unlike other lists, the line selector spans across two lines. When you scroll down quickly from top to bottom, the line selector will somehow come off, and span across the wrong two lines. I guess this is somehow related to the "jumpy" scrolling problem.

3. I think the activation delay should be specified in rows (i.e. scrolling distance) rather than Milliseconds. It's very confusing/annoying when you only want to scroll a few lines down and suddenly the acceleration kicks in.

4. The acceleration should only trigger when I'm quickly scrolling through a list. Right now it also triggers when I turn the wheel slowly. This is kind of annoying when you are slowly scrolling through a long list, in search of a particular song, and suddenly the scrolling speed increases.

Overall I think that this is a nice feature addition, but it needs some refinement. :)
Title: Re: List scan accelleration new feature--superb!
Post by: JdGordon on May 28, 2007, 09:42:43 AM
I think the code for iPods was removed in March as it didn't work properly. I haven't seen anything since then.

No, back then the repeat action wasnt being sent whihc meant that extra code was needed on the ipod for this to work, since then this was fixed though so it does work on it, althogh apparently no very well on the nano.

Vortex:
1) I think you'll find that the selection stays correct, it just moves in the screen a bit unexpectadly.
2) Ok, need to fix this
3) set it to a higher wait value,...
4) no way to do this with the current button code. if you are moving fast enough that the repeat actio is triggered then there is nothing we can do... to fix this set a higher start delay.
Title: Re: List scan accelleration new feature--superb!
Post by: DefineByte on May 28, 2007, 12:39:15 PM
since then this was fixed though so it does work on it
Good to hear (not that I have any particularly long lists).
Title: Re: List scan accelleration new feature--superb!
Post by: Buschel on May 28, 2007, 02:31:48 PM
jdgordon: Am I doing something wrong with the configuration? I cannot see/feel any difference in scrolling on my 5.5G... Is there something with the other scroll-settings which may interfere with the new scroll-acceleration?
Title: Re: List scan accelleration new feature--superb!
Post by: Llorean on May 28, 2007, 03:58:40 PM
There aren't other scroll settings.

Try setting the timeout to very short,  and the jump distance to very long, move your finger quickly, and make absolutely sure it never lightens up or leaves the wheel.
Title: Re: List scan accelleration new feature--superb!
Post by: Flid on May 28, 2007, 08:24:12 PM
Three cheers for Jonathan!!! Excellent implementation of accelerated list scrolling. Exactly what I've been looking for for ages (and hinting at several times  ;) ) Much smoother than other patch attempts. Nice one.

Only one minor bug I've noticed. With smaller fonts, where the bottom/top offset is 3 lines when scrolling... at the end of a list, when the selection line is looking to move in to the last three lines of the list, the actual page view jumps to the start of the list and then back to the end of the list.

@ Llorean. There are LOTS of other "scroll" settings. Just not ones applicable to list scrolling (ie. bi-directional line scrolling, paged scrolling etc).
Title: Re: List scan accelleration new feature--superb!
Post by: Llorean on May 28, 2007, 08:40:29 PM
That's what I meant though, there aren't other scroll settings that apply to this, sorry I wasn't quite clear.
Title: Re: List scan accelleration new feature--superb!
Post by: JdGordon on May 29, 2007, 10:09:48 PM

1. Sometimes the scrolling is somehow "jumpy". It jumps a few entries back and forth while scrolling, even before the acceleration triggers. This also happened when I set the action delay to "Off".

2. The acceleration patch breaks the "Show ID3 Info" screen. In this screen, unlike other lists, the line selector spans across two lines. When you scroll down quickly from top to bottom, the line selector will somehow come off, and span across the wrong two lines. I guess this is somehow related to the "jumpy" scrolling problem.

fixed and fixed.. was there a FS report for either of these that needs to be closed?
Title: Re: List scan accelleration new feature--superb!
Post by: Lear on May 30, 2007, 03:16:44 AM
Seems the acceleration is causing a minor problem for paginated scrolling (even with list acceleration off):

When moving to the last "page" of a list, the list would only move long enough to show the last entry, and not jump a full page forward (moving up to the top works like this, as expected). Now it will only re-position the last page to display a full page when receiving a repeat-down event; a "lone" down event will not cause this.
Title: Re: List scan accelleration new feature--superb!
Post by: JdGordon on May 30, 2007, 03:35:37 AM
ah, hmm... thats a bit odd ;p
Title: Re: List scan accelleration new feature--superb!
Post by: JdGordon on May 30, 2007, 04:30:20 AM
odd... but hopfully fixed?
Title: Re: List scan accelleration new feature--superb!
Post by: psycho_maniac on June 06, 2007, 03:16:41 AM
This is a very wonderful feature if it would work. for me it seems to do the opposite of what its supposed to do and i just updated rockbox. maybe im jumping to conclusions. I have 64mb 80gig ipod
Title: Re: List scan accelleration new feature--superb!
Post by: JdGordon on June 06, 2007, 03:20:40 AM
This is a very wonderful feature if it would work. for me it seems to do the opposite of what its supposed to do and i just updated rockbox

would you like he sarcastic reply or the serious one?

bah, how doesnt it work as expected? which target?
Title: Re: List scan accelleration new feature--superb!
Post by: psycho_maniac on June 07, 2007, 01:02:24 AM
ipod 80 gig. I go to scroll down the list of songs and instaed of increasing the speed it actually slows down serious reply please
Title: Re: List scan accelleration new feature--superb!
Post by: JdGordon on June 07, 2007, 01:17:35 AM
the wors it shuold be doing is not any aceleration (so no change from before..). apparetly the fix I put in for the sansa broke ipods... i dont have an ipod readily available so unless someone fixes this, my exams will take priority
Title: Re: List scan accelleration new feature--superb!
Post by: dip on June 20, 2007, 03:12:45 AM
I compiled the current svn code but list acceleration does not work on my iPod 5.5 80GB. I tried start delay 500ms and speed 2x/1s and also 2x/10s but when I scroll through long lists (e.g. browse through my artist list using the database) there is no acceleration at all.

BTW, I understand the List Acceleration Speed option to increase the speed during scrolling by 2 each X second (e.g. 2x/1s means double speed each second and 2x/10s means double speed only each 10 seconds). So a start delay of 500ms and a speed of 2x/1s should be the highest acceleration. Is this correct?

Last question: Does the List Acceleration Start Delay value = OFF mean that list acceleration is turned off or that it starts without delay?
Title: Re: List scan accelleration new feature--superb!
Post by: GodEater on June 20, 2007, 04:10:47 AM
Last question: Does the List Acceleration Start Delay value = OFF mean that list acceleration is turned off or that it starts without delay?

It means list acceleration is off.

It's still broken for iPods till JdGordon has finished his exams.
Title: Re: List scan accelleration new feature--superb!
Post by: JdGordon on June 20, 2007, 04:33:30 AM
... last exam tomorow
Title: Re: List scan accelleration new feature--superb!
Post by: dip on June 20, 2007, 04:51:36 AM
... last exam tomorow
Good luck for your exam!
Title: Re: List scan accelleration new feature--superb!
Post by: dip on July 06, 2007, 04:17:34 PM
Is the list acceleration for the iPod still broken or is it meanwhile fixed? I don't want to bother, only to know if I missed it.
Title: Re: List scan accelleration new feature--superb!
Post by: jeff.findley on August 22, 2007, 04:32:46 PM
I'm new to Rockbox.  I downloaded the most recent build a week or so ago, and I can't get this to work on my 5th Gen iPod (30 GB).  The scrolling never speeds up, even with the delay set low.   ???
Title: Re: List scan accelleration new feature--superb!
Post by: jeff.findley on September 12, 2007, 09:46:30 AM
I finally got the thing to work.  I set the Accelleration Delay to OFF, tried scrolling through a long list of Albums (obviously with accelleration OFF), then tried these settings:

Accelleration Delay 500 ms.
Accelleration Speed 2x/1s

Anyway, now it seems to work, but it's very sensitive.  It feels like if your finger comes off the iPod scroll wheel at all it slows down again.

After playing some music, it's back to being slow again.  Maybe this is some sort of memory issue with large lists?  Is there any way to make this thing faster on an iPod Video 30 GB and stay that way?
Title: Re: List scan accelleration new feature--superb!
Post by: GodEater on September 12, 2007, 09:57:17 AM
The slow/fast thing is actually to do with whether or not the CPU is boosted while you're scrolling or not. Typically it is whilst you're listening to music, and isn't when you're not.

There's a patch in flyspray at the moment for doing this the way the sansa wheel works, which hopefully will make it into svn sometime soon. This does *proper* acceleration, and you'll love it ;)

EDIT: FS 7738 if you're keen on trying it yourself - I just have, and it's brilliant :)
Title: Re: List scan accelleration new feature--superb!
Post by: dip on October 01, 2007, 10:47:17 AM
I also tested FS#7738 on the iPod Video 5G (80GB) and this patch really works great. Much less choppy then the previous patch (FS#5594) and in my opinion in principle much better than a time based solution like the list scan acceleration which does not allow to slow down when you come near to the item you are looking for. I would love to see FS#7738 comitted.
Title: Re: List scan accelleration new feature--superb!
Post by: psycho_maniac on October 01, 2007, 04:08:37 PM
yes i am using this patch as well. used the old one 2 patch old for a week while i was away in michigan and i hated how it was very touchy. now the 2 updates make it much easier to use. wonderful little patch. works great on my 80gig and my cousins nano.
Title: Re: List scan accelleration new feature--superb!
Post by: psycho_maniac on October 06, 2007, 10:32:58 PM
now for some reason i cant get it compile to clean source. i cannot copy from vmware player so i took a screenshot. i hope somebody can help me
http://xs320.xs.to/xs320/07406/error_patch.GIF