Rockbox Technical Forums
Support and General Use => Plugins/Viewers => Topic started by: stanelie on September 06, 2006, 08:18:36 AM
-
Hello.
I have a H320, an Archos recorder and a H10.
On the H10 and H320, after I quit reading a text with the text viewer, if I go back to the same text, the viewer restarts at the beginning of the text instead of resuming where I left off.
It works on my archos player and it did work a long time ago with the H320.
Any ideas?
Stanislas
-
it doesn't work for a long time... it was removed
some time ago by some developer who considered tha bookmarking wrong ... he promised to work on it but there are still no bookmarking in text viewer .... unfortunatly i didn't manage to find that forum thread ...
-
Well,
That renders the text viewer useless for reading books, which is what I want to do with it.
Stanislas
-
Well,
That renders the text viewer useless for reading books, which is what I want to do with it.
Stanislas
personaly, i'd have toruble reading from my iriver =S
why not print it out or get the real book?
-
Hi all,
I'd just like to say to all those who, like me, miss the bookmark option in the text viewer that was taken out of the build around April: If you take just the old "viewer.rock" and "viewer.config" files and replace those, it works fine as far as I can tell. I got both from another user on this forum and I'll be happy to send them to anyone who asks. My email should be accessible among my personal information.
Greetings,
Mad_Hatter
-
it doesn't work for a long time... it was removed
some time ago by some developer who considered tha bookmarking wrong ... he promised to work on it but there are still no bookmarking in text viewer .... unfortunatly i didn't manage to find that forum thread ...
Yes, I am afraid that was jdgordon's patch: http://www.rockbox.org/viewcvs.cgi/apps/plugins/viewer.c.diff?r1=1.31&r2=1.32 - probably my least favourite commit ever. And yes, he said he would fix it, but unfortunately while he likes to start new projects he seems to be getting bored with them before they are completed. :(
Roolku
-
why not print it out or get the real book?
Cheaper and more portable?
-
I would love that very much, I also miss the bookmark function...
Had to quit reading my star wars collection at book 16...
Make me happy! ;D
greetings,
niels
-
Hi,
if you read my post "bookmark option text viewer", I'm adressing exactly that problem there. It's bothered me long enough and I finally found someone to give me the old viewer.rock file which I will be happy to send to anyone who wants it. I'll try to make it available on my homepage, but I don't know how yet, so for the moment you'll have to write to my email adress which is available among my profile data.
Greetings,
whatchamacallit
-
What player do you have?
Your file will only work on your player type.
-
It's an iriver H320. As of now, the two files are also available on my homepage, www.hoffried.de
Greetings,
whatchamacallit
-
8-)
Preeesenting:
As of now, the two files for the "old style" text viewer with the bookmark option enabled are available on my homepage hoffried.de which is also in my profile.
Greetings,
whatchamacallit
-
Do you have the source code? If so, you should post it for download along with the plug-in, because that would allow others to compile the plug-in for their platform.
-
Actually, just to get nitpicky, by the terms of the GPL he can't redistribute it without making the source code available , from him, for those who ask for it.
-
Hi Febs and Llorean,
no I don't have the source code. As I wrote in my other post (and on my homepage on the Download page), I got the two files from a RB forum user and he didn't send me the source code, only the files.
If you want the source code, maybe you should ask the guy who took it out of the build in the first place? He should have a backup, shouldn't he?
Greetings,
whatchamacallit
-
If it's just an old version the source is in cvs. Based on whats in roolku post it's here (http://www.rockbox.org/viewcvs.cgi/apps/plugins/viewer.c?rev=1.31&content-type=text/vnd.viewcvs-markup).
-
Thanks the_winch,
well, that's a lot of stuff.
I don't really understand why, given the fact that it's there and that there are obviously quite some people who'd like to see the bookmark feature back, none of the active Rockboxers has yet made an attempt to integrate it into the current build again, but to comply with the GPL as pointed out by Llorean, I'll just put this into a word document and post it on my homepage along with the two files.
Greetings,
whatchamacallit
-
I've merged the two related threads on this topic.
-
Now that we know what happened to text viewer resume, can a dev please put it back in CVS so that it is available to all?
-
I would also really like to see the resume feature fix again soon.
-
Well.
I've set up a dev environment so that I can compile the old viewer.c file from rev. 1.31 ( http://www.rockbox.org/viewcvs.cgi/*checkout*/apps/plugins/viewer.c?rev=1.31&content-type=text/plain ) for my H10 and the process went well.
But it does not work. This is not the right revision, I do not have resume either.
Could someone please post the source code to the version that works? whatchamacallit?
Stanislas
-
Also, I found that the working version from whatchamacallit has the settings menu from 1.32 and the settings file from 1.31.
I really need the source code from this.
The link from the webpage http://www.hoffried.de/iriver.htm is broken.
Stanislas
-
You should be able to retrieve the old sources from CVS. See:
http://www.rockbox.org/twiki/bin/view/Main/UsingCVS
http://www.nongnu.org/cvs/
You even do not need to install CVS and learn how to use it :):
http://www.rockbox.org/viewcvs.cgi/apps/plugins/viewer.c
The autobookmarking was added here:
http://www.rockbox.org/viewcvs.cgi/apps/plugins/viewer.c.diff?r1=1.12&r2=1.13
-
Working with cvs is not the problem.
As I wrote earlier, the custom version posted by whatchamacallit is a working blend of two or more different versions from cvs. So this version (the working one) is not in cvs.
Stanislas
-
Well.
Jonathan Gordon repaired the text viewer today.
Bookmarking works again!
Thanks, Jonathan Gordon!
Stanislas
-
fixed it again, in case you dont see the cvs commit log.. now stores the last 46 files instead of 10
-
Mr. Gordon,
I have a small request : would it be possible for you to implement the capacity for the text viewer to use a font different then the one used by the system? Perhaps a menu where one could choose the font used to read text?
Thanks!
stanelie
-
I dont tihnk so. If your asking for a different font than the user font then for sure no, but if you mean to not use the system font and instead use the user font (im not sure if it does that or not...) then its possible... but dont hold your breath :p
-
Ok.
Thanks!
Stanislas
-
The text viewer uses the user font already. ;)
-
What I would like is for the text viewer to use a user font set in a preference menu, a user font different then the one set by a WPS package.
For example, when the text viewer starts it would read the currently set font and memorise it, change the font to the one set in it's preferences, open the text to read with this font. When quitting, it would revert the system back to the font memorised in the beginning.
does that make sense?
Stanislas