Rockbox Technical Forums
Support and General Use => Theming and Appearance Customization => Topic started by: NorTheBear on September 29, 2009, 09:51:35 AM
-
Hi, I upgraded from 3.3 to 3.4 recently and found that my custom WPS does not work anymore.
Basically, my custom WPS makes use of several viewports in order to frame the AlbumArt (rounded corners) and to print the song title across the AlbumArt (thus achieving bigger AA). See screenshots attached: left side = works as intended, right side = broken.
It seems to me that at some point between the two releases, AlbumArt is refreshed frequently while before it was only rendered once per song.
I couldn't find a way to rescue my theme as no matter where I place the %C tag within the WPS it will always overlay any other parts of the layout.
Any ideas?
Thanks, Norbert.
-
yes, recent changes stopped that trick from working... hopefully it will be fixed to draw the AA much less frequently.. but dunno when
-
Just upgraded from 3.3 to 3.4 and now the MaximumArt WPS is not displaying the art.
It IS displaying the noart.bmp though
Player is a Sansa C200 v1
Arwork is in jpg format and was all working fine in 3.3
The Theme page for MaximumArt C200 does say that it works OK with 3.4 - but seeingly not on my player!
Any thoughts anyone?
EDIT - have upgraded to the latest build and MaximumArt still doesn't work
Now downgraded back to 3.3 and guess what? Normal service is resumed..album art displays just fine. Must be a 3.4+ issue
-
Yes your right but I have no idea why
Please try this Severely modified wps file, just overwrite it should be fine.
Edit
Memo to self
try amendments before posting
Edit2
this attachment now works for me
Edit3
attachment removed see below
-
Many thanks Robin - that new version of the WPS file works fine with 3.4
-
yes, recent changes stopped that trick from working... hopefully it will be fixed to draw the AA much less frequently.. but dunno when
Well, you may call it a trick but I would rather see it as creative design to elegantly overcome the display limits of the H320 (due to its landscape display orientation). And I like the rounded corners.
DAPs like E200 or Gigabeat with their vertical display orientation are definetly better off when it comes to displaying XXL AA.
Anyway, thank you for affirming my suspicion. Is there any reason to display the AA more than once in a song?
-
This change also affects deeply AAfreak theme for ipod video, that I know of
-
The Maximumart wps for sansa c200 has been updated now on the theme site.
-
This change also affects deeply AAfreak theme for ipod video, that I know of
Yes it affects AAfreak and all themes (very few though) that uses any kind of overlay design in connection with AA. I am not sure if this is something that shall go to the bugs tracker or not. Any opinions around?
-
My Zune v3 theme is broken too. Please change the album art code back.[color=][/color]
-
should be fixed now
-
should be fixed now
Not quite. While it brings back the texts on top (hooray), the other parts of the layout (8 bitmaps) remain in the background (see screenshot made some minutes ago with a current build).
I wonder if it would be possible to display the graphical elements in a chronological order (as they appear in the logical flow of the WPS)? If not then I would suggest that AA is displayed first.
So far thanks a ton for taking care of this issue.
-
NorTheBear: I quite like your theme would you mind posting it to the theme site ?
if this ever gets fixed or not I'd quite like it also.
-
thats rather urious actually... the imaghes are the last thing drawn (except AA) but they are drawn every pass (5 times per second or something fast) while the AA is only drawn once per track....
post the full theme so i can have a look and debug (images also)
-
JdGordon: here you are ...
Download link is active for 7 days:
http://www.yousendit.com/download/ZW9BeUNFdGpEa1ZFQlE9PQ
-
So, is the code put back now?[color=][/color]
-
do your themes work again? and stop trying to put colour into your messages... you're not doing it right... and if you figure it out you will very likely annoy people
-
NorTheBear: hmm... ok well I have 2 fixes, I'm not sure which is better...
1) change the %xl|.... lines for the corner images to just %x|... and it works...
2) draw the AA before the regular images (I'm not sure why the order matters but apparently it does :< )
edit: 3) make the %x tag dynamic works also...
I'm going to keep trying to find a more proper solution, but until then the first option works.
Although, because those images are always shown anyway you should be using %x instead of %xl
-
OK... I've decided that its your .wps which is broken and not the code at all....
you are drawing the corners using the xd tag which is not needed because you want them to always be displayed...
%X|bg.2009.round.simple.wd.v7.bmp|
%x|c|bcorner.10x10.lo.bmp|34|12|
%x|d|bcorner.10x10.ro.bmp|176|12|
%x|e|bcorner.10x10.ru.bmp|176|154|
%x|f|bcorner.10x10.lu.bmp|34|154|
%x|a|ppcorner.8x14.lo.bmp|50|103|
%x|b|ppcorner.8x14.ro.bmp|162|103|
%x|g|ppcorner.8x14.lu.bmp|50|138|
%x|h|ppcorner.8x14.ru.bmp|162|138|
%xl|i|arrows.25x25x3.redgold.bmp|0|0|3|
%xl|j|volume.25x25x14.ol.var4.bmp|0|0|18|
%xl|k|volume.25x25x14.or.var4.bmp|0|0|18|
%xl|P|playmode.flcr.27x27x6.bmp|0|0|6|
%Cl|35|13|150|150|
%wd
%C
#%?pn<%xda|%xdl>
is how the first part should look...
-
Thank you for your time and your looking into it.
I have tried your suggestion (by copying and replacing the code above) and indeed, it's better now but the rendering is not as smooth as it was in RB 3.3 (and before). For a fractal of a second but clearly noticeable you can see the corners of the AA before the small images cover them. The flicker is visible with every new track change thus giving the WPS an uneasy and unsteady touch. I also did a crosscheck with the same WPS in RB 3.3: No flicker there.
Too bad for me because the theme had been working so nice in the past.
-
yeah, I'm not going to worry about that very small flicker... the bigger issue is what happens after 100s (which I'm not going to spend much/any time on now either)
-
Thank you very much for your help so far.
I can certainly live with the flicker at the beginning of each track, no problem at all.
But now I see what you mean with
... the bigger issue is what happens after 100s ...
There is a rendering problem at another position (circled in screenshot) that started after 1:40 min of playing. It seems as if 2 viewports (overlaying the AA) imploded out of a sudden.
This never happened before in version 3.3.
The WPS code snippet is here.
Some explanation: The viewports overlay the AA. The viewports without any content are only there for freeing parts of the background image. This worked perfect in the past.
#Title
%V|1|117|218|2|0|-|-|
%V|1|119|218|19|1|CCCCCC|000000|
%s%ac%?it<%it|%fn>
#UPPERLINE
%V|58|103|104|4|0|CCCCCC|FF00FF|
%V|58|107|104|13|0|CCCCCC|FF00FF|
%s%ac%?ia<%ia|[unknown artist]>
#BOTTOMLINE
%V|58|138|104|3|0|CCCCCC|FF00FF|
%V|58|141|104|11|0|CCCCCC|FF00FF|
%s%ac%?pn<%pn|%?id<%id|%?d1<%d1|unknown album>>>
-
In the meantime I have adjusted (downgraded) my custom wps so that it copes with the new conditions in the current builds (see screenshot).
Don't know if it is worth to put it on the themes page as it has only poor design elements (circles and lines) and overlay design is not really supported yet.
-
I found the bug and will checking the fox in the next few hours
-
Thanks a lot for your bug fixing in r23140 (http://svn.rockbox.org/viewvc.cgi?view=rev;revision=23140). It solved the problem with the "imploding" viewports after 100 seconds (though the flicker issue remains).
I will give my theme some final polishing and would like to upload it on the themes page. Could you (or someone else reading this) give me write permission (still necessary, right)? Of course, I will read and follow the guidelines.
-
The themes are no longer uploaded to the wiki, so you don't need write permission.
To upload your theme, click the "themes" links in the left column and follow the directions at the top of that page.
-
I see ... another question: it seems as if I have to upload the same theme twice, i.e. for H300 and then for ipod color photo which have the same display size and orientation, correct?
-
If the targets have the same screen size and display (color/b&w), only one upload should be necessary. But of course you will figure it out once you upload the "first" one.
-
I'm not completely sure but I think that there is an exception to the rule above if your theme includes an RWPS (for the H300 remote). You would need to upload it twice - one with and the other without the RWPS part, a theme with RWPS won't show up on the Ipod Color/Photo (and Fuze) page, if I remember correctly.
-
Yesterday, I tried to upload my theme (Lower Thirds) but I haven't got a confirmation email yet and it does not show up on the themes page. What did I wrong?
EDIT: Sorry, found the email in the spam suspicion folder. Now the theme "Lower Thirds" is available for all 220x176 color targets. Any comments and suggestions?
-
Me again: Found a way to fix the flickering corners issue in my theme "Lower Thirds". Question: Do I upgrade my theme by just re-uploading?
-
Yes. Once it is reloaded you can respond here with a request to the theme site admins to delete the old version. Alternately, you could go to #rockbox on irc and request the deletion. Either way, one of the admins should see the request.
-
ok. Reloaded updated theme "LowerThirds" now. Due to heavy use of viewports the rounded AA corners do not flicker anymore. Not very elegant but it works.
If Mr. Someone finds the time: The previous one needs to be deleted. Thanks.