Rockbox Technical Forums

Rockbox Development => Feature Ideas => Topic started by: BdN3504 on February 07, 2009, 06:06:56 PM

Title: Proper Theme Deletion
Post by: BdN3504 on February 07, 2009, 06:06:56 PM
I would like to see a viewers kind of feature, that can only be performed on cfg files in the themes directory. a long select will bring up the context menu in that folder which lists "remove theme". this feature will read out the theme file delete all files whose location is pointed in the cfg file, excpet for the font.
I think this must be possible... the option to access files of a certain kind is given, the option to delete files is given, the option to read out a cfg file is given, the option to delete folders is given, so there shouldn't be much of a hassle.

Screenshots explain what i mean.
hm how can i do this myself?
i can't find out which parts of the code i have to modify...
where can i find the context menu?
i think i can use these lines to get to the directories i am looking for in settings.h
Code: [Select]
#define WPS_DIR     ROCKBOX_DIR "/wps"
#define THEME_DIR   ROCKBOX_DIR "/themes"

please direct me to the right place, if i'm posting / looking for help in the wrong spot.
Title: Re: Proper Theme Deletion
Post by: motionman95 on April 05, 2009, 02:26:33 PM
Hmm...good idea, LOL. I think I'll work on it.
Title: Re: Proper Theme Deletion
Post by: motionman95 on April 14, 2009, 01:08:07 PM
Hey, I've have an awesome prototype that's pretty much ready. When the prototype's complete, I'll see if I can put it in the tracker.
Title: Re: Proper Theme Deletion
Post by: BdN3504 on April 14, 2009, 07:11:55 PM
good to hear. so you've implemented it as a plug in?
Title: Re: Proper Theme Deletion
Post by: motionman95 on April 14, 2009, 07:43:49 PM
Not intentionally. I plan to convert to a viewer after I learn how a viewer plugin works.
Title: Re: Proper Theme Deletion
Post by: psycho_maniac on April 24, 2009, 01:45:24 PM
yes we have a proper way of installing them finally but we never had a proper way to uninstalling them. this is a good idea.
Title: Re: Proper Theme Deletion
Post by: BdN3504 on May 14, 2009, 12:21:32 PM
Just to have it all in one place: Thanks to motionman95 there is a patch on the tracker which implements this feature (http://www.rockbox.org/tracker/task/10187).
Title: Re: Proper Theme Deletion
Post by: psycho_maniac on June 12, 2009, 03:22:30 AM
could post the tracking number perhaps?
Title: Re: Proper Theme Deletion
Post by: Chronon on June 12, 2009, 04:00:46 AM
The post previous to yours links directly to it.
Title: Re: Proper Theme Deletion
Post by: BdN3504 on July 23, 2009, 06:13:42 PM
i would just like to anounce that  Teruaki Kawashima  has implemented exactly what i wanted when i started this thread and  he also added a fully costumizable theme deletion menu, which let's you choose which part of a theme you wish to keep/delete. i want to thank him with this post and point the core developers' attention to that task (http://www.rockbox.org/tracker/task/10187) for svn consideration. Are there any changes needed to be done to get it comitted?
Title: Re: Proper Theme Deletion
Post by: saratoga on July 23, 2009, 06:30:41 PM
i want to thank him with this post and point the core developers' attention to that task (http://www.rockbox.org/tracker/task/10187) for svn consideration. Are there any changes needed to be done to get it comitted?

You should probably ask teru (who I don't think reads the forums).  I'm sure he'll commit it when he feels its done.
Title: Re: Proper Theme Deletion
Post by: BdN3504 on July 31, 2009, 10:36:03 PM
thanks!
Title: Re: Proper Theme Deletion
Post by: mcuelenaere on August 01, 2009, 07:17:32 AM
Posted (http://forums.rockbox.org/index.php?topic=22369)
Title: Re: Proper Theme Deletion
Post by: BdN3504 on December 13, 2009, 11:06:21 AM
Thanks to everybody involved in developing this feature and especially Teruaki Kawashima for this (http://svn.rockbox.org/viewvc.cgi?view=rev;revision=23130).