Rockbox Technical Forums

Support and General Use => Recording => Topic started by: restevezes on June 18, 2009, 08:03:20 PM

Title: Broken REC button, how to start new recording?
Post by: restevezes on June 18, 2009, 08:03:20 PM
So thats my problem.... my rec button seems broken.
is there a way to remap the buttons or start the recording from anywhere else?

Thanks
Title: Re: Broken REC button, how to start new recording?
Post by: AlexP on June 19, 2009, 06:54:44 AM
You can change the button mapping, but you need to edit the code and then compile it.  First step is to get a development environment set up.  I'm guessing you are on Windows, if so look at www.rockbox.org/wiki/SimpleGuideToCompiling

Another possibility is that there are multiple buttons that will start recording.  As you don't say what player you have I can't tell you, but the manual will tell you if you can use another button straight away.
Title: Re: Broken REC button, how to start new recording?
Post by: restevezes on June 19, 2009, 01:41:11 PM
forgot to say I have an h120

just testing i found out that holding the play key it looks it sstarts recording.... not sure if this is "standard" recordign and it is same as pressing the rec button

could anyone confirm?

thanks
Title: Re: Broken REC button, how to start new recording?
Post by: AlexP on June 19, 2009, 01:43:27 PM
Have a check of the manual, it should tell you what each button does in the recording screen.
Title: Re: Broken REC button, how to start new recording?
Post by: TaperChuck on September 28, 2009, 06:41:44 PM
Get a remote cable.
Title: Re: Broken REC button, how to start new recording?
Post by: petur on September 30, 2009, 12:10:04 PM
I'm working on a simple fix, it is in Flyspray (FS#10621).

Basicaly, it will swap REC and PLAY functions, meaning REC will start/pause recording, while PLAY splits into a new file.

targets changed to this scheme are h1x0, h3x0, x5 and m3

If nobody has a problem with this I can commit this soon.
Title: Re: Broken REC button, how to start new recording?
Post by: Llorean on September 30, 2009, 04:43:23 PM
What's the point of committing this to fix one person's button problem? Is something else gained from this other than "confusing all the users who've gotten used to the current controls"?
Title: Re: Broken REC button, how to start new recording?
Post by: perfectdrug on September 30, 2009, 05:25:05 PM
I'm not much a recording user but this one took me a while to figure out that Rec doesn't start recording but play does, so I think this change would be logical.
Title: Re: Broken REC button, how to start new recording?
Post by: Llorean on September 30, 2009, 07:21:13 PM
It took you a while? Why didn't you read the manual?

Meanwhile, people used to using it may be in trouble since there's no reason for them to expect it to change on them... They could attempt to record something important and be stumped (whereas anyone recording for the first time who hasn't taken the time to actually look at *how* to do it in advance is simply not prepared).
Title: Re: Broken REC button, how to start new recording?
Post by: perfectdrug on September 30, 2009, 09:32:09 PM
Of course you are right, I just said it isn't intuitive. But as I said I'm not using the recording feature very much, and you may also be right that changing this might not be the best idea for something that is that way for several years now (as I presume it is).
Maybe a poll would be nice, or just leave it as is.
Title: Re: Broken REC button, how to start new recording?
Post by: yapper on September 30, 2009, 09:45:56 PM
What's the point of committing this to fix one person's button problem? Is something else gained from this other than "confusing all the users who've gotten used to the current controls"?
If I'm understanding this correctly, the OP has a REC button that doesn't work, so the proposed  change wouldn't fix his issue at all as he would no longer be able to start/pause recordings.
Title: Re: Broken REC button, how to start new recording?
Post by: Llorean on October 01, 2009, 01:34:34 AM
What's the point of committing this to fix one person's button problem? Is something else gained from this other than "confusing all the users who've gotten used to the current controls"?
If I'm understanding this correctly, the OP has a REC button that doesn't work, so the proposed  change wouldn't fix his issue at all as he would no longer be able to start/pause recordings.

Odd. If his "Rec" button is broken, and that prevents him starting as things are now, swapping the two buttons should allow him to start. There's either a typo in the description of what they'll do after the swap (possible) or his build already possibly has swapped buttons?
Title: Re: Broken REC button, how to start new recording?
Post by: pixelma on October 01, 2009, 01:35:16 AM
As yapper said, that patch wouldn't help him at all (even makes it worse as currently he can start/stop recordings with the Play button) - but - I guess the reason, petur posted it here, is that possibly the Rec button is not broken, and the original poster just thinks so since the button does not start a recording anymore (code-wise) but it used to for years.

The question is if the button is really broken, maybe you can check other functions you usually do with Rec on the H100 (a quick look into the manual - maybe the deleting of characters on the input line of the virtual keyboard, etc).

If you read the initial patch description, there is a keymap issue on the H100/H300 and the Iaudios introduced with r21034. Basically - for years there have been two ways (two buttons) to start a recording: the button to split the recording could also be used to start the recording, additionally to the normal start/stop. The function that split also starts recording was removed in mentioned revision to avoid keymap problems on other targets. On the targets the patch addresses, split was on the Rec button and start/stop on Play so you can't start recording with Rec anymore - which is quite unintuitive, which is why the patch proposes swapping the actions (Play would then be the split button).
Title: Re: Broken REC button, how to start new recording?
Post by: petur on October 01, 2009, 03:35:33 AM
The OP's REC button isn't broken, the functionality was reassigned without asking the recording community.

Claiming he should just read the manual isn't fair because it was a KNOWN and DOCUMENTED functionality that was altered. Yes the manual was changed too, but who goes to read a manual about something he's been using - with success -  for years? It's easy to claim he should have after you know all the facts.

I really want to revert this functionality change. From reading TapersSection, there's an active firmware distribution going on to hand everybody old builds. If all tapers are reverting to old builds, we might as well remove recroding functionality as it won't be missed much.

And I am particulary pissed off by MarcGuay for misinterpreting my comment that "we do not need two buttons to the the same" meant "remove the functionality that makes REC start a recording".

This whole mess started because of a problem with keymaps on ipods. Who the hell uses ipods to record anyway? 2 users? Should that mess with the targets that are really used for recording?

*shakes head*
Title: Re: Broken REC button, how to start new recording?
Post by: Llorean on October 01, 2009, 04:01:56 AM
Well, it needs to work on both iPods and iRiver. You'll not I misunderstood the situation (and firmly am in favour of preserving whatever behaviour people are used to).

Why can't the functionality be mapped to two keys on iRiver and only one on iPod?
Title: Re: Broken REC button, how to start new recording?
Post by: petur on October 01, 2009, 09:06:42 AM
Why can't the functionality be mapped to two keys on iRiver and only one on iPod?
You could, but I'd rather not have #defines in there just for this...
Title: Re: Broken REC button, how to start new recording?
Post by: Llorean on October 01, 2009, 04:45:31 PM
Does the recording screen work different than other places in some way? Aren't there many instances where, when we have more or less keys, keymaps are different?
Title: Re: Broken REC button, how to start new recording?
Post by: petur on October 09, 2009, 03:42:59 PM
There, I fixed it....

Is there still a problem for a target now, or can we close this topic?