Rockbox Technical Forums
Support and General Use => Theming and Appearance Customization => Topic started by: JdGordon on September 06, 2009, 01:38:40 PM
-
hey all,
apparently ever since being added the AA tags have been (for lack of a better word) broken... apparently you lot arnt adventurous enough to have found the bug until Friday, so this post is probably pointless, but I'm a good bloke so I thought I'd let you lot know...
it turns out that the %C tag doesnt remember which viewport it is in, *and* the %?C tag draws the AA (if its there of course)...
What this all means is that if you have a wps with something like the following:
%Cl|0|0|94|94|
#forward conditional viewport declarations
%?mh<%Vdh|%Vdi> # hold button viewports
%?C<%Vda|> # album art viewport
%?bp<%Vdp|%Vdq> # battery viewports
%Vl|a|41|64|94|94|-|-|-|
%C
the AA will get drawn twice... the first time (the %?C) at 0,0 (in the default viewport so to left corner) and the 2nd time is the actual %C line, but now at 41,64!!!
I'm passing the buck and saying this has nothing to do with the recent skin/wps code changes and saying this has been there from the start... so its obviously a very low priority bug, but I'll try fixing it properly today/tomoorow/some time this week...
to get around it:
1) keep doing whatever you've been doing
2) put the %Cl values in the viewport you wanted it in...
-
%?C<%C%t10%Vda%Vdc%Vdl%Vdm%Vdn%Vdv%Vdo%Vdp%Vdq%Vdr%Vds%Vdt|%t5%Vdu%Vdc%Vdl%Vdm%Vdn%Vdv%Vdo%Vdp%Vdq%Vdr%Vds%Vdt>;%?C<%t10%Vdb%Vdd%Vde%Vdf%Vdg%Vdh%Vdi%Vdj%Vdk|%t10%Vdb%Vdd%Vde%Vdf%Vdg%Vdh%Vdi%Vdj%Vdk>
#%Vda%Vdc%Vdl%Vdm%Vdn%Vdo%Vdp%Vdq%Vdr%Vds%Vdt
#%Vdb%Vdd%Vde%Vdf%Vdg%Vdh%Vdi%Vdj%Vdk
%Vl|a|0|0|80|80|1|000000|C68E17|
%Cl|1|1|78|78|
%C
The above is from my theme Maximumart C200 theme page (first screen only)
This most definitively worked up until a week ago so Yes a bug but not certain that it is not brought about by a recent change.
What it does now is flash the fist screen twice then goes to the second screen and after this works properly unless you skip a track or wake the player up when this is error is repeated.
-
I've got a fix almost ready for commit...
-
should be fixed now... let me know if you find any wierdness
-
The above is from my theme Maximumart C200 theme page (first screen only)
This most definitively worked up until a week ago so Yes a bug but not certain that it is not brought about by a recent change.
What it does now is flash the fist screen twice then goes to the second screen and after this works properly unless you skip a track or wake the player up when this is error is repeated.
That sounds quite similar to my problem (unmodified Azure ultimate theme from the theme site), where the progressbar area is filled with grey color for the first subline (the sublines and progressbar are in different viewports). It works fine when the second subline comes, but not if you enter the wps or skip a track.
-
Yes alternate lines with conditionals is partially broken it would appear to be missing the first part and going directly to the alternate part. if you wait long enough the first part will be shown and this will now work correctly
and as Kugel states but not if you enter the wps or skip a track
-
robin, try the attached patch... and come on irc :)
-
so is this fixed in the current build now?
-
Yes with the above patch but that has not been committed yet
Edit @ 22:00 This has now been committed see r22668 for details