Rockbox Technical Forums

Support and General Use => Recording => Topic started by: ericzang on May 13, 2006, 01:51:57 PM

Title: mark tracks while recording?
Post by: ericzang on May 13, 2006, 01:51:57 PM
Is there a way to "mark tracks" while recording? For example, rather than having a long continuous recording session stored as one file (rec_001), I would like to be able to press something while recording so that at the moment of the press, that point forward is now stored as another file name (rec_002).

Thanks, couldn't find this feature in my searchings.

Eric
Title: Re: mark tracks while recording?
Post by: petur on May 13, 2006, 03:59:56 PM
not yet, and it's a nice tip :)

feel free to put it in tracker as a feature request (all platforms, recording)
Title: Re: mark tracks while recording?
Post by: Mmmm on June 02, 2006, 06:47:55 PM
Here's a patch to do just that...

The new keys are:

Play/pause ---> Record/Pause
Record       ---> Record/new filename

seems to work very nicely...no gaps... Please give it a test... :)

Only implemented for irivers at the mo....not sure about the buttons to use on other units but would be very easy to put in. Any suggestions?

manualrecordingsplit.patch (http://homepage.ntlworld.com/martin.scarratt/Rockbox/manualrecordingsplit.patch)
Title: Re: mark tracks while recording?
Post by: mlind on June 02, 2006, 07:07:40 PM
I like this! I want it!
I can't compile myself, but when the freeze is over maybe...
I also think that play/pause is better (like in your patch) for starting/pausing the recording, but others might (?) consider it bad to change the use of the keys....

So who's gonna make me a (post recording) wav file splitter? :-)
I have to get really bored this summer to get into programming... :-/
Yeah I know. It's a shame.
Title: Re: mark tracks while recording?
Post by: Mmmm on June 02, 2006, 07:18:35 PM
I'll put it in my personal build soon...(look in the REP thread HERE (http://forums.rockbox.org/index.php?topic=2513.0) for info about when I do)
Title: Re: mark tracks while recording?
Post by: whatboutbob on June 02, 2006, 09:42:43 PM
I likes.  Nice work Mmmm.

I've tested about 20 short file-splits (optical sine wave).  All perfect seamless.

Just testing longer splits now...and splits during buffer writes...

edit: Longer file splits (after ~1hr) and splitting during buffer-writes seem to work perfectly.

The button-mapping makes sense to me.  Now if we could just get a long press of the rec button to go from the wps/file screen to the recording screen... *nudge* :-)

Sorry to hijack...but this is a little on subject at least.  Would anyone else apart from me find it useful to have the name of the file currently being recorded listed on the recording screen?  I think it would make the file-split process a little more...err...transparent.  Can't see how it would fit on the remote screen, but since Mmmm pointed out the interference it causes, I won't be using that to record any more. :-(  ...and apart from that it doesn't make sense to not have something just because it wouldn' fit on a much smaller secondary screen...
Title: Re: mark tracks while recording?
Post by: Mmmm on June 03, 2006, 05:53:17 AM
I likes.  Nice work Mmmm.

I've tested about 20 short file-splits (optical sine wave).  All perfect seamless.

Just testing longer splits now...and splits during buffer writes...

edit: Longer file splits (after ~1hr) and splitting during buffer-writes seem to work perfectly.
Excellent, thanks for testing whatboutbob...

Quote
The button-mapping makes sense to me.  Now if we could just get a long press of the rec button to go from the wps/file screen to the recording screen... *nudge* :-)

Sorry to hijack...but this is a little on subject at least.  Would anyone else apart from me find it useful to have the name of the file currently being recorded listed on the recording screen?  I think it would make the file-split process a little more...err...transparent.  Can't see how it would fit on the remote screen, but since Mmmm pointed out the interference it causes, I won't be using that to record any more. :-(  ...and apart from that it doesn't make sense to not have something just because it wouldn' fit on a much smaller secondary screen...
I agree...I'll look into putting that info in later... I think it would look best just above the peakmeter, do you agree?

Hmmm have to think about what to do about the remote display though, it would be a pain to have seperate positions for everything on the remote and main unit...
Title: Re: mark tracks while recording?
Post by: Febs on June 03, 2006, 06:26:31 AM
The button-mapping makes sense to me.  Now if we could just get a long press of the rec button to go from the wps/file screen to the recording screen... *nudge* :-)
x2!

And if anyone decides to do a patch for this, please consider having Play+Rec automatically go to the recording screen AND start recording.
Title: Re: mark tracks while recording?
Post by: whatboutbob on June 03, 2006, 06:58:14 AM
I agree...I'll look into putting that info in later... I think it would look best just above the peakmeter, do you agree?

Hmmm have to think about what to do about the remote display though, it would be a pain to have seperate positions for everything on the remote and main unit...

I wouldn't have a problem with having the filename at the bottom of the screen.  I don't think it has to be super-prominent....just there somewhere.  That may make your life easier with the remote then.  Alternatively, there's space next to the filesize...but that's prolly crazy talk.

And if anyone decides to do a patch for this, please consider having Play+Rec automatically go to the recording screen AND start recording.

Oooh...I like that.
Title: Re: mark tracks while recording?
Post by: Febs on June 03, 2006, 08:11:47 AM
Yeah, I've suggested it before, and I should probably file a feature request.  It should be a very intuitive button combination, considering that it's the way that tape recorders, VCRs, etc. have worked for decades.
Title: Re: mark tracks while recording?
Post by: Llorean on June 03, 2006, 08:16:42 AM
Seconded! File that feature request! Hehehe
Title: Re: mark tracks while recording?
Post by: ericzang on June 03, 2006, 08:57:05 PM
Awesome, thanks very much Mmmmm! I also think all the above suggestions are great ideas too.
Title: Re: mark tracks while recording?
Post by: Mmmm on June 04, 2006, 07:57:49 AM
Cor....well I've managed to get the filename above the peakmeter, and it checks the screensize too, if the screen is big enough it will move everything down a bit (meaning the remote doesn't display the filename). This also makes it friendly to other targets! yippee...

I also had to muck about with the filename because it is stored as the whole path (ie. /recordings/rec_0001.wav) but I only want the filename part, so just check that it is displaying correctly for all the different paths you all have out there.

This was definitely harder than it looked!  :D
Just look at the difference between the sizes of the two patches!

manualrecordingsplitfilename.patch (http://homepage.ntlworld.com/martin.scarratt/Rockbox/manualrecordingsplitfilename.patch)

As for the button assignment requests I may look into that another day as it is quite seperate from this patch....Good ideas though!  :)

EDIT: oh and Llorean there seems to be somthing up with the file uploader on the forum...I think it's full or something!
Title: Re: mark tracks while recording?
Post by: Febs on June 04, 2006, 10:19:35 AM
Seconded! File that feature request! Hehehe
Request filed!
Title: Re: mark tracks while recording?
Post by: whatboutbob on June 04, 2006, 11:13:23 AM
Thanks Febs.

I prolly won't be able to test the new patch until the weekend...so if someone else wants to step up feel free. :-)
Title: Re: mark tracks while recording?
Post by: Mmmm on June 04, 2006, 02:44:19 PM
If you want to test but cant patch/compile then the build in my sig contains this patch among other things!
Title: Re: mark tracks while recording?
Post by: Mikerman on June 05, 2006, 11:50:09 AM
What a marvelous concept, that hopefully may work itself into the official build!

:)
Title: Re: mark tracks while recording?
Post by: pianoralf on June 07, 2006, 07:01:02 AM
Hi,
thank you for all your work within this project. I've observed it for a year and now I'm using it, because of it's recording features. So the feature discussed in this thread I was long waiting for, because sometimes I record a meeting and I had the problem to find the point when the next person began to talk. Now I can simply press the record button. But this should be combined with the prerecord function, so that the split could be for example 5 seconds (prerecord time) before I pressed the record button.  I guess you already use the buffer for the time the recorder takes to close the file and to open a new one and then store the buffer to the new file.

I have question to a different topic:
In IRivers Firmware I was able immediately hear the just recorded and finalized file by pressing the play button (within record modus). In Rockbox I have to leave the recording modus and seek the file  in it's subdir and the play it (At least 3 klicks).  After that I have to return to the record modus witch takes 7 klicks) Is there a shorter way?
Title: Re: mark tracks while recording?
Post by: nslhrn on August 17, 2006, 11:16:43 PM
Is this included in the file that is in your link ?

Here's a patch to do just that...

The new keys are:

Play/pause ---> Record/Pause
Record       ---> Record/new filename

seems to work very nicely...no gaps... Please give it a test... :)

Only implemented for irivers at the mo....not sure about the buttons to use on other units but would be very easy to put in. Any suggestions?

manualrecordingsplit.patch (http://homepage.ntlworld.com/martin.scarratt/Rockbox/manualrecordingsplit.patch)
Title: Re: mark tracks while recording?
Post by: Mmmm on August 18, 2006, 04:02:36 AM
I committed this patch so it is now in all builds! :)
Title: Re: mark tracks while recording?
Post by: Davide-NYC on August 18, 2006, 11:45:04 AM
Yay! Thanks Mmmm.  ;D
Title: Re: mark tracks while recording?
Post by: Mikerman on August 18, 2006, 11:56:22 AM
This really is great--a nice way to digitize one's LP records easily.  All you need to do is rename the resulting files, even using The Godfather or another db-accessing program.  This is one of the reasons why I got the iHP-140 (now 160).

Thanks!