Rockbox Technical Forums

Rockbox Development => Feature Ideas => Topic started by: Grafthos on April 01, 2010, 07:13:05 PM

Title: Instant Delete
Post by: Grafthos on April 01, 2010, 07:13:05 PM
Hello,


I am a loyal Rockbox follower.  I have been quietly using Rockbox since it's inception and I would like to start off by saying that you people who work hard for this free service don't get enough credit.

So thank you.   My hat's off to you.  You will receive a sizeable donation within the week via your donate button.


I would like to make a very serious request.  I have pondered for a while now on whether to register to ask or not and I have finally made up my mind to give it a try.


I am here to request the instant delete feature as well because I have been spending a LOT of time previewing songs for deletion.  I typically only keep 1 or 2 songs out of every 100 or more that I delete.  What's left over in the memory card is what goes into my perma-keep folder.  I'm not one to throw entire albums into my player and I suspect neither are a lot of other users.

I am a busy man and spend considerable time on the road.  Furthermore, when I am Rockbox-ing at work, I do not wish to insult my co-workers by always going for my Player to delete and skip to the next song so I'm at a loss on this deal.

Rather than hinder work, my mp3 player stays in my desk.  I would rather quietly reach into my pocket and snag the "record" (delete & next track) button without distracting anyone.

I feel that a small plug-in that can use the record button on many players as a delete-and-advance-to-the-next-track "button" would be a life changing feature for me and would make my life a WHOLE lot easier.

I also feel that many others feel the same way because when we sample a large selection of mp3s many of us want to preview them and sort first.  This would make it possible to use while driving because you won't have to glance down at the screen while on the road.

I also feel that the record button would make an excelent choice because hardly anyone uses the record feature anyway.  And with a plug-in they can choose to use this on their own.  The record button is very small and hard to press so it would limit accidental presses, but again, the choice would be up to the user.

My co-workers will also thank you if you decide to implement this feature.

I sincerely hope so.


Thank you from myself and my team and congratulations on a job well done, guys.

Feel free to contact me on my personal email.


Thanks!
Title: Re: Instant Delete
Post by: MatthewP on April 02, 2010, 09:10:52 PM
I also think this is a really useful feature.
Title: Re: Instant Delete
Post by: Chronon on April 03, 2010, 10:14:09 PM
It seems that the plugin can set a button to set or unset a flag.  At the end of each track read the state of the flag and delete the track or don't, as the case may be.  Mapping available buttons to playback functions might be nice too.  Then you could flag and then skip track to quickly get rid of an unwanted track.
Title: Re: Instant Delete
Post by: Grafthos on April 04, 2010, 03:47:54 AM
I delete the vast majority of songs from my player.  I believe I am speaking for a small group of similar users who like to organize and sort a lot.

I am patiently awaiting a reply from the devs or moderators to see what they have to say.

While I am here I will also paroose over to the bugfix section to do my duty and report a bug.

Again, job well done guys.  I would not be opposed to placing a large magnetic logo on my new truck if it would help from a business standpoint.

again, feel free to contact me via my personal email.
Title: Re: Instant Delete
Post by: saratoga on April 04, 2010, 04:01:08 AM
I think you can already do this on most players by setting delete as your hot key function, at least on the sansa e200.
Title: Re: Instant Delete
Post by: Grafthos on April 04, 2010, 05:42:39 PM
With all due respect,

If you're speaking about the quick screen,  I believe "delete" is not allowed to be added as a quick select item.  If it is then I guess I'm doing it wrong?

Likewise, sir, even if it WAS allowed, that would still be more than one button-press and also requires rudimentary navigation; generally speaking, that is.  Therefore sometimes it would require the user to glance down at his/her player to confirm that these functions were indeed being carried out correctly.  This is EXACTLY what is a 'pain-in-the-ass,' so to speak for those of us who wish to preview large quantities of audio files for the chopping block whilst performing other activities in our daily lives - especially driving.

It would be heaven on earth if I could reach down into my pocket and without looking hit one button, and viola - deleted.

You mention the word "hot key" and I promise you I did my best to find the information you were referring to but I could not.

The words "hotkey" and "hot key" are nowhere in the RockBox manuals so I wouldn't know where else to look.  Nor do they refer to much else in these forums that I have found.

I'm not asking you to explain it to me but if I'm wrong I would appreciate if you would point me toward something I can read.

I'm willing to learn please.
Title: Re: Instant Delete
Post by: saratoga on April 04, 2010, 05:49:47 PM
The words "hotkey" and "hot key" are nowhere in the RockBox manuals so I wouldn't know where else to look.  Nor do they refer to much else in these forums that I have found.

The e200 manual has been offline for several days now, so I'm not sure what you were looking at unless you compiled your own.  When it comes back online, it should be there.

Title: Re: Instant Delete
Post by: Blue Dude on April 04, 2010, 07:39:57 PM
I wrote the hotkey patch precisely for this application, and (surprise!) chose the short-record keypress on the e200 as well.  The manual now has full details on hotkeys, but the summary is this: the File Browser and WPS screens now have a button that, when pressed, execute a function within that screen's context menu.  That function is user assigned and is enabled by going into the context menu and pressing the hotkey (short record) on a menu function.  If the function is assignable (delete is one of them), then a confirmation dialog pops up and you can approve it.  If you approve, then the hotkey is assigned to that function and the hotkey is active for that screen.  You can have different assignments for each screen.  I have delete assigned to the file browser and pitchscreen assigned to the WPS, for instance.  If you assign delete to the WPS, you can delete the file currently playing and (I think) start playing the next song in the playlist.  You will still have a confirmation dialog with delete, though, so it's really two keypresses (rec, then select) per deletion.  You can do all that without looking, which is the point.


Hm, upon some experimentation it appears that the result isn't what you'd expect.  You can delete while playing but the behavior isn't clean.  The playlist doesn't update as you'd expect.  This is a bug in the buffering code that will be addressed soon.
Title: Re: Instant Delete
Post by: Grafthos on April 05, 2010, 12:51:19 AM
Blue Dude & Saratoga,

Thank you for the replies.  I download the manual and the build - confirmed.

I'll try it out for the next few days and see how it goes.


Again, thanks for your selfless service.  You guys deserve a reward.
Title: Re: Instant Delete
Post by: Yotto on April 05, 2010, 01:12:58 AM
I think I may use - daily - this "bug" you're referring to which I consider a very nice feature. I frequently delete the track I'm currently listening to (knowing that it's buffered) and want it to play to the end.

Please don't say you'll change it! Pretty please?
Title: Re: Instant Delete
Post by: saratoga on April 05, 2010, 01:15:54 AM
I think I may use - daily - this "bug" you're referring to which I consider a very nice feature. I frequently delete the track I'm currently listening to (knowing that it's buffered) and want it to play to the end.

Please don't say you'll change it! Pretty please?

See today's IRC logs.  The proper solution seems to have a queued delete that operates whenever the track is unbuffered.  This way the behavior you suggested will work on all targets and not just those with a lot of buffer space. 
Title: Re: Instant Delete
Post by: Yotto on April 05, 2010, 11:48:47 AM
That is fantastic! I feel that one day I will not be surprised by how Rockbox just gets better and better, but it never happens.
Title: Re: Instant Delete
Post by: Grafthos on April 21, 2010, 11:11:09 AM
Your hotkey implementation works flawlessly.  Congratulations on the hard work.  I would still love a "1 touch delete and advance to next track" function but beggars can't be choosers.  I can hope :)

I have included a large sum via paypal because I think you guys deserve it and I wish to support your efforts.

Thank you for a job well done.  I hope you continue to develop the platform far into the future.
Title: Re: Instant Delete
Post by: Blue Dude on April 25, 2010, 03:53:54 PM
One thing on my todo list is to replace the delete function on the WPS screen with a Mark For Deletion function, which is really how it is intended to work.  The idea here is to allow continued playback, whether it's buffered all the way to end or not, then delete the file automatically when the track is no longer playing.  That would mean your "one touch" solution would really be "two touch" but it would work every time.  One touch on the hotkey, if set to Mark For Deletion, one touch to track skip.  Done.

Perhaps there would be a way to automatically skip to the next track upon marking for deletion, but I wouldn't hope for it.  It's certainly technically possible but changing existing behavior is a big deal, and creating a setting specifically addressing this additional functionality might be deemed too bloaty to be included.  I'll keep it in mind though, when the time comes.

Thanks for the donation by the way.  The developers themselves aren't paid, but it helps for keeping the web site, and development-related facilities on the site, up and running.