Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search




Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Welcome to the Rockbox Technical Forums!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Plugins/Viewers
| | |-+  Is bubbles.c commited or lost?
« previous next »
  • Print
Pages: [1]

Author Topic: Is bubbles.c commited or lost?  (Read 1933 times)

Offline mschneider

  • Member
  • *
  • Posts: 235
Is bubbles.c commited or lost?
« on: June 08, 2007, 07:45:50 PM »
I cant seem to find the scrollweel patch for bubbles in the tracker any longer. Has it been committed?
Logged

Offline AlexP

  • Global Moderator
  • Member
  • *
  • Posts: 3688
  • ex-BigBambi
Re: Is bubbles.c commited or lost?
« Reply #1 on: June 09, 2007, 06:55:37 AM »
Can't you try playing it to see?
Logged
H140, F60, S120, e260, c240, Clip, Fuze v2, Connect, MP170, Meizu M3, Nano 1G, Android

Offline Vortex

  • Member
  • *
  • Posts: 155
Re: Is bubbles.c commited or lost?
« Reply #2 on: June 09, 2007, 01:14:04 PM »
Seems like it's not committed yet. I don't see a reason while it takes so long for this simple (and VERY useful) patch.
Logged

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: Is bubbles.c commited or lost?
« Reply #3 on: June 09, 2007, 06:38:06 PM »
Reasons it may not be committed:

 It's for a single plugin, on a single player. This means it's of minimal interest among devs, because most of them have plenty of things on their plate already without taking the time to make sure the patch is coded according to Rockbox guidelines and doesn't break anything else.

If the author of the patch perhaps went to IRC and asked what's holding it from being committed, they might be able to get it added. Which entry in the tracker is it, exactly?
Logged

Offline mschneider

  • Member
  • *
  • Posts: 235
Re: Is bubbles.c commited or lost?
« Reply #4 on: June 10, 2007, 10:23:16 AM »
I'm not sure, that's what i was trying to find.
Logged

Offline RotAtoR

  • Developer
  • Member
  • *
  • Posts: 170
  • Somewhere but not here
Re: Is bubbles.c commited or lost?
« Reply #5 on: June 10, 2007, 01:44:32 PM »
The patch was closed and its author is working on a new one.
http://www.rockbox.org/tracker/task/6562

The patch was the wrong approach, it may have improved button mappings for the Sansa, but it broke them for all other target. The real issue is that there is no suitable button action context on the Sansa for the way that buttons are used in the game since bubbles uses the new button actions rather than a per-target mapping.
Logged

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Plugins/Viewers
| | |-+  Is bubbles.c commited or lost?
 

  • SMF 2.0.6 | SMF © 2013, Simple Machines
  • XHTML
  • RSS
  • WAP2

Page created in 0.099 seconds with 49 queries.