Port of Simon Tatham's Portable Puzzle Collection

[__builtin]

To tell the truth, I don't think going through and removing certain ones based on some criteria is worth the effort. The functional ones have been enabled for all targets they can run on for some time now. The only issue they could theoretically cause is taking up disk space, but they don't take up too much space, disk is cheap, and removing them from the build won't remove them from old .rockbox directories anyway.

That being said, if you decide to go through the SOURCES.games file [1] that controls which puzzles are built for which target and submit a patch to change the behavior, it'll certainly be considered. However, just know I don't plan on making that happen myself.

[1] https://git.rockbox.org/?p=rockbox.git;a=blob;f=apps/plugins/puzzles/SOURCES.games;h=8893c3e9a452109277b2cee43824ae1a88589bd6;hb=HEAD

[__builtin]

As for the zoom feature, it's certainly feasible and I will look into it more when I have time.

EDIT 2: looked further into the zoom idea, turns out it would require a complete rewrite of the drawing code.

Turns out I was wrong, it wasn't that hard. I just pushed the commit to add a "Zoom In" feature to the pause menu. Try the latest dev build and see if it helps.

[Rick314]

Very nice!  I loaded rev 9ba899f (2017-10-28T02:30:58) onto my SanDisk Sansa c250v1, started a complex (15x15) Bridges puzzle, and did Zoom In.  See the attached picture.  Each press of up/down/left/right moves the image about 1/2 the view dimension. It takes 3+ moves to span left-to-right, and about 5 moves to span top-to-bottom. But I can't figure out how to then play the game while zoomed. I assume that isn't working yet.

A related topic: Without using Zoom In, as in the 3.14 release, user control in Bridges seems odd. During the game, pressing the MENU key does nothing. I would expect it to transition from the game screen to the Rockbox menu for this game. (VOLUME-DOWN does this instead.) During the game, pressing SELECT, the big square button centered between up/down/left/right, does nothing. I would expect it change the state of the current island to prepare for making a bridge. (VOLUME-UP does this instead. On my SanDisk Sansa e250v1 running Rockbox 3.14, the REC key does this.) So two questions: How is Bridges meant to be controlled on the SanDisk Sansa c200 series in release 3.14? How is it meant to be controlled in Zoom In (since up/down/left/right move the view window instead of the currently active island)?  I looked in the Rockbox user guide for the SanDisk Sansa c200 series, but couldn't find any documentation describing how the controls explained in the puzzle help pages maps to the SanDisk Sansa c200 series controls.

[__builtin]

The zoom in feature is only for viewing the puzzle; it cannot be played while zoomed in. All the Zoom In feature does is render the game once at 3x resolution and let you pan around a static bitmap. You must exit the zoomed-in view in and return to the game in order to interact with the game.

As for the controls, on the c200, the VOL UP button functions as the select button, and the VOL DOWN button lets you exit to the pause menu (from the zoomed-in view, for example). I do realize that this is somewhat counter-intuitive, but it's how the keymaps are for now.

[Rick314]

You must exit the zoomed-in view in and return to the game in order to interact with the game.

OK, but if left that way then Zoom In has little use to someone actually playing the puzzle.  I said earlier "Perhaps some of these puzzles just aren't appropriate to include on limited-resolution displays."  It sounds like 80 pixels just isn't enough to render and play some of the puzzles.  Fortunately most Rockbox hardware has more resolution that that, so it isn't an issue for most users.  Maybe the documentation for small-display Rockbox devices can explain the problem and leave it to the user to ignore non-playable puzzles.  This might be better than what I suggested before, deciding case-by-case which puzzles are playable on which Rockbox devices.  Regardless, good work and thanks for the puzzles!

[__builtin]

I can probably make it playable from within the zoomed-in view. I'll see what I can do.

EDIT: Just pushed it. Basically pressing whatever's mapped to select on your target while zoomed toggles interaction mode now, which lets you play the game. I'll see about improving the c200 keymap.