Sansа Clip Zip - Improve battery life

[johnb]

Yes, very strange. Can you try  0x80 | 47 + attached patch?

Thank you very much, it works.
Now I can test lower voltages.

EDIT:
no problems with 0x80 | 20
I can now confirm, that my fuzev2 variant0 works like a charm with
- Patch Set 7 471ced2d0f1df1f6e53824197c93e52563fdac3a
- rockbox-restore_irq.patch.txt
- the same changes in firmware/export/config/sansafuzev2.h as in the other config files

EDIT2:
for anyone else to test:
http://gregory.bplaced.net/rockbox/rockbox-fuzev2-1.7z

My daughter just got an ' Undefined instruction set ...' crash with this build.

[Mihail Zenkov]

My daughter just got an ' Undefined instruction set ...' crash with this build.

It was only once or regularly? In which conditions (step to reproduce)?

rbert:
Can you replace my "irq" patch with patch from jhMikeS and test it?

[johnb]

My daughter just got an ' Undefined instruction set ...' crash with this build.

It was only once or regularly? In which conditions (step to reproduce)?

So far this was the only occasion (I run it in parallel on my fuze).
What she told me she was doing is: while listening to a song, she went into the file browser and selected a track -> then crashed

[rbert]

rbert:
Can you replace my "irq" patch with patch from jhMikeS and test it?

OK, I just compiled and tested
 - Enable frequency and voltage scaling on the AMSv2 devices. http://gerrit.rockbox.org/r/#/c/1062/  Patch Set 7
 - then I cherry-picked jhMikeS patch http://gerrit.rockbox.org/1145/
 - and made my changes to firmware/export/config/sansafuzev2.h

Once I got an "Undefined instruction at 300C7BD8",
but otherwise the fuzev2 hangs completely
or only the scroll wheel works, but skips menu items and doesn't react to button presses and usb

[jhMikeS]

Okay, it doesn't appear to be a race condition. There's should no race condition in the patched driver. I wonder if certain things happening, like interrupt processing, during a voltage change can cause glitches in operation. I really should patch my Fuze V2 with this scaling patch and dive deeper.

Who has which variant? Mine is variant 0.

[johnb]

I have two of variant 0.

[rbert]

Mine is variant 0, too.

[Mihail Zenkov]

Probably we should check ascodec_wait - we have one variant when irq enabled and other when irq disabled. Can we use semaphore_wait when irq disabled?

[johnb]

Yes, very strange. Can you try  0x80 | 47 + attached patch?

Thank you very much, it works.
Now I can test lower voltages.

EDIT:
no problems with 0x80 | 20
I can now confirm, that my fuzev2 variant0 works like a charm with
- Patch Set 7 471ced2d0f1df1f6e53824197c93e52563fdac3a
- rockbox-restore_irq.patch.txt
- the same changes in firmware/export/config/sansafuzev2.h as in the other config files

EDIT2:
for anyone else to test:
http://gregory.bplaced.net/rockbox/rockbox-fuzev2-1.7z

My daughter just got an ' Undefined instruction set ...' crash with this build.

I have NOT found any issue with this build on MY fuze (and have not heard any further report from my daughter). So I would say it's pretty good.

[saratoga]

I have NOT found any issue with this build on MY fuze (and have not heard any further report from my daughter). So I would say it's pretty good.

Could you charge the battery and then do a battery bench?

[johnb]

I will.

[saratoga]

I will.

Maybe I misunderstood, but which build is this? 

[johnb]

I am using the one posted by rbert in
http://forums.rockbox.org/index.php/topic,48549.msg233959.html#msg233959
http://gregory.bplaced.net/rockbox/rockbox-fuzev2-1.7z

471ced2M-150209

[saratoga]

I am using the one posted by rbert in
http://forums.rockbox.org/index.php/topic,48549.msg233959.html#msg233959
http://gregory.bplaced.net/rockbox/rockbox-fuzev2-1.7z

471ced2M-150209

Sorry, I misunderstood and thought you meant that the newer patch was working. 

[saratoga]

Okay, it doesn't appear to be a race condition. There's should no race condition in the patched driver. I wonder if certain things happening, like interrupt processing, during a voltage change can cause glitches in operation. I really should patch my Fuze V2 with this scaling patch and dive deeper.

Are you sure theres no possible race condition in there?  I don't see how interrupt processing would be more of a problem then audio decoding, and given that it seems to crash on probably the first or second voltage change, its apparently extremely likely to occur in an ISR but rarely or never happening otherwise. 

Plus the fact that it happens on the Fuze v2 but not Zip/Clip+ which have the same SOC makes me wonder if some other thread or peripheral specific to the fuze (scrollwheel, buttons, DBOP, etc) that causes this.