Downloads
release
dev builds
extras
themes
Documentation
manual
wiki
device status
Support
forums
mailing lists
IRC
Development
bugs
patches
dev guide
Search
Donate
1 Hour
1 Day
1 Week
1 Month
Forever
Login with username, password and session length
News:
Welcome to the Rockbox Technical Forums!
Rockbox Technical Forums
Support and General Use
Theming and Appearance Customization
Variant of existing theme
« previous
next »
Print
Pages: [
1
]
Author
Topic: Variant of existing theme (Read 2051 times)
GeorgeT93
Member
Posts: 5
Variant of existing theme
«
on:
October 19, 2012, 08:00:06 PM »
Hi all,
I've got a quick question. I made a color variant of an existing theme today (basically a new background and font colors). It's otherwise the same as 2 existing themes that are already available in the themes area. Specifically it's a blue variant of lebellium Samsung-like_ABE (Advanced Battery Edition) while maintaining the 12 hour clock option from the lebellium Samsung-like theme (both by Ludovic Jakimon), for the Sansa ClipZip.
I made the changes only for my own personal use, to make it a bit more colorful, however I would like to know if it's ok for me to upload it to the themes area or not. I would ask the original author, but there's no contact information in the original files, so I want to be sure I'm not breaking any rules by uploading a properly-credited color variant of an existing theme, since I didn't write the code for the theme myself.
I *think* it should be ok, because I believe all the themes are covered under the CC BY-SA 3.0 licensing agreement, however no license is actually specified in any of the files, so I just want to be sure before posting it, that I'm not breaking any rules or anything.
Thanks,
George
Logged
[Saint]
Rockbox Expert
Member
Posts: 1662
Hayden Pearce
Re: Variant of existing theme
«
Reply #1 on:
October 21, 2012, 03:53:47 AM »
Hi GeorgeT93,
Thanks for your interest. Yes, you are correct, the licensing on the themes that exist on the themesite is
CC BY-SA
, giving you the freedom to share, adapt, and/or make commercial use of the work.
[Saint]
Logged
Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.
GeorgeT93
Member
Posts: 5
Re: Variant of existing theme
«
Reply #2 on:
October 21, 2012, 05:38:26 PM »
Thanks for the information [Saint].
I just wanted to be sure I wasn't going to break any rules by making it available. I'll upload it now in case anyone else likes the theme but wants a different color scheme for it.
Thanks again,
-George
Logged
lebellium
Member
Posts: 78
DAPs collector
Re: Variant of existing theme
«
Reply #3 on:
October 21, 2012, 07:48:19 PM »
Hello George!
Indeed I did not put any contact information in the original theme files but since I'm a bit everywhere on the Internet under the same nickname, I thought that would not be difficult to find me for those who want to contact me...maybe I was wrong
I'm glad to hear you like my theme and I find your modification very nice too (of course you were allowed to upload it!). Cool background pic and status bar background color! I'm not as creative as you, that's why I just got stuck to a white background...lol
It's just a pity that you tried to keep the 12h clock compatibility since now the playback icon, especially the Ffwd and Rew ones, display 1px over the numeric volume and the battery indicator is 1px cut off
I was to lazy to convert the white background of the FM signal strength icon to transparent color, that was not too problematic with my original white background pic but now with yours, you or I should do it. Your FM screen looks a bit strange like that.
I also noticed the 24h clock doesn't have the same position on WPS and on SBS. I don't understand why because the code (clock viewport) is the same for both files. Hum maybe I'm just too tired now, I'll have a look tomorrow.
«
Last Edit: October 21, 2012, 08:16:59 PM by lebellium
»
Logged
I swim in mp3 players!
GeorgeT93
Member
Posts: 5
Re: Variant of existing theme
«
Reply #4 on:
October 22, 2012, 12:17:07 AM »
Hi lebellium,
First, thank you for an amazing theme, it had all the information I wanted to be able to see on the screen, and frankly looks fantastic! I kept the 12h clock (though with your existing code, it will work in 24 hour mode as well, depending on the user's clock setting in the settings screen.)
I honestly didn't notice the fast forward graphic getting cut off.
Sorry about that, it was completely unintentional. I'm still trying to figure out the whole viewports thing, so I only moved the volume numeric display over about 2 pixels so it wouldn't crowd the clock. I'll look into seeing what I have to do to try and fix that. I definitely don't want it cut off, so I'm going to try and figure out how to move the play/ff/pause icon. I'm thinking that if I can get it moved down between where the year is displayed and the track time information, then that should free up enough space on the top bar to have the numeric volume display all the way over to the left, while maintaining the 12/24 hour clock option. I would also then have the room to move the battery display over, as I'm guessing it must be the 'empty' end of the battery that is getting cut off. I figure if I move the play indicator, I may even be able to add the LED activity light from the non-ABE version back to the title bar (as I really liked that feature)!
I did notice what you're talking about with the FM signal strength meter, but when I tried a transparent background, the green bars didn't really look right on the blue background (not enough difference in color between them with full signal strength, so it looked odd.) I was thinking of either 'boxing' in the white area to give it a more 3 dimensional appearance, or maybe changing the green to either a different color, or a different shade for more contrast against the blue background.
For the clock position, I copied and pasted the code into the WPS, FMS, and SBS files, and I just checked all 3 and the code is the same, so I'm not sure why it doesn't have the same position for you. To be honest, I'm not sure what screens use the SBS file, but I haven't been able to find which screen the clock is moved on as it appears to be in the same position on each screen I've checked. Please let me know what screen the SBS file actually is displayed on, so I can see if I can figure out what I might have messed up on! (How else will I learn?)
It's late here now, but tomorrow I'm going to see if I can figure out where the problem may be with the clock position, and will try my hand at moving the play indicator, and figuring out what to do with the FM signal strength indicator. If you go on the FM screen, when a stereo broadcast is playing, you'll see what I mean about the green not looking right with a transparent background on the blue backdrop.
Please, if you have any additional tips or suggestions for improving the color variant, let me know. I don't want to make this more work for you, but it is your code base, and I don't want any changes I've made to reflect poorly back on you because your stuff is fantastic, and I'm new to all this WPS stuff.
Thanks again for the great themes, and for letting me know what I need to look at fixing. I'll get on it first thing in the morning.
-George
Post Merge: October 22, 2012, 12:28:21 AM
I just had another thought. Do you think it would look ok if the play/ff/pause icon was moved to the bottom of the screen to the left of the status bar? I could just make a shorter status bar graphic, then I'd just have to make it shorter in the code and move it over enough pixels for the play/ff/pause icon to show up next to it.
Just an idea, please let me know your thoughts.
-George
Final edit of the night, I'm really going to go to bed now! LOL!
Ok, I kept the play icon where it was, and moved the numeric volume over a tad. That should rectify the play icon from getting cut off. I'll load it onto my ClipZip in the morning for further testing. I also made a small change to the clock code, so that instead of displaying "AM/PM", it now shows just "a" or "p" if the 12 hour clock is selected. This gave me room to move the battery displays (both numeric and graphic) over a bit, so that neither should be getting cut off. I did this by adding %?cp<p|a> to the end of the 12 hour side of the code.
I also reworked the colors on the signal strength so it's brighter and now has a transparent background, so that it shows up better on the blue background, and also recolored the stereo/mono indicator as well as the red/green "tuned" indicator. Finally, I darkened the background color slightly, so that everything shows up more clearly. After I test the changes on the actual ClipZip, if everything is working correctly, I'll upload the new version tomorrow. So far, all testing has been done in the simulator.
Thanks again for all the pointers. Hopefully this version will do your theme justice.
-George
Good morning!
The updated version has been tested on my end, and seems 'right' now, so I've uploaded it to the theme library. Please let me know if you encounter any additional problems with it.
-George
«
Last Edit: October 22, 2012, 09:09:05 AM by GeorgeT93
»
Logged
lebellium
Member
Posts: 78
DAPs collector
Re: Variant of existing theme
«
Reply #5 on:
October 22, 2012, 04:28:06 PM »
Hello,
Ok I just tried your version 1.1, better than the previous one, good job! Just a few points again:
-on SBS, the progress bar of the mini-player is 2px high while the grey progress bar background is 3px high. Yes, in my original theme the background pic for SBS and WPS is a bit different
-I finally found the issue with the changing clock position. Dude, never do that again, it made me crazy to find it out
=> when modifying the line you unintentionally added invisible spaces at the end of the line. Please remove them from SBS, WPS and FMS.
-in rare case of 100% battery, "%" is a bit cut off. I guess you should move the graphic battery indicator 1px right like in my original ABE theme.
Logged
I swim in mp3 players!
GeorgeT93
Member
Posts: 5
Re: Variant of existing theme
«
Reply #6 on:
October 22, 2012, 05:38:04 PM »
Yikes! I didn't realize I had managed to put some whitespace in at the end of the clock line! Thank you for finding that for me!!
I've gone through each line, and made sure that there's no longer any whitespace at the end of any of the lines, so hopefully that will have things sorted out.
I didn't notice the percentage sign on the numeric battery indicator getting cut off at 100% until you mentioned it. Guess my eyes aren't what they used to be LOL! In any case, I took your advice, and moved the graphical battery indicator to x-80, and that seems to have sorted it out.
For the progress bar, I had only changed the shade of green, and didn't even notice that you had it different on the menus vs the FM and WPS screens. What would you suggest to correct it? Should I set all of them to y-93 or y-94, or should I make a modification to the background image (I'm assuming the one in the backdrops folder?) to make it match the heights of the progress bar background area from the original themes? Again, my eyes aren't what they used to be, so I never caught that the background was a different height there, but I would like to maintain as much uniformity with your original themes as possible.
Thanks again for all the help and tips, and I look forward to hearing your recommendation for the progress bar!
-George
I decided to go with changing the backdrop for the menu screens so that it best matches your original themes. Is there somewhere I can post it for you to check it before I post it back to the themes library? If not, no worries, I can just post it to the library, I just don't want to put it up again until you've had a chance to give it the once-over.
-George
«
Last Edit: October 22, 2012, 06:17:09 PM by GeorgeT93
»
Logged
lebellium
Member
Posts: 78
DAPs collector
Re: Variant of existing theme
«
Reply #7 on:
October 22, 2012, 06:29:22 PM »
Yes I guess the best is changing the backdrop like in the original theme. Because of the lack of space on main menu for both the menu list and the mini-player, I decided to reduce the progress bar height by 1px compared to the WPS so on SBS it is 2px high while on the WPS it is 3px high. For an unknown reason, my progress bar BMP is 4px high (probably used in earlier beta versions I don't remember). It could or should be only 3px high.
Normally you can attach files to a post here by clicking on "Additional Options..." but it doesn't accept .zip format. Otherwise you can send it to me per email: my nickname [at]hotmail.com
«
Last Edit: October 22, 2012, 06:35:42 PM by lebellium
»
Logged
I swim in mp3 players!
GeorgeT93
Member
Posts: 5
Re: Variant of existing theme
«
Reply #8 on:
October 22, 2012, 06:54:30 PM »
Thanks! Email sent with the zip attached. You'll have my email from that, so you can respond here or through email to let me know if there's anything else that needs adjusting or fixing. Thank you so much, for taking time out of your day to help me along with getting this right. I really appreciate it!
-George
Thanks to the help and patience of lebellium, the updated theme (v1.11) has been tested and the remaining issues have been worked out. The new version has been uploaded to the theme library. Thank you for everything, lebellium! In two words, You Rock!
-George
«
Last Edit: October 22, 2012, 08:49:46 PM by GeorgeT93
»
Logged
Print
Pages: [
1
]
« previous
next »
Rockbox Technical Forums
Support and General Use
Theming and Appearance Customization
Variant of existing theme
SMF 2.0.19
|
SMF © 2021
,
Simple Machines
Rockbox Privacy Policy
XHTML
RSS
WAP2
Page created in 0.043 seconds with 20 queries.