Downloads
release
dev builds
extras
themes
Documentation
manual
wiki
device status
Support
forums
mailing lists
IRC
Development
bugs
patches
dev guide
Search
Donate
1 Hour
1 Day
1 Week
1 Month
Forever
Login with username, password and session length
News:
Welcome to the Rockbox Technical Forums!
Rockbox Technical Forums
Support and General Use
Audio Playback, Database and Playlists
sansa clip v2 doesn't play lame mp3s gaplessly anymore.
« previous
next »
Print
Pages: [
1
]
Author
Topic: sansa clip v2 doesn't play lame mp3s gaplessly anymore. (Read 2656 times)
marc2003
Member
Posts: 36
sansa clip v2 doesn't play lame mp3s gaplessly anymore.
«
on:
April 12, 2011, 01:34:01 PM »
one of my favourite features is now broken. :'(
trouble is, i have no idea when it last worked. if anybody can point in me in the direction of the change that might have affected it, i can build myself to test.
Logged
Buschel
Developer
Member
Posts: 190
Re: sansa clip v2 doesn't play lame mp3s gaplessly anymore.
«
Reply #1 on:
April 12, 2011, 02:29:32 PM »
Hi, there were several changes to the metadata handling since v3.8. You could check: r29610, r29609, r29606 or r29583. I hope none of these is the cause, those changes were submitted by myself
Logged
iPod 5.5G 30GB, iPod nano 2G 8GB, 97% MPC and growing...
marc2003
Member
Posts: 36
Re: sansa clip v2 doesn't play lame mp3s gaplessly anymore.
«
Reply #2 on:
April 12, 2011, 03:56:22 PM »
sorry but i think i might be wasting your time. i just tried some freshly encoded files and they play fine even in the current build.
it's only these older files i'm having a problem with. they used to work in rockbox and they still play fine in foobar2000 right now (obviously i tested that before posting) but something must have happened in the meantime - perhaps a tag update. anyway that's something for me to get to the bottom of.
apologies and keep up the great work.
Logged
Buschel
Developer
Member
Posts: 190
Re: sansa clip v2 doesn't play lame mp3s gaplessly anymore.
«
Reply #3 on:
April 12, 2011, 04:09:31 PM »
Well, if those files worked with rockbox before and still work fine (=play gapless) in foobar I am still interested in why they do not work in current rockbox. Can you provide such file (e.g. uploading it somewhere)?
Logged
iPod 5.5G 30GB, iPod nano 2G 8GB, 97% MPC and growing...
marc2003
Member
Posts: 36
Re: sansa clip v2 doesn't play lame mp3s gaplessly anymore.
«
Reply #4 on:
April 12, 2011, 05:02:41 PM »
it is a rockbox problem after all. i did the unthinkable and coverted lossy to lossy and the new lame 3.98 transcodes play ok.
lame 3.96 originals:
edit: links removed.
«
Last Edit: April 12, 2011, 06:03:13 PM by marc2003
»
Logged
Buschel
Developer
Member
Posts: 190
Re: sansa clip v2 doesn't play lame mp3s gaplessly anymore.
«
Reply #5 on:
April 12, 2011, 05:39:59 PM »
Confirmed and understood. I want to check how and when this bug came in. As a quick fix try to do the following in apps/metadata.c:
Use
info->enc_padding = ((int)(buf[i+1]&0xF) << 8 ) | buf[i+2];
instead of
info->enc_padding = ((int)buf[i+1] << 8 ) | buf[i+2];
With this change the correct amount of padding is read from the Xing header and the sanity check is not acting.
Edit: Sad truth is -> came in with r29323 and is in v3.8 and v3.8.1. Will fix this tomorrow morning. Sorry.
«
Last Edit: April 12, 2011, 05:44:17 PM by Buschel
»
Logged
iPod 5.5G 30GB, iPod nano 2G 8GB, 97% MPC and growing...
marc2003
Member
Posts: 36
Re: sansa clip v2 doesn't play lame mp3s gaplessly anymore.
«
Reply #6 on:
April 12, 2011, 06:02:09 PM »
ah fixed. thank you for taking the time to look at this.
Logged
Buschel
Developer
Member
Posts: 190
Re: sansa clip v2 doesn't play lame mp3s gaplessly anymore.
«
Reply #7 on:
April 13, 2011, 01:55:52 AM »
Fixed with r29708.
Logged
iPod 5.5G 30GB, iPod nano 2G 8GB, 97% MPC and growing...
Print
Pages: [
1
]
« previous
next »
Rockbox Technical Forums
Support and General Use
Audio Playback, Database and Playlists
sansa clip v2 doesn't play lame mp3s gaplessly anymore.
SMF 2.0.19
|
SMF © 2021
,
Simple Machines
Rockbox Privacy Policy
XHTML
RSS
WAP2
Page created in 0.063 seconds with 21 queries.